debian/patches/old/CVE-2016-1568-ide-ahci-reset-ncq-object-to-unused-on-error.patch

   1 From b9a60d97fac671f31df599e7e48fd28fc203c0af Mon Sep 17 00:00:00 2001
   2 From: Prasad J Pandit <pjp@fedoraproject.org>
   3 Date: Sat, 9 Jan 2016 01:18:31 +0530
   4 Subject: [PATCH] ide: ahci: reset ncq object to unused on error
   5
   6 When processing NCQ commands, ACHI device emulation prepares a
   7 NCQ transfer object; To which an aio control block(aiocb) object
   8 is assigned in 'execute_ncq_command'. In case, when the NCQ
   9 command is invalid, the 'aiocb' object is not assigned, and NCQ
  10 transfer object is left as 'used'. This leads to a use after
  11 free kind of error in 'bdrv_aio_cancel_async' via 'ahci_reset_port'.
  12 Reset NCQ transfer object to 'unused' to avoid it.
  13
  14 Reported-by: Qinghao Tang <luodalongde@gmail.com>
  15 Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
  16 Reviewed-by: John Snow <jsnow@redhat.com>
  17 Message-id: 1452282511-4116-1-git-send-email-ppandit@redhat.com
  18 Signed-off-by: John Snow <jsnow@redhat.com>
  19 ---
  20  hw/ide/ahci.c | 1 +
  21  1 file changed, 1 insertion(+)
  22
  23 diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
  24 index dd1912e..17f1cbd 100644
  25 --- a/hw/ide/ahci.c
  26 +++ b/hw/ide/ahci.c
  27 @@ -910,6 +910,7 @@ static void ncq_err(NCQTransferState *ncq_tfs)
  28      ide_state->error = ABRT_ERR;
  29      ide_state->status = READY_STAT | ERR_STAT;
  30      ncq_tfs->drive->port_regs.scr_err |= (1 << ncq_tfs->tag);
  31 +    ncq_tfs->used = 0;
  32  }
  33
  34  static void ncq_finish(NCQTransferState *ncq_tfs)
  35 --
  36 2.1.4
  37