package/network/netkit-base/hotfix-64bit-alignment.patch

   1 # --- T2-COPYRIGHT-NOTE-BEGIN ---
   2 # This copyright note is auto-generated by scripts/Create-CopyPatch.
   3 #
   4 # T2 SDE: package/.../netkit-base/64bit-alignment.patch
   5 # Copyright (C) 2004 - 2020 The T2 SDE Project
   6 #
   7 # More information can be found in the files COPYING and README.
   8 #
   9 # This patch file is dual-licensed. It is available under the license the
  10 # patched project is licensed under, as long as it is an OpenSource license
  11 # as defined at http://www.opensource.org/ (e.g. BSD, X11) or under the terms
  12 # of the GNU General Public License as published by the Free Software
  13 # Foundation; either version 2 of the License, or (at your option) any later
  14 # version.
  15 # --- T2-COPYRIGHT-NOTE-END ---
  16
  17 At least on sparc64 gcc optimized the memcpy into 2 32bit load/stores. However
  18 the data does not match that alignment requirements, the program receivees
  19 a SIGBUS. I'm not sure if this is a misoptimization bug in gcc ...
  20
  21   - Rene Rebe <rene@exactcode.de>
  22
  23 diff -ur netkit-base-0.17/ping/ping.c netkit-base-0.17-fixed/ping/ping.c
  24 --- netkit-base-0.17/ping/ping.c        2000-07-23 06:16:21.000000000 +0200
  25 +++ netkit-base-0.17-fixed/ping/ping.c  2005-01-29 17:53:55.000000000 +0100
  26 @@ -673,7 +673,7 @@
  27  {
  28         struct ip *ip;
  29         struct icmp *icp;
  30 -       struct timeval now, packettv, *tp;
  31 +       struct timeval now, packettv;
  32         long triptime = 0;
  33         int hlen, dupflag;
  34         int rv;
  35 @@ -722,8 +722,7 @@
  36                         return 0;               /* 'Twas not our ECHO */
  37                 nreceived++;
  38                 if (timing) {
  39 -                       tp = (struct timeval *)icp->icmp_data;
  40 -                       memcpy(&packettv, tp, sizeof(struct timeval));
  41 +                       memcpy(&packettv, icp->icmp_data, sizeof(struct timeval));
  42                         tvsub(&now, &packettv);
  43
  44                         /* precision: tenths of milliseconds */