WebKitTools/ChangeLog

   1 2009-12-14  Robert Hogan  <robert@roberthogan.net>
   2
   3         Reviewed by Eric Seidel.
   4
   5         [Qt] Fix https://bugs.webkit.org/show_bug.cgi?id=32437
   6
   7         Amend the behaviour of DRT::notifyDone to dump only when
   8         the page has finished loading.
   9
  10         This fix permits removal of the following tests from the Qt skipped list:
  11         fast/forms/textarea-linewrap-dynamic.html
  12         fast/forms/textarea-setvalue-submit.html
  13         fast/forms/textarea-hard-linewrap-empty.html
  14         fast/forms/submit-to-url-fragment.html
  15         http/tests/misc/percent-sign-in-form-field-name.html
  16         http/tests/security/escape-form-data-field-names.html
  17
  18         However it also requires the following two to be added to the skipped list:
  19
  20         http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
  21         svg/custom/use-instanceRoot-as-event-target.xhtml
  22
  23         It appears the behaviour of notifyDone was masking problems with these two
  24         tests.
  25
  26         * DumpRenderTree/qt/DumpRenderTree.cpp:
  27         (WebCore::DumpRenderTree::DumpRenderTree):
  28         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  29         (LayoutTestController::reset):
  30         (LayoutTestController::processWork):
  31         (LayoutTestController::maybeDump):
  32         (LayoutTestController::notifyDone):
  33         (LayoutTestController::provisionalLoad):
  34         * DumpRenderTree/qt/LayoutTestControllerQt.h:
  35         (LayoutTestController::resetLoadFinished):
  36
  37 2009-12-14  Simon Hausmann  <hausmann@webkit.org>
  38
  39         Reviewed by Holger Freyther.
  40
  41         [Qt] Add support for keyboard modifiers to Qt DRT's EventSender for touch events
  42
  43         https://bugs.webkit.org/show_bug.cgi?id=32482
  44
  45         * DumpRenderTree/qt/EventSenderQt.cpp:
  46         (EventSender::setTouchModifier):
  47         (EventSender::clearTouchPoints):
  48         (EventSender::sendTouchEvent):
  49         * DumpRenderTree/qt/EventSenderQt.h:
  50
  51 2009-12-13  Maciej Stachowiak  <mjs@apple.com>
  52
  53         Reviewed by Gavin Barraclaugh.
  54
  55         Fix minor problem in sunspider-compare-results which left it broken.
  56
  57         * Scripts/sunspider-compare-results: Declare $parseonly
  58
  59 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
  60
  61         Reviewed by Oliver Hunt.
  62
  63         Give command-line sunspider the ability to handle multiple suites and versions
  64         https://bugs.webkit.org/show_bug.cgi?id=32477
  65
  66         * Scripts/run-sunspider: Updated for changes to command-line parameters.
  67         * Scripts/sunspider-compare-results: ditto
  68
  69 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
  70
  71         Not reviewed, fixing previous comment.
  72
  73         Remove accidental change to sunspider-compare-results
  74
  75         * Scripts/sunspider-compare-results:
  76
  77 2009-12-11  Yael Aharon  <yael.aharon@nokia.com>
  78
  79         Unreviewed build fix for Qt versions < 4.6.
  80         Guard every slot individually with #ifdef.
  81
  82         * DumpRenderTree/qt/EventSenderQt.cpp:
  83         (EventSender::addTouchPoint):
  84         (EventSender::updateTouchPoint):
  85         (EventSender::touchStart):
  86         (EventSender::touchMove):
  87         (EventSender::touchEnd):
  88         (EventSender::clearTouchPoints):
  89         (EventSender::releaseTouchPoint):
  90         (EventSender::sendTouchEvent):
  91         * DumpRenderTree/qt/EventSenderQt.h:
  92
  93 2009-12-11  Eric Seidel  <eric@webkit.org>
  94
  95         Reviewed by Adam Barth.
  96
  97         CommandsTest.assert_execute_outputs doesn't check stderr
  98         https://bugs.webkit.org/show_bug.cgi?id=32352
  99
 100         Fix assert_execute_outputs to check stderr
 101         and then fix all the unit tests which needed to
 102         pass stderr output.
 103
 104         * Scripts/modules/commands/commandtest.py:
 105         * Scripts/modules/commands/download_unittest.py:
 106         * Scripts/modules/commands/upload_unittest.py:
 107
 108 2009-12-11  Adam Barth  <abarth@webkit.org>
 109
 110         Reviewed by Eric Seidel.
 111
 112         [check-webkit-style] False positive for tst_QWebFrame
 113         https://bugs.webkit.org/show_bug.cgi?id=32436
 114
 115         Add an exception for function names that start with "tst_".  These are
 116         used by the Qt unit testing framework.
 117
 118         * Scripts/modules/cpp_style.py:
 119         * Scripts/modules/cpp_style_unittest.py:
 120
 121 2009-12-11  Simon Hausmann  <hausmann@webkit.org>, Kim Grönholm  <kim.gronholm@nomovok.com>
 122
 123         Reviewed by Antti Koivisto.
 124
 125         Added support for creating synthetic touch events with EventSender
 126         in Qt's DumpRenderTree.
 127
 128         https://bugs.webkit.org/show_bug.cgi?id=32114
 129
 130         * DumpRenderTree/qt/EventSenderQt.cpp:
 131         (EventSender::addTouchPoint):
 132         (EventSender::updateTouchPoint):
 133         (EventSender::touchStart):
 134         (EventSender::touchMove):
 135         (EventSender::touchEnd):
 136         (EventSender::clearTouchPoints):
 137         (EventSender::releaseTouchPoint):
 138         (EventSender::sendTouchEvent):
 139         * DumpRenderTree/qt/EventSenderQt.h:
 140
 141 2009-12-11  Benjamin Poulain  <benjamin.poulain@nokia.com>
 142
 143         Reviewed by Darin Adler.
 144
 145         The values of RuntimeArray are not enumerable
 146         https://bugs.webkit.org/show_bug.cgi?id=29005
 147
 148         * DumpRenderTree/mac/ObjCController.m:
 149         (+[ObjCController isSelectorExcludedFromWebScript:]):
 150         (+[ObjCController webScriptNameForSelector:]):
 151         (-[ObjCController arrayOfString]):
 152
 153 2009-12-10  Eric Seidel  <eric@webkit.org>
 154
 155         No review, just updating unit tests to match recent checkins.
 156
 157         * Scripts/modules/mock_bugzillatool.py:
 158          - Add missing red_core_builders_names method causing exception.
 159         * Scripts/modules/workqueue_unittest.py:
 160          - processutils is dead, use executive.py instead.
 161
 162 2009-12-10  Eric Seidel  <eric@webkit.org>
 163
 164         Reviewed by Adam Barth.
 165
 166         Move run_command onto Executive to make code which uses run_command testable
 167         https://bugs.webkit.org/show_bug.cgi?id=32396
 168
 169         * Scripts/modules/executive.py:
 170          - Move run_command and error handlers onto Executive.
 171         * Scripts/modules/scm.py:
 172         * Scripts/modules/scm_unittest.py:
 173
 174 2009-12-09  Eric Seidel  <eric@webkit.org>
 175
 176         Reviewed by Adam Barth.
 177
 178         bugzilla-tool needs a command to list patches needing cq+
 179         https://bugs.webkit.org/show_bug.cgi?id=32351
 180
 181         * Scripts/modules/bugzilla.py:
 182          - Parse attacher_email from attachment xml.
 183         * Scripts/modules/bugzilla_unittest.py:
 184          - Test new attacher_email parsing.
 185         * Scripts/modules/commands/queries.py:
 186          - Add PatchesToCommitQueue
 187         * Scripts/modules/commands/queries_unittest.py:
 188          - Tests for PatchesToCommitQueue
 189         * Scripts/modules/mock_bugzillatool.py:
 190          - Add necessary mock methods for running PatchesToCommitQueue
 191
 192 2009-12-10  Adam Barth  <abarth@webkit.org>
 193
 194         Unreviewed.  Turns out every StepSequence command needs a --quiet
 195         option.
 196
 197         * Scripts/modules/stepsequence.py:
 198
 199 2009-12-10  Eric Z. Ayers  <zundel@google.com>
 200
 201         Reviewed by Pavel Feldman.
 202
 203         Implements displayWebView() to force an invalidation and repaint.
 204         This fixes a problem running the timeline-paint.html unit test.
 205
 206         https://bugs.webkit.org/show_bug.cgi?id=31729
 207
 208         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 209         (displayWebView):
 210
 211 2009-12-10  Adam Barth  <abarth@webkit.org>
 212
 213         Reviewed by Eric Seidel.
 214
 215         [bzt] Convert more commands to StepSequences
 216         https://bugs.webkit.org/show_bug.cgi?id=32362
 217
 218         We should eventually convert all the commands, but I'm starting with
 219         the easy ones.
 220
 221         * Scripts/modules/commands/download.py:
 222
 223 2009-12-10  Xan Lopez  <xlopez@igalia.com>
 224
 225         Reviewed by Jan Alonzo.
 226
 227         [GTK] editing/selection/shrink-selection-after-shift-pagedown.html failing
 228         https://bugs.webkit.org/show_bug.cgi?id=31103
 229
 230         Give focus to the webviews when we create them, since some tests expect this.
 231
 232         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 233         (main):
 234
 235 2009-12-10  Eric Seidel  <eric@webkit.org>
 236
 237         Reviewed by Adam Barth.
 238
 239         bugzilla-tool "builders are red" error should tell you which builders
 240         https://bugs.webkit.org/show_bug.cgi?id=32211
 241
 242         * Scripts/modules/buildsteps.py:
 243
 244 2009-12-09  Marwan Al Jubeh  <marwan.aljubeh@gmail.com>
 245
 246         Reviewed by Adam Roben.
 247
 248         Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228
 249         Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
 250         in Windows as part of running update_webkit.
 251
 252         * Scripts/update-webkit:
 253          - Run setupAppleWinEnv() on Apple's Windows port.
 254         * Scripts/webkitdirs.pm:
 255          - Added functions that return the source directory, libraries directory and default build directory on Windows.
 256          - Added isWindowsNT() which tests if the current Windows version is from the Windows NT family.
 257          - Implemented setupAppleWinEnv() which sets the environment variables WebKitOutputDir, WebKitLibrariesDir
 258            and Cygwin to their desired values.
 259
 260 2009-12-09  Adam Barth  <abarth@webkit.org>
 261
 262         Reviewed by Eric Seidel.
 263
 264         exception thrown when running apply-patches
 265         https://bugs.webkit.org/show_bug.cgi?id=32344
 266
 267         The update step now takes a port option.  Once we finish the Steps
 268         refactoring, we won't have to worry about this kind of bug again.
 269
 270         * Scripts/modules/commands/download.py:
 271
 272 2009-12-09  Adam Barth  <abarth@webkit.org>
 273
 274         Unreviewed.  Fix ScriptError includes.  I don't understand why these
 275         didn't throw during unit testing...
 276
 277         * Scripts/modules/commands/download.py:
 278         * Scripts/modules/logging_unittest.py:
 279         * Scripts/modules/workqueue.py:
 280
 281 2009-12-09  Adam Barth  <abarth@webkit.org>
 282
 283         Reviewed by Eric Seidel.
 284
 285         [bzt] Remove unused PatchCollection class
 286         https://bugs.webkit.org/show_bug.cgi?id=32312
 287
 288         It's dead code.
 289
 290         * Scripts/modules/patchcollection.py:
 291         * Scripts/modules/patchcollection_unittest.py: Removed.
 292
 293 2009-12-09  Adam Barth  <abarth@webkit.org>
 294
 295         Unreviewed "build" fix.  CheckStyle needs a --no-upate option.
 296
 297         * Scripts/modules/commands/download.py:
 298
 299 2009-12-09  Adam Barth  <abarth@webkit.org>
 300
 301         Reviewed by Eric Seidel.
 302
 303         [bzt] Convert Build to use Sequence
 304         https://bugs.webkit.org/show_bug.cgi?id=32310
 305
 306         So much prettier.
 307
 308         * Scripts/modules/buildsteps.py:
 309         * Scripts/modules/commands/download.py:
 310         * Scripts/modules/landingsequence.py:
 311         * Scripts/modules/stepsequence.py: Added.
 312
 313 2009-12-09  Adam Barth  <abarth@webkit.org>
 314
 315         Add missing file.
 316
 317         * Scripts/modules/executive.py: Added.
 318
 319 2009-12-09  Adam Barth  <abarth@webkit.org>
 320
 321         Unreviewed "build" fix.
 322
 323         * Scripts/modules/landingsequence.py:
 324
 325 2009-12-09  Adam Barth  <abarth@webkit.org>
 326
 327         Reviewed by Eric Seidel.
 328
 329         [bzt] Implement abstract Steps
 330         https://bugs.webkit.org/show_bug.cgi?id=32212
 331
 332         This is a fairly disruptive change that refactors how we build
 333         commands.  Instead of using a landing sequence, we can now assemble a
 334         sequence of steps directly.  We still use the landing sequence in the
 335         interim, but this will be removed soon.
 336
 337         * Scripts/bugzilla-tool:
 338         * Scripts/modules/buildsteps.py:
 339         * Scripts/modules/commands/download.py:
 340         * Scripts/modules/commands/early_warning_system.py:
 341         * Scripts/modules/commands/queues.py:
 342         * Scripts/modules/commands/queues_unittest.py:
 343         * Scripts/modules/landingsequence.py:
 344         * Scripts/modules/mock_bugzillatool.py:
 345         * Scripts/modules/processutils.py: Removed.
 346         * Scripts/modules/scm.py:
 347         * Scripts/modules/scm_unittest.py:
 348         * Scripts/modules/webkitport.py:
 349
 350 2009-12-08  Eric Seidel  <eric@webkit.org>
 351
 352         Reviewed by Adam Barth.
 353
 354         run_command and ScriptError should move into processutils.py
 355         https://bugs.webkit.org/show_bug.cgi?id=32305
 356
 357         Turns out there are a zillion callers to run_command.
 358
 359         * Scripts/modules/commands/download.py:
 360         * Scripts/modules/commands/early_warning_system.py:
 361         * Scripts/modules/commands/queues.py:
 362         * Scripts/modules/landingsequence.py:
 363         * Scripts/modules/logging_unittest.py:
 364         * Scripts/modules/processutils.py:
 365         * Scripts/modules/scm.py:
 366         * Scripts/modules/scm_unittest.py:
 367         * Scripts/modules/workqueue.py:
 368         * Scripts/modules/workqueue_unittest.py:
 369
 370 2009-12-08  Kevin Watters  <kevinwatters@gmail.com>
 371
 372         Reviewed by Kevin Ollivier.
 373
 374         [wx] Mac plugins support.
 375
 376         https://bugs.webkit.org/show_bug.cgi?id=32236
 377
 378         * wx/browser/wscript:
 379
 380 2009-12-08  David Levin  <levin@chromium.org>
 381
 382         Reviewed by Adam Barth.
 383
 384         [check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) {
 385         https://bugs.webkit.org/show_bug.cgi?id=32193
 386
 387         * Scripts/modules/cpp_style.py: For the function { rule, if there is space
 388           at the beginning of line, ignore lines which then have a macro.
 389         * Scripts/modules/cpp_style_unittest.py: Add tests to verify the
 390           new behavior.
 391
 392 2009-12-08  Dmitry Titov  <dimich@chromium.org>
 393
 394         Rubber-stamped by David Levin.
 395
 396         Revert and reopen "Add asserts to RefCounted to make sure ref/deref happens on the right thread."
 397         It may have caused massive increase of reported leaks on the bots.
 398         https://bugs.webkit.org/show_bug.cgi?id=31639
 399
 400         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
 401
 402 2009-12-08  Dmitry Titov  <dimich@chromium.org>
 403
 404         Reviewed by Darin Adler.
 405
 406         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
 407         https://bugs.webkit.org/show_bug.cgi?id=31639
 408
 409         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Added.
 410
 411 2009-12-08  David Levin  <levin@chromium.org>
 412
 413         Reviewed by Adam Barth.
 414
 415         [check-webkit-style] False positive for camel case of JSC op codes
 416         https://bugs.webkit.org/show_bug.cgi?id=32192
 417
 418         * Scripts/modules/cpp_style.py: Added an exception for the JSC op
 419           code functions and const_iterator as well since I noticed a false
 420           positive there when testing the fix.
 421         * Scripts/modules/cpp_style_unittest.py: Added tests for these
 422           changes.
 423
 424 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
 425
 426         Rubber-stamped by Maciej Stachowiak.
 427
 428         Turn on (SVG) Filters for Win.
 429         https://bugs.webkit.org/show_bug.cgi?id=32224
 430
 431         * Scripts/webkitdirs.pm:
 432
 433 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
 434
 435         Rubber-stamped by Maciej Stachowiak.
 436
 437         Turn on (SVG) Filters for Gtk.
 438         https://bugs.webkit.org/show_bug.cgi?id=32224
 439
 440         * Scripts/build-webkit:
 441
 442 2009-12-07  Shinichiro Hamaji  <hamaji@chromium.org>
 443
 444         Reviewed by David Levin.
 445
 446         [check-webkit-style] S_OK is a fine identifier
 447         https://bugs.webkit.org/show_bug.cgi?id=32225
 448
 449         * Scripts/modules/cpp_style.py:
 450         * Scripts/modules/cpp_style_unittest.py:
 451
 452 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
 453
 454         Rubber-stamped by Maciej Stachowiak.
 455
 456         Turn on (SVG) Filters for Qt.
 457         https://bugs.webkit.org/show_bug.cgi?id=32224
 458
 459         * Scripts/build-webkit:
 460
 461 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
 462
 463         Reviewed by Alexey Proskuryakov.
 464
 465         Make run-webkit-websocketserver log to stderr rather than to a file.
 466         https://bugs.webkit.org/show_bug.cgi?id=32234
 467
 468         * Scripts/run-webkit-websocketserver:
 469
 470 2009-12-07  Dmitry Titov  <dimich@chromium.org>
 471
 472         Rubber-stamped by Darin Adler.
 473
 474         Remove ENABLE_SHARED_SCRIPT flags
 475         https://bugs.webkit.org/show_bug.cgi?id=32245
 476         This patch was obtained by "git revert" command and then un-reverting of ChangeLog files.
 477
 478         * Scripts/build-webkit:
 479
 480 2009-12-07  Simon Fraser  <simon.fraser@apple.com>
 481
 482         Reviewed by Darin Adler.
 483
 484         <rdar://problem/7450481> One compositing test keeps DRT in "compositing mode", breaks repaint tests
 485
 486         The counter that WebView used to keep track of the number of enclosed WebHTMLViews using
 487         accelerated compositing was hard to manage, and maintained incorrectly in a number of cases.
 488         This caused one compositing test make DumpRenderTree think that all subsequent tests
 489         were compositing too.
 490
 491         Replace this counter with notifications, which are only fired if a client (DRT) requests them. The
 492         notification informs the client that a WebHTMLView entered compositing mode (or an already-
 493         compositing WebHTML was added); it does not say when a view becomes uncomposited, or all
 494         compositing subviews were removed, since this is tricky to get right.
 495
 496         DumpRenderTreeWindow listens for this notification, and uses it to turn on window
 497         autodisplay, which is necessary to kick-start Core Animation rendering and animations.
 498         We ensure that window autodisplay is turned off before every test.
 499
 500         * DumpRenderTree/mac/DumpRenderTree.mm:
 501         (createWebViewAndOffscreenWindow):
 502         (resetWebViewToConsistentStateBeforeTesting):
 503         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
 504         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
 505         (-[DumpRenderTreeWindow close]):
 506         (-[DumpRenderTreeWindow startListeningForAcceleratedCompositingChanges]):
 507         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
 508
 509 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
 510
 511         Reviewed by Holger Hans Peter Freyther.
 512
 513         Turn on (SVG) Filters support, by default.
 514         https://bugs.webkit.org/show_bug.cgi?id=32224
 515
 516         For now only enable FILTERS build flag on WebKit/mac. Other platforms will follow soon.
 517
 518         * Scripts/build-webkit:
 519
 520 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
 521
 522         Reviewed by Darin Fisher.
 523
 524         Chromium buildbots are not red when they fail
 525         https://bugs.webkit.org/show_bug.cgi?id=32235
 526
 527         * Scripts/build-webkit:
 528
 529 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
 530
 531         Reviewed by Darin Fisher.
 532
 533         Typo in chromium linux builder
 534         https://bugs.webkit.org/show_bug.cgi?id=32238
 535
 536         * Scripts/webkitdirs.pm:
 537
 538 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
 539
 540         Reviewed by Darin Fisher.
 541
 542         fixes to build-webkit --chromium
 543         https://bugs.webkit.org/show_bug.cgi?id=32179
 544
 545         * Scripts/webkitdirs.pm:
 546
 547 2009-12-07  Eric Seidel  <eric@webkit.org>
 548
 549         No review, just adding two recently approved committers.
 550
 551         * Scripts/modules/committers.py:
 552
 553 2009-12-07  Alexey Proskuryakov  <ap@apple.com>
 554
 555         * Scripts/run-webkit-websocketserver: Added property svn:executable.
 556
 557 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
 558
 559         Reviewed by Alexey Proskuryakov.
 560
 561         Add run-webkit-websocketserver
 562
 563         https://bugs.webkit.org/show_bug.cgi?id=31390
 564
 565         * Scripts/run-webkit-websocketserver: Added.
 566
 567 2009-12-07  Steve Falkenburg  <sfalken@apple.com>
 568
 569         Build fix. Be flexible about which version of ICU is used on Windows.
 570
 571         * DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2.
 572
 573 2009-12-07  Dirk Schulze  <krit@webkit.org>
 574
 575         Not reviewed, adding myself to the reviewers list.
 576
 577         * Scripts/modules/committers.py:
 578
 579 2009-12-06  Eric Seidel  <eric@webkit.org>
 580
 581         Reviewed by Adam Barth.
 582
 583         Add an API for uploading results files to StatusBot
 584         https://bugs.webkit.org/show_bug.cgi?id=32210
 585
 586         Add Content-Type: plain/text which was forgotten
 587         from the previous commit when I landed with land-patches
 588         instead of land-diff.
 589
 590         * QueueStatusServer/queue_status.py:
 591
 592 2009-12-06  Eric Seidel  <eric@webkit.org>
 593
 594         Reviewed by Adam Barth.
 595
 596         Status Server needs a way to handle uploaded results
 597         https://bugs.webkit.org/show_bug.cgi?id=32209
 598
 599         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
 600         * QueueStatusServer/update_status.html: Add file upload.
 601
 602 2009-12-06  Eric Seidel  <eric@webkit.org>
 603
 604         Reviewed by Adam Barth.
 605
 606         Add an API for uploading results files to StatusBot
 607         https://bugs.webkit.org/show_bug.cgi?id=32210
 608
 609         * Scripts/modules/statusbot.py:
 610
 611 2009-12-06  Eric Seidel  <eric@webkit.org>
 612
 613         Reviewed by Adam Barth.
 614
 615         Status Server needs a way to handle uploaded results
 616         https://bugs.webkit.org/show_bug.cgi?id=32209
 617
 618         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
 619         * QueueStatusServer/update_status.html: Add file upload.
 620
 621 2009-12-06  Adam Barth  <abarth@webkit.org>
 622
 623         Reviewed by Eric Seidel.
 624
 625         [bzt] BuildAttachment should not check the builders
 626         https://bugs.webkit.org/show_bug.cgi?id=32207
 627
 628         This is code that got copied here by accident when the class was created.
 629
 630         * Scripts/modules/commands/download.py:
 631
 632 2009-12-06  Adam Barth  <abarth@webkit.org>
 633
 634         Reviewed by Eric Seidel.
 635
 636         [bzt] Make LandingSequence.update aware of ports
 637         https://bugs.webkit.org/show_bug.cgi?id=32208
 638
 639         This is required to make build work on the Chromium port because
 640         Chromium has a custom update-webkit.
 641
 642         * Scripts/modules/landingsequence.py:
 643
 644 2009-12-06  Adam Barth  <abarth@webkit.org>
 645
 646         Reviewed by Eric Seidel.
 647
 648         Add early warning system commands to bugzilla-tool.
 649
 650         * Scripts/bugzilla-tool:
 651         * Scripts/modules/landingsequence.py:
 652         * Scripts/modules/webkitport.py:
 653
 654 2009-12-06  Adam Barth  <abarth@webkit.org>
 655
 656         Reviewed by Eric Seidel.
 657
 658         [bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem
 659         https://bugs.webkit.org/show_bug.cgi?id=32205
 660
 661         * Scripts/modules/commands/early_warning_system.py: Added.
 662         * Scripts/modules/commands/queues.py:
 663
 664 2009-12-06  Dan Bernstein  <mitz@apple.com>
 665
 666         Reviewed by Adele Peterson.
 667
 668         REGRESSION (r51728): update-webkit fails when the current directory is
 669         not inside a Subversion working copy
 670         https://bugs.webkit.org/show_bug.cgi?id=32204
 671
 672         * Scripts/update-webkit: Invoke isSVN() in the correct working
 673         directory.
 674
 675 2009-12-06  Adam Barth  <abarth@webkit.org>
 676
 677         Reviewed by Eric Seidel.
 678
 679         [bzt] Rename AbstractTryQueue to AbstractReviewQueue
 680         https://bugs.webkit.org/show_bug.cgi?id=32202
 681
 682         * Scripts/modules/commands/queues.py:
 683
 684 2009-12-05  Adam Barth  <abarth@webkit.org>
 685
 686         Reviewed by Eric Seidel.
 687
 688         [bzt] Implement ChromiumPort
 689         https://bugs.webkit.org/show_bug.cgi?id=32182
 690
 691         * Scripts/modules/webkitport.py:
 692         * Scripts/modules/webkitport_unittest.py:
 693
 694 2009-12-05  Adam Barth  <abarth@webkit.org>
 695
 696         Reviewed by Eric Seidel.
 697
 698         Move update-webkit into BuildSteps
 699         https://bugs.webkit.org/show_bug.cgi?id=32181
 700
 701         We need to move update-webkit out of SCM.py because SCM isn't supposed to know
 702         that WebKit exists.  The proper place for the knowledge of the existence of
 703         update-webkit is in WebKitPort because some ports have specialized update
 704         scripts (analogous to build-webkit).
 705
 706         * Scripts/modules/buildsteps.py:
 707         * Scripts/modules/commands/download.py:
 708         * Scripts/modules/landingsequence.py:
 709         * Scripts/modules/scm.py:
 710         * Scripts/modules/webkitport.py:
 711
 712 2009-12-05  Adam Barth  <abarth@webkit.org>
 713
 714         Reviewed by Eric Seidel.
 715
 716         update-webkit should call git svn rebase and resolve-ChangeLogs -f
 717         https://bugs.webkit.org/show_bug.cgi?id=27162
 718
 719         Teach update-webkit about Git.  I didn't add the call to
 720         resolve-ChangeLogs -f because sometimes that script goes bananas.  We
 721         can iterate from here, however.
 722
 723         * Scripts/update-webkit:
 724
 725 2009-12-04  Yael Aharon  <yael.aharon@nokia.com>
 726
 727         Unreviewed build fix.
 728
 729         [Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.
 730
 731         * DumpRenderTree/qt/DumpRenderTree.cpp:
 732
 733 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 734
 735         Reviewed by Adam Treat.
 736
 737         Add some missing methods for showing and hiding the
 738         Web Inspector.
 739
 740         * DumpRenderTree/qt/DumpRenderTree.cpp:
 741         (WebCore::WebPage::WebPage):
 742         (WebCore::WebPage::~WebPage):
 743         (WebCore::WebPage::webInspector):
 744         * DumpRenderTree/qt/DumpRenderTree.h:
 745         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 746         (LayoutTestController::showWebInspector):
 747         (LayoutTestController::hideWebInspector):
 748         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 749
 750 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 751
 752         Reviewed by Adam Treat.
 753
 754         Implement the setAllowUniversalAccessFromFileURLs method
 755         for the Qt LayoutTestController.
 756
 757         * DumpRenderTree/qt/DumpRenderTree.cpp:
 758         (WebCore::WebPage::resetSettings):
 759         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 760         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 761         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 762
 763 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
 764
 765         Reviewed by Darin Adler.
 766
 767         REGRESSION: AX: buttons now extremely repetitive
 768         https://bugs.webkit.org/show_bug.cgi?id=32164
 769
 770         * DumpRenderTree/AccessibilityUIElement.cpp:
 771         (isAttributeSupportedCallback):
 772         (AccessibilityUIElement::getJSClass):
 773         * DumpRenderTree/AccessibilityUIElement.h:
 774         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 775         (AccessibilityUIElement::isAttributeSupported):
 776         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 777         (AccessibilityUIElement::isAttributeSupported):
 778         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 779         (AccessibilityUIElement::isAttributeSupported):
 780
 781 2009-12-03  Shinichiro Hamaji  <hamaji@chromium.org>
 782
 783         Reviewed by David Levin.
 784
 785         check-webkit-style should check for camelCase variable names
 786         https://bugs.webkit.org/show_bug.cgi?id=32051
 787
 788         * Scripts/modules/cpp_style.py:
 789         * Scripts/modules/cpp_style_unittest.py:
 790
 791 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
 792
 793         Reviewed by Eric Seidel.
 794
 795         AX: VO just says "term" on many web sites
 796         https://bugs.webkit.org/show_bug.cgi?id=32139
 797
 798         * DumpRenderTree/AccessibilityUIElement.cpp:
 799         (getRoleDescriptionCallback):
 800         (AccessibilityUIElement::getJSClass):
 801         * DumpRenderTree/AccessibilityUIElement.h:
 802         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 803         (AccessibilityUIElement::roleDescription):
 804         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 805         (AccessibilityUIElement::roleDescription):
 806         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 807         (AccessibilityUIElement::roleDescription):
 808
 809 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
 810
 811         Reviewed by Beth Dakin.
 812
 813         Implement WAI-ARIA scrollbar role and related property aria-orientation
 814         https://bugs.webkit.org/show_bug.cgi?id=32126
 815
 816         * DumpRenderTree/AccessibilityUIElement.cpp:
 817         (getOrientationCallback):
 818         (AccessibilityUIElement::getJSClass):
 819         * DumpRenderTree/AccessibilityUIElement.h:
 820         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 821         (AccessibilityUIElement::orientation):
 822         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 823         (AccessibilityUIElement::orientation):
 824         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 825         (AccessibilityUIElement::orientation):
 826
 827 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
 828
 829         Reviewed by Adam Roben.
 830
 831         Minor correction to r51663.
 832
 833         * DumpRenderTree/win/DumpRenderTree.cpp:
 834         (addQTDirToPATH):
 835             GetEnvironmentVariable -> GetEnvironmentVariableW.
 836
 837 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
 838
 839         Reviewed by Adam Roben.
 840
 841         ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
 842         https://bugs.webkit.org/show_bug.cgi?id=30256
 843
 844         Add the QuickTime dll directory to the PATH environment variable so
 845         inialization can succeed.
 846
 847         * DumpRenderTree/win/DumpRenderTree.cpp:
 848         (addQTDirToPATH):
 849         (initialize):
 850
 851 2009-12-03  Shu Chang  <Chang.Shu@nokia.com>
 852
 853         Reviewed by Kenneth Rohde Christiansen.
 854
 855         [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.
 856
 857         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 858         (LayoutTestController::maybeDump):
 859
 860 2009-12-03  Yuzo Fujishima  <yuzo@google.com>
 861
 862         Reviewed by Eric Seidel.
 863
 864         Update pywebsocket to 0.4.3
 865         This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
 866         Stack trace is logged now in INFO level.
 867         https://bugs.webkit.org/show_bug.cgi?id=32097
 868
 869         * pywebsocket/mod_pywebsocket/dispatch.py:
 870         * pywebsocket/mod_pywebsocket/msgutil.py:
 871         * pywebsocket/mod_pywebsocket/standalone.py:
 872         * pywebsocket/mod_pywebsocket/util.py:
 873         * pywebsocket/setup.py:
 874         * pywebsocket/test/test_dispatch.py:
 875         * pywebsocket/test/test_util.py:
 876
 877 2009-12-03  Sam Weinig  <sam@webkit.org>
 878
 879         Reviewed by Gavin Barraclough.
 880
 881         Fix JSClassRef leak.
 882
 883         * DumpRenderTree/AccessibilityController.cpp:
 884         (AccessibilityController::makeWindowObject):
 885         * DumpRenderTree/GCController.cpp:
 886         (GCController::makeWindowObject):
 887         * DumpRenderTree/LayoutTestController.cpp:
 888         (LayoutTestController::makeWindowObject):
 889
 890 2009-12-03  Brady Eidson  <beidson@apple.com>
 891
 892         Reviewed by Sam Weinig.
 893
 894         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
 895
 896         Keep DRT-win building...
 897
 898         * DumpRenderTree/win/FrameLoadDelegate.h:
 899         (FrameLoadDelegate::didPushStateWithinPageForFrame):
 900         (FrameLoadDelegate::didReplaceStateWithinPageForFrame):
 901         (FrameLoadDelegate::didPopStateWithinPageForFrame):
 902
 903 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
 904
 905         Unreviewed build fix.
 906
 907         [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
 908
 909         * DumpRenderTree/qt/DumpRenderTree.cpp:
 910
 911 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
 912
 913         Reviewed by Kenneth Rohde Christiansen.
 914
 915         [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
 916         Prevent DRT from showing the main view if these childs get deleted.
 917         This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
 918
 919         * DumpRenderTree/qt/DumpRenderTree.cpp:
 920         (WebCore::WebPage::WebPage):
 921         (WebCore::DumpRenderTree::DumpRenderTree):
 922         (WebCore::DumpRenderTree::~DumpRenderTree):
 923         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 924         (WebCore::DumpRenderTree::open):
 925         (WebCore::DumpRenderTree::closeRemainingWindows):
 926         (WebCore::DumpRenderTree::createWindow):
 927         (WebCore::DumpRenderTree::windowCount):
 928         * DumpRenderTree/qt/DumpRenderTree.h:
 929
 930 2009-12-02  Eric Seidel  <eric@webkit.org>
 931
 932         Reviewed by Adam Barth.
 933
 934         REGRESSION(51595): commit-queue is throwing exceptions
 935         https://bugs.webkit.org/show_bug.cgi?id=32083
 936
 937         * Scripts/modules/commands/queues.py:
 938          - Don't use default value of [] as it ends up getting shared.
 939          - Make log_progress accept arrays of ints as well as strings.
 940          - Return an exit code from execute()
 941         * Scripts/modules/commands/queues_unittest.py: Added.
 942          - Test to make sure log_progress will accept ints.
 943          - Test to make sure run_bugzilla_tool will accept ints.
 944         * Scripts/modules/workqueue.py:
 945          - Print the stack trace on unexpected exceptions for easier debugging.
 946         * Scripts/run-webkit-unittests:
 947          - Add queues_unittest.
 948
 949         * Scripts/modules/commands/queues.py:
 950         * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
 951         * Scripts/modules/mock_bugzillatool.py:
 952         * Scripts/modules/workqueue.py:
 953         * Scripts/run-webkit-unittests:
 954
 955 2009-12-02  David Levin  <levin@chromium.org>
 956
 957         Reviewed by Adam Barth.
 958
 959         check-webkit-style is too noisy about namespace indenting issues.
 960         https://bugs.webkit.org/show_bug.cgi?id=32096
 961
 962         * Scripts/modules/cpp_style.py:
 963         Added a _FileState object to be able to track file level information. In this
 964         case, it simply tracks whether the error has already been given, so that it isn't
 965         done again.
 966         * Scripts/modules/cpp_style_unittest.py:
 967         Modified test cases to pass in the _FileState object and fix a test that expected
 968         to see the namespace error twice (now it only occurs once). No new tests because
 969         existing tests cover the change in functionality.
 970
 971 2009-12-01  Kevin Ollivier  <kevino@theolliviers.com>
 972
 973         Reviewed by Eric Seidel.
 974
 975         [wx] Get DumpRenderTree building after waf switch.
 976
 977         https://bugs.webkit.org/show_bug.cgi?id=32041
 978
 979         * DumpRenderTree/wscript: Added.
 980         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 981         (LayoutTestController::setTimelineProfilingEnabled):
 982         (LayoutTestController::evaluateScriptInIsolatedWorld):
 983         (LayoutTestController::disableImageLoading):
 984         (LayoutTestController::whiteListAccessFromOrigin):
 985         (LayoutTestController::counterValueForElementById):
 986         * Scripts/build-webkit:
 987
 988 2009-12-02  Adam Barth  <abarth@webkit.org>
 989
 990         Reviewed by Eric Seidel.
 991
 992         [bzt] build-attachment shouldn't check whether the builders are red
 993         https://bugs.webkit.org/show_bug.cgi?id=32062
 994
 995         build-attachment doesn't touch the remote repository, so there isn't a
 996         need to hold off when the builders are red.
 997
 998         * Scripts/modules/commands/download.py:
 999         * Scripts/modules/landingsequence.py:
1000
1001 2009-12-02  Eric Seidel  <eric@webkit.org>
1002
1003         Reviewed by Adam Barth.
1004
1005         REGRESSION(51590): style-queue and build-queue think their empty when they are not
1006         https://bugs.webkit.org/show_bug.cgi?id=32061
1007
1008         * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
1009         * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
1010
1011 2009-12-02  Eric Seidel  <eric@webkit.org>
1012
1013         Reviewed by Adam Barth.
1014
1015         build-queue is throwing exceptions and complaining about
1016         lack of --no-update on build-attachment.  Make it stop.
1017
1018         * Scripts/modules/buildsteps.py:
1019         * Scripts/modules/commands/download.py:
1020
1021 2009-12-02  Adam Barth  <abarth@webkit.org>
1022
1023         Unreviewed "build" fix.  Forgot to declare my variables.  :(
1024
1025         * QueueStatusServer/queue_status.py:
1026
1027 2009-12-02  Adam Barth  <abarth@webkit.org>
1028
1029         Reviewed by Eric Seidel.
1030
1031         [bzt] Implement status bubble view
1032         https://bugs.webkit.org/show_bug.cgi?id=32057
1033
1034         The status bubble is a compact representation of the queue status for a
1035         given patch.  This will eventually help us reduce the comment spam from
1036         the queues.
1037
1038         * QueueStatusServer/index.html: Added HTML5 doctype for sanity.
1039         * QueueStatusServer/queue_status.py:
1040         * QueueStatusServer/status_bubble.html: Added.
1041
1042 2009-12-02  Eric Seidel  <eric@webkit.org>
1043
1044         Reviewed by Adam Barth.
1045
1046         trim commands/*.py includes now that commands are unit tested
1047         https://bugs.webkit.org/show_bug.cgi?id=32056
1048
1049         In the course of ensuring that the unit tests still
1050         passed after this change, I had to actually make them
1051         pass in the first place.
1052
1053         * Scripts/modules/bugzilla.py:
1054          - Fix _parse_attachment_ids_request_query to return ints instead of strings.
1055         * Scripts/modules/commands/download.py: Remove unneeded imports.
1056         * Scripts/modules/commands/queries.py: Ditto.
1057         * Scripts/modules/commands/queues.py: Ditto.
1058         * Scripts/modules/commands/upload.py: Ditto.
1059         * Scripts/modules/scm_unittest.py:
1060          - Fix to expect the \n after the path since echo adds an \n.
1061
1062 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
1063
1064         build-webkit: Remove flex,bison,gperf check for chromium
1065         https://bugs.webkit.org/show_bug.cgi?id=32043
1066
1067         * Scripts/webkitdirs.pm:
1068
1069 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
1070
1071         Build fixage for Windows/GTK for DumpRenderTree.
1072
1073         WAI-ARIA: implement support for ARIA drag and drop
1074         https://bugs.webkit.org/show_bug.cgi?id=32007
1075
1076         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1077         (AccessibilityUIElement::ariaIsGrabbed):
1078         (AccessibilityUIElement::ariaDropEffects):
1079         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1080         (AccessibilityUIElement::ariaIsGrabbed):
1081         (AccessibilityUIElement::ariaDropEffects):
1082
1083 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
1084
1085         Reviewed by Darin Adler.
1086
1087         WAI-ARIA: implement support for ARIA drag and drop
1088         https://bugs.webkit.org/show_bug.cgi?id=32007
1089
1090         * DumpRenderTree/AccessibilityUIElement.cpp:
1091         (getARIADropEffectsCallback):
1092         (getARIAIsGrabbedCallback):
1093         (AccessibilityUIElement::getJSClass):
1094         * DumpRenderTree/AccessibilityUIElement.h:
1095         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1096         (AccessibilityUIElement::ariaIsGrabbed):
1097         (AccessibilityUIElement::ariaDropEffects):
1098
1099 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1100
1101         Not reviewed. GTK DRT try 2.
1102
1103         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1104         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1105
1106 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1107
1108         Not reviewed. Try to fix gtk DRT build.
1109
1110         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1111
1112 2009-12-01  David Levin  <levin@chromium.org>
1113
1114         Reviewed by Eric Seidel.
1115
1116         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
1117         https://bugs.webkit.org/show_bug.cgi?id=32033
1118
1119         * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
1120                                         instead of startswith.
1121         * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
1122
1123 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1124
1125         Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
1126
1127         * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature.
1128
1129 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1130
1131         Reviewed by Simon Fraser.
1132
1133         Add SVG animation test framework with 'snapshot' functionality
1134         https://bugs.webkit.org/show_bug.cgi?id=31897
1135
1136         Add new 'sampleSVGAnimationForElementAtTime' DRT method,
1137         used by the new SVG animation testing framework, implemented
1138         for qt/gtk/win/mac.
1139
1140         * DumpRenderTree/LayoutTestController.cpp:
1141         (sampleSVGAnimationForElementAtTimeCallback):
1142         (LayoutTestController::staticFunctions):
1143         * DumpRenderTree/LayoutTestController.h:
1144         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1145         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1146         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1147         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1148         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1149         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1150         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1151         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1152         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1153         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1154         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1155
1156 2009-12-01  Adam Roben  <aroben@apple.com>
1157
1158         Remove user content before running each test on Windows
1159
1160         Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
1161
1162         Reviewed by Alexey Proskuryakov.
1163
1164         * DumpRenderTree/win/DumpRenderTree.cpp:
1165         (resetWebViewToConsistentStateBeforeTesting): Remove all user content
1166         before each test, which matches Mac.
1167
1168 2009-12-01  Yuzo Fujishima  <yuzo@google.com>
1169
1170         Reviewed by Alexey Proskuryakov.
1171
1172         Make pywebsocket log errors to a file
1173         https://bugs.webkit.org/show_bug.cgi?id=31604
1174
1175         * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
1176         (by passing the path to the server via a recently added -l option).
1177
1178 2009-12-01  Adam Roben  <aroben@apple.com>
1179
1180         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
1181
1182         Reviewed by Ada Chan.
1183
1184         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
1185         TestNetscapePlugin fail in Debug_Internal builds
1186
1187         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
1188         directory in Debug and Debug_All builds, but not in Debug_Internal
1189         builds.
1190
1191 2009-12-01  Adam Roben  <aroben@apple.com>
1192
1193         Re-enable DRT's watchdog timer on Windows
1194
1195         It was accidentally disabled in r50907.
1196
1197         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1198         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
1199         into an if condition.
1200
1201 2009-12-01  Adam Barth  <abarth@webkit.org>
1202
1203         Reviewed by Eric Seidel.
1204
1205         check-webkit-style complains about #imports with / in them
1206         https://bugs.webkit.org/show_bug.cgi?id=32022
1207
1208         We need to exclude #import directives in addition to #include from the
1209         binary operator whitespace checks.
1210
1211         * Scripts/modules/cpp_style.py:
1212         * Scripts/modules/cpp_style_unittest.py:
1213
1214 2009-11-30  Adam Barth  <abarth@webkit.org>
1215
1216         Reviewed by Eric Seidel.
1217
1218         check-webkit-style is slightly too verbose
1219         https://bugs.webkit.org/show_bug.cgi?id=32010
1220
1221         check-webkit-style prints out a bunch of "done" lines that seem redundant,
1222         especially for the style-queue.
1223
1224         * Scripts/modules/cpp_style.py:
1225
1226 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
1227
1228         Reviewed by Eric Seidel.
1229
1230         [GTK] Moved the functions that are closing the result log of the
1231         tests to the last line of the runTest function, this avoids
1232         reporting crashes in the wrong test if there is a problem when
1233         reseting the state after the test.
1234
1235         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1236         (dump):
1237         (runTest):
1238
1239 2009-11-30  Sam Weinig  <sam@webkit.org>
1240
1241         Reviewed by Geoffrey Garen.
1242
1243         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
1244         fast/js/date-proto-generic-invocation breaks another test
1245
1246         Don't cache JSClassRefs, a change to the prototype chain will
1247         last between tests.
1248
1249         * DumpRenderTree/AccessibilityController.cpp:
1250         (AccessibilityController::getJSClass):
1251         * DumpRenderTree/GCController.cpp:
1252         (GCController::getJSClass):
1253         * DumpRenderTree/GCController.h:
1254         * DumpRenderTree/LayoutTestController.cpp:
1255         (LayoutTestController::getJSClass):
1256
1257 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
1258
1259         Reviewed by Alexey Proskuryakov.
1260
1261         Update pywebsocket to 0.4.2.1.
1262         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
1263         https://bugs.webkit.org/show_bug.cgi?id=31976
1264
1265         * pywebsocket/mod_pywebsocket/standalone.py:
1266         * pywebsocket/setup.py:
1267
1268 2009-11-30  Adam Barth  <abarth@webkit.org>
1269
1270         Reviewed by Eric Seidel.
1271
1272         [bzt] Generate pass messages for style-queue
1273         https://bugs.webkit.org/show_bug.cgi?id=31995
1274
1275         With this change, the style-queue posts "pass" messages to bugs as
1276         well.  Also, added more information to the state store w.r.t. passing
1277         and failing.
1278
1279         * Scripts/modules/commands/queues.py:
1280         * Scripts/modules/patchcollection.py:
1281
1282 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1283
1284         Reviewed by Simon Fraser.
1285
1286         Check for WEBKIT_TESTFONTS environment variable in
1287         run-webkit-tests, for GTK+, to have a more prominent error
1288         message.
1289
1290         * Scripts/run-webkit-tests:
1291
1292 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
1293
1294         Reviewed by Dimitri Glazkov.
1295
1296         update-webkit --chromium forces gclient sync
1297
1298         https://bugs.webkit.org/show_bug.cgi?id=31967
1299
1300         * Scripts/update-webkit-chromium:
1301
1302 2009-11-29  Eric Seidel  <eric@webkit.org>
1303
1304         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
1305
1306         * Scripts/modules/committers.py:
1307
1308 2009-11-29  Eric Seidel  <eric@webkit.org>
1309
1310         No review, just adding missing svn property.
1311
1312         Set svn:executable property on new scripts.
1313         These were added by commit-queue commits, but the executable
1314         property was lost due to a bug in svn-apply:
1315         https://bugs.webkit.org/show_bug.cgi?id=27204
1316
1317         * Scripts/update-webkit-chromium: Added property svn:executable.
1318         * Scripts/validate-committer-lists: Added property svn:executable.
1319
1320 2009-11-29  Eric Seidel  <eric@webkit.org>
1321
1322         Reviewed by Adam Barth.
1323
1324         Need a way to validate that committers.py includes all committers/reviewers
1325         https://bugs.webkit.org/show_bug.cgi?id=30970
1326
1327         Add a script which knows how to compare our public committer/reviewer
1328         lists and show discrepancies between them.
1329
1330         Validates mailing lists vs. committers.py:
1331         - committers.py committers missing from webkit-committers@lists
1332         - webkit-committers@lists members missing from committers.py
1333         - committers.py reviewers missing from webkit-reviewers@lists
1334         - webkit-reviewers@lists members missing from committers.py
1335         - webkit-reviewers@lists members missing from committers.py reviewer list
1336
1337         Validates committers.py vs. trunk/ SVN history:
1338         - committers who have not committed in over a year
1339         - SVN committers missing from committers.py
1340         - committers.py members who have no record in SVN.
1341
1342         All of these lists still show "false positives" until a few more committers.py updates are made, like:
1343         https://bugs.webkit.org/show_bug.cgi?id=31366
1344
1345         * Scripts/validate-committer-lists: Added.
1346
1347 2009-11-28  Adam Barth  <abarth@webkit.org>
1348
1349         Reviewed by Eric Seidel.
1350
1351         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
1352         https://bugs.webkit.org/show_bug.cgi?id=31950
1353
1354         Now we cache the last status that we get back from QueueStatusServer.
1355         Eventually we'll have to do something more fancy if we want to support
1356         a "try again" button on QueueStatusServer, but we can cross that bridge
1357         when we come to it.
1358
1359         * Scripts/modules/patchcollection.py:
1360
1361 2009-11-28  Adam Barth  <abarth@webkit.org>
1362
1363         Reviewed by Eric Seidel.
1364
1365         StyleQueue scans ~100 bug pages every 5 minutes
1366         https://bugs.webkit.org/show_bug.cgi?id=31947
1367
1368         Instead of getting the pending-review attachment ids by scanning each
1369         bug (which results in a network request), we should just get them all
1370         from webkit.org/pending-review in one shot.
1371
1372         * Scripts/modules/bugzilla.py:
1373         * Scripts/modules/bugzilla_unittest.py:
1374         * Scripts/modules/commands/queries.py:
1375         * Scripts/modules/commands/queries_unittest.py:
1376         * Scripts/modules/commands/queues.py:
1377         * Scripts/modules/mock_bugzillatool.py:
1378         * Scripts/modules/patchcollection.py:
1379
1380 2009-11-28  Adam Barth  <abarth@webkit.org>
1381
1382         Reviewed by Eric Seidel.
1383
1384         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
1385         https://bugs.webkit.org/show_bug.cgi?id=31952
1386
1387         The mailing list is open for anyone to subscribe.
1388
1389         * Scripts/modules/bugzilla.py:
1390         * Scripts/modules/commands/queues.py:
1391
1392 2009-11-28  Adam Barth  <abarth@webkit.org>
1393
1394         Reviewed by Eric Seidel.
1395
1396         [bzt] style-queue should report style errors to bugzilla
1397         https://bugs.webkit.org/show_bug.cgi?id=31945
1398
1399         Currently, we're just logging the style errors locally.  With this
1400         patch we'll actually log the errors to bugzilla.  Note: I plan to run
1401         with the "local-only" logging during development.
1402
1403         * Scripts/modules/commands/queues.py:
1404         * Scripts/modules/scm.py:
1405
1406 2009-11-28  Adam Barth  <abarth@webkit.org>
1407
1408         Reviewed by Eric Seidel.
1409
1410         [bzt] style-queue shouldn't reject patches from the commit-queue
1411         https://bugs.webkit.org/show_bug.cgi?id=31944
1412
1413         Currently the style-queue subprocess gets confused and thinks its the
1414         commit-queue.  If the patch has an error, it rejects it from the
1415         commit-queue.  Instead, we should have style-queue specific logic.
1416         This patch doesn't add that logic, but it gives us a callback we can
1417         use to add that logic.
1418
1419         * Scripts/modules/buildsteps.py:
1420         * Scripts/modules/commands/queues.py:
1421         * Scripts/modules/landingsequence.py:
1422
1423 2009-11-27  Adam Barth  <abarth@webkit.org>
1424
1425         Rubber stamped by Eric Seidel.
1426
1427         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
1428
1429         * CommitQueueStatus: Removed.
1430         * CommitQueueStatus/app.yaml: Removed.
1431         * CommitQueueStatus/filters: Removed.
1432         * CommitQueueStatus/filters/__init__.py: Removed.
1433         * CommitQueueStatus/filters/webkit_extras.py: Removed.
1434         * CommitQueueStatus/index.html: Removed.
1435         * CommitQueueStatus/index.yaml: Removed.
1436         * CommitQueueStatus/queue_status.py: Removed.
1437         * CommitQueueStatus/stylesheets: Removed.
1438         * CommitQueueStatus/stylesheets/main.css: Removed.
1439         * CommitQueueStatus/update_status.html: Removed.
1440         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
1441
1442 2009-11-27  Adam Barth  <abarth@webkit.org>
1443
1444         Reviewed by Eric Seidel.
1445
1446         style-queue should only process each patch once
1447         https://bugs.webkit.org/show_bug.cgi?id=31939
1448
1449         Actually address reviewer comments!
1450
1451         * Scripts/bugzilla-tool:
1452
1453 2009-11-27  Adam Barth  <abarth@webkit.org>
1454
1455         Reviewed by Eric Seidel.
1456
1457         [bzt] style-queue fails to apply a bunch of patches for no reason
1458         https://bugs.webkit.org/show_bug.cgi?id=31942
1459
1460         By passing --non-interactive to check-style, we convince check-style
1461         to pass --force to svn-apply, which lets it apply more patches.
1462
1463         * Scripts/modules/commands/queues.py:
1464
1465 2009-11-27  Adam Barth  <abarth@webkit.org>
1466
1467         Reviewed by Eric Seidel.
1468
1469         [bzt] Support --status-host in style-queue
1470         https://bugs.webkit.org/show_bug.cgi?id=31941
1471
1472         * Scripts/modules/commands/queues.py:
1473         * Scripts/modules/statusbot.py:
1474
1475 2009-11-27  Adam Barth  <abarth@webkit.org>
1476
1477         Reviewed by Eric Seidel.
1478
1479         style-queue should only process each patch once
1480         https://bugs.webkit.org/show_bug.cgi?id=31939
1481
1482         Before processing a patch, the try-queues now ask the web service
1483         whether they have already processed the patch.  This is an initial cut
1484         of this functionality.  I expect we're make it richer over time.
1485
1486         * Scripts/bugzilla-tool:
1487         * Scripts/modules/commands/queues.py:
1488         * Scripts/modules/patchcollection.py:
1489
1490 2009-11-27  Adam Barth  <abarth@webkit.org>
1491
1492         Reviewed by Eric Seidel.
1493
1494         PatchStatus does not return status
1495         https://bugs.webkit.org/show_bug.cgi?id=31938
1496
1497         We need to parse attachment_id as an int.  Otherwise, we can't find
1498         anything in the datastore.
1499
1500         * CommitQueueStatus/queue_status.py:
1501
1502 2009-11-27  Adam Barth  <abarth@webkit.org>
1503
1504         Reviewed by Eric Seidel.
1505
1506         Make commit-queue status not throw an exception where there is not
1507         status
1508         https://bugs.webkit.org/show_bug.cgi?id=31936
1509
1510         We need to actually fetch the results of the query to see what's in the
1511         datastore.
1512
1513         * CommitQueueStatus/queue_status.py:
1514
1515 2009-11-27  Adam Barth  <abarth@webkit.org>
1516
1517         Reviewed by Eric Seidel.
1518
1519         [bzt] unit test ApplyPatches and ApplyAttachment
1520         https://bugs.webkit.org/show_bug.cgi?id=31935
1521
1522         * Scripts/modules/commands/download.py:
1523         * Scripts/modules/commands/download_unittest.py:
1524
1525 2009-11-27  Adam Barth  <abarth@webkit.org>
1526
1527         Reviewed by Eric Seidel.
1528
1529         [bzt] Unit test download commands
1530         https://bugs.webkit.org/show_bug.cgi?id=31923
1531
1532         Adds download_unittest and fixes a bug found while testing.
1533
1534         * Scripts/modules/commands/commandtest.py:
1535         * Scripts/modules/commands/download.py:
1536             Fixed a bug where we'd throw an error because [].append returns
1537             None.
1538         * Scripts/modules/commands/download_unittest.py: Added.
1539         * Scripts/modules/mock_bugzillatool.py:
1540         * Scripts/run-webkit-unittests:
1541
1542 2009-11-27  Adam Barth  <abarth@webkit.org>
1543
1544         Unreviewed "build" fix found while writing unit tests.
1545
1546         * Scripts/modules/commands/download.py:
1547
1548 2009-11-27  Adam Barth  <abarth@webkit.org>
1549
1550         Reviewed by Eric Seidel.
1551
1552         [bzt] Kill WebKitLandingScripts
1553         https://bugs.webkit.org/show_bug.cgi?id=31904
1554
1555         Step 6: Kill the rest.
1556
1557         * Scripts/modules/buildsteps.py:
1558         * Scripts/modules/commands/download.py:
1559         * Scripts/modules/commands/queries.py:
1560         * Scripts/modules/commands/upload.py:
1561         * Scripts/modules/landingsequence.py:
1562         * Scripts/modules/scm.py:
1563         * Scripts/modules/webkitlandingscripts.py: Removed.
1564
1565 2009-11-27  Adam Barth  <abarth@webkit.org>
1566
1567         Reviewed by Eric Seidel.
1568
1569         [bzt] Unit test upload commands
1570         https://bugs.webkit.org/show_bug.cgi?id=31903
1571
1572         Adds unit tests for all but two of the upload commands.  The two
1573         remaining ones are more difficult.  I'll return to them later.  The
1574         goal of these tests is just to run the commands.  We can test more
1575         detailed behavior later.
1576
1577         * Scripts/modules/commands/commandtest.py:
1578         * Scripts/modules/commands/upload.py:
1579         * Scripts/modules/commands/upload_unittest.py:
1580         * Scripts/modules/mock.py: Added.
1581         * Scripts/modules/mock_bugzillatool.py:
1582
1583 2009-11-26  Adam Barth  <abarth@webkit.org>
1584
1585         Reviewed by Eric Seidel.
1586
1587         [bzt] Kill WebKitLandingScripts
1588         https://bugs.webkit.org/show_bug.cgi?id=31904
1589
1590         Step 5: Kill run_and_throw_if_fail.
1591
1592         * Scripts/modules/buildsteps.py:
1593         * Scripts/modules/processutils.py: Added.
1594         * Scripts/modules/webkitlandingscripts.py:
1595
1596 2009-11-26  Adam Barth  <abarth@webkit.org>
1597
1598         Reviewed by Eric Seidel.
1599
1600         [bzt] Kill WebKitLandingScripts
1601         https://bugs.webkit.org/show_bug.cgi?id=31904
1602
1603         Step 4: Kill run_webkit_script.
1604
1605         * Scripts/modules/buildsteps.py:
1606         * Scripts/modules/commands/download.py:
1607         * Scripts/modules/webkitlandingscripts.py:
1608
1609 2009-11-26  Adam Barth  <abarth@webkit.org>
1610
1611         Reviewed by Eric Seidel.
1612
1613         [bzt] Kill WebKitLandingScripts
1614         https://bugs.webkit.org/show_bug.cgi?id=31904
1615
1616         Step 3: Kill build_webkit.
1617
1618         * Scripts/modules/buildsteps.py:
1619         * Scripts/modules/landingsequence.py:
1620         * Scripts/modules/webkitlandingscripts.py:
1621
1622 2009-11-26  Adam Barth  <abarth@webkit.org>
1623
1624         Reviewed by Eric Seidel.
1625
1626         [bzt] Kill WebKitLandingScripts
1627         https://bugs.webkit.org/show_bug.cgi?id=31904
1628
1629         Step 2: Kill ensure_builders_are_green.
1630
1631         * Scripts/modules/buildsteps.py:
1632         * Scripts/modules/commands/download.py:
1633         * Scripts/modules/landingsequence.py:
1634         * Scripts/modules/webkitlandingscripts.py:
1635
1636 2009-11-26  Adam Barth  <abarth@webkit.org>
1637
1638         Reviewed by Eric Seidel.
1639
1640         [bzt] Kill WebKitLandingScripts
1641         https://bugs.webkit.org/show_bug.cgi?id=31904
1642
1643         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
1644
1645         * Scripts/bugzilla-tool:
1646         * Scripts/modules/buildsteps.py: Added.
1647         * Scripts/modules/commands/download.py:
1648         * Scripts/modules/landingsequence.py:
1649         * Scripts/modules/webkitlandingscripts.py:
1650
1651 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
1652
1653         Reviewed by Adam Barth.
1654
1655         Remove directory prefixes from linux commands
1656
1657         SCM unittests can cause errors on some systems if we use absolute reference to
1658         the commands, so directory prefixes have been removed.
1659
1660         * Scripts/modules/scm_unittest.py:
1661
1662 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
1663
1664         Reviewed by Kenneth Rohde Christiansen.
1665
1666         Link DumpRenderTree to the Qt Ui Tools
1667         https://bugs.webkit.org/show_bug.cgi?id=31203
1668
1669         Implement QWebPage::createPlugin using the Qt Ui Tools
1670         to be able to create classes like QProgressBar from within
1671         the <object></object> tags This is required for the
1672         new automatic test of Qt Plugins.
1673
1674         * DumpRenderTree/qt/DumpRenderTree.cpp:
1675         (WebCore::WebPage::createPlugin):
1676         * DumpRenderTree/qt/DumpRenderTree.h:
1677         * DumpRenderTree/qt/DumpRenderTree.pro:
1678
1679 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
1680
1681         Reviewed by Eric Seidel.
1682
1683         Update pywebsocket to 0.4.2
1684
1685         Update pywebsocket to 0.4.2
1686         https://bugs.webkit.org/show_bug.cgi?id=31861
1687
1688         * pywebsocket/example/echo_client.py:
1689         * pywebsocket/example/echo_wsh.py:
1690         * pywebsocket/mod_pywebsocket/__init__.py:
1691         * pywebsocket/mod_pywebsocket/dispatch.py:
1692         * pywebsocket/mod_pywebsocket/msgutil.py:
1693         * pywebsocket/mod_pywebsocket/standalone.py:
1694         * pywebsocket/setup.py:
1695         * pywebsocket/test/test_dispatch.py:
1696         * pywebsocket/test/test_msgutil.py:
1697
1698 2009-11-25  Adam Barth  <abarth@webkit.org>
1699
1700         Reviewed by Eric Seidel.
1701
1702         Add unit test for mark-fixed
1703         https://bugs.webkit.org/show_bug.cgi?id=31896
1704
1705         * Scripts/modules/commands/commandtest.py: Added.
1706         * Scripts/modules/commands/queries_unittest.py:
1707         * Scripts/modules/commands/upload_unittest.py: Added.
1708         * Scripts/modules/mock_bugzillatool.py:
1709         * Scripts/run-webkit-unittests:
1710
1711 2009-11-25  Adam Barth  <abarth@webkit.org>
1712
1713         Reviewed by Eric Seidel.
1714
1715         bugzilla-tool should have a mark-fixed command
1716         https://bugs.webkit.org/show_bug.cgi?id=31853
1717
1718         Pretty simple stuff.
1719
1720         * Scripts/modules/commands/upload.py:
1721
1722 2009-11-25  Eric Seidel  <eric@webkit.org>
1723
1724         Reviewed by Adam Barth.
1725
1726         'bugzilla-tool help' should only show common commands like how 'git help' does
1727         https://bugs.webkit.org/show_bug.cgi?id=31772
1728
1729         I also took this opportunity to make 'help' a real Command.
1730         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
1731
1732         * Scripts/bugzilla-tool:
1733          - change should_show_command_help to should_show_in_main_help
1734         * Scripts/modules/commands/download.py:
1735          - Mark commands as being shown in main help or not.
1736          - show_in_main_help = False is not required (default is false),
1737            but it seemed to make the commands more self-documenting.
1738         * Scripts/modules/commands/queries.py: ditto
1739         * Scripts/modules/commands/queues.py: ditto
1740         * Scripts/modules/commands/upload.py: ditto
1741         * Scripts/modules/multicommandtool.py:
1742          - Make Command hold a pointer to tool in self.tool.  Most Command
1743            subclasses do not take advantage of this yet, but it was required
1744            for HelpCommand to be able to reach the tool from _help_epilog().
1745          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
1746          - Move MultiCommandTool._help_epilog to Command._help_epilog
1747          - Move "help" logic into HelpCommand.execute()
1748          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
1749         * Scripts/modules/multicommandtool_unittest.py:
1750          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
1751
1752 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
1753
1754         Reviewed by Dan Bernstein.
1755
1756         Patch by Mark Rowe.
1757
1758         The buildbots are failing on Windows because when they were upgraded
1759         to 4.0.4, Apple Application Support was not in their path. Add it to
1760         the path to fix the buildots.
1761
1762         * Scripts/webkitdirs.pm:
1763
1764 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
1765
1766         Reviewed by David Kilzer.
1767
1768         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
1769         https://bugs.webkit.org/show_bug.cgi?id=31799
1770
1771         * Scripts/run-webkit-tests: Fixed.
1772
1773 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
1774
1775         Reviewed by Eric Seidel.
1776
1777         Change run_command to give back stderr by default
1778         https://bugs.webkit.org/show_bug.cgi?id=31734
1779
1780         Change run_command to give back stderr by default.
1781         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
1782         Change the related unittest call.
1783
1784         * Scripts/modules/scm.py:
1785         * Scripts/modules/scm_unittest.py:
1786
1787 2009-11-25  Eric Seidel  <eric@webkit.org>
1788
1789         Reviewed by Adam Barth.
1790
1791         Centralize required argument parsing in Command
1792         https://bugs.webkit.org/show_bug.cgi?id=31872
1793
1794         * Scripts/modules/commands/download.py: remove custom required arg message.
1795         * Scripts/modules/commands/upload.py: ditto.
1796         * Scripts/modules/multicommandtool.py:
1797          - Add _parse_required_arguments.
1798          - Pass program name off to OptionParser.
1799          - Add name() for access to tool name.
1800          - Add check_arguments_and_execute and make it return a return code.
1801          - Replace a couple uses of + with %.
1802         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
1803
1804 2009-11-25  Eric Seidel  <eric@webkit.org>
1805
1806         Reviewed by Adam Barth.
1807
1808         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
1809         https://bugs.webkit.org/show_bug.cgi?id=31870
1810
1811         * Scripts/modules/commands/queries_unittest.py: Use the new class.
1812         * Scripts/modules/multicommandtool_unittest.py: Ditto.
1813         * Scripts/modules/outputcapture.py: Added.
1814
1815 2009-11-24  Dmitry Titov  <dimich@chromium.org>
1816
1817         Reviewed by Eric Seidel.
1818
1819         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
1820         https://bugs.webkit.org/show_bug.cgi?id=31444
1821
1822         * Scripts/build-webkit:
1823
1824 2009-11-24  Chris Marrin  <cmarrin@apple.com>
1825
1826         Reviewed by Simon Fraser.
1827
1828         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
1829         https://bugs.webkit.org/show_bug.cgi?id=27314
1830
1831         Now the script allows the directories with these tests to be included on all
1832         platforms but Mac, where they behave the same as always. For all other platforms
1833         the tests need to be excluded using the Skipped files, which is currently done
1834         for all platforms (including win since we're not turned on yet)
1835
1836         * Scripts/webkitdirs.pm:
1837
1838 2009-11-24  Eric Seidel  <eric@webkit.org>
1839
1840         Reviewed by Adam Barth.
1841
1842         queries_unittest.py should test command output
1843         https://bugs.webkit.org/show_bug.cgi?id=31845
1844
1845         * Scripts/modules/commands/queries_unittest.py:
1846          - Capture stdout and stderr and compare with expected strings.
1847
1848 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
1849
1850         No Review.
1851
1852         Fix spelling error ("depenedencies").
1853
1854         * Scripts/build-webkit:
1855
1856 2009-11-24  Mark Rowe  <mrowe@apple.com>
1857
1858         Land the configuration that includes the two debug GTK Linux builders.
1859
1860         * BuildSlaveSupport/build.webkit.org-config/config.json:
1861
1862 2009-11-24  David Kilzer  <ddkilzer@apple.com>
1863
1864         <http://webkit.org/b/31840> bisect-builds broke after r50080
1865
1866         Reviewed by Dan Bernstein.
1867
1868         * Scripts/bisect-builds:
1869         (mountAndRunNightly): Switched back to using backticks to run
1870         the hdiutil command since exec() will terminate the existing
1871         script, which is not what we want.  Store the output of
1872         File::Spec->devnull() in a variable for use in the hdiutil
1873         detach commands.
1874
1875 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1876
1877         Reviewed by Kenneth Rohde Christiansen.
1878
1879         Include "config.h" to meet Coding Style Guidelines
1880         https://bugs.webkit.org/show_bug.cgi?id=31792
1881
1882         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
1883         * DumpRenderTree/qt/jsobjects.cpp:
1884         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1885
1886 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1887
1888         Reviewed by Oliver Hunt.
1889
1890         Implement new required function to pass test we used to pass. This
1891         change is required since r51294.
1892
1893         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1894         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1895
1896 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
1897
1898         Reviewed by Kenneth Rohde Christiansen.
1899
1900         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
1901         https://bugs.webkit.org/show_bug.cgi?id=31775
1902
1903         LayoutTestController::dumpBackForwardList() should work with local URLs
1904         as well as with normal URLs (in http tests for instance).
1905         Currently it does not output the latter properly.
1906
1907         Unskip a bunch of passing http/navigation tests.
1908
1909         * DumpRenderTree/qt/DumpRenderTree.cpp:
1910         (WebCore::dumpHistoryItem):
1911
1912 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
1913
1914         Reviewed by Oliver Hunt.
1915
1916         ARIA: support aria-flowto
1917         https://bugs.webkit.org/show_bug.cgi?id=31762
1918
1919         * DumpRenderTree/AccessibilityUIElement.cpp:
1920         (ariaFlowToElementAtIndexCallback):
1921         (AccessibilityUIElement::getJSClass):
1922         * DumpRenderTree/AccessibilityUIElement.h:
1923         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1924         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1925         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1926         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1927         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1928         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1929
1930 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
1931
1932         Reviewed by Kenneth Christiansen.
1933
1934         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
1935         https://bugs.webkit.org/show_bug.cgi?id=31638
1936
1937         Unfreeze WorkQueue after each test execution.
1938
1939         * DumpRenderTree/qt/DumpRenderTree.cpp:
1940         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1941
1942 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1943
1944         Reviewed by Adam Barth.
1945
1946         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
1947         for localhost and 127.0.0.1.
1948         https://bugs.webkit.org/show_bug.cgi?id=31783
1949
1950         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
1951
1952         * DumpRenderTree/qt/DumpRenderTree.cpp:
1953         (WebCore::NetworkAccessManager::NetworkAccessManager):
1954         (WebCore::NetworkAccessManager::sslErrorsEncountered):
1955         (WebCore::WebPage::WebPage):
1956         * DumpRenderTree/qt/DumpRenderTree.h:
1957
1958 2009-11-22  Chris Evans  <cevans@chromium.org>
1959
1960         Reviewed by Adam Barth.
1961
1962         Disable access to file:/// directory listings
1963         https://bugs.webkit.org/show_bug.cgi?id=31329
1964
1965         Implemented setAllowUniversalAccessFromFileURLs to support testing of
1966         file URL security.
1967
1968         * DumpRenderTree/LayoutTestController.cpp:
1969         (setAllowUniversalAccessFromFileURLsCallback):
1970         (LayoutTestController::staticFunctions):
1971         * DumpRenderTree/LayoutTestController.h:
1972         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1973         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1974         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1975         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1976         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1977         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1978         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1979         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1980
1981 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1982
1983         Reviewed by Kenneth Rohde Christiansen.
1984
1985         [Qt] Fix the timeout of fast/frames/frame-navigation.html
1986         https://bugs.webkit.org/show_bug.cgi?id=31638
1987
1988         The test is timeouting, because it uses the WorkQueue to load a document in one
1989         of the child frames and once the loading is finished, the DRT does not dump the
1990         tree. This is because it waits for the QWebFrame::loadFinished() signal from
1991         the main frame, while it should connect to QWebPage::loadFinished().
1992
1993         * DumpRenderTree/qt/DumpRenderTree.cpp:
1994         (WebCore::DumpRenderTree::DumpRenderTree):
1995
1996 2009-11-21  Eric Seidel  <eric@webkit.org>
1997
1998         Reviewed by Adam Barth.
1999
2000         bugzilla-tool --help spews way too much text
2001         https://bugs.webkit.org/show_bug.cgi?id=31771
2002
2003         * Scripts/bugzilla-tool:
2004          - Remove self.cached_scm initialization hack.
2005         * Scripts/modules/buildbot.py:
2006          - Make default_host accessible to callers.
2007         * Scripts/modules/commands/download.py:
2008          - Phrase help for all commands consistently and remove spurious help text punctuation.
2009         * Scripts/modules/commands/queries.py: Ditto.
2010         * Scripts/modules/commands/queues.py: Ditto.
2011         * Scripts/modules/commands/upload.py: Ditto.
2012         * Scripts/modules/multicommandtool.py:
2013          - Add HelpPrintingOptionParser.format_epilog to replace
2014            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
2015            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
2016          - Make --help only show a list of commands like "svn help" and "git help" do --
2017            previously --help was listing all commands and options.
2018          - Sort list of commands alphabetically.
2019
2020 2009-11-21  Eric Seidel  <eric@webkit.org>
2021
2022         No review.  Fixing a typo from the previous patch for bug 31767.
2023
2024         AbstractQueue.run_bugzilla_tool throws an exception
2025         https://bugs.webkit.org/show_bug.cgi?id=31769
2026
2027         * Scripts/modules/commands/queues.py:
2028
2029 2009-11-21  Eric Seidel  <eric@webkit.org>
2030
2031         Reviewed by Adam Barth.
2032
2033         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
2034         https://bugs.webkit.org/show_bug.cgi?id=31767
2035
2036         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
2037         Since we don't have a good way to test BugzillaTool pieces, I've
2038         left out a test for now.
2039
2040         * Scripts/bugzilla-tool:
2041          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
2042         * Scripts/modules/commands/queues.py:
2043          - Use tool.path() instead of __file__.
2044         * Scripts/modules/multicommandtool.py:
2045          - Add a new path() method to MultiComandTool.
2046         * Scripts/modules/multicommandtool_unittest.py:
2047          - Provide a path() method.  Little point in testing this mock implementation.
2048
2049 2009-11-21  Adam Barth  <abarth@webkit.org>
2050
2051         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
2052         WebKitTools.
2053
2054         * Scripts/modules/commands/download.py:
2055
2056 2009-11-21  Adam Barth  <abarth@webkit.org>
2057
2058         Reviewed by Eric Seidel.
2059
2060         Convert check-style to use LandingSequence
2061         https://bugs.webkit.org/show_bug.cgi?id=31763
2062
2063         Instead of manipulating the working copy by hand, we should use the
2064         LandingSequence in CheckStyle.  This will make this code eaiser to
2065         test.
2066
2067         * Scripts/modules/commands/download.py:
2068
2069 2009-11-20  Adam Barth  <abarth@webkit.org>
2070
2071         Reviewed by Eric Seidel.
2072
2073         Unit test query commands
2074         https://bugs.webkit.org/show_bug.cgi?id=31755
2075
2076         These tests are pretty rough, but hopefully they'll grow.
2077
2078         * Scripts/modules/commands/queries_unittest.py: Added.
2079         * Scripts/modules/mock_bugzillatool.py: Added.
2080         * Scripts/run-webkit-unittests:
2081
2082 2009-11-20  Eric Seidel  <eric@webkit.org>
2083
2084         Reviewed by Adam Barth.
2085
2086         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
2087         https://bugs.webkit.org/show_bug.cgi?id=31758
2088
2089         * Scripts/modules/multicommandtool.py:
2090          - Allow passing of explicit commands to MultiCommandTool.__init__
2091         * Scripts/modules/multicommandtool_unittest.py:
2092          - Use new Command.name naming system.
2093          - Test Command auto-discovery.
2094         * Scripts/modules/workqueue.py:
2095          - bug_id no longer exists, use patch['bug_id'] instead.
2096         * Scripts/modules/workqueue_unittest.py:
2097          - WorkQueues require names now.
2098          - should_proceed_with_work_item must return a patch object.
2099
2100 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
2101
2102         Reviewed by Beth Dakin.
2103
2104         WAI-ARIA: add support for aria-owns
2105         https://bugs.webkit.org/show_bug.cgi?id=31702
2106
2107         * DumpRenderTree/AccessibilityUIElement.cpp:
2108         (ariaOwnsElementAtIndexCallback):
2109         (AccessibilityUIElement::getJSClass):
2110         * DumpRenderTree/AccessibilityUIElement.h:
2111         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2112         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2113         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2114         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2115         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2116         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2117
2118 2009-11-20  Eric Seidel  <eric@webkit.org>
2119
2120         Reviewed by Adam Barth.
2121
2122         Fix exception thrown when running the commit-queue.
2123
2124         * Scripts/modules/statusbot.py: patch is optional.
2125         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
2126
2127 2009-11-20  Eric Seidel  <eric@webkit.org>
2128
2129         Reviewed by Adam Barth.
2130
2131         Teach the StatusBot how to support more than just the commit-queue
2132         https://bugs.webkit.org/show_bug.cgi?id=31754
2133
2134         * Scripts/modules/workqueue.py: Another typo.
2135
2136 2009-11-20  Eric Seidel  <eric@webkit.org>
2137
2138         Reviewed by Adam Barth.
2139
2140         Teach the StatusBot how to support more than just the commit-queue
2141         https://bugs.webkit.org/show_bug.cgi?id=31754
2142
2143         * Scripts/modules/commands/queues.py: Fix silly typo.
2144
2145 2009-11-20  Eric Seidel  <eric@webkit.org>
2146
2147         Reviewed by Adam Barth.
2148
2149         Teach the StatusBot how to support more than just the commit-queue
2150         https://bugs.webkit.org/show_bug.cgi?id=31754
2151
2152         * CommitQueueStatus/index.yaml:
2153          - Add indices required for the new queries.
2154         * CommitQueueStatus/queue_status.py:
2155          - Add a patch-status page and move update_status to update-status.
2156          - Only display "commit-queue" status records for the commit-queue.
2157          - Add support for a queue_name property on status records.
2158          - Fix _int_from_request to actually work.
2159         * CommitQueueStatus/update_status.html:
2160          - Add support for a queue_name on status records.
2161          - Remove unused list of bug ids.
2162          * Scripts/modules/commands/queues.py
2163           - Make the queues pass the patch instead of the bug_id to StatusBot.
2164         * Scripts/modules/statusbot.py:
2165          - Support passing the queue_name to the status updates.
2166          - Support fetching patch status with patch_status().
2167         * Scripts/modules/workqueue.py:
2168          - Pass the patch to the StatusBot instead of the bug_id.
2169          - Let WorkQueues have a name.
2170
2171 2009-11-20  Adam Barth  <abarth@webkit.org>
2172
2173         Reviewed by Eric Seidel.
2174
2175         Move bugzilla-tool commands into their own file
2176         https://bugs.webkit.org/show_bug.cgi?id=31752
2177
2178         This will let us write unit tests.
2179
2180         * Scripts/bugzilla-tool:
2181         * Scripts/modules/commands/__init__.py: Added.
2182         * Scripts/modules/commands/download.py: Added.
2183         * Scripts/modules/commands/queries.py: Added.
2184         * Scripts/modules/commands/queues.py: Added.
2185         * Scripts/modules/commands/upload.py: Added.
2186         * Scripts/modules/grammar.py: Added.
2187
2188 2009-11-20  Adam Barth  <abarth@webkit.org>
2189
2190         Reviewed by Eric Seidel.
2191
2192         BuildQueue should check if the tree is currently buildable
2193         https://bugs.webkit.org/show_bug.cgi?id=31744
2194
2195         * Scripts/bugzilla-tool:
2196         * Scripts/modules/landingsequence.py:
2197         * Scripts/modules/webkitlandingscripts.py:
2198
2199 2009-11-20  Adam Barth  <abarth@webkit.org>
2200
2201         Reviewed by Eric Seidel.
2202
2203         Move prepare_clean_working_directory into the LandingSequence
2204         https://bugs.webkit.org/show_bug.cgi?id=31743
2205
2206         * Scripts/bugzilla-tool:
2207         * Scripts/modules/landingsequence.py:
2208
2209 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
2210
2211         Reviewed by Kenneth Rohde Christiansen.
2212
2213         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
2214         https://bugs.webkit.org/show_bug.cgi?id=30460
2215
2216         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
2217
2218         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2219         (pluginInvoke):
2220
2221 2009-11-20  Adam Barth  <abarth@webkit.org>
2222
2223         Reviewed by Eric Seidel.
2224
2225         Pass the port information to the child process
2226         https://bugs.webkit.org/show_bug.cgi?id=31736
2227
2228         We need to do this so the child process knows what to build!
2229
2230         * Scripts/bugzilla-tool:
2231         * Scripts/modules/landingsequence.py:
2232         * Scripts/modules/webkitport.py:
2233         * Scripts/modules/webkitport_unittest.py:
2234
2235 2009-11-20  Adam Barth  <abarth@webkit.org>
2236
2237         Reviewed by Eric Seidel.
2238
2239         Support Qt port in build-queue
2240         https://bugs.webkit.org/show_bug.cgi?id=31733
2241
2242         * Scripts/bugzilla-tool:
2243
2244 2009-11-20  Adam Barth  <abarth@webkit.org>
2245
2246         Reviewed by Eric Seidel.
2247
2248         Implement a build-queue
2249         https://bugs.webkit.org/show_bug.cgi?id=31725
2250
2251         Currently this just builds the first 10 patches in the review queue.
2252         We'll want to do something smarter soon.
2253
2254         * Scripts/bugzilla-tool:
2255
2256 2009-11-20  Adam Barth  <abarth@webkit.org>
2257
2258         Reviewed by Eric Seidel.
2259
2260         Make commit-queue and style-queue show up in help
2261         https://bugs.webkit.org/show_bug.cgi?id=31724
2262
2263         We need to store their names on their class to make these commands
2264         properly register themselves with MultiCommandTool.
2265
2266         * Scripts/bugzilla-tool:
2267
2268 2009-11-20  Adam Barth  <abarth@webkit.org>
2269
2270         Reviewed by Eric Seidel.
2271
2272         Implement bugzilla-tool build-attachment
2273         https://bugs.webkit.org/show_bug.cgi?id=31722
2274
2275         This command builds an attachment from bugzilla.  It leaves the built
2276         patch in the working copy.
2277
2278         * Scripts/bugzilla-tool:
2279         * Scripts/modules/landingsequence.py:
2280         * Scripts/modules/webkitlandingscripts.py:
2281
2282 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
2283
2284         Reviewed by Xan Lopez.
2285
2286         [GTK] DRT release event does not create the state correctly
2287         https://bugs.webkit.org/show_bug.cgi?id=31717
2288
2289         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2290
2291 2009-11-20  Eric Seidel  <eric@webkit.org>
2292
2293         Reviewed by Adam Barth.
2294
2295         MultiCommandTool should find Command objects automatically instead of with a manual list
2296         https://bugs.webkit.org/show_bug.cgi?id=31710
2297
2298         * Scripts/bugzilla-tool:
2299         * Scripts/modules/multicommandtool.py:
2300          - Use some wild python-fu to crawl all the known subclasses of Command.
2301
2302 2009-11-20  Adam Barth  <abarth@webkit.org>
2303
2304         Unreviewed "build" fix.  Added missing import.
2305
2306         * Scripts/bugzilla-tool:
2307
2308 2009-11-20  Adam Barth  <abarth@webkit.org>
2309
2310         Unreviewed "build" fix.  I failed to update LandingSequence.test
2311         properly.
2312
2313         * Scripts/modules/landingsequence.py:
2314
2315 2009-11-20  Adam Barth  <abarth@webkit.org>
2316
2317         Reviewed by Eric Seidel.
2318
2319         Create LandingSequence as the all-sing, all-dance landing class
2320         https://bugs.webkit.org/show_bug.cgi?id=31709
2321
2322         Client can inherit from this class to carefully control exactly which
2323         steps they wish to have happen in the landing sequence.
2324
2325         * Scripts/bugzilla-tool:
2326         * Scripts/modules/landingsequence.py: Added.
2327         * Scripts/modules/webkitlandingscripts.py: Added.
2328
2329 2009-11-19  Adam Barth  <abarth@webkit.org>
2330
2331         Reviewed by Eric Seidel.
2332
2333         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
2334         https://bugs.webkit.org/show_bug.cgi?id=31707
2335
2336         This is to help when we implement build-attachment.
2337
2338         * Scripts/bugzilla-tool:
2339
2340 2009-11-19  Adam Barth  <abarth@webkit.org>
2341
2342         Reviewed by Eric Seidel.
2343
2344         Support Qt port in bugzilla-tool
2345         https://bugs.webkit.org/show_bug.cgi?id=31701
2346
2347         Now we support building with Qt!
2348
2349         * Scripts/bugzilla-tool:
2350         * Scripts/modules/webkitport.py: Added.
2351         * Scripts/modules/webkitport_unittest.py: Added.
2352         * Scripts/run-webkit-unittests:
2353
2354 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
2355
2356         Reviewed by Adam Barth.
2357
2358         Remove inserting stderr into patch in bugzilla-tool
2359         https://bugs.webkit.org/show_bug.cgi?id=29914
2360
2361         Modify SCM python module's run_command function to avoid return of stderr
2362         by default, so stderr won't be inserted into the patches.
2363         Modify the related unit test.
2364
2365         * Scripts/modules/scm.py:
2366         * Scripts/modules/scm_unittest.py:
2367
2368 2009-11-19  Eric Seidel  <eric@webkit.org>
2369
2370         Reviewed by Adam Barth.
2371
2372         bugzilla-tool needs per-command help
2373         https://bugs.webkit.org/show_bug.cgi?id=31697
2374
2375         Added support for "bugzilla-tool help command-name"
2376         and a unit test to make sure it works.
2377
2378         * Scripts/modules/multicommandtool.py:
2379         * Scripts/modules/multicommandtool_unittest.py:
2380
2381 2009-11-19  Eric Seidel  <eric@webkit.org>
2382
2383         Reviewed by Adam Barth.
2384
2385         Move MultiCommandTool and Command into a separate file and add some basic unit tests
2386         https://bugs.webkit.org/show_bug.cgi?id=31695
2387
2388         * Scripts/bugzilla-tool:
2389         * Scripts/modules/multicommandtool.py: Added.
2390         * Scripts/modules/multicommandtool_unittest.py: Added.
2391         * Scripts/run-webkit-unittests:
2392
2393 2009-11-19  Eric Seidel  <eric@webkit.org>
2394
2395         No review, just adding a FIXME.
2396
2397         Split out command parsing and help printing from BugzillaTool
2398         https://bugs.webkit.org/show_bug.cgi?id=31688
2399
2400         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
2401
2402 2009-11-19  Eric Seidel  <eric@webkit.org>
2403
2404         Reviewed by Adam Barth.
2405
2406         Split out command parsing and help printing from BugzillaTool
2407         https://bugs.webkit.org/show_bug.cgi?id=31688
2408
2409         * Scripts/bugzilla-tool:
2410          - Add new MultiCommandTool class to contain option parsing and help printing logic.
2411          - Rename private methods to use _ pattern.
2412          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
2413          -
2414
2415 2009-11-19  Eric Seidel  <eric@webkit.org>
2416
2417         Reviewed by Adam Barth.
2418
2419         Re-factor help printing to use modern python idioms
2420         https://bugs.webkit.org/show_bug.cgi?id=31685
2421
2422         * Scripts/bugzilla-tool:
2423
2424 2009-11-19  Eric Seidel  <eric@webkit.org>
2425
2426         Reviewed by Darin Adler.
2427
2428         commit-queue empty queue logs twice
2429         https://bugs.webkit.org/show_bug.cgi?id=31679
2430
2431         * Scripts/bugzilla-tool:
2432
2433 2009-11-19  Eric Seidel  <eric@webkit.org>
2434
2435         Reviewed by Darin Adler.
2436
2437         bugzilla-tool's reviewer/committer rejection message should be clearer
2438         https://bugs.webkit.org/show_bug.cgi?id=31126
2439
2440         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
2441
2442         * Scripts/modules/bugzilla.py:
2443
2444 2009-11-19  Eric Z. Ayers  <zundel@google.com>
2445
2446         Reviewed by Pavel Feldman.
2447
2448         Forces a WM_PAINT event on calling layoutTestController.display()
2449         in order to enable the timeline-paint.html test on Windows.
2450         ::UpdateWindow() does not force an event becaue the window is
2451         not visible.
2452
2453         https://bugs.webkit.org/show_bug.cgi?id=31402
2454
2455         * DumpRenderTree/win/DumpRenderTree.cpp:
2456         (displayWebView):
2457
2458 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
2459
2460         No review needed.
2461
2462         Added myself to committers list.
2463
2464         * Scripts/modules/committers.py:
2465
2466 2009-11-19  Adam Barth  <abarth@webkit.org>
2467
2468         Reviewed by Eric Seidel.
2469
2470         Bugzilla-tool command classes should match command names
2471         https://bugs.webkit.org/show_bug.cgi?id=31666
2472
2473         I renamed all the commands except CommitMessageForCurrentDiff because
2474         the new name would conflict with an existing class.
2475
2476         * Scripts/bugzilla-tool:
2477
2478 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
2479
2480         Reviewed by Gustavo Noronha Silva.
2481
2482         Web Inspector: Implement "show inspector" in WebKit GTK
2483         API and enable console tests.
2484
2485         https://bugs.webkit.org/show_bug.cgi?id=31669
2486
2487         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2488         (LayoutTestController::showWebInspector):
2489
2490 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2491
2492         Reviewed by Simon Hausmann.
2493
2494         Minor refactoring + more documentation.
2495
2496         * DumpRenderTree/qt/DumpRenderTree.cpp:
2497         (WebCore::clearHistory):
2498         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2499
2500 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
2501
2502         Reviewed by Eric Seidel.
2503
2504         Ignore websocket tests when --no-http is specified.
2505         https://bugs.webkit.org/show_bug.cgi?id=31662
2506
2507         * Scripts/run-webkit-tests:
2508
2509 2009-11-18  Adam Barth  <abarth@webkit.org>
2510
2511         Reviewed by Eric Seidel.
2512
2513         Normalize ' and " in bugzilla-tool
2514         https://bugs.webkit.org/show_bug.cgi?id=31655
2515
2516         We decided " is better than ' and we should be consistent.
2517
2518         * Scripts/bugzilla-tool:
2519
2520 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2521
2522         Reviewed by Kenneth Rohde Christiansen.
2523
2524         [Qt] Remove support for Qt v4.3 or older versions
2525         https://bugs.webkit.org/show_bug.cgi?id=29469
2526
2527         * DumpRenderTree/qt/DumpRenderTree.pro:
2528         * DumpRenderTree/qt/ImageDiff.pro:
2529
2530 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
2531
2532         Reviewed by Eric Seidel.
2533
2534         GitTest.test_create_binary_patch fails if /tmp is symlink
2535         https://bugs.webkit.org/show_bug.cgi?id=31536
2536
2537         * Scripts/modules/scm_unittest.py:
2538
2539 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
2540
2541         Reviewed by Darin Adler.
2542
2543         Configuration for Chromium Build Slaves.
2544
2545         https://bugs.webkit.org/show_bug.cgi?id=31442
2546
2547         * BuildSlaveSupport/build.webkit.org-config/config.json:
2548         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2549
2550 2009-11-18  Eric Seidel  <eric@webkit.org>
2551
2552         Reviewed by Darin Adler.
2553
2554         workqueue.py results in totally broken commit-queue UI
2555         https://bugs.webkit.org/show_bug.cgi?id=31645
2556
2557         * Scripts/bugzilla-tool:
2558          - Remove unneeded use of PatchCollection.
2559          - Grab a new copy of the cq'd patches every run of the queue.
2560
2561 2009-11-18  Sam Weinig  <sam@webkit.org>
2562
2563         Reviewed by Anders Carlsson.
2564
2565         Make the Mac Geolocation API async.
2566
2567         Update DRT to use the new async Mac Geolocation API.
2568
2569         * DumpRenderTree/mac/UIDelegate.mm:
2570         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2571
2572 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2573
2574         Reviewed by Kenneth Rohde Christiansen.
2575
2576         Add and option to toggle HTML5 datalist support to build-webkit
2577         https://bugs.webkit.org/show_bug.cgi?id=31599
2578
2579         * Scripts/build-webkit:
2580
2581 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
2582
2583         Reviewed by Kevin Ollivier.
2584
2585         Enable wx plugin support using the Windows implementation as a base.
2586
2587         https://bugs.webkit.org/show_bug.cgi?id=31636
2588
2589         * wx/build/settings.py:
2590
2591 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2592
2593         Reviewed by Simon Hausmann.
2594
2595         Change the initialization order so that the controllers
2596         will be created before exporting them to the JS DOM window.
2597
2598         * DumpRenderTree/qt/DumpRenderTree.cpp:
2599         (WebCore::DumpRenderTree::DumpRenderTree):
2600
2601 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2602
2603         Reviewed by Simon Hausmann.
2604
2605         Fix a code copy and paste error. m_page should be page.
2606
2607         * DumpRenderTree/qt/DumpRenderTree.cpp:
2608         (WebCore::DumpRenderTree::createWindow):
2609
2610 2009-11-17  Mark Rowe  <mrowe@apple.com>
2611
2612         Reviewed by Alexey Proskuryakov.
2613
2614         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
2615
2616         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
2617         This prevents symlinks from confusing the descendant check.
2618
2619 2009-11-17  Mark Rowe  <mrowe@apple.com>
2620
2621         Reviewed by Alexey Proskuryakov.
2622
2623         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
2624
2625         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
2626         server to be up rather than having run-webkit-tests abort immediately.
2627
2628         * Scripts/run-webkit-tests:
2629
2630 2009-11-17  Eric Seidel  <eric@webkit.org>
2631
2632         Reviewed by Darin Adler.
2633
2634         commit-queue is failing to set reviewer in ChangeLogs
2635         https://bugs.webkit.org/show_bug.cgi?id=31592
2636
2637         * Scripts/bugzilla-tool: Clarify the "applying" log message.
2638         * Scripts/modules/bugzilla.py:
2639          - Add a new _validate_committer_and_reviewer function as a
2640            temporary solution until we can make a real Attachment object
2641            which knows how to fill in its committer/reviewer fields automatically.
2642
2643 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2644
2645         Unreviewed buildbot fix.
2646
2647         Revert part of earlier patch and add comment, as it
2648         was causing timeouts on the buildbot.
2649
2650         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2651         (LayoutTestController::notifyDone):
2652
2653 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2654
2655         Reviewed by Oliver Hunt.
2656
2657         Make the timeout 15 sec as for the other DRT's and make
2658         it print out the same output when a test timeout.
2659
2660         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2661         (LayoutTestController::waitUntilDone):
2662         (LayoutTestController::notifyDone):
2663         (LayoutTestController::timerEvent):
2664
2665 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
2666
2667         Reviewed by Timothy Hatcher.
2668
2669         Fixed typos in comments.
2670
2671         * Scripts/modules/committers.py:
2672
2673 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
2674
2675         Reviewed by Timothy Hatcher.
2676
2677         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
2678         - Updated DRT to show/close inspector for all tests under /inspector
2679         - Introduced LayoutTestController::setTimelineProfilingEnabled and
2680           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
2681         - Removed reload on each inspector test
2682         - Renamed fast/inspector to fast/inspector-support in order not to trigger
2683         inspector for those.
2684         - Reimplemented timeline tests in order to get rid of reload there.
2685         - Moved tests that don't require harness into the fast group.
2686
2687         https://bugs.webkit.org/show_bug.cgi?id=31472
2688
2689         * DumpRenderTree/LayoutTestController.cpp:
2690         (setTimelineProfilingEnabledCallback):
2691         (closeWebInspectorCallback):
2692         (LayoutTestController::staticFunctions):
2693         * DumpRenderTree/LayoutTestController.h:
2694         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2695         (shouldOpenWebInspector):
2696         (runTest):
2697         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2698         (LayoutTestController::setTimelineProfilingEnabled):
2699         * DumpRenderTree/mac/DumpRenderTree.mm:
2700         (shouldOpenWebInspector):
2701         (runTest):
2702         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2703         (LayoutTestController::setTimelineProfilingEnabled):
2704         * DumpRenderTree/win/DumpRenderTree.cpp:
2705         (shouldOpenWebInspector):
2706         (runTest):
2707         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2708         (LayoutTestController::setTimelineProfilingEnabled):
2709
2710 2009-11-17  Oliver Hunt  <oliver@apple.com>
2711
2712         Reviewed by Maciej Stachowiak.
2713
2714         Incorrect use of JavaScriptCore API in DumpRenderTree
2715         https://bugs.webkit.org/show_bug.cgi?id=31577
2716
2717         Return undefined rather than a literal null.
2718
2719         * DumpRenderTree/AccessibilityUIElement.cpp:
2720         (setSelectedTextRangeCallback):
2721         (incrementCallback):
2722         (decrementCallback):
2723         (showMenuCallback):
2724
2725 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
2726
2727         Reviewed by Beth Dakin.
2728
2729         AX: aria-labelledby duplicates some of its WAI-ARIA label
2730         https://bugs.webkit.org/show_bug.cgi?id=31565
2731
2732         * DumpRenderTree/AccessibilityUIElement.cpp:
2733         (titleUIElementCallback):
2734         (getIsValidCallback):
2735         (AccessibilityUIElement::getJSClass):
2736
2737 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2738
2739         Reviewed by Simon Hausmann.
2740
2741         r50942 broke output from created windows. Make the
2742         m_enableTextOutput a member of the DRT and not the
2743         WebPage.
2744
2745         * DumpRenderTree/qt/DumpRenderTree.cpp:
2746         (WebCore::WebPage::WebPage):
2747         (WebCore::WebPage::javaScriptAlert):
2748         (WebCore::WebPage::javaScriptConsoleMessage):
2749         (WebCore::WebPage::javaScriptConfirm):
2750         (WebCore::WebPage::javaScriptPrompt):
2751         (WebCore::WebPage::acceptNavigationRequest):
2752         (WebCore::DumpRenderTree::DumpRenderTree):
2753         (WebCore::DumpRenderTree::open):
2754         (WebCore::DumpRenderTree::createWindow):
2755         * DumpRenderTree/qt/DumpRenderTree.h:
2756         (WebCore::DumpRenderTree::setTextOutputEnabled):
2757         (WebCore::DumpRenderTree::isTextOutputEnabled):
2758         (WebCore::WebPage::shouldInterruptJavaScript):
2759         (WebCore::WebPage::isTextOutputEnabled):
2760         (WebCore::WebPage::setViewGeometry):
2761
2762 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2763
2764         Reviewed by Gustavo Noronha Silva.
2765
2766         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
2767         as the implementation is being used by at least Qt and Gtk+.
2768
2769         Update buildsystems as well.
2770
2771         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2772         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
2773         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
2774         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
2775         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2776         * GNUmakefile.am:
2777
2778 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
2779
2780         Reviewed by Alexey Proskuryakov.
2781
2782         Disable wss until all platforms support pyOpenSSL
2783
2784         https://bugs.webkit.org/show_bug.cgi?id=31479
2785
2786         * Scripts/run-webkit-tests:
2787
2788 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
2789
2790         Reviewed by Kenneth Christiansen.
2791
2792         [Qt] Implement load error pages support for Qt's DRT.
2793         https://bugs.webkit.org/show_bug.cgi?id=31509
2794
2795         For now, it will not be a default feature, and layout tests
2796         that want to make use of this have to explicitily call
2797         'handleErrorPages();' for the test source.
2798
2799         Any of the other DumpRenderTree's (mac, win and gtk)
2800         support handling error pages. Qt's will be the first.
2801
2802         * DumpRenderTree/qt/DumpRenderTree.cpp:
2803         (WebCore::WebPage::supportsExtension):
2804         (WebCore::WebPage::extension):
2805         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2806         (LayoutTestController::reset):
2807         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2808         (LayoutTestController::shouldHandleErrorPages):
2809         (LayoutTestController::handleErrorPages):
2810
2811 2009-11-16  Eric Seidel  <eric@webkit.org>
2812
2813         Reviewed by Adam Barth.
2814
2815         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
2816         https://bugs.webkit.org/show_bug.cgi?id=31549
2817
2818         Renamed --commit-queue to --non-interactive in most places
2819         and remove the code in land-patches which is no longer needed.
2820
2821         * Scripts/bugzilla-tool:
2822
2823 2009-11-16  Eric Seidel  <eric@webkit.org>
2824
2825         Reviewed by Adam Barth.
2826
2827         The commit-queue should use land-attachment
2828         https://bugs.webkit.org/show_bug.cgi?id=31548
2829
2830         * Scripts/bugzilla-tool:
2831
2832 2009-11-16  Adam Barth  <abarth@webkit.org>
2833
2834         Reviewed by Eric Seidel.
2835
2836         Convert CommitQueue over to PatchCollection
2837         https://bugs.webkit.org/show_bug.cgi?id=31547
2838
2839         Also fixes a bug in workqueue and adds a test!
2840
2841         * Scripts/bugzilla-tool:
2842         * Scripts/modules/workqueue.py:
2843         * Scripts/modules/workqueue_unittest.py:
2844
2845 2009-11-16  Adam Barth  <abarth@webkit.org>
2846
2847         Reviewed by Eric Seidel.
2848
2849         Move StyleQueue over to using PatchCollection
2850         https://bugs.webkit.org/show_bug.cgi?id=31544
2851
2852         That's what the class it's for.
2853
2854         * Scripts/bugzilla-tool:
2855         * Scripts/modules/patchcollection.py:
2856         * Scripts/modules/patchcollection_unittest.py:
2857
2858 2009-11-16  Eric Seidel  <eric@webkit.org>
2859
2860         Reviewed by Adam Barth.
2861
2862         bugzilla-tool needs a land-attachment command
2863         https://bugs.webkit.org/show_bug.cgi?id=31546
2864
2865         * Scripts/bugzilla-tool:
2866          - Move all the logic into AbstractLandingCommand and
2867            add a new LandAttachment command subclass.
2868          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
2869
2870 2009-11-16  Eric Seidel  <eric@webkit.org>
2871
2872         Reviewed by Adam Barth.
2873
2874         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
2875         https://bugs.webkit.org/show_bug.cgi?id=31543
2876
2877         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
2878
2879         * Scripts/bugzilla-tool:
2880
2881 2009-11-16  Eric Seidel  <eric@webkit.org>
2882
2883         Reviewed by Adam Barth.
2884
2885         Disable the style queue from posting to the commit queue status page.
2886
2887         * Scripts/bugzilla-tool:
2888
2889 2009-11-16  Adam Barth  <abarth@webkit.org>
2890
2891         Reviewed by Eric Seidel.
2892
2893         Implement PatchCollection
2894         https://bugs.webkit.org/show_bug.cgi?id=31541
2895
2896         This class holds a set of patches and lets clients iterate through
2897         them.  Optionally, clients can install a filter.
2898
2899         * Scripts/modules/patchcollection.py: Added.
2900         * Scripts/modules/patchcollection_unittest.py: Added.
2901         * Scripts/run-webkit-unittests:
2902
2903 2009-11-16  Eric Seidel  <eric@webkit.org>
2904
2905         Reviewed by Adam Barth.
2906
2907         bugzilla-tool land-patches will close bugs with patches r=?
2908         https://bugs.webkit.org/show_bug.cgi?id=28230
2909
2910         The commit-queue shouldn't close patches with outstanding reviews on them,
2911         even if many reviewers seem to be against multi-patch bugs.
2912
2913         * Scripts/bugzilla-tool:
2914
2915 2009-11-16  Eric Seidel  <eric@webkit.org>
2916
2917         Reviewed by Adam Barth.
2918
2919         bugzilla-tool check-style should work with attachment ids instead of bug ids
2920         https://bugs.webkit.org/show_bug.cgi?id=31540
2921
2922         * Scripts/bugzilla-tool:
2923
2924 2009-11-16  Eric Seidel  <eric@webkit.org>
2925
2926         Reviewed by Adam Barth.
2927
2928         WorkQueue is the only place that should know about special exit codes
2929         https://bugs.webkit.org/show_bug.cgi?id=31534
2930
2931         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
2932         and add tests for handling exit codes.
2933         I also cleaned up workqueue_unittest.py more.
2934
2935         * Scripts/bugzilla-tool:
2936         * Scripts/modules/workqueue.py:
2937         * Scripts/modules/workqueue_unittest.py:
2938
2939 2009-11-16  Eric Seidel  <eric@webkit.org>
2940
2941         Reviewed by Adam Barth.
2942
2943         Re-factor workqueue_unittest to allow for more than one test.
2944         https://bugs.webkit.org/show_bug.cgi?id=31535
2945
2946         * Scripts/modules/workqueue_unittest.py:
2947
2948 2009-11-16  Eric Seidel  <eric@webkit.org>
2949
2950         Reviewed by Adam Barth.
2951
2952         land-patches needs to be re-factored into smaller chunks
2953         https://bugs.webkit.org/show_bug.cgi?id=31532
2954
2955         * Scripts/bugzilla-tool: fix a couple obvious typos.
2956
2957 2009-11-16  Eric Seidel  <eric@webkit.org>
2958
2959         Reviewed by Adam Barth.
2960
2961         land-patches needs to be re-factored into smaller chunks
2962         https://bugs.webkit.org/show_bug.cgi?id=31532
2963
2964         The next patch will move these methods into WebKitLandingScripts.
2965
2966         * Scripts/bugzilla-tool:
2967          - Split out _land_patch and _close_bug_if_no_active_patches.
2968
2969 2009-11-16  Adam Barth  <abarth@webkit.org>
2970
2971         Reviewed by Eric Seidel.
2972
2973         Fix silly copy-and-paste code.  I am a terrible coder.
2974
2975         * Scripts/modules/bugzilla.py:
2976
2977 2009-11-16  Adam Barth  <abarth@webkit.org>
2978
2979         Reviewed by Eric Seidel.
2980
2981         Implement a StyleQueue
2982         https://bugs.webkit.org/show_bug.cgi?id=31537
2983
2984         The first iteration of the style queue only produces output locally.
2985         There is also a limit of 10 patches because it's not that useful to
2986         iterate through the entire review queue at this point.  We can remove
2987         the limit later.
2988
2989         * Scripts/bugzilla-tool:
2990         * Scripts/modules/bugzilla.py:
2991
2992 2009-11-16  Adam Barth  <abarth@webkit.org>
2993
2994         Reviewed by Eric Seidel.
2995
2996         Unit test WorkQueue
2997         https://bugs.webkit.org/show_bug.cgi?id=31531
2998
2999         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
3000
3001         * Scripts/bugzilla-tool:
3002         * Scripts/modules/statusbot.py:
3003         * Scripts/modules/workqueue.py:
3004         * Scripts/modules/workqueue_unittest.py: Added.
3005         * Scripts/run-webkit-unittests:
3006
3007 2009-11-16  Eric Seidel  <eric@webkit.org>
3008
3009         Reviewed by Adam Barth.
3010
3011         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
3012         https://bugs.webkit.org/show_bug.cgi?id=31530
3013
3014         * Scripts/bugzilla-tool:
3015
3016 2009-11-16  Eric Seidel  <eric@webkit.org>
3017
3018         Reviewed by Adam Barth.
3019
3020         bugzilla-tool needs apply-attachment
3021         https://bugs.webkit.org/show_bug.cgi?id=31528
3022
3023         * Scripts/bugzilla-tool:
3024          - Add ApplyAttachment command.
3025          - Abstract applying code into WebKitApplyingScripts.
3026          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
3027         * Scripts/modules/bugzilla.py:
3028          - Add fetch_attachment and bug_id_for_attachment_id.
3029         * Scripts/modules/bugzilla_unittest.py:
3030          - Add test for new parsing.
3031          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
3032
3033 2009-11-16  Eric Seidel  <eric@webkit.org>
3034
3035         Reviewed by Adam Barth.
3036
3037         Document check-style's use of force_clean.
3038
3039         * Scripts/bugzilla-tool:
3040         * Scripts/modules/scm.py:
3041
3042 2009-11-16  Adam Barth  <abarth@webkit.org>
3043
3044         Reviewed by Eric Seidel.
3045
3046         Move WorkQueue to its own file
3047         https://bugs.webkit.org/show_bug.cgi?id=31529
3048
3049         WorkQueue and WorkQueueDelegate are separate concerns from
3050         bugzilla-tool.  Also added a missing include to logging.py.
3051
3052         * Scripts/bugzilla-tool:
3053         * Scripts/modules/logging.py:
3054         * Scripts/modules/workqueue.py:
3055
3056 2009-11-16  Adam Barth  <abarth@webkit.org>
3057
3058         Reviewed by Eric Seidel.
3059
3060         Move OutputTee to logging.py.
3061
3062         * Scripts/bugzilla-tool:
3063         * Scripts/modules/logging.py:
3064
3065 2009-11-15  Adam Barth  <abarth@webkit.org>
3066
3067         Reviewed by Eric Seidel.
3068
3069         Refactor bugzilla-tool to allow for multiple queues
3070         https://bugs.webkit.org/show_bug.cgi?id=31513
3071
3072         Divide the commit queue class into three class to make creating
3073         additional queues easier.
3074
3075         * Scripts/bugzilla-tool:
3076
3077 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
3078
3079         Reviewed by Eric Seidel.
3080
3081         svn-apply may not handle git patches created by bugzilla-tool
3082         https://bugs.webkit.org/show_bug.cgi?id=31457
3083
3084         * Scripts/modules/scm.py:
3085         * Scripts/modules/scm_unittest.py:
3086
3087 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
3088
3089         Reviewed by Eric Seidel.
3090
3091         bugzilla-tool should post git binary diff
3092         https://bugs.webkit.org/show_bug.cgi?id=31458
3093
3094         Add --binary option to Git.create_patch.
3095
3096         * Scripts/modules/scm.py:
3097         * Scripts/modules/scm_unittest.py:
3098
3099 2009-11-15  Adam Barth  <abarth@webkit.org>
3100
3101         Reviewed by Darin Adler.
3102
3103         Add bugzilla-tool check-style
3104         https://bugs.webkit.org/show_bug.cgi?id=31515
3105
3106         * Scripts/bugzilla-tool:
3107         * Scripts/modules/bugzilla.py:
3108
3109 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3110
3111         Reviewed by Simon Hausmann.
3112
3113         Make the Qt Linux only --valgrind feature, suppress errors
3114         defined in the SuppressedValgrindErrors file.
3115
3116         * Scripts/run-webkit-tests:
3117
3118 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3119
3120         Reviewed by Simon Hausmann.
3121
3122         Set the locale to C and not to the current one in use on the system.
3123
3124         * DumpRenderTree/qt/DumpRenderTree.cpp:
3125         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3126
3127 2009-11-13  Adam Roben  <aroben@apple.com>
3128
3129         Add support for
3130         http/tests/security/isolatedWorld/didClearWindowObject.html
3131
3132         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
3133         window objects in isolated worlds are cleared
3134
3135         Reviewed by Dave Hyatt.
3136
3137         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
3138
3139         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3140         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3141         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
3142         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
3143         Added. Sets a __worldID property on the global object whose value is
3144         the ID of this world.
3145         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
3146         Respond to this new delegate callback by calling through to one of the
3147         above new methods.
3148         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3149         (worldMap): Added. Returns a HashMap containing all the worlds we've
3150         created.
3151         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
3152         haven't kept track of this world.
3153         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
3154         instead of declaring our own.
3155
3156         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
3157
3158         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3159         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
3160         didClearWindowObjectForFrameInStandardWorld.
3161         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
3162         Respond to this new delegate callback by calling through to one of the
3163         below new methods.
3164         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
3165         Added. Sets a __worldID property on the gobal object whose value is
3166         the ID of this world.
3167         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
3168         Added. Moved code here from didClearWindowObject.
3169
3170         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
3171         didClearWindowObjectForFrame* functions.
3172
3173         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3174         (worldMap): Added. Returns a HashMap containing all the worlds we've
3175         created.
3176         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
3177         haven't kept track of this world.
3178         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
3179         instead of declaring our own.
3180
3181 2009-11-13  Adam Roben  <aroben@apple.com>
3182
3183         Finish replacing worldIDs with world objects
3184
3185         The only remaining use of worldIDs was in a method only used by DRT
3186         for the isolated worlds tests.
3187
3188         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
3189
3190         Reviewed by Mark Rowe.
3191
3192         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3193         (LayoutTestController::evaluateScriptInIsolatedWorld):
3194         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3195         (LayoutTestController::evaluateScriptInIsolatedWorld):
3196         Updated for changes to WebFrame. Now holds the map of worldID -> world
3197         at this level instead of making WebKit do it.
3198
3199 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3200
3201         Reviewed by Simon Hausmann.
3202
3203         [Qt] Ensure the DRT does not output anything until first test is run
3204
3205         * DumpRenderTree/qt/DumpRenderTree.cpp:
3206         * DumpRenderTree/qt/DumpRenderTree.h:
3207
3208 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3209
3210         Reviewed by Tor Arne Vestbø.
3211
3212         Clear the undo stack in before each new test run.
3213
3214         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
3215
3216         * DumpRenderTree/qt/DumpRenderTree.cpp:
3217         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3218
3219 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3220
3221         Reviewed by Kenneth Rohde Christiansen.
3222
3223         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
3224
3225         * DumpRenderTree/qt/DumpRenderTree.cpp:
3226         (WebCore::WebPage::resetSettings):
3227         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3228         (LayoutTestController::overridePreference):
3229
3230 2009-11-13  Eric Seidel  <eric@webkit.org>
3231
3232         Reviewed by Adam Barth.
3233
3234         Update committers.py based on svn records
3235         https://bugs.webkit.org/show_bug.cgi?id=31366
3236
3237         This list was generated using validate-committer-lists from
3238         https://bugs.webkit.org/show_bug.cgi?id=30970
3239         and makes committers.py current for committers who have
3240         committed in the last 3 years.
3241
3242         * Scripts/modules/committers.py:
3243
3244 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
3245
3246         Reviewed by Adam Barth.
3247
3248         The document-open.html test was flaky at times. The test invokes the layout test plugin
3249         which in its destroy stream handler opens a new document. This basically tears down the
3250         stream and the associated plugin instance. The pluginLog function in the layout test
3251         plugin attempts to retrieve the window script object on a torn down plugin instance
3252         which crashed consistently on windows in the debugger. The functions which issue
3253         these logs already have a valid window script object. We now have variants of the pluginLog
3254         function which take in a window script object with and without variable arguments.
3255
3256         https://bugs.webkit.org/show_bug.cgi?id=31067
3257
3258         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3259         (pluginLogWithWindowObject):
3260         (pluginLogWithWindowObjectVariableArgs):
3261         (pluginLog):
3262         (notifyTestCompletion):
3263         (testDocumentOpen):
3264         (testWindowOpen):
3265
3266 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3267
3268         Reviewed by Gustavo Noronha Silva.
3269
3270         https://bugs.webkit.org/show_bug.cgi?id=30997
3271         [Gtk] Implemment AtkDocument
3272
3273         Added testing support.
3274
3275         * DumpRenderTree/AccessibilityUIElement.cpp:
3276         * DumpRenderTree/AccessibilityUIElement.h:
3277         (getDocumentEncodingCallback):
3278         (getDocumentURICallback):
3279         (AccessibilityUIElement::getJSClass):
3280         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3281         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3282         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3283         (AccessibilityUIElement::documentEncoding):
3284         (AccessibilityUIElement::documentURI):
3285
3286 2009-11-12  Adam Roben  <aroben@apple.com>
3287
3288         Replace worldIDs with world objects
3289
3290         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
3291         user scripts/stylesheets and isolated worlds
3292
3293         Reviewed by Sam Weinig.
3294
3295         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3296         (LayoutTestController::addUserScript):
3297         (LayoutTestController::addUserStyleSheet):
3298         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3299         (LayoutTestController::addUserScript):
3300         (LayoutTestController::addUserStyleSheet):
3301         Changed these functions to create a new WebJSWorld each time they're
3302         called and to pass that world to WebKit.
3303
3304 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
3305
3306         Reviewed by Oliver Hunt.
3307
3308         need to implement aria tree roles
3309         https://bugs.webkit.org/show_bug.cgi?id=31284
3310
3311         * DumpRenderTree/AccessibilityUIElement.cpp:
3312         (disclosedRowAtIndexCallback):
3313         (selectedRowAtIndexCallback):
3314         (isEqualCallback):
3315         (isAttributeSettableCallback):
3316         (isActionSupportedCallback):
3317         (disclosedByRowCallback):
3318         (hierarchicalLevelCallback):
3319         (AccessibilityUIElement::getJSClass):
3320         * DumpRenderTree/AccessibilityUIElement.h:
3321         (AccessibilityUIElement::isEqual):
3322         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3323         (AccessibilityUIElement::hierarchicalLevel):
3324         (AccessibilityUIElement::disclosedRowAtIndex):
3325         (AccessibilityUIElement::selectedRowAtIndex):
3326         (AccessibilityUIElement::disclosedByRow):
3327         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3328         (AccessibilityUIElement::getChildAtIndex):
3329         (AccessibilityUIElement::disclosedRowAtIndex):
3330         (AccessibilityUIElement::selectedRowAtIndex):
3331         (AccessibilityUIElement::titleUIElement):
3332         (AccessibilityUIElement::parentElement):
3333         (AccessibilityUIElement::disclosedByRow):
3334         (AccessibilityUIElement::hierarchicalLevel):
3335         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3336         (AccessibilityUIElement::hierarchicalLevel):
3337         (AccessibilityUIElement::disclosedRowAtIndex):
3338         (AccessibilityUIElement::selectedRowAtIndex):
3339         (AccessibilityUIElement::disclosedByRow):
3340
3341 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
3342
3343         Reviewed by Darin Adler.
3344
3345         svn-apply can not handle git binary diffs
3346         https://bugs.webkit.org/show_bug.cgi?id=26830
3347
3348         Support "literal" type git binary diffs.
3349
3350         * Scripts/VCSUtils.pm:
3351         * Scripts/modules/scm_unittest.py:
3352         * Scripts/svn-apply:
3353
3354 2009-11-11  Dmitry Titov  <dimich@chromium.org>
3355
3356         Not reviewed, removing duplicate entry for myself in committers.py.
3357
3358         * Scripts/modules/committers.py:
3359
3360 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
3361
3362         Reviewed by Darin Adler and Mark Rowe.
3363
3364         https://bugs.webkit.org/show_bug.cgi?id=31200
3365         Tests in http/tests/security/mixedContent start to fail when new tests are added
3366
3367         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
3368
3369 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3370
3371         Reviewed by Jan Alonzo.
3372
3373         Create, and display a window for the inspector, for inspector
3374         tests.
3375
3376         Need to also show/hide the inspector window to avoid having
3377         problems with code assuming it is realized
3378         https://bugs.webkit.org/show_bug.cgi?id=31347
3379
3380         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3381         (webInspectorShowWindow):
3382         (webInspectorCloseWindow):
3383         (webInspectorInspectWebView):
3384         (createWebView):
3385
3386 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3387
3388         Unreviewed Qt buildbot fix.
3389
3390         My previous fix was wrong, so revert that change and fix it by
3391         returning when the document of the frame has no document element.
3392         Idea is borrowed from mac and win DRT.
3393
3394         * DumpRenderTree/qt/DumpRenderTree.cpp:
3395         (WebCore::DumpRenderTree::dumpFramesAsText):
3396
3397 2009-11-11  Eric Seidel  <eric@webkit.org>
3398
3399         Reviewed byg Kenneth Rohde Christiansen.
3400
3401         Update Kenneth's committer record to include the email he
3402         uses on lists.webkit.org.
3403
3404         * Scripts/modules/committers.py:
3405
3406 2009-11-11  Eric Seidel  <eric@webkit.org>
3407
3408         Reviewed by Gustavo Noronha Silva.
3409
3410         Several committers use separate email addresses for bugzilla and svn.webkit.org
3411         https://bugs.webkit.org/show_bug.cgi?id=31364
3412
3413         Update records for existing committers to include email addresses
3414         used in svn.webkit.org and lists.webkit.org.
3415         Most committers use the same email address in all 3 places, but some use
3416         separate addresses.  committers.py needs record of each of these addresses.
3417
3418         * Scripts/modules/committers.py:
3419
3420 2009-11-11  Eric Seidel  <eric@webkit.org>
3421
3422         No review, adding second email address for an existing committer.
3423
3424         Add Yong Li's second bugzilla account to his committer record.
3425         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
3426
3427         * Scripts/modules/committers.py:
3428
3429 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3430
3431         Reviewed by Simon Hausmann.
3432
3433         If the frame has no innerText don't append it, and
3434         do not add a newline which breaks some cross platform
3435         results.
3436
3437         * DumpRenderTree/qt/DumpRenderTree.cpp:
3438         (WebCore::DumpRenderTree::dumpFramesAsText):
3439
3440 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3441
3442         Reviewed by Simon Hausmann.
3443
3444         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
3445
3446         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
3447         (webkit_test_plugin_new_instance):
3448         (webkit_test_plugin_destroy_instance):
3449         (webkit_test_plugin_destroy_stream):
3450
3451 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3452
3453         Reviewed by Mark Rowe.
3454
3455         Implement the functionality needed by plugins/window-open.html
3456
3457         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
3458         (webkit_test_plugin_new_instance):
3459         (webkit_test_plugin_set_window):
3460
3461 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3462
3463         Reviewed by Simon Hausmann.
3464
3465         [Qt] Force -graphicssystem raster and -style windows when running DRT
3466
3467         * DumpRenderTree/qt/main.cpp:
3468         * Scripts/run-webkit-tests:
3469
3470 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3471
3472         Reviewed by Simon Hausmann.
3473
3474         Compute correct library paths for Qt
3475
3476         * Scripts/webkitdirs.pm:
3477
3478 2009-11-10  Mark Rowe  <mrowe@apple.com>
3479
3480         Reviewed by Sam Weinig.
3481
3482         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
3483
3484         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
3485         about the validity of the self-signed certificates used in the regression tests.  We would then add the
3486         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
3487         that had enabled frame load delegate logging this would result in extra log messages being generated,
3488         causing the test to fail.
3489
3490         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
3491         tests.
3492
3493         * DumpRenderTree/mac/DumpRenderTree.mm:
3494         (dumpRenderTree):
3495         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3496         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3497
3498 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3499
3500         Reviewed by Kenneth Rohde Christiansen.
3501
3502         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
3503
3504         * DumpRenderTree/qt/DumpRenderTree.cpp:
3505         (WebCore::DumpRenderTree::DumpRenderTree):
3506
3507 2009-11-10  Philippe Normand  <pnormand@igalia.com>
3508
3509         Reviewed by Jan Alonzo.
3510
3511         [GTK] Remove WebSocket configuration from WebKitWebSettings
3512         https://bugs.webkit.org/show_bug.cgi?id=31244
3513
3514         Follow-up of r50724. Don't set the enable-web-socket property
3515         anymore.
3516
3517         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3518         (resetDefaultsToConsistentValues):
3519
3520 2009-11-10  Oliver Hunt  <oliver@apple.com>
3521
3522         Reviewed by Maciej Stachowiak.
3523
3524         Rename 3D Canvas related classes to use WebGL prefix
3525         https://bugs.webkit.org/show_bug.cgi?id=29095
3526
3527         Checkin new version of do-webcore-rename used to do the WebGL type rename,
3528         and upate webkitdirs script to new method of testing for WebGL.
3529
3530         * Scripts/do-webcore-rename:
3531         * Scripts/webkitdirs.pm:
3532
3533 2009-11-09  Oliver Hunt  <oliver@apple.com>
3534
3535         Reviewed by Geoff Garen.
3536
3537         Make do-webcore-rename work with git.
3538
3539         * Scripts/do-webcore-rename:
3540
3541 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3542
3543         Adding Kenneth to the reviewers list.
3544
3545         * Scripts/modules/committers.py:
3546
3547 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
3548
3549         Reviewed by Jan Alonzo.
3550
3551         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
3552         https://bugs.webkit.org/show_bug.cgi?id=30482
3553
3554         LayoutTestControllerGtk now uses the exposed
3555         Page::tabKeyCyclesThroughElements API
3556
3557         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3558         (LayoutTestController::setTabKeyCyclesThroughElements):
3559
3560 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
3561
3562         Reviewed by Holger Freyther.
3563
3564         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
3565         This helps to pass the test case below. Also replaced hardcoded
3566         code numbers with defined constants.
3567         https://bugs.webkit.org/show_bug.cgi?id=31185
3568
3569         Test: editing/undo/undo-deleteWord.html
3570
3571         * DumpRenderTree/qt/EventSenderQt.cpp:
3572         (EventSender::keyDown):
3573
3574 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
3575
3576         Reviewed by Holger Freyther.
3577
3578         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
3579         https://bugs.webkit.org/show_bug.cgi?id=31164
3580
3581         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
3582
3583         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3584         (LayoutTestController::processWork):
3585
3586 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
3587
3588         Reviewed by Holger Freyther.
3589
3590         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
3591         https://bugs.webkit.org/show_bug.cgi?id=31158
3592
3593         By invoking a script queue'd by queueScript(), 'true' was beeing returned
3594         always, which from WorkQueue prospective means that a load has been started
3595         and the queue processing should stop and wait for the load to finish.
3596         Spinning it off into a loading and a non-loading variants was the solution
3597         adopted by Mac's DRT to work around this problem. The former keeps returning
3598         'true' while the later executes the script synchronously and returns 'false'
3599         making it possible to the WorkQueue to proceed right away.
3600
3601         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3602         (LayoutTestController::processWork):
3603         (LayoutTestController::queueLoadingScript):
3604         (LayoutTestController::queueNonLoadingScript):
3605         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3606         * DumpRenderTree/qt/WorkQueueItem.h:
3607         (LoadingScriptItem::LoadingScriptItem):
3608         (LoadingScriptItem::invoke):
3609         (NonLoadingScriptItem::NonLoadingScriptItem):
3610         (NonLoadingScriptItem::invoke):
3611
3612 2009-11-07  Mark Rowe  <mrowe@apple.com>
3613
3614         Rubber-stamped by Cameron Zwarich.
3615
3616         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
3617
3618         * Scripts/commit-log-editor:
3619
3620 2009-11-07  Mark Rowe  <mrowe@apple.com>
3621
3622         Reviewed by Darin Adler.
3623
3624         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
3625         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
3626
3627         Move logic for determining the name and email address to use in a ChangeLog entry from
3628         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
3629         whether the author of the patch matches committer, and therefore needs access to the
3630         email address that would be used in a ChangeLog entry.
3631
3632         Based on a patch by Pierre d'Herbemont.
3633
3634         * Scripts/VCSUtils.pm:
3635         * Scripts/commit-log-editor:
3636         * Scripts/prepare-ChangeLog:
3637         * Scripts/webkitdirs.pm:
3638
3639 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
3640
3641         Reviewed by Adam Barth.
3642
3643         Added functionality to the layout test plugin to invoke document.open and
3644         window.open with default arguments. The associated webkit bug is
3645         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
3646         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
3647         work in Chromium (V8) if there is no calling javascript context. To achieve this
3648         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
3649         for the window.open test case and in NPP_DestroyStream for the document.open test case.
3650
3651         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3652         (testDocumentOpen):
3653         (testWindowOpen):
3654         (pluginAllocate):
3655         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3656         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3657         (NPP_New):
3658         (NPP_SetWindow):
3659         (NPP_DestroyStream):
3660         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3661         (NPP_New):
3662         (NPP_SetWindow):
3663         (NPP_NewStream):
3664         (NPP_DestroyStream):
3665
3666 2009-11-06  Eric Seidel  <eric@webkit.org>
3667
3668         Reviewed by Adam Barth.
3669
3670         bugzilla-tool crashed with exception
3671         https://bugs.webkit.org/show_bug.cgi?id=31092
3672
3673         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
3674
3675 2009-11-04  Eric Seidel  <eric@webkit.org>
3676
3677         No review, just add a line which got left out of the patch uploaded for commit.
3678
3679         commit-queue is crashing when trying to reject patches after unknown failures
3680         https://bugs.webkit.org/show_bug.cgi?id=31091
3681
3682         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
3683
3684 2009-11-04  Adam Roben  <aroben@apple.com>
3685
3686         Remove bogus else clause in bugzilla-tool
3687
3688         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
3689         create-bug raises exception after entering bug description
3690
3691         Reviewed by David Kilzer.
3692
3693         * Scripts/bugzilla-tool:
3694         (CreateBug): else clauses are only hit if no exception is raised, so
3695         it makes no sense to try to re-raise the exception in an else clause.
3696         The exception will automatically be re-raised if it doesn't match any
3697         of the except clauses, so we don't have to do anything special here at
3698         all to get the desired behavior.
3699
3700 2009-11-04  Eric Seidel  <eric@webkit.org>
3701
3702         Reviewed by David Kilzer.
3703
3704         svn-apply's fixChangeLogPatch function seems broken
3705         https://bugs.webkit.org/show_bug.cgi?id=30683
3706
3707         Update fixChangeLogPatch to be able to handle patches which
3708         don't start at line 1.
3709         Add unit tests for svn-apply to scm_unittest.py.
3710
3711         * Scripts/VCSUtils.pm:
3712         * Scripts/modules/scm_unittest.py:
3713
3714 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
3715
3716         Reviewed by Beth Dakin.
3717
3718         Need to implement ARIA role="combobox"
3719         https://bugs.webkit.org/show_bug.cgi?id=31096
3720
3721         * DumpRenderTree/AccessibilityUIElement.cpp:
3722         (showMenuCallback):
3723         (getIsExpandedCallback):
3724         (AccessibilityUIElement::getJSClass):
3725         * DumpRenderTree/AccessibilityUIElement.h:
3726         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3727         (AccessibilityUIElement::isExpanded):
3728         (AccessibilityUIElement::showMenu):
3729         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3730         (AccessibilityUIElement::isExpanded):
3731         (AccessibilityUIElement::showMenu):
3732         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3733         (AccessibilityUIElement::isSelected):
3734         (AccessibilityUIElement::isExpanded):
3735         (AccessibilityUIElement::showMenu):
3736
3737 2009-11-04  Eric Seidel  <eric@webkit.org>
3738
3739         Reviewed by Adam Barth.
3740
3741         commit-queue is crashing when trying to reject patches after unknown failures
3742         https://bugs.webkit.org/show_bug.cgi?id=31091
3743
3744         * Scripts/bugzilla-tool:
3745          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
3746            so we have to find out what the current patch is by asking bugzilla again.
3747          - Discovered that this code was also leaking file descriptors, so fixed that.
3748
3749 2009-11-04  Adam Roben  <aroben@apple.com>
3750
3751         Make run-webkit-tests work for the Debug_Internal Windows
3752         configuration
3753
3754         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
3755         suffix.
3756
3757         Fixes <http://webkit.org/b/31123>.
3758
3759         Reviewed by Sam Weinig.
3760
3761         * Scripts/run-webkit-tests: Don't add the _debug suffix in
3762         Debug_Internal, either.
3763
3764 2009-11-04  Eric Seidel  <eric@webkit.org>
3765
3766         Reviewed by Adam Barth.
3767
3768         committers.py needs a way to store non-bugzilla email addresses
3769         https://bugs.webkit.org/show_bug.cgi?id=31037
3770
3771         Make Committer and Reviewer constructors take a single email or a list of emails.
3772         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
3773         Expose reviewers(), used by validate-committer-lists on bug 30970.
3774
3775         * Scripts/modules/committers.py:
3776         * Scripts/modules/committers_unittest.py: Added tests for the new code.
3777
3778 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
3779
3780         Reviewed by David Levin.
3781
3782         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
3783         https://bugs.webkit.org/show_bug.cgi?id=27491
3784
3785         The test path determination logic is changed to handle websocket and websocket/ssl cases.
3786         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
3787
3788         Functions to start or stop Web Socket servers are added.
3789
3790         * Scripts/run-webkit-tests:
3791
3792 2009-11-03  Eric Seidel  <eric@webkit.org>
3793
3794         No review, just changing wording of log message.
3795
3796         Change log string to say "failed" instead of "rejected"
3797         when a commit fails due to an out of date checkout.
3798         This makes grepping the commit-queue log for rejected patches easier.
3799
3800         * Scripts/bugzilla-tool:
3801
3802 2009-11-03  Eric Seidel  <eric@webkit.org>
3803
3804         No review, adding commonly known committers missing from the file.
3805
3806         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
3807
3808 2009-11-03  Eric Seidel  <eric@webkit.org>
3809
3810         No review, just sort-order cleanup.
3811
3812         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
3813
3814 2009-11-03  Stephen White  <senorblanco@chromium.org>
3815
3816         (Unreviewed).
3817
3818         Add myself to committers.py.
3819
3820         * Scripts/modules/committers.py:
3821
3822 2009-11-03  Robin Dunn  <robin@alldunn.com>
3823
3824         Reviewed by Kevin Ollviier.
3825
3826         Add packaging scripts for Debian-based Linux distros.
3827
3828         https://bugs.webkit.org/show_bug.cgi?id=31075
3829
3830         * wx/packaging/build-debian-installer.py: Added.
3831         * wx/packaging/debian: Added.
3832
3833 2009-11-03  Dan Bernstein  <mitz@apple.com>
3834
3835         Reviewed by Anders Carlsson and Beth Dakin.
3836
3837         https://bugs.webkit.org/show_bug.cgi?id=31070
3838
3839         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
3840         destroyed, it executes the value of the 'ondestroy' parameter as a
3841         script.
3842
3843         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3844         (pluginAllocate): Initialize onDestroy.
3845         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
3846         onDestroy.
3847         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3848         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
3849         specified.
3850         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
3851
3852 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3853
3854         Reviewed by Xan Lopez.
3855
3856         https://bugs.webkit.org/show_bug.cgi?id=31035
3857         [GTK] some accessibility tests hitting assertion in debug builds
3858
3859         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
3860
3861         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3862         (AccessibilityController::rootElement):
3863
3864 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
3865
3866         Reviewed by Beth Dakin.
3867
3868         Support ARIA "tab" roles
3869         https://bugs.webkit.org/show_bug.cgi?id=30842
3870
3871         * DumpRenderTree/AccessibilityUIElement.cpp:
3872         * DumpRenderTree/AccessibilityUIElement.h:
3873         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3874         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3875         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3876
3877 2009-11-01  Eric Seidel  <eric@webkit.org>
3878
3879         Reviewed by David Levin.
3880
3881         buildbots should use --exit-after-N-failures
3882         https://bugs.webkit.org/show_bug.cgi?id=30809
3883
3884         Make the bots exit after 20 failures to prevent never-ending
3885         test runs where every test spends a minute crashing.
3886
3887         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3888
3889 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3890
3891         Reviewed by Eric Seidel.
3892
3893         Turn on warnings for QtWebKit for gcc
3894         https://bugs.webkit.org/show_bug.cgi?id=30958
3895
3896         * DumpRenderTree/qt/main.cpp:
3897         (crashHandler): Mark function NO_RETURN
3898
3899 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
3900
3901         Adding myself to the committers list.
3902
3903         * Scripts/modules/committers.py:
3904
3905 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
3906
3907         Fix an issue that Adam noticed in DRT.
3908
3909         Reviewed by Darin Adler.
3910
3911         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3912         (AccessibilityUIElement::role):
3913         Get the length of the role text, and create a buffer dynamically.
3914
3915 2009-10-30  Eric Seidel  <eric@webkit.org>
3916
3917         No review, rolling out r50105.
3918         http://trac.webkit.org/changeset/50105
3919
3920         This commit was causing:
3921         https://bugs.webkit.org/show_bug.cgi?id=30869
3922         We'll re-implement the feature a different way.
3923
3924         * Scripts/bugzilla-tool:
3925
3926 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3927
3928         Test for MSAA: Accessibility of headings is not correct
3929
3930         https://bugs.webkit.org/show_bug.cgi?id=30937
3931
3932         Reviewed by Adam Roben.
3933
3934         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3935         (AccessibilityUIElement::role):
3936         Allow the role returned to be a BSTR.
3937         (AccessibilityUIElement::description):
3938         Fix a copy/paste error.
3939
3940 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3941
3942         Test for MSAA: Accessibility of links is wrong
3943
3944         https://bugs.webkit.org/show_bug.cgi?id=30928
3945
3946         Reviewed by Darin Adler.
3947
3948         * DumpRenderTree/AccessibilityUIElement.cpp:
3949         (getAccessibilityValueCallback):
3950         Return the accessibility value.
3951         (AccessibilityUIElement::getJSClass):
3952         Added "accessibilityValue" value.
3953
3954         * DumpRenderTree/AccessibilityUIElement.h:
3955
3956         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3957         (AccessibilityUIElement::accessibilityValue):
3958         Stubbed.
3959
3960         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3961         (AccessibilityUIElement::accessibilityValue):
3962         Stubbed.
3963
3964         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3965         (AccessibilityUIElement::accessibilityValue):
3966         Get the object's value, and return it as a JS string.
3967
3968 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
3969
3970         Fix typo in command name used by wx build system.
3971
3972         * wx/build/build_utils.py:
3973
3974 2009-10-30  Adam Barth  <abarth@webkit.org>
3975
3976         Reviewed by Darin Adler.
3977
3978         Patch v1 is a dumb default name for patches
3979         https://bugs.webkit.org/show_bug.cgi?id=30952
3980
3981         Let's use "Patch" instead.
3982
3983         * Scripts/bugzilla-tool:
3984
3985 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3986
3987         Unreviewed trivial buildfix.
3988
3989         [Qt] Buildfix for r50333.
3990
3991         * DumpRenderTree/qt/DumpRenderTree.pro:
3992
3993 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
3994
3995         Reviewed by Holger Freyther.
3996
3997         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
3998         https://bugs.webkit.org/show_bug.cgi?id=30953
3999
4000         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
4001         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
4002         makes qt DRT to share this implementation (as gtk and mac ports do).
4003
4004         * DumpRenderTree/qt/DumpRenderTree.pro:
4005         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
4006         * DumpRenderTree/qt/WorkQueue.h: Removed.
4007
4008 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4009
4010         Unreviewed potential buildbot fix.
4011
4012         Second try: Reset page history before running each test.
4013
4014         Apparently the QWebHistory::clear() keeps the current page
4015         in history which is not what we want, so we not additionally
4016         sets the history capacity to 0 (forces removing everything)
4017         and then sets it back to its original value.
4018
4019         * DumpRenderTree/qt/DumpRenderTree.cpp:
4020         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4021
4022 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4023
4024         Unreviewed potential buildbot fix.
4025
4026         Reset page history before running each test.
4027
4028         * DumpRenderTree/qt/DumpRenderTree.cpp:
4029         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4030
4031 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
4032
4033         Reviewed by Eric Seidel.
4034
4035         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
4036
4037         Bug 28420 -  Implement HTML5 <ruby> rendering
4038         (https://bugs.webkit.org/show_bug.cgi?id=28420)
4039
4040         No new tests (no functional change).
4041
4042         * Scripts/build-webkit:
4043
4044 2009-10-29  Dan Bernstein  <mitz@apple.com>
4045
4046         Reviewed by Mark Rowe.
4047
4048         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
4049         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
4050         define it.
4051
4052         * Scripts/VCSUtils.pm:
4053         * Scripts/svn-apply:
4054         * Scripts/svn-unapply:
4055
4056 2009-10-29  Xan Lopez  <xlopez@igalia.com>
4057
4058         Reviewed by Gustavo Noronha.
4059
4060         Use the GTK+ main loop instead of rolling our own mini-version of
4061         it.
4062
4063         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4064         (dump):
4065         (runTest):
4066         (webViewLoadFinished):
4067
4068 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4069
4070         Reviewed by Oliver Hunt.
4071
4072         Implement the Qt version of DRT dumpBackForwardList().
4073
4074         * DumpRenderTree/qt/DumpRenderTree.cpp:
4075         (WebCore::dumpHistoryItem):
4076         (WebCore::DumpRenderTree::dumpBackForwardList):
4077
4078 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4079
4080         Reviewed by Adam Roben.
4081
4082         Implement DRT functionality for Qt introduced in
4083         r28690 and r28705.
4084
4085         - Implemented pathToLocalResource which exposes the functionality of
4086         converting a given unix path to the correct location on Windows.
4087         - Implemented a way to remove machine-dependent information from paths
4088         in layout test results.
4089
4090         * DumpRenderTree/qt/DumpRenderTree.cpp:
4091         (WebCore::urlSuitableForTestResult):
4092         (WebCore::WebPage::javaScriptConsoleMessage):
4093         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4094         (LayoutTestController::pathToLocalResource):
4095         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4096
4097 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
4098
4099         Adding myself to the committers list.
4100
4101         * Scripts/modules/committers.py:
4102
4103 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
4104
4105         Adding myself to the committers list.
4106
4107         * Scripts/modules/committers.py:
4108
4109 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4110
4111         Reviewed by Jan Alonzo.
4112
4113         [GTK] API to start inspector for a WebView
4114         https://bugs.webkit.org/show_bug.cgi?id=22551
4115
4116         Use the new inspector API to implement the LayoutTestController
4117         interfaces used to test the inspector.
4118
4119         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4120         (webInspectorInspectWebView):
4121         (createWebView):
4122         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4123         (LayoutTestController::showWebInspector):
4124         (LayoutTestController::closeWebInspector):
4125         (LayoutTestController::evaluateInWebInspector):
4126
4127 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
4128
4129         Reviewed by Eric Seidel.
4130
4131         [Qt] WebFrame::counterValueForElementById must not be exposed
4132         https://bugs.webkit.org/show_bug.cgi?id=30882
4133
4134         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4135         (LayoutTestController::counterValueForElementById):
4136
4137 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4138
4139         Rubberstamped by Oliver Hunt.
4140
4141         Fix the warning:
4142
4143         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
4144         declared with attribute warn_unused_result".
4145
4146         by actually checking the result. In the case it is null, an
4147         error has occoured, so treat it as the other fatal errors.
4148
4149         * DumpRenderTree/qt/DumpRenderTree.cpp:
4150         (WebCore::DumpRenderTree::initializeFonts):
4151
4152 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
4153
4154         Reviewed by Darin Adler.
4155
4156         Provide a way to get counter values with layoutTestContoller
4157         https://bugs.webkit.org/show_bug.cgi?id=30555
4158
4159         Define layoutTestContoller.counterValueForElementById.
4160
4161         * DumpRenderTree/LayoutTestController.cpp:
4162         (counterValueForElementByIdCallback):
4163         (LayoutTestController::staticFunctions):
4164         * DumpRenderTree/LayoutTestController.h:
4165         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4166         (LayoutTestController::counterValueForElementById):
4167
4168 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4169
4170         Rubberstamped by Oliver Hunt.
4171
4172         Change two methods to be internal for DRT use only.
4173
4174         Part of [Qt] Review all new API in Qt 4.6
4175         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
4176
4177         * DumpRenderTree/qt/DumpRenderTree.cpp:
4178         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4179         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4180         (LayoutTestController::whiteListAccessFromOrigin):
4181
4182 2009-10-27  Eric Seidel  <eric@webkit.org>
4183
4184         Reviewed by Adam Barth.
4185
4186         REGRESSION: svn-apply exits(1) when applying a patch with a file add
4187         https://bugs.webkit.org/show_bug.cgi?id=30826
4188
4189         * Scripts/svn-apply:
4190          - Add () around all system() calls.
4191          - Use the correct system() == 0 or die instead of system() or die
4192          - Add descriptive messages to all die statements.
4193
4194 2009-10-27  Steve Block  <steveblock@google.com>
4195
4196         Reviewed by NOBODY.
4197
4198         Adds steveblock@google.com to list of committers.
4199
4200         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
4201
4202 2009-10-27  Eric Seidel  <eric@webkit.org>
4203
4204         Reviewed by Adam Barth.
4205
4206         svn-apply can exit(0) even on patch failure
4207         https://bugs.webkit.org/show_bug.cgi?id=29622
4208
4209         * Scripts/svn-apply:
4210          - Add a bunch of "or die" statements, hopefully catching all
4211            possible cases where failure could still exit(0).
4212
4213 2009-10-27  Eric Seidel  <eric@webkit.org>
4214
4215         Reviewed by Adam Barth.
4216
4217         svn-* scripts should share code through VCSUtils.pm
4218         https://bugs.webkit.org/show_bug.cgi?id=30791
4219
4220         Just moving code into a shared location.
4221
4222         * Scripts/VCSUtils.pm:
4223         * Scripts/prepare-ChangeLog:
4224         * Scripts/resolve-ChangeLogs:
4225         * Scripts/svn-apply:
4226         * Scripts/svn-create-patch:
4227         * Scripts/svn-unapply:
4228         * Scripts/update-webkit:
4229
4230 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
4231
4232         Suppress a huge number of MSVC warnings when building wxWebKit.
4233
4234         * wx/build/settings.py:
4235
4236 2009-10-26  Eric Seidel  <eric@webkit.org>
4237
4238         No review, just adding Mike Belshe to the committers list.
4239
4240         * Scripts/modules/committers.py:
4241
4242 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4243
4244         Reviewed by Darin Adler.
4245
4246         Make .rc files compile on Windows without depending on MFC headers
4247         https://bugs.webkit.org/show_bug.cgi?id=30750
4248
4249         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
4250         windows.h instead of afxres.h because it exists even when MFC is not
4251         installed, and is all that's needed here.
4252
4253         * FindSafari/FindSafari.rc: Ditto
4254
4255 2009-10-24  Eric Seidel  <eric@webkit.org>
4256
4257         Reviewed by Adam Barth.
4258
4259         bugzilla-tool post-diff should know how to mark commit-queue=?
4260         https://bugs.webkit.org/show_bug.cgi?id=29202
4261
4262         * Scripts/bugzilla-tool:
4263          - Add --commit-queue option to post-diff, post-commits and create-bug.
4264         * Scripts/modules/bugzilla.py:
4265          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
4266          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
4267
4268 2009-10-23  Eric Seidel  <eric@webkit.org>
4269
4270         Reviewed by Adam Barth.
4271
4272         bugzilla-tool commit-queue does not notice modifications to committers.py
4273         https://bugs.webkit.org/show_bug.cgi?id=30084
4274
4275         * Scripts/bugzilla-tool:
4276          - Make commit-queue re-exec itself instead of using while(1).
4277          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
4278          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
4279
4280 2009-10-22  Eric Seidel  <eric@webkit.org>
4281
4282         Reviewed by Adam Barth.
4283
4284         commit-queue will get stuck on patches if land-patches terminates unexpectedly
4285         https://bugs.webkit.org/show_bug.cgi?id=30634
4286
4287         * Scripts/bugzilla-tool:
4288          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
4289          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
4290
4291 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
4292
4293         Reviewed by Eric Seidel.
4294
4295         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
4296
4297         https://bugs.webkit.org/show_bug.cgi?id=30763
4298
4299         * pywebsocket/mod_pywebsocket/__init__.py:
4300         * pywebsocket/mod_pywebsocket/dispatch.py:
4301         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
4302         * pywebsocket/mod_pywebsocket/standalone.py:
4303         * pywebsocket/setup.py:
4304         * pywebsocket/test/test_dispatch.py:
4305
4306 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
4307
4308         Reviewed by David Levin.
4309
4310         REGRESSION: 2 failures in run-webkit-unittests
4311         https://bugs.webkit.org/show_bug.cgi?id=30645
4312
4313         * Scripts/modules/cpp_style_unittest.py:
4314         Fixed a few test scenarios which apparently lost some spaces from
4315         text literals.
4316
4317 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
4318
4319         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
4320
4321         * Scripts/webkitdirs.pm:
4322
4323 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
4324
4325         Reviewed by Darin Adler.
4326
4327         Unification of using null device in perl scripts.
4328         https://bugs.webkit.org/show_bug.cgi?id=30572
4329
4330         * Scripts/VCSUtils.pm:
4331         * Scripts/bisect-builds:
4332         * Scripts/resolve-ChangeLogs:
4333         * Scripts/run-iexploder-tests:
4334         * Scripts/run-jsc:
4335         * Scripts/run-mangleme-tests:
4336         * Scripts/run-webkit-tests:
4337         * Scripts/webkitdirs.pm:
4338         Using File::Spec->devnull() instead of hard coded /dev/null.
4339
4340 2009-10-26  Eric Seidel  <eric@webkit.org>
4341
4342         Reviewed by Holger Freyther.
4343
4344         Reviewers are missing from committers.py
4345         https://bugs.webkit.org/show_bug.cgi?id=30733
4346
4347         * Scripts/modules/committers.py:
4348
4349 2009-10-23  Eric Seidel  <eric@webkit.org>
4350
4351         No review, only adding Alice to the list of reviewers.
4352
4353         * Scripts/modules/committers.py:
4354
4355 2009-10-23  Eric Seidel  <eric@webkit.org>
4356
4357         Reviewed by Eric Carlson.
4358
4359         fast/media/mq-transform-02.html failed on Leopard Commit Bot
4360         https://bugs.webkit.org/show_bug.cgi?id=30700
4361
4362         * DumpRenderTree/mac/DumpRenderTree.mm:
4363         (resetDefaultsToConsistentValues): Update QuickTime version check.
4364
4365 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
4366
4367         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
4368         character measurement APIs that are private on Tiger.
4369
4370         * wx/build/settings.py:
4371
4372 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
4373
4374         Reviewed by NOBODY (build fix).
4375         Build fix following bug #30696.
4376
4377         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4378         (LayoutTestController::evaluateScriptInIsolatedWorld):
4379
4380 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
4381
4382         Reviewed by Sam Weinig & Geoff Garen.
4383
4384         https://bugs.webkit.org/show_bug.cgi?id=30696
4385         Enable isolated-worlds tests on mac.
4386
4387         Add private interface for DRT to invoke execution in a given world.
4388
4389         * DumpRenderTree/LayoutTestController.cpp:
4390         (evaluateScriptInIsolatedWorldCallback):
4391         (LayoutTestController::staticFunctions):
4392         * DumpRenderTree/LayoutTestController.h:
4393         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4394         (LayoutTestController::evaluateScriptInIsolatedWorld):
4395         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4396         (LayoutTestController::evaluateScriptInIsolatedWorld):
4397
4398 2009-10-21  Eric Seidel  <eric@webkit.org>
4399
4400         Reviewed by Adam Barth.
4401
4402         bugzilla-tool's "patch failed to download an apply" error should give more information
4403         https://bugs.webkit.org/show_bug.cgi?id=30632
4404
4405         * Scripts/modules/scm.py:
4406          - Use the common run_command method instead of custom POpen code.
4407          - Make run_command know how to take pipes as input.
4408         * Scripts/modules/scm_unittest.py:
4409          - Add new tests to cover change.
4410          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
4411
4412 2009-10-21  Kent Tamura  <tkent@chromium.org>
4413
4414         Unreviewed.  Adding myself to the committers list.
4415
4416         * Scripts/modules/committers.py:
4417
4418 2009-10-21  Robin Dunn  <robin@alldunn.com>
4419
4420         Reviewed by Kevin Ollivier.
4421
4422         Update the Windows installer builder to work with Vista / Win 7 and with git.
4423
4424         https://bugs.webkit.org/show_bug.cgi?id=30649
4425
4426         * wx/build/build_utils.py:
4427         * wx/packaging/build-mac-installer.py:
4428         * wx/packaging/build-win-installer.py:
4429         * wx/packaging/wxWebKitInstaller.iss.in:
4430
4431 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
4432
4433         Reviewed by Gustavo Noronha.
4434
4435         [GTK] Added conditional code to avoid using
4436         gdk_window_get_root_coords if we do not have a gtk+ release newer
4437         than 2.17.3.
4438         https://bugs.webkit.org/show_bug.cgi?id=30636
4439
4440         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
4441
4442 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
4443
4444         Reviewed by Eric Seidel.
4445
4446         [Qt] Added dummy implementation for keepWebHistory()
4447         https://bugs.webkit.org/show_bug.cgi?id=30592
4448
4449         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4450         (LayoutTestController::keepWebHistory):
4451         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4452
4453 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
4454
4455         Reviewed by Xan Lopez.
4456
4457         [GTK] Fixed the double click condition, it is not double click if
4458         we move in just in one direction.
4459         https://bugs.webkit.org/show_bug.cgi?id=30636
4460
4461         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
4462
4463 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
4464
4465         Reviewed by Xan Lopez.
4466
4467         [GTK] Initialize the events completly before emitting them.
4468         https://bugs.webkit.org/show_bug.cgi?id=30633
4469
4470         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
4471
4472 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
4473
4474         wx build fix. Fix for when linking using --as-needed with gcc.
4475
4476         * wx/browser/wscript:
4477
4478 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
4479
4480         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
4481         to support all the features used by CURL backend.
4482
4483         * wx/build/settings.py:
4484         * wx/install-unix-extras:
4485
4486 2009-10-20  Anton Muhin  <antonm@chromium.org>
4487
4488         Reviewed by Adam Barth.
4489
4490         Add {ager,antonm,yurys}@chromium.org into committers.py
4491         https://bugs.webkit.org/show_bug.cgi?id=30560
4492
4493         * Scripts/modules/committers.py:
4494
4495 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4496
4497         Reviewed by Tor Arne Vestbø.
4498
4499         Make the Netscape Test plugin available to the Qt launcher.
4500
4501         * Scripts/run-launcher:
4502
4503 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
4504
4505         Reviewed by David Levin.
4506
4507         Removed WebSocket runtime settings.
4508         https://bugs.webkit.org/show_bug.cgi?id=29896
4509
4510         WebSocket runtime configuration is supported by chromium/v8 only.
4511
4512         * DumpRenderTree/mac/DumpRenderTree.mm:
4513         (resetDefaultsToConsistentValues):
4514         * DumpRenderTree/win/DumpRenderTree.cpp:
4515         (resetDefaultsToConsistentValues):
4516
4517 2009-10-19  Nate Chapin  <japhet@chromium.org>
4518
4519         Reviewed by Adam Barth.
4520
4521         Add testFail() to test plugin so we can test our handling of a
4522         plugin invoke call returning false.
4523
4524         https://bugs.webkit.org/show_bug.cgi?id=30239
4525
4526         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
4527         (pluginInvoke):
4528         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
4529
4530 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
4531
4532         Reviewed by Gustavo Noronha.
4533
4534         Enable DOM pasting when running layout tests.
4535
4536         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4537         (resetDefaultsToConsistentValues):
4538
4539 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4540
4541         Reviewed by Simon Hausmann.
4542
4543         Use the setPreferredContentsSize method instead
4544         of setFixedContentsSize, as the method has been renamed.
4545
4546         * DumpRenderTree/qt/DumpRenderTree.cpp:
4547         (WebCore::DumpRenderTree::open):
4548         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4549         (LayoutTestController::setFixedContentsSize):
4550
4551 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
4552
4553         Reviewed by Dan Bernstein.
4554
4555         https://bugs.webkit.org/show_bug.cgi?id=30456
4556         Fixes for new Debug_All Windows build configuration.
4557
4558         * DumpRenderTree/win/DumpRenderTree.cpp:
4559         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
4560         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
4561
4562 2009-10-16  Eric Seidel  <eric@webkit.org>
4563
4564         Reviewed by Adam Barth.
4565
4566         commit-queue status bot should list which buildbot is blocking the queue
4567         https://bugs.webkit.org/show_bug.cgi?id=30452
4568
4569         Add new methods and testing.
4570
4571         * Scripts/bugzilla-tool:
4572         * Scripts/modules/buildbot.py:
4573         * Scripts/modules/buildbot_unittest.py:
4574
4575 2009-10-16  Eric Seidel  <eric@webkit.org>
4576
4577         Reviewed by Adam Barth.
4578
4579         run-webkit-tests fails when CWD is not inside a WebKit checkout
4580         https://bugs.webkit.org/show_bug.cgi?id=30451
4581
4582         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
4583         * Scripts/modules/scm_unittest.py:
4584           - Remove use of original_path (we don't need to restore the CWD).
4585           - Don't use '.' to find the webkit checkout, use __file__ instead.
4586
4587 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
4588
4589         Reviewed by Adam Roben.
4590
4591         Add a Debug_All configuration to build entire stack as debug.
4592         Change Debug_Internal to:
4593         - stop using _debug suffix for all WebKit/Safari binaries
4594         - not use _debug as a DLL naming suffix
4595         - use non-debug C runtime lib.
4596
4597         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
4598         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
4599         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
4600         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
4601         Add missing debug.vsprops inherited property sheet.
4602         Add Debug_All configuration.
4603         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
4604         * WinLauncher/WinLauncher.vcproj:
4605         Removed extraneous definitions inherited from vsprops.
4606         Add Debug_All configuration.
4607
4608 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
4609
4610         Reviewed by David Levin.
4611
4612         check-webkit-style is wrong about indent checking in namespaces
4613         in header files and a few other things
4614         https://bugs.webkit.org/show_bug.cgi?id=30362
4615
4616         The few other things include:
4617         + check-webkit-style does not require spaces around the equal sign
4618           inside 'if' statements and around binary operators that take
4619           numeric literals.
4620         + check-webkit-style reports false errors for the / operator
4621           when part of a filename in the #include directive.
4622
4623         * Scripts/modules/cpp_style.py:
4624         Improved indentation checking and space checking around
4625         binary operators. While the checks are still not perfect,
4626         they are clearly better than before.
4627         * Scripts/modules/cpp_style_unittest.py:
4628         Added test cases for the newly supported checks and modified old
4629         test cases to match the new guidelines
4630
4631 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
4632
4633         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
4634
4635         * wx/build/settings.py:
4636
4637 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
4638
4639         Reviewed by David Levin.
4640
4641         Add mod_pywebsocket to test Web Sockets.
4642         http://code.google.com/p/pywebsocket/
4643         https://bugs.webkit.org/show_bug.cgi?id=27490
4644
4645         * pywebsocket/COPYING: Added.
4646         * pywebsocket/MANIFEST.in: Added.
4647         * pywebsocket/README: Added.
4648         * pywebsocket/example/echo_client.py: Added.
4649         * pywebsocket/example/echo_wsh.py: Added.
4650         * pywebsocket/mod_pywebsocket/__init__.py: Added.
4651         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
4652         * pywebsocket/mod_pywebsocket/handshake.py: Added.
4653         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
4654         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
4655         * pywebsocket/mod_pywebsocket/standalone.py: Added.
4656         * pywebsocket/mod_pywebsocket/util.py: Added.
4657         * pywebsocket/setup.py: Added.
4658         * pywebsocket/test/config.py: Added.
4659         * pywebsocket/test/mock.py: Added.
4660         * pywebsocket/test/run_all.py: Added.
4661         * pywebsocket/test/test_dispatch.py: Added.
4662         * pywebsocket/test/test_handshake.py: Added.
4663         * pywebsocket/test/test_mock.py: Added.
4664         * pywebsocket/test/test_msgutil.py: Added.
4665         * pywebsocket/test/test_util.py: Added.
4666         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
4667         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
4668         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
4669         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
4670         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
4671         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
4672         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
4673         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
4674
4675 2009-10-15  James Robinson  <jamesr@google.com>
4676
4677         Reviewed by David Levin.
4678
4679         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
4680
4681         https://bugs.webkit.org/show_bug.cgi?id=30426
4682
4683         * Scripts/modules/cpp_style.py:
4684         * Scripts/modules/cpp_style_unittest.py:
4685
4686 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
4687
4688         Reviewed by Adam Roben.
4689
4690         Fixes <http://webkit.org/b/30411>.
4691         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
4692
4693         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
4694         building Chromium.
4695
4696         * Scripts/pdevenv:
4697
4698 2009-10-15  Robin Dunn  <robin@alldunn.com>
4699
4700         Reviewed by Kevin Ollivier.
4701
4702         Add Mac package building scripts for wx.
4703
4704         https://bugs.webkit.org/show_bug.cgi?id=30405
4705
4706         * wx/build/build_utils.py:
4707         * wx/build/settings.py:
4708         * wx/packaging/build-mac-installer.py: Added.
4709
4710 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
4711
4712         Reviewed by Gustavo Noronha.
4713
4714         Enable Web Sockets support when running layout tests.
4715
4716         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4717         (resetDefaultsToConsistentValues):
4718
4719 2009-10-15  Xan Lopez  <xlopez@igalia.com>
4720
4721         Reviewed by Gustavo Noronha.
4722
4723         Need to initialize event.button.button, since in most cases a
4724         button number is not passed as an argument.
4725
4726         * DumpRenderTree/gtk/EventSender.cpp:
4727         (mouseDownCallback):
4728         (mouseUpCallback):
4729
4730 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
4731
4732         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
4733         the OS if none was explicitly set.
4734
4735         * wx/build/settings.py:
4736
4737 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
4738
4739         Reviewed by Timothy Hatcher.
4740
4741         Web Inspector: enable developers extras within inspector layout tests.
4742
4743         https://bugs.webkit.org/show_bug.cgi?id=30014
4744
4745         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4746         (LayoutTestController::showWebInspector):
4747         (LayoutTestController::closeWebInspector):
4748         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4749         (LayoutTestController::showWebInspector):
4750         (LayoutTestController::closeWebInspector):
4751
4752 2009-10-14  José Millán Soto  <jmillan@igalia.com>
4753
4754         Reviewed by Jan Alonzo.
4755
4756         GtkLauncher is using a deprecated signal
4757         https://bugs.webkit.org/show_bug.cgi?id=30364
4758
4759         Modified GtkLauncher to use notify::title signal instead of
4760         deprecated title-changed signal
4761
4762         * GtkLauncher/main.c:
4763         (notify_title_cb):
4764         (create_browser):
4765
4766 2009-10-14  Brady Eidson  <beidson@apple.com>
4767
4768         Reviewed by Sam Weinig.
4769
4770         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
4771         1 - Disables WebHistory
4772         2 - Doesn't make sense in that context anyway.
4773
4774         * DumpRenderTree/win/DumpRenderTree.cpp:
4775         (createWebViewAndOffscreenWindow):
4776
4777 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
4778
4779         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
4780         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
4781
4782         * wx/build/settings.py:
4783         * wx/install-unix-extras:
4784
4785 2009-10-14  Brady Eidson  <beidson@apple.com>
4786
4787         Reviewed by Sam Weinig.
4788
4789         WebKit Win API should provide a delegate interface for global history.
4790         https://bugs.webkit.org/show_bug.cgi?id=29905
4791
4792         * DumpRenderTree/LayoutTestController.cpp:
4793         (LayoutTestController::LayoutTestController):
4794         * DumpRenderTree/LayoutTestController.h:
4795         (LayoutTestController::dumpHistoryDelegateCallbacks):
4796         (LayoutTestController::setDumpHistoryDelegateCallbacks):
4797
4798         * DumpRenderTree/win/DumpRenderTree.cpp:
4799         (shouldLogHistoryDelegates):
4800         (runTest):
4801         (createWebViewAndOffscreenWindow):
4802         (main):
4803         * DumpRenderTree/win/DumpRenderTree.vcproj:
4804
4805         Add the IWebHistoryDelegate to DRT Windows:
4806         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
4807         (wstringFromBSTR):
4808         (HistoryDelegate::HistoryDelegate):
4809         (HistoryDelegate::~HistoryDelegate):
4810         (HistoryDelegate::QueryInterface):
4811         (HistoryDelegate::AddRef):
4812         (HistoryDelegate::Release):
4813         (HistoryDelegate::didNavigateWithNavigationData):
4814         (HistoryDelegate::didPerformClientRedirectFromURL):
4815         (HistoryDelegate::didPerformServerRedirectFromURL):
4816         (HistoryDelegate::updateHistoryTitle):
4817         (HistoryDelegate::populateVisitedLinksForWebView):
4818         * DumpRenderTree/win/HistoryDelegate.h: Added.
4819
4820         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4821         (LayoutTestController::removeAllVisitedLinks):
4822
4823 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
4824
4825         Reviewed by Simon Hausmann.
4826
4827         [Qt] Implement support for setPOSIXLocale on Qt.
4828         https://bugs.webkit.org/show_bug.cgi?id=30268
4829
4830         * DumpRenderTree/qt/DumpRenderTree.cpp:
4831         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4832         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4833         (LayoutTestController::setPOSIXLocale):
4834         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4835
4836 2009-10-13  Stephanie Lewis  <slewis@apple.com>
4837
4838         Unreviewed, adding myself to reviewers list.
4839
4840         * Scripts/modules/committers.py:
4841
4842 2009-10-13  Stephanie Lewis  <slewis@apple.com>
4843
4844         Reviewed by Mark Rowe.
4845
4846         Fix null assignment so root tests work again.
4847
4848         * Scripts/webkitdirs.pm:
4849
4850 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
4851
4852         Reviewed by Simon Hausmann.
4853
4854         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
4855         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
4856         This is done in preparation of implementing missing features in DRT.
4857         No functionality changes made yet.
4858
4859         * DumpRenderTree/qt/DumpRenderTree.cpp:
4860         * DumpRenderTree/qt/DumpRenderTree.pro:
4861         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
4862         (EventSender::EventSender):
4863         (EventSender::mouseDown):
4864         (EventSender::mouseUp):
4865         (EventSender::mouseMoveTo):
4866         (EventSender::leapForward):
4867         (EventSender::keyDown):
4868         (EventSender::contextClick):
4869         (EventSender::scheduleAsynchronousClick):
4870         (EventSender::frameUnderMouse):
4871         * DumpRenderTree/qt/EventSenderQt.h: Added.
4872         (EventSender::clearKillRing):
4873         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
4874         (LayoutTestController::LayoutTestController):
4875         (LayoutTestController::reset):
4876         (LayoutTestController::processWork):
4877         (LayoutTestController::maybeDump):
4878         (LayoutTestController::waitUntilDone):
4879         (LayoutTestController::notifyDone):
4880         (LayoutTestController::windowCount):
4881         (LayoutTestController::clearBackForwardList):
4882         (LayoutTestController::dumpEditingCallbacks):
4883         (LayoutTestController::dumpResourceLoadCallbacks):
4884         (LayoutTestController::queueBackNavigation):
4885         (LayoutTestController::queueForwardNavigation):
4886         (LayoutTestController::queueLoad):
4887         (LayoutTestController::queueReload):
4888         (LayoutTestController::queueScript):
4889         (LayoutTestController::provisionalLoad):
4890         (LayoutTestController::timerEvent):
4891         (LayoutTestController::encodeHostName):
4892         (LayoutTestController::decodeHostName):
4893         (LayoutTestController::setJavaScriptProfilingEnabled):
4894         (LayoutTestController::setFixedContentsSize):
4895         (LayoutTestController::setPrivateBrowsingEnabled):
4896         (LayoutTestController::setPopupBlockingEnabled):
4897         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
4898         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
4899         (LayoutTestController::numberOfActiveAnimations):
4900         (LayoutTestController::disableImageLoading):
4901         (LayoutTestController::dispatchPendingLoadRequests):
4902         (LayoutTestController::setDatabaseQuota):
4903         (LayoutTestController::clearAllDatabases):
4904         (LayoutTestController::whiteListAccessFromOrigin):
4905         (LayoutTestController::waitForPolicyDelegate):
4906         (LayoutTestController::overridePreference):
4907         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
4908         (LayoutTestController::isLoading):
4909         (LayoutTestController::setLoading):
4910         (LayoutTestController::shouldDumpAsText):
4911         (LayoutTestController::shouldDumpBackForwardList):
4912         (LayoutTestController::shouldDumpChildrenAsText):
4913         (LayoutTestController::shouldDumpDatabaseCallbacks):
4914         (LayoutTestController::shouldDumpStatusCallbacks):
4915         (LayoutTestController::shouldWaitUntilDone):
4916         (LayoutTestController::canOpenWindows):
4917         (LayoutTestController::shouldDumpTitleChanges):
4918         (LayoutTestController::waitForPolicy):
4919         (LayoutTestController::dumpAsText):
4920         (LayoutTestController::dumpChildFramesAsText):
4921         (LayoutTestController::dumpDatabaseCallbacks):
4922         (LayoutTestController::dumpStatusCallbacks):
4923         (LayoutTestController::setCanOpenWindows):
4924         (LayoutTestController::dumpBackForwardList):
4925         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
4926         (LayoutTestController::display):
4927         (LayoutTestController::dumpTitleChanges):
4928         (LayoutTestController::dumpSelectionRect):
4929         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
4930         (TextInputController::TextInputController):
4931         (TextInputController::doCommand):
4932         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
4933         * DumpRenderTree/qt/WorkQueue.cpp:
4934         * DumpRenderTree/qt/WorkQueue.h:
4935         * DumpRenderTree/qt/WorkQueueItem.h:
4936         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
4937         (findFrameNamed):
4938         (LoadItem::invoke):
4939         (ReloadItem::invoke):
4940         (ScriptItem::invoke):
4941         (BackForwardItem::invoke):
4942         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
4943         * DumpRenderTree/qt/jsobjects.h:
4944
4945 2009-10-13  Dmitry Titov  <dimich@chromium.org>
4946
4947         Not reviewed, adding myself to the list of reviewers.
4948
4949         * Scripts/modules/committers.py:
4950
4951 2009-10-13  Anders Carlsson  <andersca@apple.com>
4952
4953         Reviewed by Sam Weinig.
4954
4955         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
4956
4957         Make the private browsing mode testable by the test plug-in.
4958
4959         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
4960         (pluginGetProperty):
4961         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
4962         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
4963         (NPP_New):
4964         (NPP_SetValue):
4965
4966 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
4967
4968         No review, just adding self to the list of reviewers.
4969
4970         * Scripts/modules/committers.py:
4971
4972 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
4973
4974         Reviewed by Adam Roben.
4975
4976         Web Inspector: Use proper web view in inspector layout
4977         tests for windows.
4978
4979         https://bugs.webkit.org/show_bug.cgi?id=30298
4980
4981         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4982         (LayoutTestController::showWebInspector):
4983         (LayoutTestController::closeWebInspector):
4984         (LayoutTestController::evaluateInWebInspector):
4985
4986 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
4987
4988         Reviewed by Sam Weinig.
4989
4990         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
4991         https://bugs.webkit.org/show_bug.cgi?id=29841
4992
4993         * DumpRenderTree/mac/DumpRenderTree.mm:
4994         (resetDefaultsToConsistentValues):
4995         * DumpRenderTree/win/DumpRenderTree.cpp:
4996         (resetDefaultsToConsistentValues):
4997
4998 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
4999
5000         Reviewed by Dimitri Glazkov.
5001
5002         Chromium Port - Windows
5003         https://bugs.webkit.org/show_bug.cgi?id=29969
5004
5005         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
5006         * Scripts/webkitdirs.pm:
5007
5008 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
5009
5010         Reviewed by Darin Adler.
5011
5012         jsc scripts cleanup and Qt/GTK fix
5013         https://bugs.webkit.org/show_bug.cgi?id=30288
5014
5015         Duplicated jscPath() moved to webkitdirs.pm.
5016         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
5017         Configuration added (release/debug) to path for Qt-port on Windows.
5018
5019         * Scripts/run-javascriptcore-tests:
5020         * Scripts/run-jsc:
5021         * Scripts/run-sunspider:
5022         * Scripts/sunspider-compare-results:
5023         * Scripts/webkitdirs.pm:
5024
5025 2009-10-11  Adam Barth  <abarth@webkit.org>
5026
5027         Unreviewed.  Add Collin to committers.py.
5028
5029         * Scripts/modules/committers.py:
5030
5031 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
5032
5033         wx build fix, add bindings to source/include dirs now that there are sources there.
5034
5035         * wx/build/settings.py:
5036
5037 2009-10-09  Mark Rowe  <mrowe@apple.com>
5038
5039         Reviewed by Brady Eidson.
5040
5041         Enable plug-in halting in DumpRenderTree.
5042
5043         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
5044         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
5045
5046         * DumpRenderTree/mac/DumpRenderTree.mm:
5047         (resetDefaultsToConsistentValues):
5048         * DumpRenderTree/mac/UIDelegate.mm:
5049         (-[UIDelegate webView:shouldHaltPlugin:]):
5050
5051 2009-10-08  Brady Eidson  <beidson@apple.com>
5052
5053         Reviewed by Dan Bernstein.
5054
5055         Ask the History Delegate to populate the visited links hash.
5056         <rdar://problem/7285293> and https://webkit.org/b/29904
5057
5058         Add the ability for LayoutTestController to clear all visited links.
5059         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
5060
5061         * DumpRenderTree/LayoutTestController.cpp:
5062         (LayoutTestController::LayoutTestController):
5063         (removeAllVisitedLinksCallback):
5064         (LayoutTestController::staticFunctions):
5065         * DumpRenderTree/LayoutTestController.h:
5066         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
5067         (LayoutTestController::removeAllVisitedLinks):
5068
5069         * DumpRenderTree/mac/HistoryDelegate.mm:
5070         (-[HistoryDelegate populateVisitedLinksForWebView:]):
5071
5072         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
5073         (LayoutTestController::removeAllVisitedLinks):
5074         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
5075         (LayoutTestController::removeAllVisitedLinks):
5076         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
5077         (LayoutTestController::removeAllVisitedLinks):
5078
5079
5080 2009-10-08  Daniel Bates  <dbates@webkit.org>
5081
5082         Reviewed by Adam Roben.
5083
5084         https://bugs.webkit.org/show_bug.cgi?id=30175
5085
5086         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
5087         the OLE drag-and-drop return value like the function it emulates. Currently,
5088         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
5089         whether the drag-and-drop operation was successful or was cancelled.
5090
5091         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
5092         return value according to whether the drop operation was successful or not.
5093
5094         * DumpRenderTree/win/EventSender.cpp:
5095         (doMouseUp): Added parameter oleDragAndDropReturnValue.
5096         (replaySavedEvents): Ditto.
5097         * DumpRenderTree/win/EventSender.h:
5098         * DumpRenderTree/win/UIDelegate.cpp:
5099         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
5100
5101 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
5102
5103         Reviewed by Xan Lopez.
5104
5105         [GTK] Added support for a parameter setting the button that was
5106         pressed in the mouseDown function.
5107         https://bugs.webkit.org/show_bug.cgi?id=30220
5108
5109         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
5110
5111 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
5112
5113         Reviewed by Xan Lopez.
5114
5115         [GTK] Added a line to the bottom of the expected result to match
5116         the output of the test.
5117         https://bugs.webkit.org/show_bug.cgi?id=30220
5118
5119         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
5120         expected.txt:
5121
5122 2009-10-08  Adam Roben  <aroben@apple.com>
5123
5124         Use QueryInterface to get IWebInspectorPrivate
5125
5126         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
5127         accessed in a more standard way
5128
5129         Reviewed by John Sullivan and Tim Hatcher.
5130
5131         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
5132         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
5133         by calling IWebViewPrivate::inspector, then use QueryInterface to get
5134         to the IWebInspectorPrivate interface.
5135
5136 2009-10-07  Adam Roben  <aroben@apple.com>
5137
5138         Implement DRT support for origin whitelisting
5139
5140         Fixes <http://webkit.org/b/30185>.
5141
5142         Reviewed by Eric Seidel.
5143
5144         * DumpRenderTree/win/DumpRenderTree.cpp:
5145         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
5146         whitelist, to match Mac DRT.
5147         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
5148         (LayoutTestController::whiteListAccessFromOrigin): Call through to
5149         IWebViewPrivate::whiteListAccessFromOrigin.
5150
5151 2009-10-07  Brady Eidson  <beidson@apple.com>
5152
5153         Reviewed by Darin Adler.
5154
5155         Send title changes to the global history delegate.
5156         <rdar://problem/7285293> and https://webkit.org/b/29904
5157
5158         * DumpRenderTree/mac/HistoryDelegate.mm:
5159         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
5160
5161 2009-10-07  Adam Barth  <abarth@webkit.org>
5162
5163         Unreviewed.  Remove some folks from committers.py who were listed on
5164         the WebKit Team wiki page but who weren't actually listed as commit+.
5165         At some point, we should coorelate this list with the committers
5166         mailing list.
5167
5168         * Scripts/modules/committers.py:
5169
5170 2009-10-07  Adam Barth  <abarth@webkit.org>
5171
5172         Unreviewed.  Import a bunch of committers from the WebKit Team page on
5173         the wiki into committers.py.
5174
5175         * Scripts/modules/committers.py:
5176
5177 2009-10-07  Adam Barth  <abarth@webkit.org>
5178
5179         Unreviewed.  Added Aaron Boodman to committers.py.
5180
5181         * Scripts/modules/committers.py:
5182
5183 2009-10-07  Evan Martin  <evan@chromium.org>
5184
5185         Reviewed by Darin Adler.
5186
5187         Add API to LayoutTestController for re/setting the system locale.
5188         https://bugs.webkit.org/show_bug.cgi?id=18994
5189
5190         * DumpRenderTree/LayoutTestController.cpp:
5191         (setLocaleCallback):
5192         (LayoutTestController::staticFunctions):
5193         (LayoutTestController::setLocale):
5194         * DumpRenderTree/LayoutTestController.h:
5195
5196 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
5197
5198         Reviewed by Jan Alonzo.
5199
5200         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
5201         https://bugs.webkit.org/show_bug.cgi?id=29689
5202
5203         Build fix by adding -lfontconfig for DumpRenderTree.
5204
5205         * GNUmakefile.am:
5206
5207 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
5208
5209         Reviewed by Simon Hausmann.
5210
5211         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
5212
5213         * Scripts/run-webkit-tests:
5214
5215 2009-10-07  Xan Lopez  <xlopez@igalia.com>
5216
5217         Reviewed by Gustavo Noronha.
5218
5219         "delete" in EventSender is the backspace key, not the delete one.
5220
5221         * DumpRenderTree/gtk/EventSender.cpp:
5222         (keyDownCallback):
5223
5224 2009-10-07  Xan Lopez  <xlopez@igalia.com>
5225
5226         Reviewed by Gustavo Noronha.
5227
5228         getChildrenWithRange expects as last parameter the end index, not
5229         the length of the range. Correct this and clarify the variable
5230         names to reflect how the code works.
5231
5232         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
5233         (AccessibilityUIElement::getChildrenWithRange):
5234         (AccessibilityUIElement::getChildAtIndex):
5235
5236 2009-10-06  Mark Rowe  <mrowe@apple.com>
5237
5238         Reviewed by Simon Fraser.
5239
5240         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
5241
5242         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
5243         the fact we have already changed the working directory to the top of the open source tree.
5244
5245 2009-10-06  Julie Parent  <jparent@chromium.org>
5246
5247         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
5248         rather than my committer email.
5249
5250         * Scripts/modules/committers.py:
5251
5252 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
5253
5254         Reviewed by Eric Seidel.
5255
5256         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
5257
5258         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
5259         it after each layout test as it should do, making the DRT dump additional output
5260         for all of the subsequent layout tests.
5261
5262         * DumpRenderTree/qt/jsobjects.cpp:
5263         (LayoutTestController::reset):
5264
5265 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
5266
5267         Reviewed by Simon Hausmann.
5268
5269         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
5270         fast/dom/assign-to-window-status.html test, which is passing as a result.
5271
5272         https://bugs.webkit.org/show_bug.cgi?id=30127
5273
5274         * DumpRenderTree/qt/DumpRenderTree.cpp:
5275         (WebCore::DumpRenderTree::DumpRenderTree):
5276         (WebCore::DumpRenderTree::statusBarMessage):
5277         * DumpRenderTree/qt/DumpRenderTree.h:
5278         * DumpRenderTree/qt/jsobjects.h:
5279         (LayoutTestController::shouldDumpStatusCallbacks):
5280         (LayoutTestController::dumpStatusCallbacks):
5281
5282 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
5283
5284         Reviewed by Simon Hausmann.
5285
5286         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
5287         ignores the argument indicating which mouse button to trigger.
5288         https://bugs.webkit.org/show_bug.cgi?id=30048
5289
5290         This affects the fast/events/mouse-click-events.html layout test.
5291
5292         * DumpRenderTree/qt/jsobjects.cpp:
5293         (EventSender::mouseDown):
5294         (EventSender::mouseUp):
5295         * DumpRenderTree/qt/jsobjects.h:
5296
5297 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
5298
5299         Reviewed by Simon Hausmann.
5300
5301         [Qt] Fix the EventSender::keyDown() implementation
5302         https://bugs.webkit.org/show_bug.cgi?id=30043
5303
5304         It should post both a key press event and a key release event,
5305         just like other ports do.
5306
5307         * DumpRenderTree/qt/jsobjects.cpp:
5308         (EventSender::keyDown):
5309
5310 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
5311
5312         wx build fix. Add jpeg to the list of libs to link against.
5313
5314         * wx/build/settings.py:
5315
5316 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
5317
5318         Reviewed by Simon Hausmann.
5319
5320         [Qt] EventSender::keyDown() cannot send function-key events.
5321         https://bugs.webkit.org/show_bug.cgi?id=30044
5322
5323         This affects the fast/events/keydown-function-keys.html layout test.
5324
5325         * DumpRenderTree/qt/jsobjects.cpp:
5326         (EventSender::keyDown):
5327
5328 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
5329
5330         Added --wx-compiler-prefix waf option to allow building wxWebKit with
5331         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
5332
5333         * wx/build/settings.py:
5334         * wx/build/wxpresets.py:
5335
5336 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
5337
5338         Reviewed by Timothy Hatcher.
5339
5340         Web Inspector: add testing harness for Web Inspector.
5341
5342         https://bugs.webkit.org/show_bug.cgi?id=30010
5343
5344         * DumpRenderTree/LayoutTestController.cpp:
5345         (showWebInspectorCallback):
5346         (closeWebInspectorCallback):
5347         (evaluateInWebInspectorCallback):
5348         (LayoutTestController::staticFunctions):
5349         * DumpRenderTree/LayoutTestController.h:
5350         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
5351         (LayoutTestController::showWebInspector):
5352         (LayoutTestController::closeWebInspector):
5353         (LayoutTestController::evaluateInWebInspector):
5354         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
5355         (LayoutTestController::showWebInspector):
5356         (LayoutTestController::closeWebInspector):
5357         (LayoutTestController::evaluateInWebInspector):
5358         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
5359         (LayoutTestController::showWebInspector):
5360         (LayoutTestController::closeWebInspector):
5361         (LayoutTestController::evaluateInWebInspector):
5362         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
5363         (LayoutTestController::showWebInspector):
5364         (LayoutTestController::closeWebInspector):
5365         (LayoutTestController::evaluateInWebInspector):
5366
5367 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
5368
5369         Reviewed by Ariyha Hidayat.
5370
5371         Pass arguments to system() as a string instead of array
5372
5373         When passed as an array entries with a space fail to translate
5374         to two arguments to the child process, so instead of manually
5375         splitting all the entries in @buildArgs we pass the whole thing
5376         as a string instead.
5377
5378         * Scripts/webkitdirs.pm:
5379
5380 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
5381
5382         Reviewed by David Levin.
5383
5384         check-webkit-style misses whitespace errors for operators:
5385         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
5386         https://bugs.webkit.org/show_bug.cgi?id=30021
5387
5388         * Scripts/modules/cpp_style.py:
5389         Added the operators mentioned above to the same list as == and !=.
5390
5391 2009-10-02  Julie Parent  <jparent@chromium.org>
5392
5393         Unreviewed.
5394
5395         Adding myself and Ojan Vafai as committers, because we are committers.
5396
5397         * Scripts/modules/committers.py:
5398
5399 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
5400
5401         Reviewed by Adam Roben.
5402
5403         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
5404         this will help the patch merging process when TryBots are used.
5405
5406         * Scripts/svn-create-patch:
5407
5408 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
5409
5410         Reviewed by Simon Hausmann.
5411
5412         [Qt] Implement layoutTestController.overridePreference().
5413         https://bugs.webkit.org/show_bug.cgi?id=29970
5414
5415         * DumpRenderTree/qt/DumpRenderTree.cpp:
5416         (WebCore::WebPage::WebPage):
5417         (WebCore::WebPage::resetSettings):
5418         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
5419         * DumpRenderTree/qt/jsobjects.cpp:
5420         (LayoutTestController::reset):
5421         (LayoutTestController::setPrivateBrowsingEnabled):
5422         (LayoutTestController::setPopupBlockingEnabled):
5423         (LayoutTestController::overridePreference):
5424         * DumpRenderTree/qt/jsobjects.h:
5425
5426 2009-10-01  Chris Marrin  <cmarrin@apple.com>
5427
5428         Reviewed by Oliver Hunt.
5429
5430         Turn on ENABLE_3D_CANVAS in TOT
5431         https://bugs.webkit.org/show_bug.cgi?id=29906
5432
5433         * Scripts/build-webkit:
5434
5435 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
5436
5437         Rubberstamped by Simon Hausmann.
5438
5439         Enable HTTP tests for Qt
5440
5441         * Scripts/run-webkit-tests:
5442
5443 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
5444
5445         Reviewed by Dimitri Glazkov.
5446
5447         build-webkit --chromium now also works on cygwin.
5448
5449         https://bugs.webkit.org/show_bug.cgi?id=29973
5450
5451         * Scripts/webkitdirs.pm:
5452
5453 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
5454
5455         Reviewed by Simon Hausmann.
5456
5457         [Qt] Don't use TCmalloc in DumpRenderTree
5458         https://bugs.webkit.org/show_bug.cgi?id=27029
5459
5460         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
5461
5462         * DumpRenderTree/qt/DumpRenderTree.pro:
5463
5464 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
5465
5466         Reviewed by Simon Hausmann.
5467
5468         [Qt] Implement eventSender.scheduleAsynchronousClick().
5469
5470         https://bugs.webkit.org/show_bug.cgi?id=29931
5471
5472         * DumpRenderTree/qt/jsobjects.cpp:
5473         (EventSender::scheduleAsynchronousClick):
5474         * DumpRenderTree/qt/jsobjects.h:
5475
5476 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
5477
5478         Reviewed by Simon Hausmann.
5479
5480         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
5481         fast/events/open-window-from-another-frame.html from the Skipped list.
5482
5483         https://bugs.webkit.org/show_bug.cgi?id=29930
5484
5485         * DumpRenderTree/qt/jsobjects.cpp:
5486         (LayoutTestController::setPopupBlockingEnabled):
5487         * DumpRenderTree/qt/jsobjects.h:
5488
5489 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
5490
5491         Unreviewed.
5492
5493         Added myself to the list of committers.
5494
5495         * Scripts/modules/committers.py:
5496
5497 2009-09-30  Eric Seidel  <eric@webkit.org>
5498
5499         No review, just adding Geoff to the list of reviewers.
5500
5501         * Scripts/modules/committers.py:
5502
5503 2009-09-30  Dan Bernstein  <mitz@apple.com>
5504
5505         Reviewed by Sam Weinig.
5506
5507         Added the WebKit Layout Tests fonts that are referenced in
5508         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
5509
5510         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
5511         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
5512
5513 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
5514
5515         Reviewed by David Kilzer.
5516
5517         Make sunspider scripts work on Windows platform.
5518         https://bugs.webkit.org/show_bug.cgi?id=29656
5519
5520         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
5521         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
5522         * Scripts/webkitdirs.pm: currentPerlPath() added.
5523
5524 2009-09-29  Brady Eidson  <beidson@apple.com>
5525
5526         Rubberstamped by Dan Bernstein.
5527
5528         Fix license and some sorting in new files.
5529
5530         * DumpRenderTree/mac/HistoryDelegate.h:
5531         * DumpRenderTree/mac/HistoryDelegate.mm:
5532
5533 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
5534
5535         Reviewed by David Kilzer.
5536
5537         Fixed how error codes are handled.
5538         https://bugs.webkit.org/show_bug.cgi?id=29898
5539
5540         * Scripts/update-webkit:
5541         * Scripts/update-webkit-chromium:
5542
5543 2009-09-29  Brady Eidson  <beidson@apple.com>
5544
5545         Reviewed by John Sullivan.
5546
5547         Updated way-out-of-date sorting throughout the dump methods/flags.
5548
5549         * DumpRenderTree/LayoutTestController.cpp:
5550         (LayoutTestController::LayoutTestController):
5551         (dumpAsPDFCallback):
5552         (dumpAsTextCallback):
5553         (dumpFrameLoadCallbacksCallback):
5554         (dumpResourceLoadCallbacksCallback):
5555         (LayoutTestController::staticFunctions):
5556
5557         * DumpRenderTree/LayoutTestController.h:
5558         (LayoutTestController::dumpAsText):
5559         (LayoutTestController::setDumpAsText):
5560         (LayoutTestController::dumpFrameLoadCallbacks):
5561         (LayoutTestController::setDumpFrameLoadCallbacks):
5562         (LayoutTestController::dumpSelectionRect):
5563         (LayoutTestController::setDumpSelectionRect):
5564         (LayoutTestController::dumpSourceAsWebArchive):
5565         (LayoutTestController::setDumpSourceAsWebArchive):
5566         (LayoutTestController::dumpStatusCallbacks):
5567         (LayoutTestController::setDumpStatusCallbacks):
5568         (LayoutTestController::dumpTitleChanges):
5569         (LayoutTestController::setDumpTitleChanges):
5570         (LayoutTestController::dumpWillCacheResponse):
5571         (LayoutTestController::setDumpWillCacheResponse):
5572
5573 2009-09-29  Brady Eidson  <beidson@apple.com>
5574
5575         Reviewed by John Sullivan.
5576
5577         WebKit Mac API should provide a delegate interface for global history.
5578         <rdar://problem/7042773> and https://webkit.org/b/29904
5579
5580         Adding the dumping of global history delegate callbacks.
5581
5582         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
5583
5584         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
5585         * DumpRenderTree/mac/DumpRenderTree.mm:
5586         (createWebViewAndOffscreenWindow):
5587         (allocateGlobalControllers):
5588         (shouldLogFrameLoadDelegates):
5589         (shouldLogHistoryDelegates):
5590         (runTest):
5591
5592         Dump history delegate callbacks:
5593         * DumpRenderTree/mac/HistoryDelegate.h: Added.
5594         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
5595         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
5596         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
5597         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
5598
5599 2009-09-29  Daniel Bates  <dbates@webkit.org>
5600
5601         Reviewed by Adam Roben.
5602
5603         https://bugs.webkit.org/show_bug.cgi?id=28902
5604
5605         Fixes an issue where the drop effect returned by Window Dump Render Tree
5606         was always DROPEFFECT_NONE (since it was hard coded to do so).
5607
5608         This patch corrects this issue by determining the actual drop effect
5609         performed by the corresponding drag-and-drop operation so that we can
5610         return it.
5611
5612         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
5613         (DraggingInfo::DraggingInfo):
5614         (DraggingInfo::performedDropEffect): Added method.
5615         (DraggingInfo::setPerformedDropEffect): Added method.
5616         * DumpRenderTree/win/EventSender.cpp:
5617         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
5618         Moved delete draggingInfo to UIDelegate::doDragDrop.
5619         * DumpRenderTree/win/UIDelegate.cpp:
5620         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
5621
5622 2009-09-29  Dan Bernstein  <mitz@apple.com>
5623
5624         Reviewed by Adam Roben.
5625
5626         Remove copying of unnecessary or nonexistent files from the ImageDiff
5627         post-build event.
5628
5629         * DumpRenderTree/win/ImageDiff.vcproj:
5630
5631 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
5632
5633         Reviewed by David Kilzer.
5634
5635         [Qt] Make build-webkit script work on Windows
5636         https://bugs.webkit.org/show_bug.cgi?id=29802
5637
5638         * Scripts/run-webkit-tests:
5639         * Scripts/webkitdirs.pm:
5640          - Removed unnecessary -p switch for mkdir on Windows.
5641          - Use canonical path, which uses slashes or backslashes depends on platform.
5642          - isWindows() only test for Windows and not for Cyqwin.
5643
5644 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
5645
5646         Reviewed by Simon Hausmann.
5647
5648         Fix time measurement in build-webkit after refactoring done in r48853.
5649
5650         * Scripts/build-webkit:
5651
5652 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
5653
5654         Reviewed by Tor Arne Vestbø.
5655
5656         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
5657         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
5658
5659         * DumpRenderTree/qt/DumpRenderTree.cpp:
5660         (WebCore::WebPage::WebPage):
5661
5662 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
5663
5664         Reviewed by Simon Hausmann.
5665
5666         [Qt] Implement eventSender.contextClick().
5667         https://bugs.webkit.org/show_bug.cgi?id=29821
5668
5669         * DumpRenderTree/qt/jsobjects.cpp:
5670         (EventSender::contextClick):
5671         * DumpRenderTree/qt/jsobjects.h:
5672
5673 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
5674
5675         Reviewed by Eric Seidel.
5676
5677         Add experimentalWebSocketsEnabled in WebPreferences.
5678         https://bugs.webkit.org/show_bug.cgi?id=28941
5679
5680         * DumpRenderTree/mac/DumpRenderTree.mm:
5681         (resetDefaultsToConsistentValues):
5682         * DumpRenderTree/win/DumpRenderTree.cpp:
5683         (resetDefaultsToConsistentValues):
5684
5685 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
5686
5687         Reviewed by David Kilzer.
5688
5689         Integrated chromium port building into webkit tools update-webkit and
5690         build-webkit.
5691
5692         https://bugs.webkit.org/show_bug.cgi?id=29749
5693
5694         * Scripts/build-webkit: When --chromium is specified, will build
5695           the chromium port (currently only Mac is supported).
5696         * Scripts/update-webkit: When --chromium is specified, delegates to
5697           update-webkit-chromium.
5698         * Scripts/webkitdirs.pm: Added chromium specific defs.
5699         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
5700           chromium port's dependencies and update its project files.
5701
5702 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
5703
5704         Unreviewed.
5705
5706         Add myself to list of committers.
5707
5708         * Scripts/modules/committers.py:
5709
5710 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
5711
5712         Reviewed by Darin Adler.
5713
5714         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
5715         https://bugs.webkit.org/show_bug.cgi?id=29771
5716
5717         * Scripts/run-webkit-tests:
5718
5719 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
5720
5721         Reviewed by Simon Hausmann.
5722
5723         [Qt] Implement layoutTestController.waitForPolicyDelegate.
5724         https://bugs.webkit.org/show_bug.cgi?id=25037
5725
5726         * DumpRenderTree/qt/DumpRenderTree.cpp:
5727         (WebCore::WebPage::acceptNavigationRequest):
5728         * DumpRenderTree/qt/DumpRenderTree.pro:
5729         * DumpRenderTree/qt/jsobjects.cpp:
5730         (LayoutTestController::reset):
5731         (LayoutTestController::notifyDone):
5732         (LayoutTestController::waitForPolicyDelegate):
5733         * DumpRenderTree/qt/jsobjects.h:
5734         (LayoutTestController::waitForPolicy):
5735
5736 2009-09-26  David Kilzer  <ddkilzer@apple.com>
5737
5738         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
5739
5740         Reviewed by Eric Seidel.
5741
5742         The -o|--open switch uses the open(1) command on Mac OS X to
5743         open the bug URL in the default web browser.  If there are
5744         similar mechanisms on other platforms, they may be added later.
5745
5746         * Scripts/mark-bug-fixed:
5747         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
5748         options.
5749         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
5750         code into main() and extracted prompting code into
5751         _prompt_user_for_correctness().
5752         (MarkBugFixed._open_bug_in_web_browser): Added.
5753         (MarkBugFixed._prompt_user_for_correctness): Added.
5754         (MarkBugFixed.main): Added logging code from
5755         _determine_bug_id_and_svn_revision().  Added code to call
5756         _open_bug_in_web_browser() if the switch is set.  Added code to
5757         call _prompt_user_for_correctness() when needed.
5758         * Scripts/modules/bugzilla.py:
5759         (Bugzilla.short_bug_url_for_bug_id): Added.
5760
5761 2009-09-26  David Kilzer  <ddkilzer@apple.com>
5762
5763         svn-unapply and svn-apply don't work when used outside multiple svn working directories
5764
5765         <http://webkit.org/b/29744>
5766         <rdar://problem/7252905>
5767
5768         Reviewed by Eric Seidel.
5769
5770         Some users have a workflow where svn-create-patch, svn-apply and
5771         svn-unapply are used outside of multiple svn working
5772         directories.  Instead of aborting the scripts in these cases,
5773         print a warning and assume that Subversion is being used.
5774
5775         * Scripts/VCSUtils.pm:
5776         (determineVCSRoot): Call warn() instead of die() if both isGit()
5777         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
5778         to enforce the assumption about Subversion, then return
5779         determineSVNRoot().
5780         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
5781         VCSUtils.pm.  They both already cache their values and checking
5782         here is redundant since determineVCSRoot() is called later.
5783
5784 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
5785
5786         Reviewed by Gustavo Noronha.
5787
5788         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
5789         https://bugs.webkit.org/show_bug.cgi?id=29689
5790
5791         Load test fonts through FontConfig before each test.
5792         This ensures a more proper rendering of the tests.
5793
5794         * DumpRenderTree/gtk/DumpRenderTree.cpp:
5795         (initializeFonts):
5796         (runTest):
5797         (main):
5798         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
5799         * GNUmakefile.am:
5800
5801 2009-09-25  David Kilzer  <ddkilzer@apple.com>
5802
5803         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
5804
5805         Reviewed by Eric Seidel.
5806
5807         * Scripts/mark-bug-fixed:
5808         (MarkBugFixed.__init__): Added -u|--update-only switch to list
5809         of parse options.
5810         (MarkBugFixed.main): When -u|--update-only is specified, add a
5811         comment to the bug without marking it Resolved/Fixed.
5812
5813 2009-09-25  Darin Adler  <darin@apple.com>
5814
5815         Reviewed by Geoffrey Garen.
5816
5817         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
5818         out, just as we do for the resources directory.
5819
5820 2009-09-25  Adam Barth  <abarth@webkit.org>
5821
5822         Unreviewed.  Added Tony to committers.py because he's a
5823         committer now.
5824
5825         * Scripts/modules/committers.py:
5826
5827 2009-09-25  Eric Seidel  <eric@webkit.org>
5828
5829         Reviewed by Simon Fraser.
5830
5831         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
5832         https://bugs.webkit.org/show_bug.cgi?id=28624
5833
5834         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
5835
5836         * DumpRenderTree/mac/DumpRenderTree.mm:
5837         (resetDefaultsToConsistentValues):
5838
5839 2009-09-25  Eric Seidel  <eric@webkit.org>
5840
5841         Reviewed by Adam Barth.
5842
5843         commit-queue should auto-retry patches which fail to commit due to out of date files
5844         https://bugs.webkit.org/show_bug.cgi?id=28316
5845
5846         * Scripts/bugzilla-tool:
5847          - Handle new CheckoutNeedsUpdate exception.
5848         * Scripts/modules/logging_unittest.py:
5849          - Call the ScriptError constructor correctly (this test had regressed).
5850         * Scripts/modules/scm.py:
5851          - Added the ability to define custom error handlers for run_command
5852            and added a commit_error_handler which throws CheckoutNeedsUpdate
5853            instead of ScriptError.
5854          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
5855         * Scripts/modules/scm_unittest.py:
5856          - Added tests of new error handlers.
5857
5858 2009-09-25  Eric Seidel  <eric@webkit.org>
5859
5860         Reviewed by Adam Barth.
5861
5862         commit-queue should give better feedback when failing a patch
5863         https://bugs.webkit.org/show_bug.cgi?id=29316
5864
5865         * Scripts/bugzilla-tool:
5866          - Update ScriptError uses to the new constructor format.
5867          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
5868            so that we can print to both stdout as well as an output buffer for error reporting.
5869          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
5870          - Use e.message_with_output() when failing a patch (this is the real fix here).
5871            I also removed use of "This patch will require manual commit." as that's not always true.
5872          - Add missing word "bug" from log message.
5873         * Scripts/modules/scm.py:
5874          - Make ScriptError save a bunch more data so that error messages can be nicer.
5875          - Update ScriptError callers.
5876
5877 2009-09-24  John Gregg  <johnnyg@google.com>
5878
5879         Reviewed by Eric Seidel.
5880
5881         Enable switch for notifications (experimental) in Page Settings
5882         https://bugs.webkit.org/show_bug.cgi?id=28930
5883
5884         Now that desktop notifications are controlled by run-time switch,
5885         set that switch to true for DumpRenderTree.
5886
5887         * DumpRenderTree/mac/DumpRenderTree.mm:
5888         (resetDefaultsToConsistentValues):
5889         * DumpRenderTree/win/DumpRenderTree.cpp:
5890         (resetDefaultsToConsistentValues):
5891         * DumpRenderTree/win/UIDelegate.cpp:
5892         (UIDelegate::QueryInterface):
5893
5894 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
5895
5896         wx build fix. SnowLeopard fixes for Mac dependencies.
5897
5898         * wx/build/build_utils.py:
5899         * wx/build/settings.py:
5900         * wx/install-unix-extras:
5901
5902 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
5903
5904         Reviewed by Oliver Hunt.
5905
5906         Add support for DRT to send mouse wheel events.
5907
5908         https://bugs.webkit.org/show_bug.cgi?id=29348
5909         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
5910
5911         * DumpRenderTree/gtk/EventSender.cpp:
5912         (mouseWheelToCallback):
5913
5914 2009-09-17  Eric Seidel  <eric@webkit.org>
5915
5916         Reviewed by David Levin.
5917
5918         commit-queue needs web-based status reporting
5919         https://bugs.webkit.org/show_bug.cgi?id=29307
5920
5921         Add a first-pass web-based status for the commit-queue.
5922         The bot is currently reachable at:
5923         http://webkit-commit-queue.appspot.com/
5924
5925         * CommitQueueStatus/app.yaml: Added.
5926          - Application description file required by App Engine.
5927         * CommitQueueStatus/filters/__init__.py: Added.
5928          - Required by python to treat 'filters' as a module.
5929         * CommitQueueStatus/filters/webkit_extras.py: Added.
5930          - Support for turning 'bug 123' and 'patch 123' into links.
5931            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
5932         * CommitQueueStatus/index.html: Added.
5933         * CommitQueueStatus/index.yaml: Added.
5934          - Some auto-generated file from app engine.
5935         * CommitQueueStatus/queue_status.py: Added.
5936          - The core logic of this bot.  We could eventually split this file out into pieces.
5937         * CommitQueueStatus/stylesheets/main.css: Added.
5938          - Some basic lame-o CSS to make the page look less awful.
5939         * CommitQueueStatus/update_status.html: Added.
5940          - The form that the commit-queue (or a human) can use to update the status.
5941         * Scripts/bugzilla-tool:
5942          - Add some very basic update_status calls.
5943         * Scripts/modules/statusbot.py: Added.
5944          - Knows how to post to the CommitQueueStatus web application.
5945
5946 2009-09-24  David Kilzer  <ddkilzer@apple.com>
5947
5948         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
5949
5950         Reviewed by Adam Roben.
5951
5952         * Scripts/mark-bug-fixed:
5953         (MarkBugFixed.__init__): Added -m|--comment switch to list of
5954         parse options.
5955         (MarkBugFixed.main): When specified, prepend comment from
5956         -m|--comment command-line switch to the bug comment.
5957
5958 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
5959
5960         Reviewed by Jan Alonzo.
5961
5962         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
5963         https://bugs.webkit.org/show_bug.cgi?id=29693
5964
5965         Show the window, to be able to synthesize events correctly.
5966
5967         * DumpRenderTree/gtk/DumpRenderTree.cpp:
5968         (runTest):
5969         (main):
5970
5971 2009-09-24  Oliver Hunt  <oliver@apple.com>
5972
5973         Reviewed by NOBODY(rollout)
5974
5975         Roll out r48712 as it is incorrect.
5976
5977         * DumpRenderTree/mac/ObjCController.m:
5978         (+[ObjCController isSelectorExcludedFromWebScript:]):
5979         (+[ObjCController webScriptNameForSelector:]):
5980
5981 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
5982
5983         Reviewed by Eric Seidel.
5984
5985         https://bugs.webkit.org/show_bug.cgi?id=29005
5986         The indices of RuntimeArray should be enumerated like for a regular array.
5987
5988         * DumpRenderTree/mac/ObjCController.m:
5989         (+[ObjCController isSelectorExcludedFromWebScript:]):
5990         (+[ObjCController webScriptNameForSelector:]):
5991         (-[ObjCController arrayOfString]):
5992
5993 2009-09-23  David Kilzer  <ddkilzer@apple.com>
5994
5995         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
5996
5997         Reviewed by Darin Adler.
5998
5999         Also fixed a bug where specifying a revision on the command-line
6000         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
6001
6002         * Scripts/bugzilla-tool: Updated module import statements.
6003         (parse_bug_id): Removed.  Moved to bugzilla.py.
6004         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
6005         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
6006         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
6007         (BugzillaTool.__init__): Removed mark-fixed subcommand.
6008         * Scripts/mark-bug-fixed: Added.
6009         * Scripts/modules/bugzilla.py:
6010         (parse_bug_id): Added.  Moved from bugzilla-tool.
6011         * Scripts/modules/comments.py: Added.
6012         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
6013         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
6014
6015 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
6016
6017         Reviewed by Eric Seidel.
6018
6019          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
6020          "false" in non-implemented stub for setAlwaysAcceptCookies.
6021          https://bugs.webkit.org/show_bug.cgi?id=29661
6022
6023         * DumpRenderTree/win/DumpRenderTree.vcproj:
6024         * DumpRenderTree/win/DumpRenderTree.cpp:
6025
6026 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
6027
6028         Reviewed by Xan Lopez.
6029
6030         [GTK] need to dump number of pending unload handlers
6031         https://bugs.webkit.org/show_bug.cgi?id=29685
6032
6033         Implement dumping of the number of pending unload handlers.
6034
6035         The following tests will pass:
6036
6037           fast/loader/unload-form-about-blank.html
6038           fast/loader/unload-form-post-about-blank.html
6039           fast/loader/unload-form-post.html
6040           fast/loader/unload-form.html
6041           fast/loader/unload-hyperlink.html
6042           fast/loader/unload-javascript-url.html
6043           fast/loader/unload-reload.html
6044           fast/loader/unload-window-location.html
6045
6046         * DumpRenderTree/gtk/DumpRenderTree.cpp:
6047         (getFrameNameSuitableForTestResult):
6048         (webViewLoadFinished):
6049
6050 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
6051
6052         Reviewed by Eric Seidel.
6053
6054         js tests should move into jstests subdirectory instead of resources/
6055         https://bugs.webkit.org/show_bug.cgi?id=25880
6056
6057         Remove support of resources directory.
6058
6059         * Scripts/make-script-test-wrappers:
6060
6061 2009-09-22  Eric Seidel  <eric@webkit.org>
6062
6063         No review, only fixing typo (missing space character).
6064
6065         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
6066
6067         * Scripts/run-webkit-tests:
6068
6069 2009-09-22  Eric Seidel  <eric@webkit.org>
6070
6071         Reviewed by Darin Adler.
6072
6073         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
6074         https://bugs.webkit.org/show_bug.cgi?id=29220
6075
6076         * Scripts/run-webkit-tests:
6077
6078 2009-09-22  Eric Seidel  <eric@webkit.org>
6079
6080         Reviewed by David Kilzer.
6081
6082         svn-apply can't handle single-line binary file additions
6083         https://bugs.webkit.org/show_bug.cgi?id=29100
6084
6085         Fixed the regexp and added a unit test.
6086
6087         * Scripts/modules/scm_unittest.py:
6088         * Scripts/svn-apply:
6089
6090 2009-09-11  Eric Seidel  <eric@webkit.org>
6091
6092         Reviewed by David Kilzer.
6093
6094         post-diff and post-commits should be able to find bug urls in ChangeLogs.
6095         https://bugs.webkit.org/show_bug.cgi?id=29206
6096
6097         * Scripts/bugzilla-tool:
6098          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
6099          - Rename --no-comment to --add-log-as-comment and reverse behavior.
6100            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
6101          - Split out code into helper functions to try and make execute() more legible.
6102          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
6103          - Fallback to bug urls in commit diffs, instead of just in commit messages,
6104            meaning post-commits will now find bug urls in ChangeLogs.
6105
6106 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
6107
6108         Reviewed by Maciej Stachowiak.
6109
6110         --parse-only parameter wasn't passed to SunSpider/sunspider script.
6111         https://bugs.webkit.org/show_bug.cgi?id=29611
6112
6113         * Scripts/run-sunspider: Missing parameter passing added.
6114
6115 2009-09-20  David Kilzer  <ddkilzer@apple.com>
6116
6117         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
6118
6119         Reviewed by Mark Rowe.
6120
6121         The require statement is like the use statement, except that it
6122         is run during script execution instead of during the 'BEGIN'
6123         phase.  This makes it possible to change @INC before the require
6124         statement is run.  See 'require' and 'use' in the perlfunc(1)
6125         manpage and 'BEGIN' in perlmod(1) manpage.
6126
6127         * Scripts/run-webkit-tests: Replace eval statement with require
6128         statement.
6129
6130 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
6131
6132         wx build fixes. Fix the config name under git and allow users to specify
6133         their own waf install for experimenting with new versions.
6134
6135         * Scripts/webkitdirs.pm:
6136         * wx/build/settings.py:
6137
6138 2009-09-18  Alex Milowski  <alex@milowski.com>
6139
6140         Reviewed by Maciej Stachowiak.
6141
6142         Added checkWebCoreMathMLSupport and hasMathMLSupport to support
6143         checking for whether MathML tests should be run
6144
6145         * Scripts/run-webkit-tests:
6146         * Scripts/webkitdirs.pm:
6147
6148 2009-08-28  Darin Adler  <darin@apple.com>
6149
6150         Reviewed by Mark Rowe.
6151
6152         Break more of run-webkit-tests into separate functions
6153         https://bugs.webkit.org/show_bug.cgi?id=29497
6154
6155         Some small steps toward improving run-webkit-tests. My goal is to
6156         refactor much more of the script into functions. Later we can add
6157         parallel test running to the tool. But better structure may help
6158         even if someone decides to translate this into another scripting
6159         language instead.
6160
6161         * Scripts/run-webkit-tests: Break more pieces of the script into
6162         seprate functions. Added readSkippedFiles, findTestsToRun, and
6163         printResults functions. Removed custom code to skip results.html
6164         and instead just put it into the ignoredFiles hash. Fixed some
6165         indentation. Sorted function declarations, global variables,
6166         and options at the top of the file alphabetically so they're not
6167         in a semi-random order.
6168
6169 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
6170
6171         wx build fix, add missing dependency.
6172
6173         * wx/browser/wscript:
6174
6175 2009-09-16  Mark Rowe  <mrowe@apple.com>
6176
6177         Split the SnowLeopard build across a few machines.
6178
6179         * BuildSlaveSupport/build.webkit.org-config/config.json:
6180
6181 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
6182
6183         wx build fix to support monolithic builds on Windows.
6184
6185         * wx/build/wxpresets.py:
6186
6187 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
6188
6189         wx build fix, improve debug support and 2.9 support on MSW.
6190
6191         * wx/build/settings.py:
6192         * wx/build/wxpresets.py:
6193
6194 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
6195
6196         Blind try at fixing new test failure on Windows.
6197
6198         * DumpRenderTree/win/FrameLoadDelegate.cpp:
6199         (FrameLoadDelegate::didReceiveTitle):
6200
6201 2009-09-15  Alex Milowski  <alex@milowski.com>
6202
6203         Reviewed by Tor Arne Vestbø.
6204
6205         Added mathml toggle
6206
6207         * Scripts/build-webkit:
6208
6209 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
6210
6211         wx build fix. Allow waf build to support Python < 2.6.
6212
6213         * wx/build/waf_extensions.py:
6214
6215 2009-09-14  Chris Marrin  <cmarrin@apple.com>
6216
6217         Reviewed by Oliver Hunt.
6218
6219         Add LayoutTests infrastructure to enable and disable webgl tests.
6220         https://bugs.webkit.org/show_bug.cgi?id=29254
6221
6222         * Scripts/run-webkit-tests:
6223         * Scripts/webkitdirs.pm:
6224
6225 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
6226
6227         Reviewed by Darin Adler.
6228
6229         Add --iterations option to run-webkit-tests to repeat the tests N times
6230         https://bugs.webkit.org/show_bug.cgi?id=29263
6231
6232         When run with --iterations N, run-webkit-tests will repeat the tests N times.
6233
6234         * Scripts/run-webkit-tests:
6235
6236 2009-09-14  Brady Eidson  <beidson@apple.com>
6237
6238         Not reviewed, maybe should've been:
6239
6240         Cleaning up more Windows-specific fallout from the fix for:
6241         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
6242
6243         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
6244         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter,
6245           and call the correct method to get the Sender.
6246
6247 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
6248
6249         GTK build fix.
6250
6251         Unreviewed.
6252
6253         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
6254         (AccessibilityController::setLogScrollingStartEvents):
6255
6256 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
6257
6258         DRT/test part of
6259         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
6260         jumping to a named anchor
6261
6262         https://bugs.webkit.org/show_bug.cgi?id=28899
6263
6264         Reviewed by Adam Roben.
6265
6266         * DumpRenderTree/AccessibilityController.cpp:
6267         (logScrollingStartEventsCallback):
6268         Turn on logging of scrolling start events.
6269         (AccessibilityController::getJSClass):
6270         Add a "logScrollingStartEvents" to the AccessibilityController's JS
6271         class definition.
6272         (AccessibilityController::resetToConsistentState):
6273         Turn off logging of scrolling start events.
6274
6275         * DumpRenderTree/AccessibilityController.h:
6276         Declare setLogScrollingStartEvents(). Add a member for the scrolling
6277         start event hook.
6278
6279         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
6280         (AccessibilityController::setLogScrollingStartEvents):
6281         Stubbed.
6282
6283         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
6284         (AccessibilityController::AccessibilityController):
6285         Initialize the handle to 0.
6286         (logEventProc):
6287         Renamed from logFocusEventProc; now logs scrolling start events, too.
6288         Removed the assertion that the event is a focus event. Added a switch
6289         to print a message for focus, scrolling start, and other, unknown
6290         events.
6291         (AccessibilityController::setLogFocusEvents):
6292         Changed to use logEventProc.
6293         (AccessibilityController::setLogScrollingStartEvents):
6294         If turning logging off, unhook the scrolling start event hook, and clear
6295         the member holding the handle. If turning on, query for the root
6296         accessible, so that accessibility is enabled for the WebView, and call
6297         SetWinEventHook to setup an event hook using logEventProc as the
6298         callback function.
6299
6300 2009-09-14  Brady Eidson  <beidson@apple.com>
6301
6302         Windows build fix.
6303
6304         * DumpRenderTree/LayoutTestController.cpp:
6305         (setAuthenticationPasswordCallback):
6306         (setAuthenticationUsernameCallback):
6307
6308         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
6309         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
6310
6311 2009-09-14  Brady Eidson  <beidson@apple.com>
6312
6313         Reviewed by Alexey Proskuryakov.
6314
6315         Safari 4 cannot be used to update firmware on Linksys routers.
6316         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
6317
6318         Add the ability for DRT to handle authentication challenges.
6319
6320         * DumpRenderTree/LayoutTestController.cpp:
6321         (setAuthenticationPasswordCallback):
6322         (setAuthenticationUsernameCallback):
6323         (setHandlesAuthenticationChallengesCallback):
6324         (LayoutTestController::staticFunctions):
6325
6326         * DumpRenderTree/LayoutTestController.h:
6327         (LayoutTestController::handlesAuthenticationChallenges):
6328         (LayoutTestController::setHandlesAuthenticationChallenges):
6329         (LayoutTestController::authenticationUsername):
6330         (LayoutTestController::setAuthenticationUsername):
6331         (LayoutTestController::authenticationPassword):
6332         (LayoutTestController::setAuthenticationPassword):
6333
6334         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
6335         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
6336
6337         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
6338         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
6339         * DumpRenderTree/win/ResourceLoadDelegate.h:
6340
6341 2009-09-12  Mark Rowe  <mrowe@apple.com>
6342
6343         Reviewed by Dan Bernstein.
6344
6345         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
6346
6347         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
6348         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
6349
6350         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
6351         (NPP_New):
6352
6353 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
6354
6355         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
6356
6357         * wx/build/build_utils.py:
6358         * wx/build/settings.py:
6359
6360 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
6361
6362         Reviewed by Tor Arne Vestbø.
6363
6364         [Qt] Build fix for windows build.
6365
6366         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
6367
6368 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
6369
6370         Fix typo accidently landed in last commit.
6371
6372         * wx/build/settings.py:
6373
6374 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
6375
6376         wx build fix, error out if using the wrong Python.
6377
6378         * wx/build/settings.py:
6379
6380 2009-09-13  Xan Lopez  <xlopez@igalia.com>
6381
6382         Build fix for GTK+ < 2.14.
6383
6384         Do not use gtk_widget_get_window, access the window directly
6385         through the struct.
6386
6387         * DumpRenderTree/gtk/EventSender.cpp:
6388         (contextClickCallback):
6389         (mouseDownCallback):
6390         (mouseUpCallback):
6391         (mouseMoveToCallback):
6392         (keyDownCallback):
6393
6394 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
6395
6396         Reviewed by Xan Lopez and Jan Alonzo.
6397
6398         [GTK] EventSender does not set 'window' property on synthesized GDK events
6399         https://bugs.webkit.org/show_bug.cgi?id=29169
6400
6401         Set the window property on synthesized GDK events in the GTK+ EventSender.
6402
6403         * DumpRenderTree/gtk/EventSender.cpp:
6404         (contextClickCallback):
6405         (mouseDownCallback):
6406         (mouseUpCallback):
6407         (mouseMoveToCallback):
6408         (keyDownCallback):
6409
6410 2009-09-12  Drew Wilson  <atwilson@google.com>
6411
6412         Reviewed by Mark Rowe.
6413
6414         run-webkit-tests has a timeout value that is too low
6415         https://bugs.webkit.org/show_bug.cgi?id=29223
6416
6417         * Scripts/run-webkit-tests:
6418         Changed timeout value to 20 seconds to avoid timing out too early.
6419
6420 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
6421
6422         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
6423         architectures are supported for building wxWebKit.
6424
6425         * wx/build/settings.py:
6426
6427 2009-09-11  Eric Seidel  <eric@webkit.org>
6428
6429         Reviewed by David Levin.
6430
6431         bugzilla-tool rollout threw exception under svn
6432         https://bugs.webkit.org/show_bug.cgi?id=29211
6433
6434         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
6435         * Scripts/modules/scm_unittest.py: add testing for this fix.
6436
6437 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
6438
6439         Add myself to the committers list.
6440
6441         * Scripts/modules/committers.py:
6442
6443 2009-09-11  Eric Seidel  <eric@webkit.org>
6444
6445         Reviewed by Adam Barth.
6446
6447         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
6448         https://bugs.webkit.org/show_bug.cgi?id=29201
6449
6450         * Scripts/bugzilla-tool:
6451
6452 2009-09-11  Adam Roben  <aroben@apple.com>
6453
6454         Make commit-log-editor move common prefixes to the top of the log
6455
6456         Fies <http://webkit.org/b/29190> commit-log-editor should move common
6457         prefixes to the top of the commit log
6458
6459         Reviewed by Darin Adler.
6460
6461         * Scripts/commit-log-editor: Find and remove the longest common prefix
6462         ending in a double newline from each ChangeLog entry, then put that
6463         common prefix at the top of the commit log.
6464         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
6465         removes, and returns the longest common prefix ending in a double
6466         newline from a hash of strings
6467
6468 2009-09-11  Eric Seidel  <eric@webkit.org>
6469
6470         Fix obvious typo in previous commit, no review.
6471
6472         bugzilla-tool should automate rollouts
6473         https://bugs.webkit.org/show_bug.cgi?id=26715
6474
6475         * Scripts/bugzilla-tool: add back missing "scm" argument.
6476
6477 2009-09-11  Eric Seidel  <eric@webkit.org>
6478
6479         Reviewed by Adam Barth.
6480
6481         bugzilla-tool should automate rollouts
6482         https://bugs.webkit.org/show_bug.cgi?id=26715
6483
6484         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
6485         The --complete-rollout option will automatically land and update the bug.
6486         Eventually --complete-rollout will be default, but that will require more testing.
6487
6488         This first pass is good enough for others to try and file bugs about.
6489
6490         * Scripts/bugzilla-tool:
6491          - Move modified_changelogs into scm.py.
6492          - Move svn_revision_from_commit_text logic into scm.py.
6493          - Add RolloutCommit command.
6494         * Scripts/modules/bugzilla.py:
6495          - Add reopen_bug command used by RolloutCommit.
6496         * Scripts/modules/scm.py:
6497          - Add functions to support RolloutCommit.
6498          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
6499          - Add a str() call so that svn_commit_log can take a numeric argument.
6500          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
6501          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
6502         * Scripts/modules/scm_unittest.py:
6503          - Add read_from_path for easy file reading.
6504          - Put test4 on a new line to make reverts work w/o conflict.
6505          - Add an "svn update" call so that the checkout revision matches the server revision.
6506          - Add tests for svn_revision_from_commit_text.
6507          - Add a simple test for apply_reverse_diff.
6508          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
6509          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
6510
6511 2009-09-11  Adam Roben  <aroben@apple.com>
6512
6513         Get user script/stylesheet tests running on Windows
6514
6515         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
6516         skipped on Windows
6517
6518         Reviewed by John Sullivan.
6519
6520         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
6521         against comsuppw.lib so we can use _bstr_t.
6522
6523         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
6524         order, added #include of comutil.h for _bstr_t.
6525
6526         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
6527         (LayoutTestController::addUserScript):
6528         (LayoutTestController::addUserStyleSheet):
6529         Implemented. Implementations were based on those in
6530         LayoutTestControllerMac.mm.
6531
6532 2009-09-10  David Kilzer  <ddkilzer@apple.com>
6533
6534         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help
6535
6536         Reviewed by Mark Rowe.
6537
6538         * Scripts/run-webkit-tests: Updated to make -h switch show help.
6539
6540 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
6541
6542         Reviewed by Alexey Proskuryakov.
6543
6544         Add WebCore/websockets directory in wx build system.
6545         https://bugs.webkit.org/show_bug.cgi?id=28038
6546
6547         * wx/build/settings.py:
6548
6549 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
6550
6551         [GTK] EventSender does not properly convert some keyDown strings
6552         https://bugs.webkit.org/show_bug.cgi?id=29119
6553
6554         Add more keyDown string to character code conversions for GTK+ EventSender.
6555
6556         * DumpRenderTree/gtk/EventSender.cpp:
6557         (keyDownCallback):
6558
6559 2009-09-09  Steve Block  <steveblock@google.com>
6560
6561         Reviewed by Maciej Stachowiak.
6562
6563         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
6564         https://bugs.webkit.org/show_bug.cgi?id=29080
6565
6566         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
6567
6568 2009-09-09  Eric Seidel  <eric@webkit.org>
6569
6570         Reviewed by Eric Carlson.
6571
6572         reviewer/committer lookups are backwards
6573         https://bugs.webkit.org/show_bug.cgi?id=29113
6574
6575         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
6576
6577         * Scripts/modules/bugzilla.py:
6578         * Scripts/modules/committers.py:
6579
6580 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
6581
6582         Reviewed by Eric Seidel.
6583
6584         svn-unapply doesn't revert directories correctly
6585         https://bugs.webkit.org/show_bug.cgi?id=29065
6586
6587         * Scripts/svn-unapply: Make svnStatus consistently return status
6588         lines including a newline.
6589         * Scripts/svn-apply: Keep svnStatus in sync with the one in
6590         svn-unapply, in lieu of moving it to a common file.
6591
6592 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
6593
6594         Reviewed by Eric Seidel.
6595
6596         svn-apply doesn't handle changes to files copied to new directories properly
6597         https://bugs.webkit.org/show_bug.cgi?id=29059
6598
6599         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
6600         additions if we know that we've just copied a file to this name.
6601
6602 2009-09-09  Eric Seidel  <eric@webkit.org>
6603
6604         Reviewed by David Levin.
6605
6606         commit-queue hangs if a builder has never built
6607         https://bugs.webkit.org/show_bug.cgi?id=29091
6608
6609         * Scripts/modules/buildbot.py:
6610         * Scripts/modules/buildbot_unittest.py:
6611
6612 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
6613
6614         Reviewed by Gustavo Noronha.
6615
6616         [GTK] DumpRenderTree needs eventSender object and implementation
6617         https://bugs.webkit.org/show_bug.cgi?id=25990
6618
6619         Implements most of the EventSender object's functionality for
6620         the DumpRenderTree tool. Implementation still lacks support
6621         for drag and drop tests and forward leaps.
6622
6623         Based on work by Holger Hans Peter Freyther.
6624
6625         * DumpRenderTree/gtk/DumpRenderTree.cpp:
6626         (runTest): Focus on the view before loading a new test.
6627         (webViewWindowObjectCleared):
6628         * DumpRenderTree/gtk/EventSender.cpp: Added.
6629         (getDragModeCallback):
6630         (setDragModeCallback):
6631         (leapForwardCallback):
6632         (contextClickCallback):
6633         (updateClickCount):
6634         (mouseDownCallback):
6635         (mouseUpCallback):
6636         (mouseMoveToCallback):
6637         (beginDragWithFilesCallback):
6638         (replaySavedEvents):
6639         (keyDownCallback):
6640         (textZoomInCallback):
6641         (textZoomOutCallback):
6642         (zoomPageInCallback):
6643         (zoomPageOutCallback):
6644         (getClass):
6645         (makeEventSender):
6646         * DumpRenderTree/gtk/EventSender.h: Added.
6647         * GNUmakefile.am: Add build rules for EventSender.
6648
6649 2009-09-09  Daniel Bates  <dbates@webkit.org>
6650
6651         Reviewed by Adam Roben.
6652
6653         https://bugs.webkit.org/show_bug.cgi?id=28953
6654
6655         Added pre- and post- build events so that on build failure, the file
6656         buildfailed is written to the directory $(WebKitOutputDir).
6657
6658         * WinLauncher/WinLauncher.vcproj:
6659
6660 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
6661
6662         Unreviewed.
6663
6664         Add myself to list of committers.
6665
6666         * Scripts/modules/committers.py:
6667
6668 2009-09-08  Eric Seidel  <eric@webkit.org>
6669
6670         Reviewed by David Levin.
6671
6672         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
6673         https://bugs.webkit.org/show_bug.cgi?id=28605
6674         https://bugs.webkit.org/show_bug.cgi?id=28916
6675
6676         * Scripts/bugzilla-tool:
6677          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
6678            comment now that it's used for rejecting patches for invalid committers too.
6679          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
6680          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
6681         * Scripts/modules/bugzilla.py:
6682          - Make _parse_attachment_element not validate reviewer/committer.
6683          - Share flag parsing code in _parse_attachment_flag.
6684          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
6685          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
6686          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
6687         * Scripts/modules/bugzilla_unittest.py:
6688          - Update this test to no longer expect committer/reviewer validation.
6689         * Scripts/modules/committers.py:
6690          - Return None on failed lookups instead of raising Exceptions.
6691         * Scripts/modules/committers_unittest.py:
6692          - Update tests to expect None returns instead of exceptions.
6693
6694 2009-09-09  David Kilzer  <ddkilzer@apple.com>
6695
6696         <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
6697
6698         Reviewed by Mark Rowe.
6699
6700         No change to layout test results.
6701
6702         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
6703         (AccessibilityUIElement::clickPointY): Changed to return y value
6704         instead of x value.
6705
6706 2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>
6707
6708         Reviewed by Mark Rowe.
6709
6710         Reduce dglazkov's boboiness by properly concatenating revision value.
6711
6712         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
6713             rather than "+".
6714
6715 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
6716
6717         wxWebKit Python extension build fix - get swig.py if it doesn't exist.
6718
6719         * wx/build/build_utils.py:
6720
6721 2009-09-08  Mark Rowe  <mrowe@apple.com>
6722
6723         Fix an incorrect variable name in UpdateChromiumSource.
6724
6725         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
6726
6727 2009-09-08  Mark Rowe  <mrowe@apple.com>
6728
6729         Don't check for leaks on the release SnowLeopard builder.
6730
6731         * BuildSlaveSupport/build.webkit.org-config/config.json:
6732
6733 2009-09-08  Mark Rowe  <mrowe@apple.com>
6734
6735         Add a SnowLeopard release builder.
6736
6737         * BuildSlaveSupport/build.webkit.org-config/config.json:
6738
6739 2009-09-08  David Levin  <levin@chromium.org>
6740
6741         Reviewed by Darin Adler.
6742
6743         Remove end of line whitespace check from check-webkit-style.
6744         https://bugs.webkit.org/show_bug.cgi?id=29053
6745
6746         * Scripts/modules/cpp_style.py:
6747
6748 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
6749
6750         Reviewed by Darin Adler.
6751
6752         Fix DumpRenderTree build from clean tree on Tiger
6753         https://bugs.webkit.org/show_bug.cgi?id=28927
6754
6755         * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
6756         DerivedSources/DumpRenderTree directory exists when
6757         building on Tiger.
6758
6759 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
6760
6761         wx build fix after introduction of platform/mock directory.
6762
6763         * wx/build/settings.py:
6764
6765 2009-09-08  Yael Aharon  <yael.aharon@nokia.com>
6766
6767         Unreviewed.
6768
6769         Add myself to list of committers.
6770
6771         * Scripts/modules/committers.py:
6772
6773 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
6774
6775         Unreviewed.
6776
6777         Add myself to list of committers.
6778
6779         * Scripts/modules/committers.py:
6780
6781 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
6782
6783         Reviewed by Darin Adler.
6784
6785         prepare-ChangeLog too chatty on file additions
6786         https://bugs.webkit.org/show_bug.cgi?id=29019
6787
6788         * Scripts/prepare-ChangeLog: Omit description of added properties
6789         on newly added files.
6790
6791 2009-09-08  Steve Block  <steveblock@google.com>
6792
6793         Reviewed by Adam Barth.
6794
6795         Adds a LayoutTestController method to set the permission state for Geolocation.
6796         This is required to use the mock Geolocation service for testing.
6797         https://bugs.webkit.org/show_bug.cgi?id=29027
6798
6799         * DumpRenderTree/LayoutTestController.cpp: Modified.
6800         (setDatabaseQuotaCallback): Modified. Style fix.
6801         (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
6802         (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
6803         * DumpRenderTree/LayoutTestController.h: Modified.
6804         (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
6805         (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
6806         (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
6807         * DumpRenderTree/mac/UIDelegate.mm: Modified.
6808         (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
6809
6810 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
6811
6812         Reviewed by Simon Hausmann.
6813
6814         [Qt] QtWebKit single API to enable persistency
6815         https://bugs.webkit.org/show_bug.cgi?id=28682
6816
6817         Use the new enablePersistentStorage API instead
6818         of enabling all persistent features one-by-one.
6819
6820         * DumpRenderTree/qt/DumpRenderTree.cpp:
6821         (WebCore::WebPage::WebPage):
6822         (WebCore::DumpRenderTree::DumpRenderTree):
6823
6824 2009-09-07  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
6825
6826         Reviewed by Tor Arne Vestbø.
6827
6828         Refactor --strict switch to --ignore-metrics and correct the
6829         implementation to make the feature usable on all platforms.
6830         https://bugs.webkit.org/show_bug.cgi?id=28907
6831
6832         run-webkit-tests --ignore-metrics strips the font related metrics from
6833         the actual and expected data before comparing them.
6834         In this way the render trees can be checked for obvious differences but
6835         a successful test implies by no means that the layout is actually correct.
6836
6837         * Scripts/run-webkit-tests:
6838
6839 2009-09-07  Steve Block  <steveblock@google.com>
6840
6841         Reviewed by Adam Barth.
6842
6843         Adds a mock Geolocation service. This will be used to provide predictable behavior of the
6844         Geolocation API for use in LayoutTests. Later changes will integrate the the mock
6845         Geolocation service with DumpRenderTree.
6846         https://bugs.webkit.org/show_bug.cgi?id=28264
6847
6848         * DumpRenderTree/LayoutTestController.cpp: Modified.
6849         (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
6850         (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
6851         (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
6852         * DumpRenderTree/LayoutTestController.h: Modified.
6853         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
6854         (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
6855         (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
6856
6857 2009-09-07  Drew Wilson  <atwilson@google.com>
6858
6859         Reviewed by David Levin.
6860
6861         Enable SHARED_WORKERS by default
6862         https://bugs.webkit.org/show_bug.cgi?id=28959
6863
6864         * Scripts/build-webkit:
6865
6866 2009-09-07  Kevin Ollivier  <kevino@theolliviers.com>
6867
6868         wx build fixes for wx SVN trunk.
6869
6870         * wx/build/settings.py:
6871
6872 2009-09-04  Kevin Ollivier  <kevino@theolliviers.com>
6873
6874         wx build fix. Switch USE_ defines over to the compiler so that they can be
6875         checked by files not including config.h (like WebCorePrefix.h).
6876
6877         * wx/build/settings.py:
6878
6879 2009-09-04  Adam Barth  <abarth@webkit.org>
6880
6881         Unreviewed build fix.
6882
6883         Update declaration of FrameLoadDelegate to reflect that
6884         IWebFrameLoadDelegatePrivate2 inherits from
6885         IWebFrameLoadDelegatePrivate.
6886
6887         * DumpRenderTree/win/FrameLoadDelegate.h:
6888
6889 2009-09-04  Adam Barth  <abarth@webkit.org>
6890
6891         Reviewed by Eric Seidel.
6892
6893         https://bugs.webkit.org/show_bug.cgi?id=24696
6894
6895         Add testing instrumentation for mixed content.
6896
6897         * DumpRenderTree/mac/FrameLoadDelegate.mm:
6898         (-[FrameLoadDelegate webView:]):
6899         (-[FrameLoadDelegate webView:didRunInsecureContent:]):
6900         * DumpRenderTree/win/FrameLoadDelegate.cpp:
6901         (descriptionSuitableForTestResult):
6902         (FrameLoadDelegate::QueryInterface):
6903         (FrameLoadDelegate::didDisplayInsecureContent):
6904         (FrameLoadDelegate::didRunInsecureContent):
6905         * DumpRenderTree/win/FrameLoadDelegate.h:
6906
6907 2009-09-03  Kevin Watters  <kevinwatters@gmail.com>
6908
6909         Reviewed by Kevin Ollivier.
6910
6911         [wx] Frames support
6912         https://bugs.webkit.org/show_bug.cgi?id=19041
6913
6914         * wx/build-wxwebkit:
6915
6916 2009-09-02  David Kilzer  <ddkilzer@apple.com>
6917
6918         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
6919
6920         Reviewed by Eric Seidel.
6921
6922         This fixes "svn-apply --force" and adds unit tests for the
6923         scm.apply_patch() method which uses this script.
6924
6925         * Scripts/svn-apply: Created $globalExitCode variable that
6926         defaults to 0.  Exit with a value of $globalExitCode when the
6927         script is finished.
6928         (applyPatch): Ignore a non-zero $exitCode if $force is true, but
6929         set $globalExitCode to $exitCode so that svn-apply exits with a
6930         non-zero status if any patches did not apply cleanly.  Also
6931         print out the actual patch command if $force was not true.
6932
6933         * Scripts/modules/scm.py:
6934         (scripts_directory): Added.  Extracted from script_path().
6935         (script_path): Extracted scripts_directory().
6936         * Scripts/modules/scm_unittest.py: Import urllib.
6937         (SVNTestRepository.setup): Save the original working directory
6938         in test_object since this represents the WebKit repository from
6939         where the unit tests are run.
6940         (SCMTest): Created new super class to hold utility methods.
6941         (SCMTest._create_patch): Creates a patch file on disk and a
6942         dictionary for use with scm.svn_apply().
6943         (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink
6944         back to WebKitTools/Scripts in the test repository so that
6945         scm.apply_patch() is able to find the svn-apply script.
6946         (SVNTest): Inherit from SCMTest instead of unittest.TestCase.
6947         (SVNTest.tearDown): Make sure to change directories back to the
6948         original_path before the next test.
6949         (SVNTest.test_apply_svn_patch): New test case for applying an
6950         svn patch with scm.apply_patch().
6951         (SVNTest.test_apply_svn_patch_force): New test case for applying
6952         an svn patch with scm.apply_patch() that conflicts.
6953         (GitTest): Inherit from SCMTest instead of unittest.TestCase.
6954         (GitTest.tearDown): Make sure to change directories back to the
6955         original_path before the next test.
6956         (GitTest.test_apply_git_patch): New test case for applying a git
6957         patch with scm.apply_patch().
6958         (GitTest.test_apply_git_patch_force): New test case for applying
6959         a git patch with scm.apply_patch() that conflicts.
6960
6961 2009-09-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
6962
6963         Reviewed by Mark Rowe.
6964
6965         [Qt] Add support for platform-spesific layout-test results
6966
6967         For the Qt port we use the qt-[mac|linux|win] directories and then fall
6968         back to the generic qt directory for both test results and skipped list.
6969
6970         * Scripts/run-webkit-tests:
6971         * Scripts/webkitdirs.pm:
6972
6973 2009-09-02  Laurent Cerveau  <lcerveau@me.com>
6974
6975         Reviewed by David Kilzer.
6976
6977         <http://webkit.org/b/25517> build-webkit script should print build time at end
6978
6979         * Scripts/build-webkit:
6980         Added startTime and endTime variable so that the build time is computed and printed as
6981         part of the build message; display formatting has been separated in a dedicated subroutine.
6982
6983 2009-09-02  David Kilzer  <ddkilzer@apple.com>
6984
6985         <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root
6986
6987         Reviewed by Eric Seidel.
6988
6989         * Scripts/VCSUtils.pm:
6990         (determineSvnRoot): Added back check for repository root that
6991         was removed in r46134 when this code lived in svn-create-patch.
6992         It's necessary to check both the repository root and the
6993         repository UUID in case two different working directories are
6994         checked out from the same repository.
6995
6996 2009-09-02  Timothy Hatcher  <timothy@apple.com>
6997
6998         Use new 512x512 icons for nightly builds.
6999
7000         Rubber-stamped by Mark Rowe.
7001
7002         * WebKitLauncher/webkit.icns:
7003
7004 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
7005
7006         waf build fix. Remove local variable shadowing global.
7007
7008         * wx/build/settings.py:
7009
7010 2009-09-02  Zan Dobersek  <zandobersek@gmail.com>
7011
7012         Reviewed by David Kilzer.
7013
7014         Calls exitStatus function from the main package where it is also defined.
7015
7016         * Scripts/VCSUtils.pm:
7017
7018 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
7019
7020         waf build fixes for Windows/MSVC and Mac/Snow Leopard.
7021
7022         * wx/browser/wscript:
7023         * wx/build/build_utils.py:
7024         * wx/build/settings.py:
7025
7026 2009-08-10  Kevin Ollivier  <kevino@theolliviers.com>
7027
7028         Reviewed by Eric Seidel.
7029
7030         Changes needed for build-webkit to support the waf build system for the wx port.
7031
7032         https://bugs.webkit.org/show_bug.cgi?id=27619
7033
7034         * Scripts/build-webkit:
7035         * Scripts/run-launcher:
7036         * Scripts/webkitdirs.pm:
7037
7038 2009-09-02  David Kilzer  <ddkilzer@apple.com>
7039
7040         <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts
7041
7042         Reviewed by Eric Seidel.
7043
7044         * Scripts/update-webkit: Added "--accept postpone" to
7045         @svnOptions when running with svn-1.6 or newer.
7046
7047 2009-09-02  David Kilzer  <ddkilzer@apple.com>
7048
7049         Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()
7050
7051         Reviewed by Eric Seidel.
7052
7053         * Scripts/VCSUtils.pm:
7054         (@EXPORT): Added &isSVNVersion16OrNewer.
7055         (svnVersion): Added.  Internal method that gets the SVN version
7056         and caches it.
7057         (isSVNVersion16OrNewer): Added.  Method that does the SVN 1.6
7058         version check.
7059         * Scripts/prepare-ChangeLog: Switched to use new
7060         isSVNVersion16OrNewer() method.
7061         * Scripts/resolve-ChangeLogs: Ditto.
7062         * Scripts/svn-create-patch: Ditto.
7063
7064 2009-09-02  David Kilzer  <ddkilzer@apple.com>
7065
7066         Clean up VCSUtils.pm
7067
7068         Reviewed by Eric Seidel.
7069
7070         * Scripts/VCSUtils.pm: Added proper package statement.  Fixed
7071         indentation of BEGIN block.  Listed each exported method on a
7072         line by itself.  Added methods to the export list after adding
7073         the package statement.  Sorted module variables.  Moved
7074         definiton of $gitRoot next to other module variables.
7075
7076 2009-09-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
7077
7078         Rubber-stamped by Simon Hausmann.
7079
7080         [Qt] Fix layout-test plugins/plugin-javascript-access.html
7081
7082         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
7083
7084 2009-09-02  Shinichiro Hamaji  <hamaji@chromium.org>
7085
7086         Reviewed by Eric Seidel.
7087
7088         js tests should move into jstests subdirectory instead of resources/
7089         https://bugs.webkit.org/show_bug.cgi?id=25880
7090
7091         make-script-wrappers supports both resources and script-tests directories.
7092         run-webkit-tests ignores files in script-tests.
7093         Move script tests of animations to check the new script is working.
7094
7095         * Scripts/make-script-test-wrappers:
7096         * Scripts/run-webkit-tests:
7097
7098 2009-09-02  Szabo Carol  <carol.szabo@nokia.com>
7099
7100         Reviewed by David Levin.
7101
7102         check-webkit-style uses python from /usr/bin instead of the PATH
7103         https://bugs.webkit.org/show_bug.cgi?id=28225
7104
7105         * Scripts/bugzilla-tool:
7106         * Scripts/check-webkit-style:
7107         * Scripts/run-webkit-unittests:
7108         * Scripts/update-sources-list.py:
7109           Changed the first line from
7110           #!/usr/bin/python
7111           to
7112           #!/usr/bin/env python
7113           which causes python to be invoked from the path location returned
7114           by "which python" when any of these scripts are launched.
7115           these are currently all the python scripts in WebKitTools/Scripts.
7116
7117 2009-09-01  David Kilzer  <ddkilzer@apple.com>
7118
7119         <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards
7120
7121         Reviewed by Adam Barth.
7122
7123         * Scripts/modules/scm.py:
7124         (Git.commit_ids_from_commitish_arguments): Reverse the list of
7125         commits returned from git-rev-list since we always want to post
7126         the oldest patches first to bugs.webkit.org.
7127         * Scripts/modules/scm_unittest.py:
7128         (run): Added return statement to return the output now that we
7129         want it sometimes.
7130         (SVNTestRepository._setup_test_commits): Added a fourth commit
7131         so the GitTest.test_commitish_order() test has more commits to
7132         work with.
7133         (GitTest.test_commitish_order): Added unit test for change to
7134         Git.commit_ids_from_commitish_arguments() in scm.py.
7135
7136 2009-09-01  David Kilzer  <ddkilzer@apple.com>
7137
7138         <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed
7139
7140         Reviewed by David Levin.
7141
7142         The mark-fixed subcommand is for those times when you don't use
7143         bugzilla-tool to commit a patch, but you want to use it to close
7144         the bug with a committed-revision message.
7145
7146         * Scripts/bugzilla-tool:
7147         (bug_comment_from_svn_revision): Added.  Extracted from
7148         bug_comment_from_commit_text().
7149         (bug_comment_from_commit_text): Extracted
7150         bug_comment_from_svn_revision() from this method.
7151         (MarkBugFixed.__init__): Added.
7152         (MarkBugFixed._fetch_commit_log): Added.  Retrieves the commit
7153         log from the last commit if no svn revision is specified, else
7154         the commit log for the specified svn revision.
7155         (MarkBugFixed._determine_bug_id_and_svn_revision): Added.
7156         Attempts to determine the bug id and svn revision if one or both
7157         were not defined on the command line.
7158         (MarkBugFixed.execute): Added.  Adds a comment about the
7159         revision that fixed the bug and closes the bug.
7160         (BugzillaTool.__init__): Added mark-fixed subcommand.
7161         * Scripts/modules/bugzilla.py:
7162         (Bugzilla.fetch_title_from_bug): Added.  Returns the title of a
7163         bug given a bug id.
7164         * Scripts/modules/scm.py:
7165         (SCM.strip_r_from_svn_revision): Added.  Utility method to strip
7166         the leading 'r' from an svn revision.
7167         (SCM.svn_commit_log): Added.  Subclasses must override.
7168         (SCM.last_svn_commit_log): Added.  Subclasses must override.
7169         (SVN.svn_commit_log): Added.  Returns svn log for a given
7170         revision.
7171         (SVN.last_svn_commit_log): Added.  Uses svnversion to find the
7172         last commit in an svn working directory and then runs svn log.
7173         (Git.svn_commit_log): Added.  Returns svn log for a given
7174         revision.
7175         (Git.last_svn_commit_log): Added.  Runs git-svn-log with a limit
7176         of one log message.
7177
7178 2009-09-01  David Kilzer  <ddkilzer@apple.com>
7179
7180         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
7181
7182         Reviewed by Brady Eidson.
7183
7184         * Scripts/svn-apply:
7185         (applyPatch): Add "--force" to $options arrayref if $force is
7186         set.
7187
7188 2009-09-01  David Kilzer  <ddkilzer@apple.com>
7189
7190         <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch
7191
7192         Reviewed by Adam Roben.
7193
7194         When git-filter-branch has been invoked to rewrite ChangeLog
7195         files on series of git commits, it changes directories into
7196         .git-rewrite/t before re-running resolve-ChangeLogs.  This
7197         causes determineVCSRoot() in VCSUtils.pm to return
7198         ".git-rewrite/t", which causes that path to be prepended to all
7199         ChangeLog paths, which results in an error like this:
7200
7201             error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git.
7202             Died at WebKitTools/Scripts/resolve-ChangeLogs line 376.
7203
7204         The correct way to fix this is not to try to find the repository
7205         root when invoked by git-filter-branch.
7206
7207         * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true,
7208         set $relativePath to '.' instead of calling
7209         chdirReturningRelativePath(determineVCSRoot()).
7210         (isInGitFilterBranch): Added.  Checks for the existence of the
7211         MAPPED_PREVIOUS_COMMIT environment variable.
7212
7213 2009-09-01  Xan Lopez  <xlopez@igalia.com>
7214
7215         Reviewed by Gustavo Noronha.
7216
7217         Add support for Fedora distros in the http tests
7218         https://bugs.webkit.org/show_bug.cgi?id=28263
7219
7220         Add detection code for Fedora distribution, and use the proper
7221         httpd conf file when needed.
7222
7223         * Scripts/run-webkit-httpd:
7224         * Scripts/run-webkit-tests:
7225         * Scripts/webkitdirs.pm:
7226
7227 2009-09-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
7228
7229         Reviewed by Eric Seidel.
7230
7231         [Gtk] DRT needs implementation of overridePreference
7232         https://bugs.webkit.org/show_bug.cgi?id=28830
7233
7234         Implement overridePreference.
7235
7236         * DumpRenderTree/gtk/DumpRenderTree.cpp:
7237         (resetDefaultsToConsistentValues):
7238         (setDefaultsToConsistentStateValuesForTesting):
7239         (runTest):
7240         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
7241         (toWebSettingKey):
7242         (LayoutTestController::overridePreference):
7243
7244 2009-09-01  Joseph Pecoraro  <joepeck@webkit.org>
7245
7246         <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying
7247
7248         Reviewed by Eric Seidel.
7249
7250         Jump back and forth between the repository root directory (to apply) and the
7251         directory the script was run from (to find the patch).
7252
7253         * Scripts/svn-apply:
7254         * Scripts/svn-unapply:
7255
7256 2009-08-31  Adam Roben  <aroben@apple.com>
7257
7258         Fall back to a Release version of Safari if a Debug one doesn't exist
7259
7260         <http://webkit.org/b/28849>
7261
7262         Reviewed by Sam Weinig.
7263
7264         * Scripts/webkitdirs.pm:
7265         (safariPath): If the user is working with a Debug build, but there's
7266         no Debug version of Safari present, fall back to using a Release
7267         version of Safari.
7268
7269 2009-08-31  Adam Roben  <aroben@apple.com>
7270
7271         Make safariPath() work for Debug builds of Safari on Windows
7272
7273         <http://webkit.org/b/28849>
7274
7275         Reviewed by Sam Weinig.
7276
7277         * Scripts/webkitdirs.pm:
7278         (safariPath): If the user is working with a Debug build, add the
7279         _debug suffix to Safari.exe.
7280
7281 2009-08-28  Eric Seidel  <eric@webkit.org>
7282
7283         Reviewed by Adam Barth.
7284
7285         commit-queue needs a master process
7286         https://bugs.webkit.org/show_bug.cgi?id=28040
7287
7288         Add a bugzilla-tool commit-queue command
7289         Keeps per-bug logs, but doesn't yet upload them anywhere.
7290
7291         * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
7292         * Scripts/modules/buildbot.py: remove noisy log message
7293         * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
7294
7295 2009-08-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
7296
7297         Reviewed by Gustavo Noronha.
7298
7299         [GTK] Geolocation needs permission API before being enabled by default
7300
7301         Build the Gtk port with geolocation enabled. This option is only
7302         enabled for the buildbot. The autotools option will be enabled by
7303         default once the permissions API is implemented.
7304
7305         * Scripts/build-webkit:
7306
7307 2009-08-26  Cameron McCormack  <cam@mcc.id.au>
7308
7309         Reviewed by David Kilzer.
7310
7311         Make prepare-ChangeLog notice property changes
7312         https://bugs.webkit.org/show_bug.cgi?id=28675
7313
7314         Make the generated ChangeLog entry include a short description of
7315         property changes if there were such changes.  Also make
7316         prepare-ChangeLog not bail if the only changes are property changes.
7317
7318         * Scripts/prepare-ChangeLog:
7319
7320 2009-08-26  Adam Barth  <abarth@webkit.org>
7321
7322         Reviewed by Oliver Hunt.
7323
7324         Don't let local files access web URLs
7325         https://bugs.webkit.org/show_bug.cgi?id=28480
7326
7327         A bunch of our LayoutTests rely on our old behavior, so we explicitly
7328         grant local files universal access during testing.  Mainly, these tests
7329         involve making XMLHttpRequests for data URLs.
7330
7331         * DumpRenderTree/mac/DumpRenderTree.mm:
7332         (resetDefaultsToConsistentValues):
7333         * DumpRenderTree/qt/DumpRenderTree.cpp:
7334         (WebCore::WebPage::WebPage):
7335         * DumpRenderTree/win/DumpRenderTree.cpp:
7336         (resetDefaultsToConsistentValues):
7337
7338 2009-08-26  John Gregg  <johnnyg@google.com>
7339
7340         Reviewed by David Levin.
7341
7342         Minor style correction and include fix for notifications
7343         https://bugs.webkit.org/show_bug.cgi?id=28745
7344
7345         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
7346           change to correct EnumStyle
7347         (DRTDesktopNotificationPresenter::checkNotificationPermission):
7348
7349 2009-08-26  David Levin  <levin@chromium.org>
7350
7351         Reviewed by Alexey Proskuryakov.
7352
7353         XMLHttpRequest.withCredentials=false shouldn't save cookies.
7354         https://bugs.webkit.org/show_bug.cgi?id=28743
7355
7356         Added the support to the layout test controller on OSX and
7357         Windows (for CFNETWORK) to allow for changing the accept cookie
7358         policy.
7359
7360         * DumpRenderTree/LayoutTestController.cpp:
7361         (LayoutTestController::LayoutTestController): Added a bool
7362         to track the state of accepting cookies.
7363         (setAlwaysAcceptCookiesCallback): Standard wrapper method
7364         to go from js to a C++ method.
7365         (LayoutTestController::staticFunctions): Added the
7366         setAlwaysAcceptCookies method to the js layoutTestController.
7367         * DumpRenderTree/LayoutTestController.h:
7368         (LayoutTestController::alwaysAcceptCookies): Returns the value.
7369         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
7370         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
7371         * DumpRenderTree/mac/DumpRenderTree.mm:
7372         (resetDefaultsToConsistentValues): Reset the accept cookie to
7373         its default.
7374         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
7375         (LayoutTestController::setAlwaysAcceptCookies): Does the work for
7376         OSX to change the cookie accept policy.
7377         * DumpRenderTree/win/DumpRenderTree.cpp:
7378         (setAlwaysAcceptCookies): Method to handle all the calls necessary
7379         to change the accept cookie policy on Windows.
7380         (resetDefaultsToConsistentValues): Reset the accept cookie to
7381         its default.
7382         * DumpRenderTree/win/DumpRenderTreeWin.h:
7383         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
7384         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
7385         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
7386         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
7387
7388 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
7389
7390         Unreviewed.
7391
7392         Remove accidentally left in clobber option.
7393         https://bugs.webkit.org/show_bug.cgi?id=28400
7394
7395         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
7396
7397 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
7398
7399         Reviewed by Mark Rowe.
7400
7401         Add canary-style Chromium WebKit build slave to the waterfall.
7402         https://bugs.webkit.org/show_bug.cgi?id=28400
7403
7404         * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
7405         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
7406
7407 2009-08-25  Cameron McCormack  <cam@mcc.id.au>
7408
7409         Reviewed by Darin Adler.
7410
7411         make-script-test-wrappers should be executable
7412         https://bugs.webkit.org/show_bug.cgi?id=28669
7413
7414         Make make-script-test-wrappers and update-sources-list.py both be
7415         executable.
7416
7417         * Scripts/update-sources-list.py:
7418         * Scripts/make-script-test-wrappers:
7419
7420 2009-08-25  Brent Fulgham  <bfulgham@webkit.org>
7421
7422         Build fix
7423
7424         Revise Debug_Cairo targets to point inherit from the
7425         debug_wincairo.vsprops property sheet so that they link
7426         against the proper libraries in Debug build.
7427
7428         * DumpRenderTree/win/DumpRenderTree.vcproj:
7429         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
7430         * WinLauncher/WinLauncher.vcproj:
7431
7432 2009-08-25  David Levin  <levin@chromium.org>
7433
7434         Reviewed by Adam Roben.
7435
7436         PLATFORM(CFNETWORK) should be USE(CFNETWORK).
7437         https://bugs.webkit.org/show_bug.cgi?id=28713
7438
7439         * DumpRenderTree/win/DumpRenderTree.cpp:
7440         (main):
7441
7442 2009-08-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
7443
7444         Reviewed by Ariya Hidayat.
7445
7446         [Qt/Mac] Use CONFIG+=build_all only when building libraries
7447
7448         If no configuration is specified when building WebKit we pass the
7449         debug_and_release option to QMake which results in Makefiles for
7450         both configurations being generated.
7451
7452         Previously we built both of these configurations by default, for
7453         all targets (both the QtWebKit framework/dyldlib and the various
7454         executables such as QtLauncher and tests). This makes sense for
7455         the libraries, which get the _debug suffix and can be loaded on
7456         demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
7457         ended up building the same executable twice.
7458
7459         We now only build one instance of each executable, and since this
7460         is a developer build we build the debug-version. Passing either
7461         --debug or --release to build-webkit will override this, and
7462         even in the default case the release version can still be built
7463         by running 'make release' in the the build directory of each
7464         target.
7465
7466         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
7467         * Scripts/webkitdirs.pm:
7468
7469 2009-08-24  Hironori Bono  <hbono@chromium.org>
7470
7471         Reviewed by Adam Barth.
7472
7473         Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
7474         <https://bugs.webkit.org/show_bug.cgi?id=27827>.
7475
7476         Because of the lack of mappings from GDK key-codes to WebKit key-codes,
7477         Chromium cannot send valid key-codes to JavaScript when a user types
7478         function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.
7479
7480         To write layout tests for this issue, added mappings from function-key
7481         names to platform-specific key-codes to EventSendingController objects
7482         so that eventSender.keyDown() can send function-key events without using
7483         platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
7484         is only for Mac. So this change adds this new test to Skipped tests for other
7485         platforms to prevent this change from crashing the build trees.)
7486
7487         * DumpRenderTree/mac/EventSendingController.mm:
7488         (-[EventSendingController keyDown:withModifiers:]):
7489
7490 2009-08-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
7491
7492         Reviewed by Xan Lopez.
7493
7494         [Gtk] API for disabling local file access to web URLs
7495         https://bugs.webkit.org/show_bug.cgi?id=28663
7496
7497         Enable this setting for DRT.
7498
7499         * DumpRenderTree/gtk/DumpRenderTree.cpp:
7500         (resetWebViewToConsistentStateBeforeTesting):
7501
7502 2009-08-22  Adam Barth  <abarth@webkit.org>
7503
7504         Revert 47684.  We're going to do this later once clients have had a
7505         chance to opt into the setting they like.
7506
7507         * DumpRenderTree/mac/DumpRenderTree.mm:
7508         (resetDefaultsToConsistentValues):
7509         * DumpRenderTree/qt/DumpRenderTree.cpp:
7510         (WebCore::WebPage::WebPage):
7511         * DumpRenderTree/win/DumpRenderTree.cpp:
7512         (resetDefaultsToConsistentValues):
7513
7514 2009-08-22  Adam Barth  <abarth@webkit.org>
7515
7516         Reviewed by Eric Seidel.
7517
7518         Don't let local files access web URLs
7519         https://bugs.webkit.org/show_bug.cgi?id=28480
7520
7521         A bunch of our LayoutTests rely on our old behavior, so we explicitly
7522         grant local files universal access during testing.  Mainly, these tests
7523         involve making XMLHttpRequests for data URLs.
7524
7525         * DumpRenderTree/mac/DumpRenderTree.mm:
7526         (resetDefaultsToConsistentValues):
7527         * DumpRenderTree/qt/DumpRenderTree.cpp:
7528         (WebCore::WebPage::WebPage):
7529         * DumpRenderTree/win/DumpRenderTree.cpp:
7530         (resetDefaultsToConsistentValues):
7531
7532 2009-08-22  Mark Rowe  <mrowe@apple.com>
7533
7534         Rubber-stamped by Anders Carlsson.
7535
7536         Bring signed updates to the Mac nightly builds.
7537
7538         * WebKitLauncher/Info.plist:
7539         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
7540         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
7541         (initializeSparkle):
7542         * WebKitLauncher/nightly.webkit.org.public.pem: Added.
7543
7544 2009-08-21  Jan Michael Alonzo  <jmalonzo@webkit.org>
7545
7546         Rubberstamped by Simon Fraser.
7547
7548         Remove GNOME keyring support in build-webkit. This dependency's
7549         already been removed in the Gtk port.
7550
7551         * Scripts/build-webkit:
7552
7553 2009-08-20  Brian Weinstein  <bweinstein@apple.com>
7554
7555         Reviewed by Adam Roben.
7556         Based on original patch by Stephanie Lewis.
7557
7558         Added support of the Windows malloc history format to parse-malloc history, so we can
7559         read and parse it.
7560
7561         * Scripts/parse-malloc-history:
7562
7563 2009-08-20  Chris Fleizach  <cfleizach@apple.com>
7564
7565         Reviewed by Darin Adler.
7566
7567         Enable various "grouping" ARIA roles
7568         https://bugs.webkit.org/show_bug.cgi?id=28486
7569
7570         Expose the ability to retrieve the subrole through accessibility for DRT.
7571
7572         * DumpRenderTree/AccessibilityUIElement.cpp:
7573         * DumpRenderTree/AccessibilityUIElement.h:
7574         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
7575         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
7576         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
7577
7578 2009-08-20  Joseph Pecoraro  <joepeck@webkit.org>
7579
7580         Unreviewed.
7581
7582         Added myself as a committer.
7583
7584         * Scripts/modules/committers.py:
7585
7586 2009-08-20  Xan Lopez  <xlopez@igalia.com>
7587
7588         Reviewed by Gustavo Noronha.
7589
7590         Fix memory leaks.
7591
7592         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
7593         (LayoutTestController::whiteListAccessFromOrigin):
7594         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
7595         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
7596
7597 2009-08-20  Eric Seidel  <eric@webkit.org>
7598
7599         Reviewed by Adam Barth.
7600
7601         bugzilla-tool post-diff can post partial diffs from SVN checkouts.
7602         https://bugs.webkit.org/show_bug.cgi?id=28445
7603
7604         Pass the checkout root as the cwd.  Also wrote a test to ensure this.
7605
7606         * Scripts/modules/scm.py:
7607         * Scripts/modules/scm_unittest.py:
7608
7609 2009-08-20  Mark Rowe  <mrowe@apple.com>
7610
7611         Reviewed by Adele Peterson.
7612
7613         Don't leak the JSStringRef returned by AccessibilityUIElement::attributeValue.
7614
7615         * DumpRenderTree/AccessibilityUIElement.cpp:
7616         (attributeValueCallback):
7617
7618 2009-08-20  Ariya Hidayat  <ariya.hidayat@nokia.com>
7619
7620         Unreviewed, build fix.
7621
7622         [Qt] The template-based qMax() compares two qreals.
7623
7624         * DumpRenderTree/qt/ImageDiff.cpp:
7625         (main):
7626
7627 2009-08-20  David Levin  <levin@chromium.org>
7628
7629         Reviewed by David Kilzer.
7630
7631         bugzilla-tool patch retrieval should handle 302 redirects.
7632         https://bugs.webkit.org/show_bug.cgi?id=28485
7633
7634         * Scripts/modules/scm.py: Pass the --location parameter to curl
7635         so that 302's are followed.
7636
7637 2009-08-20  Aaron Boodman  <aa@chromium.org>
7638
7639         One more speculative build for gtk.
7640
7641         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
7642
7643 2009-08-20  Aaron Boodman  <aa@chromium.org>
7644
7645         Speculative build for gtk.
7646
7647         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
7648         (LayoutTestController::whiteListAccessFromOrigin):
7649
7650 2009-08-20  Mark Rowe  <mrowe@apple.com>
7651
7652         Ignore some leaks that are known to originate from ImageIO.
7653
7654         * Scripts/run-webkit-tests:
7655
7656 2009-08-20  Aaron Boodman  <aa@chromium.org>
7657
7658         With David Levin.
7659
7660         Speculative build fix for qt.
7661
7662         * DumpRenderTree/qt/jsobjects.cpp:
7663         (LayoutTestController::whiteListAccessFromOrigin):
7664         * DumpRenderTree/qt/jsobjects.h:
7665
7666 2009-08-19  Mark Rowe  <mrowe@apple.com>
7667
7668         Reviewed by Dan Bernstein.
7669
7670         Fix <http://webkit.org/b/28484> Plug-in-related leaks seen on the build bot
7671
7672         Update check-for-global-initializers to accommodate the new uses of RefCountedLeakCounter in WebKit.
7673
7674         * Scripts/check-for-global-initializers:
7675
7676 2009-08-19  Aaron Boodman  <aa@chromium.org>
7677
7678         Reviewed by David Levin.
7679
7680         https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
7681         specify a more granular policy for cross-origin XHR access.
7682
7683         * DumpRenderTree/LayoutTestController.cpp: Expose whiteListAccessFromOrigin() to layout tests.
7684         (whiteListAccessFromOriginCallback): Ditto.
7685         (LayoutTestController::staticFunctions): Ditto.
7686         * DumpRenderTree/LayoutTestController.h: Ditto.
7687         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
7688         (LayoutTestController::whiteListAccessToOrigin): Ditto.
7689         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
7690         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
7691         * DumpRenderTree/qt/jsobjects.cpp: Ditto.
7692         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
7693         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Stub out whiteListAccessFromOrigin().
7694         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
7695         * DumpRenderTree/gtk/DumpRenderTree.cpp: Reset origin access lists before each test.
7696         (resetWebViewToConsistentStateBeforeTesting): Ditto.
7697         * DumpRenderTree/mac/DumpRenderTree.mm: Ditto.
7698         (resetWebViewToConsistentStateBeforeTesting): Ditto.
7699         * DumpRenderTree/qt/DumpRenderTree.cpp: Ditto.
7700         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Ditto.
7701
7702 2009-08-19  Mark Rowe  <mrowe@apple.com>
7703
7704         Rubber-stamped by Dan Bernstein.
7705
7706         Ignore some leaks that are known to originate from QTKit.
7707
7708         * Scripts/run-webkit-tests:
7709
7710 2009-08-19  Eric Seidel  <eric@webkit.org>
7711
7712         Reviewed by Adam Barth.
7713
7714         commit-queue/bugzilla-tool can get wedged if git is mid-rebase
7715         https://bugs.webkit.org/show_bug.cgi?id=28436
7716
7717         Make clean_working_directory cancel rebases too (even though that's a bit of a hack).
7718         This code will only ever be run when --force-clean is passed.
7719
7720         I also added a new unit test to make sure this code actually works. :)
7721
7722         * Scripts/modules/scm.py:
7723         * Scripts/modules/scm_unittest.py:
7724
7725 2009-08-19  Eric Seidel  <eric@webkit.org>
7726
7727         Reviewed by David Levin.
7728
7729         WebKit needs a changelogs.py to hold changelog-related code
7730         https://bugs.webkit.org/show_bug.cgi?id=28477
7731
7732         This is moving code and adding tests.  There was only one functional
7733         change (which was removing a trailing newline from the last_entry() result).
7734
7735         * Scripts/bugzilla-tool:
7736         * Scripts/modules/changelogs.py: Added.
7737         * Scripts/modules/changelogs_unittest.py: Added.
7738         * Scripts/run-webkit-unittests:
7739
7740 2009-08-20  Eric Seidel  <eric@webkit.org>
7741
7742         Reviewed by Adam Barth.
7743
7744         bugzilla-tool needs a way to ask build.webkit.org if the bots are passing
7745         https://bugs.webkit.org/show_bug.cgi?id=28222
7746
7747         Basic support for now.  This has been in testing for 24 hours now and worked great!
7748
7749         * Scripts/bugzilla-tool:
7750         * Scripts/modules/buildbot.py: Added.
7751         * Scripts/modules/buildbot_unittest.py: Added.
7752         * Scripts/run-webkit-unittests:
7753
7754 2009-08-19  Jan Michael Alonzo  <jmalonzo@webkit.org>
7755
7756         Reviewed by Gustavo Noronha.
7757
7758         [Gtk] Bump waitToDumpWatchdog interval to 15 seconds to match the
7759         default timeout used by run-webkit-tests. Mac and Win ports were
7760         recently bumped in http://trac.webkit.org/changeset/r47465.
7761
7762         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
7763         (LayoutTestController::setWaitToDump):
7764
7765 2009-08-19  David D. Kilzer  <ddkilzer@webkit.org>
7766
7767         DumpRenderTreeSupport.pm: provide pre-generated swig source for Tiger
7768
7769         Reviewed by Mark Rowe.
7770
7771         Provide pre-generated swig source files for Tiger so it may
7772         benefit from the faster run-webkit-tests.
7773
7774         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm:
7775         Generated by swig.
7776         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c: Added.
7777         Generated by swig.
7778         (swig_type_info::SWIG_TypeNameComp):
7779         (swig_type_info::SWIG_TypeEquiv):
7780         (swig_type_info::SWIG_TypeRegisterTL):
7781         (swig_type_info::SWIG_TypeCheck):
7782         (swig_type_info::SWIG_TypeCast):
7783         (swig_type_info::SWIG_TypeDynamicCast):
7784         (swig_type_info::SWIG_TypeName):
7785         (swig_type_info::SWIG_TypePrettyName):
7786         (swig_type_info::SWIG_TypeQueryTL):
7787         (swig_type_info::SWIG_TypeClientDataTL):
7788         (swig_type_info::SWIG_PackData):
7789         (swig_type_info::SWIG_UnpackData):
7790         (swig_type_info::SWIG_PropagateClientDataTL):
7791         (swig_type_info::SWIG_PackVoidPtr):
7792         (swig_type_info::SWIG_UnpackVoidPtr):
7793         (swig_type_info::SWIG_PackDataName):
7794         (swig_type_info::SWIG_UnpackDataName):
7795         * DumpRenderTree/mac/PerlSupport/Makefile: Updated to build on
7796         Tiger using pre-generated files.
7797
7798 2009-08-18  Shinichiro Hamaji  <hamaji@chromium.org>
7799
7800         Reviewed by David Kilzer.
7801
7802         run-webkit-tests hangs when WebCore tries to log too much
7803         https://bugs.webkit.org/show_bug.cgi?id=15743
7804
7805         Read stdout and stderr in parallel.
7806
7807         * Scripts/run-webkit-tests:
7808
7809 2009-08-18  Mark Rowe  <mrowe@apple.com>
7810
7811         Rubber-stamped by Oliver Hunt.
7812
7813         Add a new build configuration that checks for leaks during the layout tests,
7814         and hook a new machine up to it.
7815
7816         * BuildSlaveSupport/build.webkit.org-config/config.json:
7817         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
7818
7819 2009-08-18  Aaron Boodman  <aa@chromium.org>
7820
7821         Reviewed by Maciej Stachowiak.
7822
7823         https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests.
7824
7825         No new tests: Already covered by existing tests.
7826
7827         * Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest.
7828
7829 2009-08-18  Mark Rowe  <mrowe@apple.com>
7830
7831         Rubber-stamped by Geoff Garen.
7832
7833         Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests.
7834
7835         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
7836         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
7837
7838 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
7839
7840         Rubber-stamped by Adam Roben.
7841
7842         Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them,
7843         and removed include to fix building on VC++ Express.
7844
7845         * DumpRenderTree/win/UIDelegate.cpp:
7846         (UIDelegate::exceededDatabaseQuota):
7847
7848 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
7849
7850         Reviewed by Oliver Hunt.
7851
7852         Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
7853         LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
7854
7855         Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface.
7856         Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac.
7857
7858         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
7859         (LayoutTestController::setDatabaseQuota):
7860         * DumpRenderTree/win/UIDelegate.cpp:
7861         (UIDelegate::exceededDatabaseQuota):
7862
7863 2009-08-18  Peter Kasting  <pkasting@google.com>
7864
7865         Reviewed by Eric Seidel.
7866
7867         https://bugs.webkit.org/show_bug.cgi?id=28415
7868         Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
7869         have it.
7870
7871         * record-memory-win/record-memory-win.vcproj:
7872         * WinLauncher/WinLauncher.vcproj:
7873         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
7874         * DumpRenderTree/win/ImageDiff.vcproj:
7875         * FindSafari/FindSafari.vcproj:
7876
7877 2009-08-18  Drew Wilson  <atwilson@google.com>
7878
7879         Reviewed by Eric Seidel.
7880
7881         Need to extend DumpRenderTree to expose number of worker threads
7882         https://bugs.webkit.org/show_bug.cgi?id=28292
7883
7884         Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit.
7885
7886         * DumpRenderTree/LayoutTestController.cpp:
7887         (getWorkerThreadCountCallback):
7888         (LayoutTestController::staticValues):
7889         * DumpRenderTree/LayoutTestController.h:
7890         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
7891         (LayoutTestController::workerThreadCount):
7892         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
7893         (LayoutTestController::workerThreadCount):
7894         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
7895         (LayoutTestController::workerThreadCount):
7896         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
7897         (LayoutTestController::workerThreadCount):
7898
7899 2009-08-18  Xan Lopez  <xlopez@igalia.com>
7900
7901         Reviewed by Jan Alonzo.
7902
7903         Initialize x and y in the GtkAllocation structure to shut up
7904         valgrind.
7905
7906         * DumpRenderTree/gtk/DumpRenderTree.cpp:
7907         (runTest):
7908
7909 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
7910
7911         Reviewed by Darin Adler.
7912
7913         Some HTMLs are modified by make-script-test-wrappers
7914         https://bugs.webkit.org/show_bug.cgi?id=28213
7915
7916         Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
7917         the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
7918         re-generated wml/* and Geolocation/* .
7919
7920         * Scripts/make-script-test-wrappers:
7921
7922 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
7923
7924         Reviewed by Eric Seidel.
7925
7926         -webkit-box-orient:horizontal doesn't work on <button> tag
7927         https://bugs.webkit.org/show_bug.cgi?id=34445
7928
7929         Make a flexible button's anonymous child flexible and pass the
7930         parent's box-orient to the anonymous child.
7931
7932         Also, added a renderName for anonymous flexible boxes.
7933
7934         * Scripts/make-script-test-wrappers:
7935
7936 2009-08-17  Eric Seidel  <eric@webkit.org>
7937
7938         Reviewed by Darin Adler.
7939
7940         Can no longer --reset-results of a layout test directory
7941         https://bugs.webkit.org/show_bug.cgi?id=28336
7942
7943         --reset-results and --exit-after-n-failures are incompatible.
7944
7945         * Scripts/run-webkit-tests:
7946
7947 2009-08-17  David Kilzer  <ddkilzer@apple.com>
7948
7949         <http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git
7950
7951         Reviewed by Adam Roben.
7952
7953         New commit message:
7954             Committed r12345: <http://trac.webkit.org/changeset/12345>
7955
7956         * Scripts/bugzilla-tool:
7957         (bug_comment_from_commit_text): Print out a compact,
7958         standardized commit message for both git and svn.
7959
7960 2009-08-17  Peter Kasting  <pkasting@google.com>
7961
7962         Reviewed by Steve Falkenburg.
7963
7964         https://bugs.webkit.org/show_bug.cgi?id=27323
7965         Only add Cygwin to the path when it isn't already there.  This avoids
7966         causing problems for people who purposefully have non-Cygwin versions of
7967         executables like svn in front of the Cygwin ones in their paths.
7968
7969         * DumpRenderTree/win/DumpRenderTree.vcproj:
7970         * DumpRenderTree/win/ImageDiff.vcproj:
7971         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
7972
7973 2009-08-17  David Kilzer  <ddkilzer@apple.com>
7974
7975         <http://webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()
7976
7977         Reviewed by David Levin.
7978
7979         * Scripts/modules/cpp_style.py:
7980         (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'.
7981         (check_max_min_macros): Added.  Returns level 4 error when MAX()
7982         and MIN() macros are used in header files and C++ source files.
7983         (check_style): Added call to check_max_min_macros().
7984         * Scripts/modules/cpp_style_unittest.py: Added unit tests.
7985         (test_max_macro): Added.
7986         (test_min_macro): Added.
7987
7988 2009-08-13  Mike Fenton  <mike.fenton@torchmobile.com>
7989
7990         Reviewed by Eric Seidel.
7991
7992         Move adjustLineToPixelBoundaries overlapping function to GraphicsContext.cpp
7993         and remove from GraphicsContextCairo.cpp and GraphicsContextQt.cpp.
7994
7995         https://bugs.webkit.org/show_bug.cgi?id=28268
7996
7997         * platform/graphics/GraphicsContext.cpp:
7998         (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
7999         * platform/graphics/GraphicsContext.h:
8000         * platform/graphics/cairo/GraphicsContextCairo.cpp:
8001         * platform/graphics/qt/GraphicsContextQt.cpp:
8002
8003 2009-08-10  Mike Fenton  <mike.fenton@torchmobile.com>
8004
8005         Reviewed by Adam Treat.
8006
8007         Style fixes for DumpRenderTree/qt/jsobjects.cpp based on cpp_style.py and
8008         WebKit style guide.
8009
8010         https://bugs.webkit.org/show_bug.cgi?id=28161
8011
8012         * DumpRenderTree/qt/jsobjects.cpp:
8013         (findFrameNamed):
8014         (LoadItem::invoke):
8015         (LayoutTestController::provisionalLoad):
8016         (LayoutTestController::timerEvent):
8017         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
8018         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
8019         (LayoutTestController::numberOfActiveAnimations):
8020         (EventSender::keyDown):
8021         (EventSender::frameUnderMouse):
8022         (TextInputController::doCommand):
8023
8024 2009-08-16  David Kilzer  <ddkilzer@apple.com>
8025
8026         <http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements
8027
8028         Reviewed by David Levin.
8029
8030         In <http://webkit.org/b/28355#c1>, it was noted that new source
8031         files use 'using namespace std;' instead of individual
8032         'using std::foo;' statements.  This adds a level 4 check for
8033         such statements.
8034
8035         * Scripts/modules/cpp_style.py:
8036         (_ERROR_CATEGORIES): Added 'build/using_std'.
8037         (check_using_std): Added.
8038         (check_style): Added call to check_using_std().
8039         * Scripts/modules/cpp_style_unittest.py:
8040         (WebKitStyleTest.test_using_std): Added unit test.
8041
8042 2009-08-16  David Kilzer  <ddkilzer@apple.com>
8043
8044         Backed out r47343 which was mistakenly committed
8045
8046         * Scripts/bugzilla-tool:
8047         * Scripts/modules/scm.py:
8048
8049 2009-08-16  David Kilzer  <ddkilzer@apple.com>
8050
8051         <http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class
8052
8053         Reviewed by David Levin.
8054
8055         The ScriptError class doesn't exist in bugzilla.py, so any
8056         errors print error messages about ScriptError instead of the
8057         actual error:
8058
8059             NameError: global name 'ScriptError' is not defined
8060
8061         * Scripts/modules/bugzilla.py:
8062         (BugzillaError): Added class.  Modeled after ScriptError class
8063         in scm.py.
8064         (Bugzilla.authenticate): Changed to use BugzillaError instead of
8065         ScriptError.
8066         (Bugzilla._check_create_bug_response): Ditto.
8067
8068 2009-08-14  Adam Bergkvist  <adam.bergkvist@ericsson.com>
8069
8070         Reviewed by Sam Weinig.
8071
8072         Added EventSource to the build script (default on).
8073         https://bugs.webkit.org/show_bug.cgi?id=14997
8074
8075         * Scripts/build-webkit:
8076
8077 2009-08-15  Ryosuke Niwa  <rniwa@webkit.org>
8078
8079         Unreviewed.
8080
8081         Add myself to list of committers.
8082
8083         * Scripts/modules/committers.py:
8084
8085 2009-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
8086
8087         Fix layout test failures after r47312.
8088
8089         Reviewed by Cameron Zwarich.
8090
8091         * DumpRenderTree/AccessibilityController.h:
8092         Replaced logFocusEvents() with setLogFocusEvents(), which takes a
8093         boolean argument to turn logging of focus events on or off.
8094         Added a function to reset the AccessibilityController to a consistent
8095         state.
8096
8097         * DumpRenderTree/AccessibilityController.cpp:
8098         (logFocusEventsCallback):
8099         Call setLogFocusEvents() to enable logging.
8100         (AccessibilityController::resetToConsistentState):
8101         Call setLogFocusEvents() to disable logging.
8102
8103         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
8104         (AccessibilityController::setLogFocusEvents):
8105         Update stub.
8106
8107         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
8108         (AccessibilityController::setLogFocusEvents):
8109         Update stub.
8110
8111         * DumpRenderTree/mac/DumpRenderTree.mm:
8112         (resetWebViewToConsistentStateBeforeTesting):
8113         Call the FrameLoadDelegate's resetToConsistentState method.
8114
8115         * DumpRenderTree/mac/FrameLoadDelegate.h:
8116         Declare the resetToConsistentState method.
8117
8118         * DumpRenderTree/mac/FrameLoadDelegate.mm:
8119         (-[FrameLoadDelegate resetToConsistentState]):
8120         Call the AccessibilityController's resetToConsistentState() function.
8121
8122         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
8123         (AccessibilityController::~AccessibilityController):
8124         Turn off focus event logging when the controller is destroyed.
8125         (AccessibilityController::setLogFocusEvents):
8126         If the caller passes false, unhook the focus event, and clear
8127         m_focusEventHook.
8128
8129         * DumpRenderTree/win/DumpRenderTree.cpp:
8130         (resetWebViewToConsistentStateBeforeTesting):
8131         Call the FrameLoadDelegate's resetToConsistentState function.
8132
8133         * DumpRenderTree/win/FrameLoadDelegate.h:
8134         Declare the resetToConsistentState() function.
8135
8136         * DumpRenderTree/win/FrameLoadDelegate.cpp:
8137         (FrameLoadDelegate::resetToConsistentState):
8138         Call the AccessibilityController's resetToConsistentState() function.
8139
8140
8141 2009-08-14  Jon Honeycutt  <jhoneycutt@apple.com>
8142
8143         Add a mechanism for logging MSAA focus events.
8144
8145         Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
8146         nightly (20866)
8147
8148         https://bugs.webkit.org/show_bug.cgi?id=20866
8149
8150         Reviewed by Oliver Hunt.
8151
8152         * DumpRenderTree/AccessibilityController.cpp:
8153         (logFocusEventsCallback):
8154         Call the AccessibilityController's logFocusEvents() function.
8155         (AccessibilityController::getJSClass):
8156         Add a "logFocusEvents" function to the AccessibilityController's JS
8157         class definition.
8158
8159         * DumpRenderTree/AccessibilityController.h:
8160         On Windows, include windows.h, and add a member variable to hold the
8161         handle to the event hook for focus events. Add a declaration for a
8162         function that enables logging of focus events.
8163
8164         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
8165         (AccessibilityController::logFocusEvents):
8166         Stubbed.
8167
8168         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
8169         (AccessibilityController::logFocusEvents):
8170         Stubbed.
8171
8172         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
8173         (AccessibilityController::AccessibilityController):
8174         (AccessibilityController::~AccessibilityController):
8175         If we hooked the focus event, unhook it.
8176         (logFocusEventProc):
8177         When we receive a focus event, get the accessible object for the event,
8178         and log its name to stdout.
8179         (AccessibilityController::logFocusEvents):
8180         Setup the focus event hook to listen for events in the current process.
8181
8182 2009-08-14  Eric Seidel  <eric@webkit.org>
8183
8184         No review.  Fix 5-space indent to be 4-spaces.
8185
8186         * Scripts/bugzilla-tool:
8187
8188 2009-08-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
8189
8190         Reviewed by Simon Hausmann.
8191
8192         [Qt] Public API to configure the storage path for HTML5 localStorage
8193         https://bugs.webkit.org/show_bug.cgi?id=28036
8194
8195         Turn on LocalStorage support for Qt DumpRenderTree since
8196         LocalStorage is now disabled by defult for QtWebkit.
8197
8198         * DumpRenderTree/qt/DumpRenderTree.cpp:
8199         (WebCore::WebPage::WebPage):
8200
8201 2009-08-14  Xan Lopez  <xlopez@igalia.com>
8202
8203         Reviewed by Jan Alonzo.
8204
8205         Do not unref the main webview, it's owned by its parent
8206         container. Instead destroy the container, which should take care
8207         of everything (not terribly important since we exit right after
8208         that, but still).
8209
8210         * DumpRenderTree/gtk/DumpRenderTree.cpp:
8211         (main):
8212
8213 2009-08-13  Eric Seidel  <eric@webkit.org>
8214
8215         No review, correcting obvious python error seen in the commit queue.
8216
8217         args can be a string or an array.  Assuming args is always an array results in
8218         double-spaced text in error logs.
8219
8220         * Scripts/bugzilla-tool:
8221
8222 2009-08-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
8223
8224         Unreviewed build fix. Include stdio.h for using stdout, stderr,
8225         and fprintf.
8226
8227         * DumpRenderTree/LayoutTestController.cpp:
8228
8229 2009-08-13  Shinichiro Hamaji  <hamaji@chromium.org>
8230
8231         Reviewed by Eric Seidel.
8232
8233         rename make-js-test-wrappers to make-script-test-wrappers
8234         https://bugs.webkit.org/show_bug.cgi?id=28212
8235
8236         * Scripts/make-script-test-wrappers: Renamed from WebKitTools/Scripts/make-js-test-wrappers.
8237
8238 2009-08-13  Drew Wilson <atwilson@chromium.org>
8239
8240         Unreviewed.
8241
8242         Add myself to list of committers.
8243
8244         * Scripts/modules/committers.py:
8245
8246 2009-08-13  John Sullivan  <sullivan@apple.com>
8247
8248         Unreviewed.
8249
8250         Add myself to list of committers.
8251
8252         * Scripts/modules/committers.py:
8253
8254 2009-08-13  Eric Seidel  <eric@webkit.org>
8255
8256         Correct spelling error in file name.  No review.
8257
8258         * Scripts/modules/committers_unittest.py: Renamed from WebKitTools/Scripts/modules/commiters_unittest.py.
8259         * Scripts/run-webkit-unittests:
8260
8261 2009-08-13  Eric Seidel  <eric@webkit.org>
8262
8263         Reviewed by Simon Fraser.
8264
8265         REGRESSION(r47175): error running run-webkit-tests
8266         https://bugs.webkit.org/show_bug.cgi?id=28261
8267
8268         Fix "Use of uninitialized value in concatenation (.) or string at
8269         WebKitTools/Scripts/run-webkit-tests line 191." by setting
8270         $testsPerDumpTool to 1000 by default.
8271
8272         * Scripts/run-webkit-tests:
8273
8274 2009-08-13  Nate Chapin  <japhet@chromium.org>
8275
8276         Unreviewed.
8277
8278         Add myself to list of committers.
8279
8280         * Scripts/modules/committers.py:
8281
8282 2009-08-13  Brent Fulgham  <bfulgham@webkit.org>
8283
8284         Unreviewed.
8285
8286         Add 'Brent Fulgham' to the committers list.
8287
8288         * Scripts/modules/committers.py:
8289
8290 2009-08-13  Adam Langley  <agl@chromium.org>
8291
8292         Review not required.
8293
8294         * Scripts/modules/committers.py:
8295           Adding myself to this list because Eric told me to.
8296
8297 2009-08-13  Greg Bolsinga  <bolsinga@apple.com>
8298
8299         Unreviewed.
8300
8301         Add 'Greg Bolsinga' to the committers list.
8302
8303         * Scripts/modules/committers.py:
8304
8305 2009-08-13  Adam Roben  <aroben@apple.com>
8306
8307         Fix off-by-one result comparisons in media tests on Windows Debug
8308         builds
8309
8310         media/video-played.html seems always to time out in Windows Debug
8311         builds. A race condition between media/video-test.js's "hang" timer and
8312         DumpRenderTree's built-in "watchdog" timer was causing results for
8313         media/video-played.html to be printed twice, causing all future media
8314         tests to be compared to the previous test's results.
8315
8316         The fix is to make the watchdog timer got through the same code path
8317         as calling notifyDone manually, so that the results will only get
8318         printed once. A subsequent patch will remove video-test.js's hang
8319         timer entirely, since it is redundant.
8320
8321         Fixes <http://webkit.org/b/28265>.
8322
8323         Reviewed by Mark Rowe.
8324
8325         * DumpRenderTree/LayoutTestController.cpp:
8326         (LayoutTestController::waitToDumpWatchdogTimerFired): Added. Code came
8327         from Gtk/Mac/Win's watchdog timer handlers, but we now call
8328         notifyDone() instead of dump() so that a subsequent call to
8329         notifyDone() won't print the results out again.
8330
8331         * DumpRenderTree/LayoutTestController.h: Added
8332         waitToDumpWatchdogTimerFired.
8333
8334         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
8335         (waitToDumpWatchdogFired):
8336         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
8337         (waitUntilDoneWatchdogFired):
8338         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
8339         (waitUntilDoneWatchdogFired):
8340         Changed to call waitToDumpWatchdogTimerFired.
8341
8342 2009-08-13  Eric Carlson  <eric.carlson@apple.com>
8343
8344         Unreviewed.
8345
8346         Added 'Eric Carlson' to the committers list.
8347
8348         * Scripts/modules/committers.py:
8349
8350 2009-08-13  Dirk Schulze  <krit@webkit.org>
8351
8352         Unreviewed.
8353         Added 'Dirk Schulze' to the committers list.
8354
8355         * Scripts/modules/committers.py:
8356
8357 2009-08-13  Adam Roben  <aroben@apple.com>
8358
8359         Enable running testapi in run-javascriptcore-tests on Windows
8360
8361         Fixes <http://webkit.org/b/24856> run-javascriptcore-tests should run
8362         testapi on Windows
8363
8364         Reviewed by Mark Rowe.
8365
8366         * Scripts/run-javascriptcore-tests: Allow testapi to run if we're in
8367         the AppleWinWebKit configuration.
8368
8369 2009-08-13  Adam Roben  <aroben@apple.com>
8370
8371         Re-enable testapi in run-javascriptcore-tests on Mac
8372
8373         This seems to have been mistakenly disabled in r47089.
8374
8375         Rubber-stamped by Mark Rowe.
8376
8377         * Scripts/run-javascriptcore-tests: Removed comment markers that were
8378         preventing running testapi.
8379
8380 2009-08-12  George Staikos  <george.staikos@torchmobile.com>
8381
8382         Reviewed by Adam Treat.
8383
8384         Enable WCSS and XHTML-MP flags for build-webkit.
8385
8386         * Scripts/build-webkit:
8387
8388 2009-08-12  David Kilzer  <ddkilzer@apple.com>
8389
8390         run-webkit-tests: document --nthly flag in help message
8391
8392         Reviewed by Simon Fraser.
8393
8394         * Scripts/run-webkit-tests: Added --nthly flag to $usage string.
8395         Also noted that -1|--singly implies --nthly 1.
8396
8397 2009-08-12  Eric Seidel  <eric@webkit.org>
8398
8399         No review, just fixing mismerged ChangeLogs.
8400
8401 2009-08-12  Eric Seidel  <eric@webkit.org>
8402
8403         Reviewed by Mark Rowe.
8404
8405         run-webkit-tests needs a --exit-after-failures=N option
8406         https://bugs.webkit.org/show_bug.cgi?id=28192
8407
8408         Added the option and deployed it to bugzilla-tool.
8409
8410         * Scripts/bugzilla-tool:
8411         * Scripts/run-webkit-tests:
8412
8413 2009-08-11  Eric Seidel  <eric@webkit.org>
8414
8415         Reviewed by Mark Rowe.
8416
8417         bugzilla-tool : various improvements for running the commit-queue
8418         https://bugs.webkit.org/show_bug.cgi?id=28199
8419
8420         Make run_and_throw_if_fail silence STDERR as well as STDIN.
8421         I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the output (per abarth's suggestion).
8422         Change a few "print" statements to "log" so they appear in the output.
8423         Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non-string objects).
8424         Added a little more logging so that --quiet mode is easier to understand.
8425         Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
8426         Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
8427         Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
8428         Made curl call (downloading patch files) quieter.
8429
8430         * Scripts/bugzilla-tool:
8431         * Scripts/modules/bugzilla.py:
8432         * Scripts/modules/scm.py:
8433
8434 2009-08-12  Peter Kasting  <pkasting@google.com>
8435
8436         Reviewed by Darin Adler.
8437
8438         https://bugs.webkit.org/show_bug.cgi?id=27323
8439         Change pattern that strips all trailing whitespace to just remove EOL
8440         chars (\r, \n), to make it clear that varying EOL chars is the primary
8441         problem being solved.
8442
8443         * Scripts/prepare-ChangeLog:
8444         * Scripts/resolve-ChangeLogs:
8445         * Scripts/svn-create-patch:
8446         * Scripts/update-webkit:
8447
8448 2009-08-12  Kevin Ollivier  <kevino@theolliviers.com>
8449
8450         wx waf build fix, add new directories to the build.
8451
8452         * wx/build/settings.py:
8453
8454 2009-08-11  Adam Roben  <aroben@apple.com>
8455
8456         Update DumpRenderTree for IWebUIDelegatePrivate changes
8457
8458         Reviewed by Dave Hyatt.
8459
8460         * DumpRenderTree/win/UIDelegate.h: Updated to match
8461         IWebUIDelegatePrivate.
8462
8463 2009-08-12  Adam Roben  <aroben@apple.com>
8464
8465         Don't try to seek to the end of stdin on Cygwin
8466
8467         Doing so seems to always cause an exception (for unknown reasons).
8468
8469         Fixes <http://webkit.org/b/28159> create-bug throws an exception in
8470         Cygwin
8471
8472         Reviewed by Dave Kilzer.
8473
8474         * Scripts/bugzilla-tool:
8475         (CreateBug.prompt_for_bug_title_and_comments): Ignore IOErrors
8476         generated by calling sys.stdin.seek, since these seem to be generated
8477         for no good reason on Cygwin.
8478
8479 2009-08-12  Adam Roben  <aroben@apple.com>
8480
8481         Don't raise an exception when --cc is not passed to create-bug
8482
8483         Fixes <http://webkit.org/b/28158> create-bug throws an exception if
8484         --cc is not specified
8485
8486         Reviewed by Dave Kilzer.
8487
8488         * Scripts/modules/bugzilla.py:
8489         (Bugzilla.create_bug_with_patch): Only set the "cc" field if a CC
8490         string was specified. Otherwise we'll generate an exception about the
8491         "cc" variable not being a string.
8492
8493 2009-08-11  Eric Seidel  <eric@webkit.org>
8494
8495         Reviewed by Adam Barth.
8496
8497         bugzilla-tool : various improvements for running the commit-queue
8498         https://bugs.webkit.org/show_bug.cgi?id=28199
8499
8500         Make run_and_throw_if_fail silence STDERR as well as STDIN.
8501         I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the out
8502         Change a few "print" statements to "log" so they appear in the output.
8503         Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non
8504         Added a little more logging so that --quiet mode is easier to understand.
8505         Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
8506         Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
8507         Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
8508         Made curl call (downloading patch files) quieter.
8509
8510         * Scripts/bugzilla-tool:
8511         * Scripts/modules/bugzilla.py:
8512         * Scripts/modules/scm.py:
8513
8514 2009-08-11  Eric Seidel  <eric@webkit.org>
8515
8516         No review, script regression fix only.
8517
8518         run-webkit-tests --quiet hangs
8519         https://bugs.webkit.org/show_bug.cgi?id=28202
8520
8521         Do a huge dance to get open3 to pipe to /dev/null w/o blocking.
8522         This was what I came up with after discussions in #perl.
8523
8524         * Scripts/run-webkit-tests:
8525
8526 2009-08-11  John Gregg  <johnnyg@google.com>
8527
8528         Reviewed by Maciej Stachowiak.
8529
8530         Switch DumpRenderTree to contain a WebUIDelegate2, which extends
8531         WebUIDelegate, so that the notifications tests will still work.
8532         https://bugs.webkit.org/show_bug.cgi?id=28198
8533
8534         * DumpRenderTree/win/UIDelegate.h:
8535
8536 2009-08-11  Darin Adler  <darin@apple.com>
8537
8538         Try to fix GTK build.
8539
8540         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
8541         (AccessibilityUIElement::stringForRange): Added.
8542
8543 2009-08-10  Mike Fenton  <mike.fenton@torchmobile.com>
8544
8545         Reviewed by Adam Treat.
8546
8547         Add processing for string constants used by the tests to trigger
8548         common actions like up, down, left, right, etc. for the Qt
8549         implementation of DumpRenderTree.
8550
8551         Note this allows fast/forms/textarea-arrow-navigation.html to pass
8552         correctly.
8553
8554         https://bugs.webkit.org/show_bug.cgi?id=28161
8555
8556         * DumpRenderTree/qt/jsobjects.cpp:
8557         (EventSender::keyDown):
8558
8559 2009-08-11  Chris Fleizach  <cfleizach@apple.com>
8560
8561         Reviewed by Darin Adler.
8562
8563         Bug 28200 - ListMarker should be included as part of the text value to parse
8564         https://bugs.webkit.org/show_bug.cgi?id=28200
8565
8566         Add the ability to retrieve a string given a plain NSRange.
8567
8568         * DumpRenderTree/AccessibilityUIElement.cpp:
8569         (stringForRangeCallback):
8570         (AccessibilityUIElement::getJSClass):
8571         * DumpRenderTree/AccessibilityUIElement.h:
8572         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
8573         (AccessibilityUIElement::valueDescription):
8574         (AccessibilityUIElement::stringForRange):
8575         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
8576         (AccessibilityUIElement::stringForRange):
8577
8578 2009-08-11  Dmitry Titov  <dimich@chromium.org>
8579
8580         Reviewed by NOBODY (Speculative fix for the layout test failure).
8581
8582         Fix fast/dom/prototype-inheritance.html
8583         and fast/dom/prototype-inheritance-2.html
8584         broken on Windows by http://trac.webkit.org/changeset/47018
8585
8586         * DumpRenderTree/win/DumpRenderTree.cpp:
8587         (resetDefaultsToConsistentValues): enable app cache in Windows DRT.
8588
8589 2009-08-11  Eric Seidel  <eric@webkit.org>
8590
8591         Reviewed by Adam Barth.
8592
8593         bugzilla-tool: Re-factor shared landing logic into helper class to share more code
8594         https://bugs.webkit.org/show_bug.cgi?id=28193
8595
8596         Added new WebKitLandingScripts class to hold this shared logic.
8597         Also added a view_source_url function to move more webkit-specific urls out of bugzilla-tool core.
8598
8599         * Scripts/bugzilla-tool:
8600
8601 2009-08-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
8602
8603         Reviewed by Adam Treat.
8604
8605         Fix the current failures on the buildbot.
8606
8607         As Qt hooks up the maybeDump to loadFinished, we need to make
8608         sure that calling dump() will not call maybeDump on loadFinished.
8609
8610         As dump is called my emitting done() which calls dump() and then
8611         setting m_isLoading to false. So in the case m_isLoading is false,
8612         do not dump again.
8613
8614         The current code is confusing, and should be made more clear
8615         in another commit.
8616
8617         * DumpRenderTree/qt/jsobjects.cpp:
8618         (LayoutTestController::maybeDump):
8619         (LayoutTestController::notifyDone):
8620
8621 2009-08-11  John Gregg  <johnnyg@google.com>
8622
8623         Reviewed by Maciej Stachowiak.
8624
8625         Add support for desktop notifications API to DumpRenderTree,
8626         and support for ENABLE_NOTIFICATIONS flag to build-webkit.
8627
8628         * DumpRenderTree/LayoutTestController.cpp:
8629         (grantDesktopNotificationPermissionCallback):
8630         (LayoutTestController::staticFunctions):
8631         (LayoutTestController::grantDesktopNotificationPermission):
8632         (LayoutTestController::checkDesktopNotificationPermission):
8633         * DumpRenderTree/LayoutTestController.h:
8634         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: Added.
8635         (DRTDesktopNotificationPresenter::DRTDesktopNotificationPresenter):
8636         (DRTDesktopNotificationPresenter::QueryInterface):
8637         (DRTDesktopNotificationPresenter::AddRef):
8638         (DRTDesktopNotificationPresenter::Release):
8639         (DRTDesktopNotificationPresenter::showDesktopNotification):
8640         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
8641         (DRTDesktopNotificationPresenter::notificationDestroyed):
8642         (DRTDesktopNotificationPresenter::checkNotificationPermission):
8643         (DRTDesktopNotificationPresenter::requestNotificationPermission):
8644         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h: Added.
8645         * DumpRenderTree/win/DumpRenderTree.vcproj:
8646         * DumpRenderTree/win/UIDelegate.cpp:
8647         (UIDelegate::UIDelegate):
8648         (UIDelegate::desktopNotificationsDelegate):
8649         * DumpRenderTree/win/UIDelegate.h:
8650         * Scripts/build-webkit:
8651
8652 2009-08-11  Peter Kasting  <pkasting@google.com>
8653
8654         Reviewed by Darin Adler.
8655
8656         https://bugs.webkit.org/show_bug.cgi?id=27323
8657         Handle arbitrary line endings when manufacturing patches for additions
8658         with history.
8659
8660         * Scripts/svn-create-patch:
8661
8662 2009-08-11  Peter Kasting  <pkasting@google.com>
8663
8664         Reviewed by Darin Adler.
8665
8666         https://bugs.webkit.org/show_bug.cgi?id=28183
8667         Support VS2008 as well as VS2005 in a few scripts.
8668
8669         * Scripts/pdevenv: Check both $VS80COMNTOOLS and $VS90COMNTOOLS.
8670         * Scripts/webkitdirs.pm: Use $VSINSTALLDIR if available instead of hardcoding the VS2005 dir.
8671
8672 2009-08-11  Eric Seidel  <eric@webkit.org>
8673
8674         Reviewed by Adam Barth.
8675
8676         run-webkit-tests --quiet should not output build-dumprendertree output
8677         https://bugs.webkit.org/show_bug.cgi?id=28189
8678
8679         * Scripts/run-webkit-tests:
8680
8681 2009-08-11  Eric Seidel  <eric@webkit.org>
8682
8683         Reviewed by Darin Adler.
8684
8685         Exception in land-patches
8686         https://bugs.webkit.org/show_bug.cgi?id=27962
8687
8688         Use ("%s" % object) instead of ("" + object).
8689         Added unit tests for logging.py.
8690
8691         * Scripts/modules/logging.py:
8692         * Scripts/modules/logging_unittest.py: Added.
8693         * Scripts/run-webkit-unittests:
8694
8695 2009-08-11  Dmitry Titov  <dimich@chromium.org>
8696
8697         Reviewed by NOBODY (Windows layout tests fix).
8698
8699         Fix for layout tests failures. Need to initialize some preferences early
8700         because WebView on Windows uses them during create time.
8701
8702         * DumpRenderTree/win/DumpRenderTree.cpp:
8703         (main):
8704
8705 2009-08-11  Dmitry Titov  <dimich@chromium.org>
8706
8707         Reviewed by Adam Roben.
8708
8709         Originally implemented by Glenn Wilson  <gwilson@chromium.org>.
8710
8711         Added support for overriding default preferences per-test.
8712         See https://bugs.webkit.org/show_bug.cgi?id=20534
8713
8714         * DumpRenderTree/LayoutTestController.cpp:
8715         (overridePreferenceCallback): add wiring for layoutTestController.overridePreference.
8716         (LayoutTestController::staticFunctions): same.
8717         * DumpRenderTree/LayoutTestController.h: same.
8718         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
8719         (LayoutTestController::overridePreference): added empty overridePreference method.
8720         * DumpRenderTree/mac/DumpRenderTree.mm: implemented preference override.
8721         (resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
8722         (setDefaultsToConsistentValuesForTesting): new method, sets other details of testing environment, every time  DRT starts.
8723         (resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().
8724         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
8725         (LayoutTestController::overridePreference):
8726         * DumpRenderTree/win/DumpRenderTree.cpp:
8727         (resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
8728         (resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().
8729         (createWebViewAndOffscreenWindow): same.
8730         (main): same.
8731         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
8732         (LayoutTestController::overridePreference):
8733         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
8734         (LayoutTestController::overridePreference):
8735
8736 2009-08-11  Brian Weinstein  <bweinstein@apple.com>
8737
8738         Reviewed by Sam Weinig.
8739
8740         Added support for DRT to support arguments for eventSender.mouseDown and eventSender.mouseUp for Windows.
8741         https://bugs.webkit.org/show_bug.cgi?id=28166.
8742
8743         This is a step towards fixing fast/events/mouse-click-events.html on Windows.
8744
8745         * DumpRenderTree/win/EventSender.cpp:
8746         (mouseDownCallback):
8747         (mouseUpCallback):
8748         (replaySavedEvents):
8749
8750 2009-08-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
8751
8752         Reviewed by Simon Hausmann.
8753
8754         Build the TestNetscapePlugin on Qt/Mac
8755
8756         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
8757
8758 2009-08-11  Dmitry Titov  <dimich@chromium.org>
8759
8760         Reviewed by NOBODY (build fix).
8761
8762         Attempt to fix the Windows test bot. Reverted r47015 caused one of the Windows
8763         bots that runs Layout Tests to save "JS disabled" and "default font 24pt"
8764         preferences permanently. Since these preferences are not initialized explicitly in DRT,
8765         almost all Layout tests are failing. Attempt to fix by explicit
8766         initialization of these into defaults (enabled, 16pt) at the beginning of the DRT.
8767
8768         * DumpRenderTree/win/DumpRenderTree.cpp:
8769         (main):  see above.
8770
8771 2009-08-10  Steve Falkenburg  <sfalken@apple.com>
8772
8773         Windows nightly fix.
8774
8775         Reviewed by Ada Chan.
8776
8777         * FindSafari/FindSafari.cpp:
8778         (_tmain): Copy Safari.dll if it exists.
8779
8780 2009-08-10  David Levin  <levin@chromium.org>
8781
8782         Reviewed by David Kilzer.
8783
8784         check-webkit-style doesn't catch braces around single line statements when followed by else.
8785         https://bugs.webkit.org/show_bug.cgi?id=28164
8786
8787         * Scripts/modules/cpp_style.py: Added else to the regex that finds ending }'s when
8788           checking the no braces for "single lines" rule.
8789         * Scripts/modules/cpp_style_unittest.py: Added test case.
8790
8791 2009-08-10  David Kilzer  <ddkilzer@apple.com>
8792
8793         <http://webkit.org/b/28163> bugzilla-tool: scm module should not import bugzilla module
8794
8795         Reviewed by David Levin.
8796
8797         * Scripts/bugzilla-tool:
8798         (parse_bug_id): Added.  Moved from CommitMessage.parse_bug_id()
8799         in scm module.
8800         * Scripts/modules/scm.py: Removed import of bugzilla module.
8801         (CommitMessage.parse_bug_id): Deleted.
8802
8803 2009-08-10  Peter Kasting  <pkasting@google.com>
8804
8805         Reviewed by David Kilzer.
8806
8807         https://bugs.webkit.org/show_bug.cgi?id=18599
8808         Work around apparent bug in abs2rel() with symlinked directories.
8809
8810         * Scripts/resolve-ChangeLogs:
8811
8812 2009-08-10  Dan Bernstein  <mitz@apple.com>
8813
8814         Build fix
8815
8816         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
8817         (NPP_New):
8818
8819 2009-08-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
8820
8821         Reviewed by Simon Hausmann.
8822
8823         Fix a bunch of build warnings in TestNetscapePlugin
8824
8825         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
8826         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
8827
8828 2009-08-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
8829
8830         Reviewed by Adam Roben.
8831
8832         Allow TestNetscapePlugIn to fall back to the Carbon event model
8833
8834         Previously the plugin would fail, even though the Carbon event
8835         model was available. The only way to get the Carbon event model
8836         was to pass the "forcecarbon" argument in the test markup, but no
8837         tests were using this.
8838
8839         Now the plugin uses carbon either if it's forced, or if the Cocoa
8840         event model is not supported.
8841
8842         This helps us run most of the plugin tests on Qt/Mac, which still
8843         does not support the Cocoa event model.
8844
8845         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
8846         (NPP_New):
8847
8848 2009-08-08  Adam Barth  <abarth@webkit.org>
8849
8850         Reviewed by Eric Seidel.
8851
8852         bugzilla-tool needs a --quiet option
8853         https://bugs.webkit.org/show_bug.cgi?id=28060
8854
8855         A first pass at a --quiet option.  This doesn't do all the excting
8856         things we might want, but it addresses 80% of the use case.
8857
8858         * Scripts/bugzilla-tool:
8859
8860 2009-08-08  Jan Michael Alonzo  <jmalonzo@webkit.org>
8861
8862         Reviewed by Xan Lopez.
8863
8864         [Gtk] Enable accessibility in Gtk DRT
8865         https://bugs.webkit.org/show_bug.cgi?id=25989
8866
8867         Add Accessibility support to the GTK DRT.
8868
8869         * DumpRenderTree/AccessibilityUIElement.h:
8870         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Added.
8871         (AccessibilityController::AccessibilityController):
8872         (AccessibilityController::~AccessibilityController):
8873         (AccessibilityController::focusedElement):
8874         (AccessibilityController::rootElement):
8875         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Added.
8876         (AccessibilityUIElement::AccessibilityUIElement):
8877         (AccessibilityUIElement::~AccessibilityUIElement):
8878         (AccessibilityUIElement::getLinkedUIElements):
8879         (AccessibilityUIElement::getDocumentLinks):
8880         (AccessibilityUIElement::getChildren):
8881         (AccessibilityUIElement::getChildrenWithRange):
8882         (AccessibilityUIElement::childrenCount):
8883         (AccessibilityUIElement::elementAtPoint):
8884         (AccessibilityUIElement::getChildAtIndex):
8885         (AccessibilityUIElement::allAttributes):
8886         (AccessibilityUIElement::attributesOfLinkedUIElements):
8887         (AccessibilityUIElement::attributesOfDocumentLinks):
8888         (AccessibilityUIElement::titleUIElement):
8889         (AccessibilityUIElement::parentElement):
8890         (AccessibilityUIElement::attributesOfChildren):
8891         (AccessibilityUIElement::parameterizedAttributeNames):
8892         (AccessibilityUIElement::role):
8893         (AccessibilityUIElement::title):
8894         (AccessibilityUIElement::description):
8895         (AccessibilityUIElement::language):
8896         (AccessibilityUIElement::x):
8897         (AccessibilityUIElement::y):
8898         (AccessibilityUIElement::width):
8899         (AccessibilityUIElement::height):
8900         (AccessibilityUIElement::clickPointX):
8901         (AccessibilityUIElement::clickPointY):
8902         (AccessibilityUIElement::intValue):
8903         (AccessibilityUIElement::minValue):
8904         (AccessibilityUIElement::maxValue):
8905         (AccessibilityUIElement::valueDescription):
8906         (AccessibilityUIElement::isEnabled):
8907         (AccessibilityUIElement::insertionPointLineNumber):
8908         (AccessibilityUIElement::isActionSupported):
8909         (AccessibilityUIElement::isRequired):
8910         (AccessibilityUIElement::attributesOfColumnHeaders):
8911         (AccessibilityUIElement::attributesOfRowHeaders):
8912         (AccessibilityUIElement::attributesOfColumns):
8913         (AccessibilityUIElement::attributesOfRows):
8914         (AccessibilityUIElement::attributesOfVisibleCells):
8915         (AccessibilityUIElement::attributesOfHeader):
8916         (AccessibilityUIElement::indexInTable):
8917         (AccessibilityUIElement::rowIndexRange):
8918         (AccessibilityUIElement::columnIndexRange):
8919         (AccessibilityUIElement::lineForIndex):
8920         (AccessibilityUIElement::boundsForRange):
8921         (AccessibilityUIElement::cellForColumnAndRow):
8922         (AccessibilityUIElement::selectedTextRange):
8923         (AccessibilityUIElement::setSelectedTextRange):
8924         (AccessibilityUIElement::attributeValue):
8925         (AccessibilityUIElement::isAttributeSettable):
8926         (AccessibilityUIElement::increment):
8927         (AccessibilityUIElement::decrement):
8928         * DumpRenderTree/gtk/DumpRenderTree.cpp:
8929         (webViewWindowObjectCleared):
8930         (main):
8931         * GNUmakefile.am:
8932
8933 2009-08-07  Jan Michael Alonzo  <jmalonzo@webkit.org>
8934
8935         Unreviewed Gtk build fix.
8936
8937         DRT needs internal WTF symbols so we link to libJavaScriptCore.la
8938         too. Also don't force Gtk to use USE_SYSTEM_MALLOC.
8939
8940         * GNUmakefile.am:
8941
8942 2009-08-07  Darin Adler  <darin@apple.com>
8943
8944         * Scripts/commit-log-editor: Fix unchecked access to environment
8945         variable that may not be there.
8946
8947 2009-08-07  Mark Rowe  <mrowe@apple.com>
8948
8949         Handle the case where only a single test is missing results.
8950
8951         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
8952
8953 2009-08-07  George Wright  <george.wright@torchmobile.com>
8954
8955         Reviewed by Adam Treat
8956
8957         Fix DumpRenderTree for the Qt port to always dump the PNG data unless
8958         the expected and actual hashes match.
8959
8960         https://bugs.webkit.org/show_bug.cgi?id=28077
8961
8962         * DumpRenderTree/qt/DumpRenderTree.cpp:
8963         (WebCore::DumpRenderTree::dump):
8964
8965 2009-08-07  Pierre d'Herbemont  <pdherbemont@apple.com>
8966
8967         Reviewed by Eric Seidel.
8968
8969         commit-log-editor does not produce a git commit log that is git friendly.
8970         https://bugs.webkit.org/show_bug.cgi?id=27754
8971
8972         We make sure we end up with:
8973         - A first paragraph describing the bug. It is eventually prefixed by
8974         "WebKit: <line>" or "WebCore: <line>". This used to be
8975         "WebCore:\n\n<line>".
8976         - The Reviewed By line.
8977         - An eventual Patch By line if author and committer doesn't match.
8978         - The rest of the commit.
8979
8980         * Scripts/commit-log-editor:
8981
8982 2009-08-07  Adam Barth  <abarth@webkit.org>
8983
8984         Unreviewed.  (Darin Adler indicated he'd prefer if we landed these
8985         kinds of changes unreviewed, like editing the WebKit Team wiki page.)
8986
8987         Added Pierre d'Herbemont to list of committers.
8988
8989         * Scripts/modules/committers.py:
8990
8991 2009-08-07  Shinichiro Hamaji  <hamaji@chromium.org>
8992
8993         Reviewed by Adele Peterson.
8994
8995         Cannot scroll for box-reflect:right
8996         https://bugs.webkit.org/show_bug.cgi?id=27979
8997
8998         Update m_overflowLeft an m_overflowWidth for reflection just like
8999         m_overflowTop and m_overflowHeight.
9000
9001         * Scripts/make-js-test-wrappers:  Added regexp to skip box-shadow-overflo
9002 w-scroll.js
9003
9004 2009-08-06  Shinichiro Hamaji  <hamaji@chromium.org>
9005
9006         Reviewed by Adam Barth.
9007
9008         box-shadow's spread is ignored with <table>
9009         https://bugs.webkit.org/show_bug.cgi?id=28017
9010
9011         Use RenderStyle::getBoxShadowExtent just like RenderBlock.
9012
9013         * Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflow-scroll.js
9014
9015 2009-08-06  Eric Seidel  <eric@webkit.org>
9016
9017         No review, only changing make-js-test-wrappers.
9018
9019         Fix make-js-test-wrappers to ignore a few more js tests
9020         with custom templates.
9021
9022         * Scripts/make-js-test-wrappers:
9023
9024 2009-08-06  Chris Marrin  <cmarrin@apple.com>
9025
9026         Reviewed by David Hyatt.
9027
9028         Added ENABLE_3D_CANVAS flag to build, default to off
9029
9030         * Scripts/build-webkit:
9031
9032 2009-08-05  Brady Eidson  <beidson@apple.com>
9033
9034         Reviewed by Darin Adler.
9035
9036         Win DRT's resource load delegate is missing didReceiveResponse
9037         https://bugs.webkit.org/show_bug.cgi?id=28033
9038
9039         * DumpRenderTree/win/FrameLoadDelegate.cpp:
9040         Added:
9041         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
9042         (FrameLoadDelegate::willPerformClientRedirectToURL):
9043         (FrameLoadDelegate::didCancelClientRedirectForFrame):
9044
9045         Minor style cleanup:
9046         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
9047         (FrameLoadDelegate::didReceiveTitle):
9048         (FrameLoadDelegate::didFinishLoadForFrame):
9049         (FrameLoadDelegate::willCloseFrame):
9050         (FrameLoadDelegate::didClearWindowObject):
9051         * DumpRenderTree/win/FrameLoadDelegate.h:
9052
9053 2009-08-05  Brady Eidson  <beidson@apple.com>
9054
9055         Reviewed by Darin Adler.
9056
9057         Win DRT's resource load delegate is missing didReceiveResponse
9058         https://bugs.webkit.org/show_bug.cgi?id=28033
9059
9060         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
9061         (ResourceLoadDelegate::didReceiveResponse):
9062         * DumpRenderTree/win/ResourceLoadDelegate.h:
9063
9064 2009-08-05  Darin Fisher  <darin@chromium.org>
9065
9066         Reviewed by Darin Adler.
9067
9068         Add layoutTestController.dumpWillCacheResponse
9069         https://bugs.webkit.org/show_bug.cgi?id=28010
9070
9071         willCacheResponse is only interesting for embedders of mainline WebKit on Mac.
9072         Splitting off a new dumpWillCacheResponse allows a number of existings tests
9073         to run across platforms.
9074
9075         The test that was specifically verifying willCacheResponse now calls
9076         dumpWillCacheResponse.
9077
9078         * DumpRenderTree/LayoutTestController.cpp: Add dumpWillCacheResponse
9079         (LayoutTestController::LayoutTestController):
9080         (dumpWillCacheResponseCallback):
9081         (LayoutTestController::staticFunctions):
9082         * DumpRenderTree/LayoutTestController.h:
9083         (LayoutTestController::dumpWillCacheResponse):
9084         (LayoutTestController::setDumpWillCacheResponse):
9085         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Inspect dumpWillCacheResponse
9086         instead of dumpResourceLoadCallbacks.
9087         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
9088
9089 2009-08-05  Jeremy Orlow  <jorlow@chromium.org>
9090
9091         Reviewed by Adam Barth.
9092
9093         Add my name to committers.py
9094         https://bugs.webkit.org/show_bug.cgi?id=28013
9095
9096         Add my name to committers.py.
9097
9098         * Scripts/modules/committers.py:
9099
9100 2009-08-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
9101
9102         Reviewed by Simon Hausmann.
9103
9104         A minor refactoring of the Qt DRT to be a bit more similar to
9105         the other DRTs, as well as more understandable.
9106
9107         Splitting up resetJSObjects into a LayoutTestController->reset()
9108         plus a new closeRemainingWindows() method.
9109
9110         Added a resetToConsistentStateBeforeTesting() method to keep
9111         the code in one place, making it easier to verify that we are
9112         doing things properly.
9113
9114         * DumpRenderTree/qt/DumpRenderTree.cpp:
9115         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
9116         (WebCore::DumpRenderTree::open):
9117         (WebCore::DumpRenderTree::closeRemainingWindows):
9118         * DumpRenderTree/qt/DumpRenderTree.h:
9119
9120 2009-08-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
9121
9122         Reviewed by Simon Hausmann.
9123
9124         Make the Qt DRT WorkQueue work similarily to the cross platform
9125         one. This means that all items return true if they started
9126         loading.
9127
9128         This change paves the way for unforking the WorkQueue, if we [Qt]
9129         would like that.
9130
9131         * DumpRenderTree/qt/WorkQueue.cpp:
9132         (WorkQueue::processWork):
9133         * DumpRenderTree/qt/WorkQueue.h:
9134         * DumpRenderTree/qt/WorkQueueItem.h:
9135         * DumpRenderTree/qt/jsobjects.cpp:
9136         (LoadItem::invoke):
9137         (ReloadItem::invoke):
9138         (ScriptItem::invoke):
9139         (BackForwardItem::invoke):
9140         (LayoutTestController::processWork):
9141         (LayoutTestController::maybeDump):
9142
9143 2009-08-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
9144
9145         Reviewed by Simon Hausmann.
9146
9147         If load of a test fails, don't dump as it will be dumped
9148         in the preceding test, resulting in a invalid incorrect layout.
9149
9150         * DumpRenderTree/qt/jsobjects.cpp:
9151         (LayoutTestController::maybeDump):
9152
9153 2009-08-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
9154
9155         Reviewed by Simon Hausmann.
9156
9157         Make the Qt DumpRenderTree more similar to the mac one.
9158
9159         Changes include:
9160         1) Reset zoom factor before each test
9161         2) Only dump the backforward list when we got other dump result
9162         3) When we dump the render tree, and got zero result print out:
9163            [mainFrame renderTreeAsExternalRepresentation]
9164            and not:
9165            [frame renderTreeAsExternalRepresentation]
9166
9167         * DumpRenderTree/qt/DumpRenderTree.cpp:
9168         (WebCore::DumpRenderTree::open):
9169         (WebCore::methodNameStringForFailedTest):
9170         (WebCore::DumpRenderTree::dump):
9171
9172 2009-08-05  chris fleizach  <cfleizach@apple.com>
9173
9174         Fix Tiger build breakage.
9175
9176         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
9177
9178 2009-08-04  Chris Fleizach  <cfleizach@apple.com>
9179
9180         Reviewed by Darin Adler.
9181
9182         Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
9183         https://bugs.webkit.org/show_bug.cgi?id=27994
9184
9185         Expose valueDescription for accessibility.
9186
9187         * DumpRenderTree/AccessibilityUIElement.cpp:
9188         (getValueDescriptionCallback):
9189         (AccessibilityUIElement::getJSClass):
9190         * DumpRenderTree/AccessibilityUIElement.h:
9191         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
9192         (AccessibilityUIElement::valueDescription):
9193         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
9194         (AccessibilityUIElement::valueDescription):
9195
9196 2009-08-04  Eric Seidel  <eric@webkit.org>
9197
9198         Reviewed by Mark Rowe.
9199
9200         REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH
9201         https://bugs.webkit.org/show_bug.cgi?id=28006
9202
9203         Hard-code perl to /usr/bin/perl and swig to /usr/bin/swig
9204
9205         * DumpRenderTree/mac/PerlSupport/Makefile:
9206
9207 2009-08-04  Adam Barth  <abarth@webkit.org>
9208
9209         Reviewed by Darin Adler.
9210
9211         Add pkasting to bugzilla-tool as a committer
9212         https://bugs.webkit.org/show_bug.cgi?id=28002
9213
9214         * Scripts/modules/committers.py:
9215
9216 2009-08-04  Chris Fleizach  <cfleizach@apple.com>
9217
9218         Reviewed by Darin Adler.
9219
9220         Bug 27993 - AXSliders are missing required attributes and actions
9221         https://bugs.webkit.org/show_bug.cgi?id=27993
9222
9223         Add ability to check if any arbitrary action is supported.
9224
9225         * DumpRenderTree/AccessibilityUIElement.cpp:
9226         (isActionSupportedCallback):
9227         (AccessibilityUIElement::getJSClass):
9228         * DumpRenderTree/AccessibilityUIElement.h:
9229         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
9230         (AccessibilityUIElement::isActionSupported):
9231         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
9232         (AccessibilityUIElement::isActionSupported):
9233
9234 2009-08-04  Adam Barth  <abarth@webkit.org>
9235
9236         Reviewed by Eric Seidel.
9237
9238         bugzilla-tool unit tests need a test harness
9239         https://bugs.webkit.org/show_bug.cgi?id=27977
9240
9241         * Scripts/run-webkit-unittests: Added.
9242
9243 2009-08-04  Mark Rowe  <mrowe@apple.com>
9244
9245         Rubber-stamped by Gavin "Gavvy" Barraclough.
9246
9247         Ensure that DumpRenderTreeSupport is regenerated when switching between OS versions
9248         by listing the DumpRenderTree binary as a dependency.  Xcode has the smarts to rebuild
9249         DumpRenderTree itself when switching OS versions so this dependency removes the need
9250         for any smarts in the Makefile.
9251
9252         * DumpRenderTree/mac/PerlSupport/Makefile:
9253
9254 2009-08-04  Eric Seidel  <eric@webkit.org>
9255
9256         Reviewed by Adam Barth.
9257
9258         bugzilla-tool needs unit tests
9259         https://bugs.webkit.org/show_bug.cgi?id=26916
9260
9261         Add some basic unit testing for scm.py.
9262
9263         * Scripts/modules/scm.py:
9264         * Scripts/modules/scm_unittest.py: Added.
9265
9266 2009-08-04  Mike Fenton  <mike.fenton@torchmobile.com>
9267
9268         Reviewed by Adam Treat.
9269
9270         Fix --skipped=only mode to honor flags such as --no-http and platform ignored directories by checking
9271         to make sure the Skipped entries are not in the $ignoredDirectories array.  Directories commonly included
9272         are (http, media, compositing, wml, wcss).
9273
9274         https://bugs.webkit.org/show_bug.cgi?id=27893
9275
9276         * Scripts/run-webkit-tests:
9277
9278 2009-08-03  Chris Fleizach  <cfleizach@apple.com>
9279
9280         Reviewed by Jon Honeycutt.
9281
9282         Bug 27958 - WAI-ARIA: Implement 'aria-required' attribute.
9283         https://bugs.webkit.org/show_bug.cgi?id=27958
9284
9285         Exposed isRequired to DumpRenderTree for accessibility.
9286
9287         * DumpRenderTree/AccessibilityUIElement.cpp:
9288         (getIsRequiredCallback):
9289         (AccessibilityUIElement::getJSClass):
9290         * DumpRenderTree/AccessibilityUIElement.h:
9291         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
9292         (AccessibilityUIElement::isRequired):
9293         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
9294         (AccessibilityUIElement::isRequired):
9295
9296 2009-08-04  Adam Barth  <abarth@webkit.org>
9297
9298         Reviewed by Eric Seidel.
9299
9300         bugzilla-tool --commit-queue should validate commit-queue setter is a committer
9301         https://bugs.webkit.org/show_bug.cgi?id=27974
9302
9303         With a test!
9304
9305         * Scripts/modules/bugzilla.py:
9306         * Scripts/modules/bugzilla_unittest.py:
9307
9308 2009-08-04  Eric Seidel  <eric@webkit.org>
9309
9310         Reviewed by Adam Barth.
9311
9312         REGRESSION(r46700): bugzilla-tool land-diff double-spaces ChangeLogs
9313         https://bugs.webkit.org/show_bug.cgi?id=27973
9314
9315         The trailing comma (suppresses newlines) was lost in r46700.
9316
9317         * Scripts/bugzilla-tool:
9318
9319 2009-08-04  Adam Barth  <abarth@webkit.org>
9320
9321         Reviewed by Eric Seidel.
9322
9323         bugzilla-tool has too many fatal errors
9324         https://bugs.webkit.org/show_bug.cgi?id=27969
9325
9326         Replace several fatal errors with ScriptError exceptions.
9327
9328         * Scripts/bugzilla-tool:
9329         * Scripts/modules/bugzilla.py:
9330         * Scripts/modules/scm.py:
9331
9332 2009-08-04  Eric Seidel  <eric@webkit.org>
9333
9334         No review, ChangeLog fix only.
9335
9336         Fix a ChangeLog line-spacing disaster caused by:
9337         https://bugs.webkit.org/show_bug.cgi?id=27973
9338
9339         Still unsure what the fix for bugzilla-tool will be.
9340
9341 2009-08-04  Adam Barth  <abarth@webkit.org>
9342
9343         Reviewed by Eric Seidel.
9344
9345         bugzilla-tool --commit-queue should only land commit-queue+ patches
9346         https://bugs.webkit.org/show_bug.cgi?id=27970
9347
9348         commit-queue mode for bugzilla-tool
9349         https://bugs.webkit.org/show_bug.cgi?id=27918
9350
9351         Make bugzilla tool smart enough to find the commit-queue+ flags and
9352         land those patches.
9353         When we call land-patches with --commit-queue, we should filter the
9354         patches we land to only those that have the commit-queue+ flag set.
9355         That way, when we call bugzilla-tool from a main commit queue process,
9356         we won't land the wrong patches.
9357
9358         * Scripts/bugzilla-tool:
9359
9360 2009-08-04  Eric Seidel  <eric@webkit.org>
9361
9362         Reviewed by Adam Barth.
9363
9364         committer logic should be split out of bugzilla.py into its own module
9365
9366         https://bugs.webkit.org/show_bug.cgi?id=27972
9367
9368         I also added unit tests for the functionality I added.
9369
9370         * Scripts/modules/bugzilla.py:
9371         * Scripts/modules/bugzilla_unittest.py: Added.
9372         * Scripts/modules/commiters_unittest.py: Added.
9373         * Scripts/modules/committers.py: Added.
9374
9375 2009-08-03  Peter Kasting  <pkasting@google.com>
9376
9377         Reviewed by David Kilzer.
9378
9379         https://bugs.webkit.org/show_bug.cgi?id=27323
9380         Handle any kind of line endings in svn-apply and svn-unapply, instead
9381         of assuming LF.
9382
9383         * Scripts/svn-apply:
9384         * Scripts/svn-unapply:
9385
9386 2009-08-03  Adam Barth  <abarth@webkit.org>
9387
9388         Reviewed by Eric Seidel.
9389
9390         bugzilla-tool land-patches needs --queue mode
9391         https://bugs.webkit.org/show_bug.cgi?id=27961
9392
9393         Add a --commit-queue command line option to suppress user interaction.
9394
9395         * Scripts/bugzilla-tool:
9396         * Scripts/modules/scm.py:
9397
9398 2009-08-03  Mark Rowe  <mrowe@apple.com>
9399
9400         Build fix.  Add installsrc, installhdrs and install targets.
9401
9402         * DumpRenderTree/mac/PerlSupport/Makefile:
9403
9404 2009-08-03  Eric Carlson  <eric.carlson@apple.com>
9405
9406         Reviewed by Eric Seidel.
9407
9408         HTMLInputElement is not controllable by assistive technologies
9409         https://bugs.webkit.org/show_bug.cgi?id=27941
9410
9411         Accessibility control of a slider required adding increment() and decrement()
9412         methods to AccessibilityObject, so expose thos methods on AccessibilityUIElement.
9413
9414         * DumpRenderTree/AccessibilityUIElement.cpp:
9415         (incrementCallback): New, call UI element increment method.
9416         (decrementCallback): New, call UI element decrement method.
9417         (AccessibilityUIElement::getJSClass): Expose increment and decrement methods.
9418
9419         * DumpRenderTree/AccessibilityUIElement.h:
9420         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
9421         (AccessibilityUIElement::increment): New, send NSAccessibilityIncrementAction to Mac wrapper.
9422         (AccessibilityUIElement::decrement): New, send NSAccessibilityDecrementAction to Mac wrapper.
9423
9424         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
9425         (AccessibilityUIElement::increment): New, do nothing.
9426         (AccessibilityUIElement::decrement): New, do nothing.
9427
9428 2009-08-02  David D. Kilzer  <ddkilzer@webkit.org>
9429
9430         <http://webkit.org/b/27930> bugzilla-tool hates Tor Arne Vestbø
9431
9432         Reviewed by Tor Arne Vestbø.
9433
9434         * Scripts/bugzilla-tool:
9435         (set_reviewer_in_changelog): Made sure reviewer is properly
9436         encoded when calling replace().
9437
9438 2009-08-02  Kevin Ollivier  <kevino@theolliviers.com>
9439
9440         Reviewed by David Levin.
9441
9442         Script for building the wxBrowser sample app for wx.
9443         https://bugs.webkit.org/show_bug.cgi?id=27619
9444
9445         * wx/browser/wscript: Added.
9446
9447 2009-08-02  Kevin Ollivier  <kevino@theolliviers.com>
9448
9449         Reviewed by Jan Alonzo.
9450
9451         Scripts needed for the waf build.
9452         https://bugs.webkit.org/show_bug.cgi?id=27619
9453
9454         * wx/build: Added.
9455         * wx/build/build_utils.py: Added.
9456         * wx/build/settings.py: Added.
9457         * wx/build/waf_extensions.py: Added.
9458         * wx/build/wxpresets.py: Added.
9459
9460 2009-08-01  Dan Bernstein  <mitz@apple.com>
9461
9462         Reviewed by Darin Adler.
9463
9464         Make pixel test results more consistent across Mac OS X versions
9465
9466         * DumpRenderTree/cg/ImageDiffCG.cpp:
9467         (createDifferenceImage): Avoid color correction when rendering the
9468             images into graphics contexts, so that the actual color values are
9469             compared, regardless of how the images are tagged.
9470         * DumpRenderTree/mac/DumpRenderTree.mm:
9471         (createWebViewAndOffscreenWindow): Set the window’s color space to the
9472             main screen’s color space, even though the window is off-screen.
9473
9474 2009-08-01  Mark Rowe  <mrowe@apple.com>
9475
9476         Try again to make the Qt build bot happy.
9477
9478         * BuildSlaveSupport/test-result-archive: Create a placeholder file inside the newly-created
9479         directory to prevent 'zip' from failing due to the directory containing no files.
9480
9481 2009-08-01  Mark Rowe  <mrowe@apple.com>
9482
9483         Try and make the Qt build bot happy.
9484
9485         * BuildSlaveSupport/test-result-archive: Handle the case where run-webkit-tests generates
9486         no output files at all and thus does not create the layout-test-results directory.
9487
9488 2009-08-01  Mark Rowe  <mrowe@apple.com>
9489
9490         Move the include of DumpRenderTreeSupport to after DumpRenderTree has been built.
9491
9492         * Scripts/run-webkit-tests:
9493
9494 2009-08-01  Mark Rowe  <mrowe@apple.com>
9495
9496         Reviewed by Sam Weinig and David D. Kilzer.
9497
9498         Fix <https://bugs.webkit.org/show_bug.cgi?id=27923>.
9499         Bug 27923: run-webkit-tests should not invoke "ps" repeatedly on Mac OS X
9500
9501         run-webkit-tests invokes "ps" after each test on Mac OS X to determine whether DumpRenderTree is
9502         in the process of crashing.  We can do the same test more efficiently with a simple call to sysctl.
9503         I couldn't find any built-in way of doing this directly from perl, so we do it from a simple C module
9504         instead.  This speeds up run-webkit-tests by around 8%.
9505
9506         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9507         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Added.
9508         (processIsCrashing):
9509         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm: Added.  Tiger does not have the SWIG tool
9510         that is used to generate the Perl binding to the C code, so we fall back to the old implementation on Tiger.
9511         * DumpRenderTree/mac/PerlSupport/Makefile: Added.
9512         * Scripts/run-webkit-tests:
9513
9514 2009-08-01  Mark Rowe  <mrowe@apple.com>
9515
9516         Reviewed by David D. Kilzer.
9517
9518         Display the reminder once rather than once per ChangeLog.
9519
9520         * Scripts/prepare-ChangeLog:
9521
9522 2009-08-01  David Kilzer  <ddkilzer@apple.com>
9523
9524         resolve-ChangeLogs: add error checking to git ls-files command on close()
9525
9526         Reviewed by Eric Seidel.
9527
9528         Item 2 of <https://bugs.webkit.org/show_bug.cgi?id=18599#c0>.
9529
9530         * Scripts/resolve-ChangeLogs: Added error checking to close()
9531         after running git ls-files.  Added error checking to all
9532         system() calls by checking for a non-zero WEXITSTATUS($?).
9533         Changed "|| die;" expressions to "or die $!;".
9534
9535 2009-08-01  David Kilzer  <ddkilzer@apple.com>
9536
9537         <http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths
9538
9539         Reviewed by Eric Seidel.
9540
9541         * Scripts/resolve-ChangeLogs: Used chdirReturningRelativePath()
9542         and determineVCSRoot() to change directories to the root of the
9543         project before running the command and to provide a path for
9544         removeChangeLogArguments() to make sure any ChangeLog arguments
9545         on the command line are still found.
9546         (canonicalRelativePath): Added.  Returns a canonical path (e.g.,
9547         stripping 'dir/../' from the path) relative to the current
9548         directory.
9549         (removeChangeLogArguments): Added argument which contains a
9550         relative path that must be prepended to any ChangeLog arguments.
9551         Used canonicalRelativePath() and File::Spec->catfile() to
9552         construct a normalized, relative path to each file.
9553
9554 2009-08-01  David Kilzer  <ddkilzer@apple.com>
9555
9556         Implement VCSUtils::chdirReturningRelativePath()
9557
9558         Reviewed by Eric Seidel.
9559
9560         Step 2 to fix:
9561         <http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths
9562
9563         * Scripts/VCSUtils.pm:
9564         (VCSUtils::chdirReturningRelativePath): Moved here from
9565         chdirAndGetDifference() in svn-create-patch.
9566         * Scripts/svn-create-patch: Switched to use
9567         chdirReturningRelativePath() instead of chdirAndGetDifference().
9568         (chdirAndGetDifference): Removed.
9569
9570 2009-08-01  David Kilzer  <ddkilzer@apple.com>
9571
9572         Implement VCSUtils::determineVCSRoot()
9573
9574         Reviewed by Eric Seidel.
9575
9576         Step 1 to fix:
9577         <http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths
9578
9579         * Scripts/VCSUtils.pm: Removed reference to webkitdirs module.
9580         (VCSUtils::EXPORT): Added &determineVCSRoot.  Realphabetized.
9581         (VCSUtils::determineGitRoot): Added.  Based on code in
9582         commit-log-editor.
9583         (VCSUtils::determineVCSRoot): Implemented using
9584         determineGitRoot() and determineSVNRoot().
9585         * Scripts/commit-log-editor: Replaced use of
9586         topLevelSourceDirectory() with determineVCSRoot().  Resorted
9587         use statements.
9588         (topLevelSourceDirectory): Removed.
9589
9590 2009-07-31  Daniel Bates  <dbates@intudata.com>
9591
9592         Reviewed by Eric Seidel.
9593
9594         https://bugs.webkit.org/show_bug.cgi?id=27757
9595
9596         Resolves Perl redefinition warnings about functions tmpfile and tmpnam which are
9597         defined in both File::Temp and POSIX.
9598
9599         This stops the warnings by preventing the "import" method of File::Temp from being called,
9600         which would otherwise add these functions into the primary namespace. Note, "use POSIX"
9601         will import these functions into the primary namespace anyway. We only need one instance
9602         of these functions in our namespace (or we get redefinition warnings), so lets use the
9603         one's in the POSIX package.
9604
9605         * Scripts/update-webkit-auxiliary-libs: Changed "use File::Temp" to "use File::Temp ()".
9606         * Scripts/update-webkit-support-libs: ditto
9607
9608 2009-07-31  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
9609
9610         Reviewed by Eric Seidel.
9611
9612         Add a top level build option to control datagrid support
9613         https://bugs.webkit.org/show_bug.cgi?id=27915
9614
9615         * Scripts/build-webkit:
9616
9617 2009-07-31  David Levin  <levin@chromium.org>
9618
9619         Reviewed by Adam Treat.
9620
9621         check-webkit-style --git-commit has bugs if you select a commit in the past
9622         https://bugs.webkit.org/show_bug.cgi?id=27908
9623
9624         * Scripts/check-webkit-style:
9625         (main): Made the git-commit command only select the first commit
9626         if a range is given (and print a warning).
9627         * Scripts/modules/scm.py:
9628         (SCM::create_patch_from_local_commit):
9629         (SCM::create_patch_since_local_commit):
9630         (SCM::commit_locally_with_message):
9631         (SCM::discard_local_commits):
9632         Added an error messages in case these aren't overriden.
9633
9634         (Git::create_patch_since_local_commit):
9635         Added this command to allow doing a diff of everything after a given commit.
9636
9637 2009-07-31  Jan Michael Alonzo  <jmalonzo@webkit.org>
9638
9639         Speculative Qt build fix. Not reviewed.
9640
9641         Add LayoutTestController::disableImageLoading() in jsobjects.h.
9642
9643         * DumpRenderTree/qt/jsobjects.h:
9644
9645 2009-07-31  Brady Eidson  <beidson@apple.com>
9646
9647         Reviewed by John Sullivan.
9648
9649         <rdar://problem/6973106> and https://bugs.webkit.org/show_bug.cgi?id=27896
9650         Favicons are still loaded when automatic image loading is disabled.
9651
9652         * DumpRenderTree/LayoutTestController.cpp:
9653         (disableImageLoadingCallback):
9654         (LayoutTestController::staticFunctions):
9655         * DumpRenderTree/LayoutTestController.h:
9656
9657         * DumpRenderTree/mac/DumpRenderTree.mm:
9658         (resetWebViewToConsistentStateBeforeTesting):
9659         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
9660         (LayoutTestController::disableImageLoading):
9661
9662         * DumpRenderTree/win/DumpRenderTree.cpp:
9663         (resetWebViewToConsistentStateBeforeTesting):
9664         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
9665         (LayoutTestController::disableImageLoading):
9666
9667         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
9668         (LayoutTestController::disableImageLoading): Stubbed for now.
9669         * DumpRenderTree/qt/jsobjects.cpp:
9670         (LayoutTestController::disableImageLoading): Ditto.
9671
9672 2009-07-30  Eric Seidel  <eric@webkit.org>
9673
9674         Reviewed by David Kilzer.
9675
9676         bugzilla-tool post-commits trunk..head errors out
9677         https://bugs.webkit.org/show_bug.cgi?id=27847
9678
9679         Rename commit_ids_from_range_arguments to commit_ids_from_commitish_arguments
9680         and make it handle the new arguments format proposed in the bug.
9681
9682         * Scripts/bugzilla-tool:
9683         * Scripts/modules/scm.py:
9684
9685 2009-07-30  Eric Seidel  <eric@webkit.org>
9686
9687         Reviewed by David Levin.
9688
9689         clean up build-webkit to use less copy/paste code and remove unneeded SVG warning
9690         https://bugs.webkit.org/show_bug.cgi?id=27857
9691
9692         * Scripts/build-webkit:
9693
9694 2009-07-31  David Kilzer  <ddkilzer@apple.com>
9695
9696         <http://webkit.org/b/27894> bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with ClientForm-0.2.10 and python-2.5
9697
9698         Reviewed by Eric Seidel.
9699
9700         * Scripts/modules/bugzilla.py:
9701         (Bugzilla.clear_attachment_review_flag): Specify which 'comment'
9702         form field to use when setting its value.
9703
9704 2009-07-31  Eric Seidel  <eric@webkit.org>
9705
9706         Reviewed by David Kilzer.
9707
9708         bugzilla-tool post-commits obsoletes its own work :(
9709         https://bugs.webkit.org/show_bug.cgi?id=27849
9710
9711         Simple fix.  Use .add() instead of .update()
9712
9713         * Scripts/bugzilla-tool:
9714
9715 2009-07-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
9716
9717         Reviewed by Anders Carlsson.
9718
9719         Improve platform-detection in run-webkit-tests
9720
9721         This prevents miss-detection of mac-* over Qt/Mac.
9722
9723         * Scripts/run-webkit-tests:
9724
9725 2009-07-30  Mark Rowe  <mrowe@apple.com>
9726
9727         Reviewed by Cameron Zwarich.
9728
9729         Teach buildbot to detect test cases that are missing results.
9730
9731         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
9732
9733 2009-07-30  Mark Rowe  <mrowe@apple.com>
9734
9735         Things work better when you create the correct directories.
9736
9737         * Scripts/run-webkit-tests:
9738
9739 2009-07-30  Mark Rowe  <mrowe@apple.com>
9740
9741         Include some information about the error when we die.
9742
9743         * Scripts/run-webkit-tests:
9744
9745 2009-07-30  Mark Rowe  <mrowe@apple.com>
9746
9747         Ensure that the path exists before writing results to it.
9748         Hopefully this will make the Windows build bot happy.
9749
9750         * Scripts/run-webkit-tests:
9751
9752 2009-07-30  Mark Rowe  <mrowe@apple.com>
9753
9754         Reviewed by Adam Treat and Jon Honeycutt.
9755
9756         Teach run-webkit-tests to always store the actual results in the results directory for new tests.
9757         This allows us to give a working link to the results from the result summary page, even if we're
9758         not generating new results in to the tree.
9759
9760         * Scripts/run-webkit-tests:
9761
9762 2009-07-30  Mark Rowe  <mrowe@apple.com>
9763
9764         Add a Qt Linux build bot.
9765
9766         * BuildSlaveSupport/build.webkit.org-config/config.json:
9767
9768 2009-07-30  Jakob Petsovits  <jakob.petsovits@torchmobile.com>
9769
9770          Reviewed by Adam Roben.
9771
9772          Add --minimal option to webkit-build.
9773          https://bugs.webkit.org/show_bug.cgi?id=27852
9774
9775          This option disables all optional build features unless
9776          they are explicitly enabled.
9777
9778          * Scripts/build-webkit:
9779
9780 2009-07-30  Jakub Wieczorek  <faw217@gmail.com>
9781
9782         [Qt] Fix build with GCC 4.4.
9783
9784         * DumpRenderTree/qt/ImageDiff.cpp:
9785
9786 2009-07-29  Ariya Hidayat  <ariya.hidayat@nokia.com>
9787
9788         Reviewed by Simon Hausmann.
9789
9790         https://bugs.webkit.org/show_bug.cgi?id=27813
9791
9792         [Qt] Support pixel tests in DumpRenderTree for the Qt port.
9793
9794         * DumpRenderTree/qt/DumpRenderTree.cpp:
9795         (WebCore::DumpRenderTree::DumpRenderTree):
9796         (WebCore::DumpRenderTree::open):
9797         (WebCore::DumpRenderTree::setDumpPixels):
9798         (WebCore::DumpRenderTree::dump):
9799         * DumpRenderTree/qt/DumpRenderTree.h:
9800         * DumpRenderTree/qt/main.cpp:
9801         (main):
9802
9803 2009-07-29  Ariya Hidayat  <ariya.hidayat@nokia.com>
9804
9805         Reviewed by Simon Hausmann.
9806
9807         https://bugs.webkit.org/show_bug.cgi?id=27813
9808
9809         [Qt] Implement ImageDiff.
9810
9811         * DumpRenderTree/qt/ImageDiff.cpp: Added.
9812         * DumpRenderTree/qt/ImageDiff.pro: Added.
9813
9814 2009-07-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
9815
9816         Reviewed by Eric Seidel.
9817
9818         build-webkit: Reorder logic for determining the baseProductDir
9819
9820         https://bugs.webkit.org/show_bug.cgi?id=27699
9821
9822         We now do port-spesific probing for the product dir first, and then
9823         fall back to either the generic WEBKITOUTPUTDIR (which now also works
9824         on Mac), or WebKitBuild.
9825
9826         Then we add the git branch if the git branch build option is enabled.
9827
9828         Finally we massage the product dir based on the port. For example the
9829         Mac port will now always set the SYMROOT and OBJROOT configuration for
9830         XCode.
9831
9832         Note that isAppleWinWebkit() and isCygwin() is not mutually exclusive,
9833         hence the normal if and not elsif in the last two blocks.
9834
9835         * Scripts/webkitdirs.pm:
9836
9837 2009-07-29  David Kilzer  <ddkilzer@apple.com>
9838
9839         <http://webkit.org/b/27082> bugzilla-tool: Add --no-close switch to land-patches
9840
9841         Reviewed by David Levin.
9842
9843         * Scripts/bugzilla-tool:
9844         (LandPatchesFromBugs.__init__): Added --no-close switch.
9845         (LandPatchesFromBugs.land_patches): Don't close the bug if the
9846         --no-close switch was used.  Always clear the review+ flag on
9847         every landed patch using the commit_text message when cleared.
9848         This prevents patches from showing up in the commit queue if
9849         reopened and provides consistency with all landed patches.
9850         * Scripts/modules/bugzilla.py:
9851         (Bugzilla.clear_attachment_review_flag): Added.
9852
9853 2009-07-29  David Kilzer  <ddkilzer@apple.com>
9854
9855         <http://webkit.org/b/27815> bugzilla-tool: add -m/--description to post-commits command
9856
9857         Reviewed by Eric Seidel.
9858
9859         * Scripts/bugzilla-tool:
9860         (PostDiffAsPatchToBug.execute): Changed default patch name from
9861         "patch" to "Patch v1".
9862         (PostCommitsAsPatchesToBug.__init__): Added -m/--description
9863         switch.
9864         (PostCommitsAsPatchesToBug.execute): Use description provided by
9865         -m/--description switch first, else fall back to the commit
9866         message.
9867
9868 2009-07-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
9869
9870         Reviewed by Dave Levin.
9871
9872         Make check-webkit-style support files as arguments.
9873         https://bugs.webkit.org/show_bug.cgi?id=27549
9874
9875         * Scripts/check-webkit-style:
9876         Support files as argument. Change documentation and use basename
9877         on the binary name when used in the documentation. Also do not
9878         die when printing something containing non-ASCII characters.
9879
9880 2009-08-06  Mike Fenton  <mike.fenton@torchmobile.com>
9881
9882         Reviewed by David Levin.
9883
9884         Add validation for pointer and reference declaration as defined by webkit style guidelines to cpp_style.py.
9885         Add unit tests for validation and update existing c style cast test to be run explicitly as c validation.
9886
9887         https://bugs.webkit.org/show_bug.cgi?id=27984
9888
9889         * Scripts/modules/cpp_style.py:
9890         * Scripts/modules/cpp_style_unittest.py:
9891
9892 2009-07-29  David Kilzer  <ddkilzer@apple.com>
9893
9894         <http://webkit.org/b/27119> bugzilla-tool: Add create-bug command
9895
9896         Reviewed by David Levin.
9897
9898         Implement "create-bug" command for bugzilla-tool.
9899
9900         * Scripts/bugzilla-tool: Added CreateBug class.
9901         (CreateBug.__init__): Added.
9902         (CreateBug.create_bug_from_commit): Added.
9903         (CreateBug.create_bug_from_patch): Added.
9904         (CreateBug.prompt_for_bug_title_and_comment): Added.
9905         (CreateBug.execute): Added.
9906         (BugzillaTool.__init__): Added create-bug command.
9907         * Scripts/modules/bugzilla.py:
9908         (Bugzilla.prompt_for_component): Added.
9909         (Bugzilla.check_create_bug_response_returning_bug_id_on_success): Added.
9910         (Bugzilla.create_bug_with_patch): Added.
9911
9912 2009-07-29  Jan Michael Alonzo  <jmalonzo@webkit.org>
9913
9914         Reviewed by Eric Seidel and Xan Lopez.
9915
9916         [Gtk] Enable http/tests/appcache tests
9917         https://bugs.webkit.org/show_bug.cgi?id=27674
9918
9919         Add support for testing http/tests/appcache tests.
9920
9921         * DumpRenderTree/gtk/DumpRenderTree.cpp:
9922         (resetWebViewToConsistentStateBeforeTesting):
9923         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
9924         (LayoutTestController::setAppCacheMaximumSize):
9925
9926 2009-07-28  Mark Rowe  <mrowe@apple.com>
9927
9928         Reviewed by Oliver Hunt.
9929
9930         Prevent nightly builds of WebKit from launching against old Safari versions that we no longer work with.
9931
9932         * WebKitLauncher/main.m:
9933         (checkSafariVersion): Add a minimum required Safari version of 4.0.  This matches the requirement on Windows.
9934         (main): If the minimum version requirement is not met, display an alert and bail out.
9935
9936 2009-07-28  David Levin  <levin@chromium.org>
9937
9938         Reviewed by Adam Treat.
9939
9940         cpplint* should be named cpp_style*
9941         https://bugs.webkit.org/show_bug.cgi?id=27752
9942
9943         The files were renamed. A few renames were done:
9944           CppLint -> CppStyle
9945           cpplint -> cpp_style
9946
9947         * Scripts/check-webkit-style:
9948         * Scripts/modules/cpp_style.py: Copied from cpplint.py and
9949           did name fix ups.
9950         * Scripts/modules/cpp_style_unittest.py: Copied from cpplint_unittest.py and
9951           did name fix ups.
9952         * Scripts/modules/cpplint.py: Removed.
9953         * Scripts/modules/cpplint_unittest.py: Removed.
9954
9955 2009-07-28  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
9956
9957         Rubber-stamped by Holger Freyther.
9958
9959         Add Steve Falkenburg to bugzilla-tools' reviewers list
9960
9961         * Scripts/modules/bugzilla.py:
9962
9963 2009-07-28  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>
9964
9965         Reviewed by Simon Hausmann.
9966
9967         Implement test result archive support for the Qt port.
9968
9969         * BuildSlaveSupport/test-result-archive:
9970
9971 2009-07-27  Brady Eidson  <beidson@apple.com>
9972
9973         Reviewed by Sam Weinig.
9974
9975         https://bugs.webkit.org/show_bug.cgi?id=27755
9976         Layout tests that dump resource load delegate calls should dump the request method and the response status code.
9977
9978         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
9979         (-[NSURLResponse _drt_descriptionSuitableForTestResult]):
9980         (-[NSURLRequest _drt_descriptionSuitableForTestResult]):
9981
9982         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
9983         (descriptionSuitableForTestResult):
9984
9985 2009-07-27  Pierre d'Herbemont  <pdherbemont@apple.com>
9986
9987         Reviewed by David Levin.
9988
9989         "bugzilla-tool post-commit head" doesn't work because it can't find the bug id from the commit load.
9990         https://bugs.webkit.org/show_bug.cgi?id=27747
9991
9992         modules.bugzilla is not found because not included.
9993
9994         * Scripts/modules/scm.py: Properly import modules.bugzilla.
9995
9996 2009-07-24  Pierre d'Herbemont  <pdherbemont@apple.com>
9997
9998         Reviewed by David Kilzer.
9999
10000         commit-log-editor should allow git commit --amend to regenerate the commit log based on the modifed ChangeLog
10001         https://bugs.webkit.org/show_bug.cgi?id=27664
10002
10003         * Scripts/commit-log-editor: Add --regenerate-log option.
10004         The user is asked if he wants to suppress previous ChangeLog and regenerate it,
10005         if this option is enabled.
10006
10007 2009-07-27  Gabor Rapcsanyi  <rapcsanyi.gabor@stud.u-szeged.hu>
10008
10009         Reviewed by Simon Hausmann.
10010
10011         Generating remote links causes a lot of unnecessary spew on Qt build bot too
10012
10013         * Scripts/run-webkit-tests:
10014
10015 2009-07-25  Kwang Yul Seo  <skyul@company100.net>
10016
10017         Reviewed by Darin Adler.
10018
10019         Windows build break due to warning C4819
10020         https://bugs.webkit.org/show_bug.cgi?id=27416
10021
10022         Disable C4819 warning to fix build.
10023
10024         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
10025
10026 2009-07-24  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
10027
10028         Not reviewed. Add Kevin McCullough as reviewer in bugzilla.py
10029
10030         * Scripts/modules/bugzilla.py:
10031
10032 2009-07-24  Eli Fidler  <eli.fidler@torchmobile.com>
10033
10034         Reviewed by Adam Treat.
10035
10036         Improve git workflow by populating commit messages with ChangeLog entries.
10037         https://bugs.webkit.org/show_bug.cgi?id=27605
10038
10039         If the user doesn't manually modify the ChangeLog files, use
10040         prepare-ChangeLog to populate the git commit message. This behaviour
10041         can be disabled by the 'webkitGenerateCommitMessage' git configuration option.
10042
10043         * Scripts/commit-log-editor:
10044
10045 2009-07-24  David Levin  <levin@chromium.org>
10046
10047         Reviewed by Adam Treat.
10048
10049         cpplint crash when there is a duplicate header followed by another header.
10050         https://bugs.webkit.org/show_bug.cgi?id=27625
10051
10052         * Scripts/modules/cpplint.py: Ensure that include_state.header_types is updated even
10053           there is a duplicate header, which resulted in some code rearrangement.  Also,
10054           changed some if's in this function to return early.  This avoids having nearly the
10055           whole function content being indented.
10056         * Scripts/modules/cpplint_unittest.py: Added a test which would have exposed the crash.
10057
10058 2009-07-24  Jakob Petsovits  <jakob.petsovits@torchmobile.com>
10059
10060          Reviewed by Adam Treat.
10061
10062          Filetype support changes for cpplint and check_webkit_style
10063          https://bugs.webkit.org/show_bug.cgi?id=27653
10064
10065          Introduce .c support for check_webkit_style, and remove support for
10066          .cc files in favor of .cpp.
10067
10068          * Scripts/check-webkit-style:
10069          * Scripts/modules/cpplint.py:
10070          * Scripts/modules/cpplint_unittest.py:
10071
10072 2009-07-24  Eli Fidler  <eli.fidler@torchmobile.com>
10073
10074         Reviewed by David Levin.
10075
10076         Improve git workflow by populating commit messages with ChangeLog entries.
10077         https://bugs.webkit.org/show_bug.cgi?id=27605
10078
10079         add --[no-]write prepare-ChangeLog options to bash completion
10080
10081         * Scripts/webkit-tools-completion.sh:
10082
10083 2009-07-24  Andrei Popescu  <andreip@google.com>
10084
10085         Reviewed by Anders Carlsson.
10086
10087         ApplicationCache should have size limit
10088         https://bugs.webkit.org/show_bug.cgi?id=22700
10089
10090         Adds a new method on the LayoutTestController that
10091         allows a JS unit test to configure the maximum size
10092         of the Application Cache.
10093
10094         * DumpRenderTree/LayoutTestController.cpp:
10095         (setAppCacheMaximumSizeCallback):
10096         (LayoutTestController::staticFunctions):
10097         * DumpRenderTree/LayoutTestController.h:
10098         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
10099         (LayoutTestController::setAppCacheMaximumSize):
10100         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
10101         (LayoutTestController::setAppCacheMaximumSize):
10102         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
10103         (LayoutTestController::setAppCacheMaximumSize):
10104         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
10105         (LayoutTestController::setAppCacheMaximumSize):
10106
10107 2009-07-24  Adam Barth  <abarth@webkit.org>
10108
10109         Rubber stamped by Eric Seidel.
10110
10111         Added andersca to list of reviewers.
10112
10113         * Scripts/modules/bugzilla.py:
10114
10115 2009-07-24  Mark Rowe  <mrowe@apple.com>
10116
10117         Reviewed by Xan Lopez.
10118
10119         Fix dozens of "Deallocation of a pointer not malloced" messages seen while running
10120         layout tests on the build bot.
10121
10122         Memory allocated via FastMalloc was being deleted via the system memory allocator
10123         due to an inconsistent including of FastMalloc.h.  We address this by including it
10124         from config.h and including config.h from every implementation file, as in our other
10125         projects.
10126
10127         * DumpRenderTree/ForwardingHeaders/wtf/FastMalloc.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h.
10128         * DumpRenderTree/config.h:
10129         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
10130         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
10131         * DumpRenderTree/mac/AppleScriptController.m:
10132         * DumpRenderTree/mac/CheckedMalloc.cpp:
10133         * DumpRenderTree/mac/DumpRenderTree.mm:
10134         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
10135         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
10136         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
10137         * DumpRenderTree/mac/EditingDelegate.mm:
10138         * DumpRenderTree/mac/EventSendingController.mm:
10139         * DumpRenderTree/mac/FrameLoadDelegate.mm:
10140         * DumpRenderTree/mac/GCControllerMac.mm:
10141         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
10142         * DumpRenderTree/mac/NavigationController.m:
10143         * DumpRenderTree/mac/ObjCController.m:
10144         * DumpRenderTree/mac/ObjCPlugin.m:
10145         * DumpRenderTree/mac/ObjCPluginFunction.m:
10146         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
10147         * DumpRenderTree/mac/PlainTextController.mm:
10148         * DumpRenderTree/mac/PolicyDelegate.mm:
10149         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
10150         * DumpRenderTree/mac/TextInputController.m:
10151         * DumpRenderTree/mac/UIDelegate.mm:
10152         * DumpRenderTree/mac/WorkQueueItemMac.mm:
10153
10154 2009-07-24  Mark Rowe  <mrowe@apple.com>
10155
10156         Reviewed by Simon Hausmann.
10157
10158         Add a command line option to run-javascriptcore-tests to explicitly opt out of attempting to rebuild JavaScriptCore.
10159         This is primarily useful to speed up the build bots where one machine builds JavaScriptCore and a second runs the tests,
10160         leading to situations where the build system unnecessarily feels that the need to recompile.
10161
10162         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
10163         * Scripts/run-javascriptcore-tests:
10164
10165 2009-07-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
10166
10167         Reviewed by Eric Seidel.
10168
10169         [Gtk] Add implementation of GCController for DRT
10170         https://bugs.webkit.org/show_bug.cgi?id=27636
10171
10172         * DumpRenderTree/gtk/DumpRenderTree.cpp:
10173         (webViewWindowObjectCleared):
10174         (main):
10175         * DumpRenderTree/gtk/GCControllerGtk.cpp:
10176         (GCController::collect):
10177         (GCController::collectOnAlternateThread):
10178         (GCController::getJSObjectCount):
10179
10180 2009-07-23  Mark Rowe  <mrowe@apple.com>
10181
10182         Update build.webkit.org config for new machine.
10183
10184         * BuildSlaveSupport/build.webkit.org-config/config.json:
10185
10186 2009-07-23  Brady Eidson  <beidson@apple.com>
10187
10188         Remove accidentally checked in code.
10189
10190         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
10191         (waitUntilDoneWatchdogFired):
10192         (LayoutTestController::setWaitToDump):
10193
10194 2009-07-23  Brady Eidson  <beidson@apple.com>
10195
10196         Reviewed by Geoff Garen.
10197
10198         WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
10199         https://bugs.webkit.org/show_bug.cgi?id=27595
10200
10201         Add the ability to tell the LayoutTestController to return a null request for willSendRequest
10202         redirect callbacks.
10203
10204         * DumpRenderTree/LayoutTestController.cpp:
10205         (LayoutTestController::LayoutTestController):
10206         (setWillSendRequestReturnsNullOnRedirectCallback):
10207         (LayoutTestController::staticFunctions):
10208         * DumpRenderTree/LayoutTestController.h:
10209         (LayoutTestController::willSendRequestReturnsNullOnRedirect):
10210         (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):
10211
10212         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
10213         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
10214         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
10215         (ResourceLoadDelegate::willSendRequest):
10216
10217 2009-07-23  Mark Rowe  <mrowe@apple.com>
10218
10219         Reviewed Oliver Hunt.
10220
10221         Fix DumpRenderTree to not fail an assertion on launch on a new machine.
10222
10223         * DumpRenderTree/mac/DumpRenderTree.mm:
10224         (setDefaultsToConsistentValuesForTesting): Disable the XSS auditor.  It being enabled
10225         breaks all of the JavaScript tests within testStringByEvaluatingJavaScriptFromString,
10226         which causes us to exit due to an assertion failure.  It's not clear why the XSS auditor
10227         decides to interfere with these tests.
10228
10229 2009-07-23  Mark Rowe  <mrowe@apple.com>
10230
10231         Reviewed by Oliver Hunt.
10232
10233         Update default state of the XSS auditor in GTK DumpRenderTree to match Mac and Windows
10234         in hopes of fixing some layout test failures seen on the build bot.
10235
10236         * DumpRenderTree/gtk/DumpRenderTree.cpp:
10237         (resetWebViewToConsistentStateBeforeTesting):
10238
10239 2009-07-23  Jakob Petsovits  <jakob.petsovits@torchmobile.com>
10240
10241          Reviewed by Adam Treat.
10242
10243          Fix false positives for switch statement indentation check in cpplint.
10244          https://bugs.webkit.org/show_bug.cgi?id=27615
10245
10246          Makes one-line case statements (e.g. "case foo: bar();") work.
10247          Also a few general improvements to the robustness and readability of
10248          the check, and more test cases.
10249
10250          * Scripts/modules/cpplint.py:
10251          * Scripts/modules/cpplint_unittest.py:
10252
10253 2009-07-23  Jakob Petsovits  <jakob.petsovits@torchmobile.com>
10254
10255          Reviewed by Adam Treat.
10256
10257          Add check for line-breaking rule #3 to cpplint.
10258          https://bugs.webkit.org/show_bug.cgi?id=27610
10259
10260          "An else if statement should be written as an if statement when
10261          the prior if concludes with a return statement."
10262
10263          Implemented by a multi-line (kind of back-tracking) algorithm.
10264          Comes with loads of unit tests. Fixes the check for label indentation
10265          to be not so overzealous, as it didn't allow for completely unindented
10266          goto labels (at the very start of a line).
10267
10268          * Scripts/modules/cpplint.py:
10269          * Scripts/modules/cpplint_unittest.py:
10270
10271 2009-07-23  Eli Fidler  <eli.fidler@torchmobile.com>
10272
10273          Reviewed by Adam Treat.
10274
10275          Improve git workflow by populating commit messages with ChangeLog entries.
10276          https://bugs.webkit.org/show_bug.cgi?id=27605
10277
10278          add --[no-]write option to optionally output new ChangeLog entries to
10279          stdout instead of modifying ChangeLog files
10280
10281          fix Torch Mobile copyright
10282
10283          * Scripts/prepare-ChangeLog:
10284
10285 2009-07-23  Jakob Petsovits  <jakob.petsovits@torchmobile.com>
10286
10287         Reviewed by Adam Treat.
10288
10289         Enable cpplint for .c files.
10290         https://bugs.webkit.org/show_bug.cgi?id=27604
10291
10292         Also make sure that the check for NULL does not apply to .c files.
10293
10294         * Scripts/modules/cpplint.py:
10295         * Scripts/modules/cpplint_unittest.py:
10296
10297 2009-07-22  Steve Falkenburg  <sfalken@apple.com>
10298
10299         Checkpoint new Windows nightly launcher.
10300
10301         Reviewed by Mark Rowe.
10302
10303         * WebKitLauncherWin: Added.
10304         * WebKitLauncherWin/Resource.h: Added.
10305         * WebKitLauncherWin/WebKitLauncherWin.cpp: Added.
10306         (getStringValue): Retrieve a string registry value.
10307         (applePathFromRegistry): Get an Apple-related path out of the registry.
10308         (copyEnvironmentVariable): Copy an environment variable.
10309         (safariInstallDir): Helper function to get the install directory for Safari.
10310         (safariBrowserExe): Helper function to get the full path of the Safari executable.
10311         (_tWinMain): Locate Safari and launch it after setting up an environment variable.
10312         * WebKitLauncherWin/WebKitLauncherWin.h: Added.
10313         * WebKitLauncherWin/WebKitLauncherWin.rc: Added.
10314         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Added.
10315         * WebKitLauncherWin/webkit.ico: Added.
10316
10317 2009-07-22  David Levin  <levin@chromium.org>
10318
10319         Reviewed by Adam Treat.
10320
10321         run-webkit-lint should be named check-webkit-style
10322         https://bugs.webkit.org/show_bug.cgi?id=27568
10323
10324         This name better reflects the fact that it is about checking the style of files.
10325
10326         * Scripts/check-webkit-style: Renamed from WebKitTools/Scripts/run-webkit-lint.
10327
10328 2009-07-22  Takeshi Yoshino  <tyoshino@google.com>
10329
10330         Reviewed by Darin Adler.
10331
10332         VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp
10333         https://bugs.webkit.org/show_bug.cgi?id=26375
10334
10335         Make it able to use hexadecimal escape sequences in .*UI_STRING(_KEY)? macros. Now,
10336         the extract-localizable-strings script unescapes hexadecimal escape sequences in string literals
10337         in the macros before writing out them into the file to update.
10338
10339         By this fix, we can eliminate raw UTF-8 strings in source code while using raw UTF-16 big endian
10340         strings in the Localizable.strings file.
10341
10342         Bonus: There's no longer extract-webkit-localizable-strings script. Fix usage message to guide
10343         users to update-webkit-localizable-strings.
10344
10345         * Scripts/extract-localizable-strings:
10346
10347 2009-07-22  Shinichiro Hamaji  <hamaji@google.com>
10348
10349         Reviewed by David Levin.
10350
10351         Tiny typo fixes for cpplint.py
10352         https://bugs.webkit.org/show_bug.cgi?id=27530
10353
10354         * Scripts/modules/cpplint.py:
10355
10356 2009-07-22  Shinichiro Hamaji  <hamaji@chromium.org>
10357
10358         Reviewed by David Levin.
10359
10360         run-webkit-lint checks code which are not changed
10361         https://bugs.webkit.org/show_bug.cgi?id=27529
10362
10363         Add check if the line is newly added.
10364
10365         * Scripts/run-webkit-lint:
10366
10367 2009-07-22  Shinichiro Hamaji  <hamaji@chromium.org>
10368
10369         Reviewed by David Levin.
10370
10371         run-webkit-lint should have --git-commit option
10372         https://bugs.webkit.org/show_bug.cgi?id=27528
10373
10374         * Scripts/modules/cpplint.py:
10375         * Scripts/run-webkit-lint:
10376
10377 2009-07-22  Peter Kasting  <pkasting@google.com>
10378
10379         Reviewed by David Kilzer.
10380
10381         https://bugs.webkit.org/show_bug.cgi?id=27323
10382         Factor svn-create-patch's "determineSvnRoot()" into a function in
10383         VCSUtils.pm so commit-log-editor can use it too.
10384
10385         * Scripts/VCSUtils.pm: Add determineSVNRoot().
10386         * Scripts/commit-log-editor: Use determineSVNRoot() instead of old
10387           code (which didn't work as well).
10388         * Scripts/svn-create-patch: Remove determineSvnRoot() (moved).
10389
10390 2009-07-22  Jakob Petsovits  <jakob.petsovits@torchmobile.com>
10391
10392         Reviewed by Adam Treat.
10393
10394         Fix false positives in namespace indentation checks.
10395         https://bugs.webkit.org/show_bug.cgi?id=27567
10396
10397         The regular expression detecting goto labels (in order
10398         to skip those) was too permissive, which caused other
10399         code like "Foo::Bar()" to be treated as a label too,
10400         thereby not stopping the processing loop as expected.
10401
10402         Now comes with a stricter regexp, and more demanding
10403         test cases to check for these issues.
10404
10405         * Scripts/modules/cpplint.py:
10406         * Scripts/modules/cpplint_unittest.py:
10407
10408 2009-07-22  Jakob Petsovits  <jakob.petsovits@torchmobile.com>
10409
10410         Reviewed by Adam Treat.
10411
10412         Fix cpplint generating false positives for
10413         "primary" includes in headers.
10414         https://bugs.webkit.org/show_bug.cgi?id=27553
10415
10416         Doing so by only flagging includes in header files
10417         as primary when the include filename exactly matches
10418         the header filename.
10419
10420         * Scripts/modules/cpplint.py:
10421         * Scripts/modules/cpplint_unittest.py:
10422
10423 2009-07-22  Jakob Petsovits  <jakob.petsovits@torchmobile.com>
10424
10425         Reviewed by Adam Treat.
10426
10427         cpplint generates false positives for primary includes
10428         https://bugs.webkit.org/show_bug.cgi?id=27544
10429
10430         Fix false positives for instances when cpplint would
10431         normally classify multiple includes as primary: After
10432         the first primary include, classify subsequent ones as
10433         "other" includes even if they look like primary ones.
10434
10435         * Scripts/modules/cpplint.py:
10436         * Scripts/modules/cpplint_unittest.py:
10437
10438 2009-07-22  Gabor Rapcsanyi  <rapcsanyi.gabor@stud.u-szeged.hu>
10439
10440         Reviewed by Simon Hausmann.
10441
10442         Pass XAUTHORITY environment variable to $dumpTool as well.
10443
10444         * Scripts/run-webkit-tests:
10445
10446 2009-07-21  Jakob Petsovits  <jakob.petsovits@torchmobile.com>
10447
10448          Reviewed by Adam Treat.
10449
10450          Add check for correct wtf includes to cpplint.
10451          https://bugs.webkit.org/show_bug.cgi?id=27524
10452
10453          * Scripts/modules/cpplint.py:
10454          * Scripts/modules/cpplint_unittest.py:
10455
10456 2009-07-21  Jakob Petsovits  <jakob.petsovits@torchmobile.com>
10457
10458         Reviewed by David Levin.
10459
10460         Add checks for multi-line boolean operator placement.
10461         https://bugs.webkit.org/show_bug.cgi?id=27496
10462
10463         * Scripts/modules/cpplint.py:
10464         * Scripts/modules/cpplint_unittest.py:
10465
10466 2009-07-21  Adam Treat  <adam.treat@torchmobile.com>
10467
10468         Reviewed by David Levin.
10469
10470         We can't match implementation file and primary header exactly
10471         since we have so many files in WebKit where the port suffix
10472         is appended to the filename.
10473
10474         Example: FooQt.cpp and the primary header is Foo.h.
10475
10476         * Scripts/modules/cpplint.py:
10477
10478 2009-07-21  Jakob Petsovits  <jakob.petsovits@torchmobile.com>
10479
10480         Reviewed by David Levin.
10481
10482         Add checks for switch statement indentation to cpplint.
10483         https://bugs.webkit.org/show_bug.cgi?id=27508
10484
10485         * Scripts/modules/cpplint.py:
10486         * Scripts/modules/cpplint_unittest.py:
10487
10488 2009-07-21  Kenneth Rohde Christiansen  <kenneth@webkit.org>
10489
10490         Reviewed by Adam Treat.
10491
10492         Feature request: cpplint should check for braces - rule 2
10493         https://bugs.webkit.org/show_bug.cgi?id=27497
10494
10495         Add the requested feature: Make sure { is on the same line
10496         as the foreach "keyword".
10497
10498         * Scripts/modules/cpplint.py:
10499         * Scripts/modules/cpplint_unittest.py:
10500
10501 2009-07-20  Jakob Petsovits  <jakob.petsovits@torchmobile.com>
10502
10503         Reviewed by David Levin.
10504
10505         Add checks for namespace indentation to cpplint.
10506         https://bugs.webkit.org/show_bug.cgi?id=27461
10507
10508         * Scripts/modules/cpplint.py:
10509         * Scripts/modules/cpplint_unittest.py:
10510
10511 2009-07-20  Adam Treat  <adam.treat@torchmobile.com>
10512
10513         Reviewed by David Levin.
10514
10515         Add cpplint check for proper include order
10516         https://bugs.webkit.org/show_bug.cgi?id=27462
10517
10518         Add a new check to cpplint to flag cases where the include section of a file
10519         does not match the mandated include order and style of the Webkit coding style
10520         guidelines.
10521
10522         Add associated tests.
10523
10524         * Scripts/modules/cpplint.py:
10525         * Scripts/modules/cpplint_unittest.py:
10526
10527 2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>
10528
10529         Reviewed by David Levin.
10530
10531         Support lint for patches
10532         https://bugs.webkit.org/show_bug.cgi?id=27291
10533
10534         Add run-webkit-lint script, which lints recent changes in local
10535         repository.  Also, modified cpplint.py so that we don't need to
10536         specify verbose level for process_file().
10537
10538         * Scripts/modules/cpplint.py:
10539         * Scripts/run-webkit-lint: Added.
10540
10541 2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>
10542
10543         Reviewed by David Levin.
10544
10545         diff_parser should accept lines without trailing \n
10546         https://bugs.webkit.org/show_bug.cgi?id=27483
10547
10548         Normalize the input lines by removing a trailing newline.
10549         Also, add a case for unittest for newly added files.
10550
10551         * Scripts/modules/diff_parser.py:
10552         * Scripts/modules/diff_parser_unittest.py:
10553
10554 2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>
10555
10556         Reviewed by David Levin.
10557
10558         cpplint.py's process_file() should accept customized error function
10559         https://bugs.webkit.org/show_bug.cgi?id=27487
10560
10561         * Scripts/modules/cpplint.py:
10562
10563 2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>
10564
10565         Reviewed by David Levin.
10566
10567         cpplint.py should have an interface to get global error count
10568         https://bugs.webkit.org/show_bug.cgi?id=27486
10569
10570         * Scripts/modules/cpplint.py:
10571         * Scripts/modules/cpplint_unittest.py:
10572
10573 2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>
10574
10575         Reviewed by David Levin.
10576
10577         cpplint's parse_argument should not exit even if no files are specified
10578         https://bugs.webkit.org/show_bug.cgi?id=27489
10579
10580         * Scripts/modules/cpplint.py:
10581         * Scripts/modules/cpplint_unittest.py:
10582
10583 2009-07-21  Shinichiro Hamaji  <hamaji@chromium.org>
10584
10585         Reviewed by David Levin.
10586
10587         diff_parser: s/add_deleted_line/add_old_line/g
10588         https://bugs.webkit.org/show_bug.cgi?id=27484
10589
10590         * Scripts/modules/diff_parser.py:
10591
10592 2009-07-21  Roland Steiner  <rolandsteiner@google.com>
10593
10594         Reviewed by David Levin.
10595
10596         Add ENABLE_RUBY to list of build options
10597         https://bugs.webkit.org/show_bug.cgi?id=27324
10598
10599         * Scripts/build-webkit: Added flag ENABLE_RUBY.
10600
10601 2009-07-20  Mark Rowe  <mrowe@apple.com>
10602
10603         Reviewed by David D. Kilzer.
10604
10605         Fix <https://bugs.webkit.org/show_bug.cgi?id=27482>.
10606         Bug 27482: svn-apply cannot apply patch generated by Windows SVN
10607
10608         A regexp in svn-apply was treating everything prior to a \n as part of the
10609         file name.  The native Windows SVN client uses \r\n for line endings which
10610         meant that the \r was being included in the file name.  This defeated the
10611         special-case logic for ChangeLogs to apply them with an increased fuzz factor,
10612         meaning that the ChangeLog portions of such patches would fail to apply.
10613
10614         Also updated two other regexps that look like they would hit similar problems
10615         with line-endings so that they will correctly handle patches from Windows SVN.
10616
10617         * Scripts/svn-apply:
10618
10619 2009-07-20  Peter Kasting  <pkasting@google.com>
10620
10621         Reviewed by Mark Rowe.
10622
10623         https://bugs.webkit.org/show_bug.cgi?id=27468
10624         Back out r46060, which caused problems for some Apple developers.
10625
10626         * DumpRenderTree/win/DumpRenderTree.vcproj:
10627         * DumpRenderTree/win/ImageDiff.vcproj:
10628         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
10629
10630 2009-07-20  Peter Kasting  <pkasting@google.com>
10631
10632         Reviewed by Darin Adler.
10633
10634         https://bugs.webkit.org/show_bug.cgi?id=27323
10635         Use shorter, more correct code for determining the current directory,
10636         which works better with symbolic links on some systems.  Also switch
10637         from checking repository root to checking UUID, to match scm.py.
10638
10639         * Scripts/svn-create-patch:
10640
10641 2009-07-20  Mark Rowe  <mrowe@apple.com>
10642
10643         Rubber-stamped by Dan Bernstein.
10644
10645         Work around <rdar://problem/7075373> by ensuring that the URL is absolute before handing it off to CoreText.
10646
10647         * DumpRenderTree/mac/DumpRenderTree.mm:
10648         (activateFonts):
10649
10650 2009-07-20  David Levin  <levin@chromium.org>
10651
10652         Reviewed by Adam Treat.
10653
10654         Enable filename completion for run-webkit-test (added "-o default").
10655
10656         * Scripts/webkit-tools-completion.sh:
10657
10658 2009-07-20  Simon Hausmann  <simon.hausmann@nokia.com>
10659
10660         No review, just adding Gavin Barraclough as reviewer.
10661
10662         * Scripts/modules/bugzilla.py:
10663
10664 2009-07-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
10665
10666         Reviewed by David Levin.
10667
10668         Add support for Qt's foreach to cpplint
10669         https://bugs.webkit.org/show_bug.cgi?id=27386
10670
10671         * Scripts/modules/cpplint.py:
10672         * Scripts/modules/cpplint_unittest.py:
10673
10674 2009-07-18  Jan Michael Alonzo  <jmalonzo@webkit.org>
10675
10676         https://bugs.webkit.org/show_bug.cgi?id=27145
10677         [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html fails after r45615
10678
10679         Reviewed by Gustavo Noronha.
10680
10681         Normalize file URLs.
10682
10683         * DumpRenderTree/gtk/DumpRenderTree.cpp:
10684         (dumpHistoryItem):
10685
10686 2009-07-17  Peter Kasting  <pkasting@google.com>
10687
10688         Reviewed by David Kilzer.
10689
10690         https://bugs.webkit.org/show_bug.cgi?id=27323
10691         Further improve non-Cygwin SVN support.
10692
10693         * Scripts/prepare-ChangeLog: Harmless change to be consistent with other
10694           places that consume whitespace at the end of svn output.
10695         * Scripts/resolve-ChangeLogs: Add support for SVN 1.6.  Slightly
10696           optimize svn info parsing based on technique in svn-create-patch.
10697           Normalize paths and consume whitespace in the same way as
10698           prepare-ChangeLog, for Windows systems with a non-Cygwin SVN.  Force
10699           diff and patch to run in binary mode so that they won't
10700           "intelligently" screw up line endings.
10701
10702 2009-07-18  Simon Fraser  <simon.fraser@apple.com>
10703
10704         Fix Tiger DRT build.
10705
10706         * DumpRenderTree/mac/DumpRenderTree.mm:
10707         (createWebViewAndOffscreenWindow):
10708         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
10709
10710 2009-07-17  Simon Fraser  <simon.fraser@apple.com>
10711
10712         Reviewed by Dan Bernstein.
10713
10714         DRT doesn't reliably snapshot composited layers
10715         https://bugs.webkit.org/show_bug.cgi?id=27399
10716
10717         If we're doing an "onscreen" pixel capture, it means that we're snapshotting a view
10718         with composited content. In that case we need to force the view to display so that
10719         the composited layers are rendered to the screen.
10720
10721         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
10722         (createBitmapContextFromWebView):
10723
10724 2009-07-17  Adam Barth  <abarth@webkit.org>
10725
10726         Reviewed by David Levin.
10727
10728         bugzilla-tool does not understand nested SVN repos
10729         https://bugs.webkit.org/show_bug.cgi?id=27404
10730
10731         Determine the root of the working copy by looking at SVN's UUIDs.
10732
10733         * Scripts/modules/scm.py:
10734
10735 2009-07-17  David Levin  <levin@chromium.org>
10736
10737         Reviewed by Mark Rowe.
10738
10739         webkit-tools-completion.sh has two typos and sorting issues.
10740         https://bugs.webkit.org/show_bug.cgi?id=27401
10741
10742         * Scripts/webkit-tools-completion.sh: Fix two typos "--dif" and "-clean".
10743           Also, sort all lists including items in the case statement and flags for
10744           the commands.
10745
10746 2009-07-17  Peter Kasting  <pkasting@google.com>
10747
10748         Reviewed by David Kilzer.
10749
10750         https://bugs.webkit.org/show_bug.cgi?id=27323
10751         Tweak some regexes for correctness.
10752
10753         * Scripts/prepare-ChangeLog: Allow 1-character filenames (my previous
10754           change here didn't quite get things right).
10755         * Scripts/update-webkit: Detect conflicting ChangeLogs correctly by not
10756           including any trailing whitespace in the name "ChangeLog", and by
10757           normalizing paths before calling basename() to avoid confusing it.
10758           (normalizePath() copied from prepare-ChangeLog.)
10759
10760 2009-07-17  Peter Kasting  <pkasting@google.com>
10761
10762         Reviewed by Steve Falkenburg.
10763
10764         https://bugs.webkit.org/show_bug.cgi?id=27323
10765         Only add Cygwin to the path when it isn't already there.  This avoids
10766         causing problems for people who purposefully have non-Cygwin versions of
10767         executables like svn in front of the Cygwin ones in their paths.
10768
10769         * DumpRenderTree/win/DumpRenderTree.vcproj:
10770         * DumpRenderTree/win/ImageDiff.vcproj:
10771         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
10772
10773 2009-07-17  David Levin  <levin@chromium.org>
10774
10775         Reviewed by Adam Treat.
10776
10777         WebKit should have a bash completion script to aid with common commands.
10778         https://bugs.webkit.org/show_bug.cgi?id=27374
10779
10780         * Scripts/webkit-tools-completion.sh: The script which enables option completion
10781           for several WebKit command line scripts.
10782
10783 2009-07-17  Peter Kasting  <pkasting@google.com>
10784
10785         Reviewed by David Kilzer.
10786
10787         https://bugs.webkit.org/show_bug.cgi?id=27323
10788         Avoid error spew on Macs, and fix a few other tiny details.
10789
10790         * Scripts/svn-create-patch:
10791
10792 2009-07-17  Adam Treat  <adam.treat@torchmobile.com>
10793
10794         Reviewed by Dave Levin.
10795
10796         https://bugs.webkit.org/show_bug.cgi?id=27377
10797         This makes cpplint complain about this for instance:
10798
10799             if (true)
10800             {
10801                 int foo;
10802             }
10803
10804         Add the appropriate unit tests.
10805
10806         * Scripts/modules/cpplint.py:
10807         * Scripts/modules/cpplint_unittest.py:
10808
10809 2009-07-17  Adam Treat  <adam.treat@torchmobile.com>
10810
10811         Reviewed by Dave Levin.
10812
10813         https://bugs.webkit.org/show_bug.cgi?id=27377
10814         Don't filter whitespace at the end of the line.  This is not
10815         explicitly a rule of webkit coding style, but there is no reason
10816         not to warn of this common style problem.
10817
10818         Don't filter whitespace newline. Now, cpplint will complain
10819         about the following situation:
10820
10821             if (true) {
10822                 doSomething();
10823                 doSomethingAgain();
10824             }
10825             else
10826                 doSomething();
10827
10828         Which is a webkit coding style rule violation.
10829
10830         * Scripts/modules/cpplint.py:
10831
10832 2009-07-17  Adam Treat  <adam.treat@torchmobile.com>
10833
10834         Reviewed by Dave Levin.
10835
10836         https://bugs.webkit.org/show_bug.cgi?id=27377
10837         Move this comment to where it belongs.
10838
10839         * Scripts/modules/cpplint_unittest.py:
10840
10841 2009-07-17  Brent Fulgham  <bfulgham@webkit.org>
10842
10843         Reviewed by Adam Roben.
10844
10845         Correct crash in WinLauncher due to improper mixing of BSTR
10846         and TCHAR types.
10847         https://bugs.webkit.org/show_bug.cgi?id=27381
10848
10849         * WinLauncher/WinLauncher.cpp:
10850         (loadURL): Perform SysReAllocString to update the BSTR with
10851           the contents of the TCHAR string.
10852
10853 2009-07-17  David Levin  <levin@chromium.org>
10854
10855         Reviewed by Adam Treat.
10856
10857         cpplint should flag usages of NULL.
10858         https://bugs.webkit.org/show_bug.cgi?id=27341
10859
10860         * Scripts/modules/cpplint.py: Add the check for NULL test and call it.
10861           Make the collapse_strings method public.
10862         * Scripts/modules/cpplint_unittest.py: Add several tests to verify
10863           the check for NULL behavior. Adjust existing tests due to the
10864           new NULL check:
10865            1. Several had NULL removed (or were just removed completely).
10866            2. Two tests now do an assert that allows the caller to check
10867               that a particular error is one of several that was returned.
10868
10869 2009-07-17  Shinichiro Hamaji  <hamaji@chromium.org>
10870
10871         Reviewed by David Levin.
10872
10873         Add a parser of patches for linter.
10874         https://bugs.webkit.org/show_bug.cgi?id=27363
10875
10876         Adds a simple parser for unified diff format.
10877
10878         * Scripts/modules/diff_parser.py: Added.
10879         * Scripts/modules/diff_parser_unittest.py: Added.
10880
10881 2009-06-30  Holger Hans Peter Freyther  <zecke@selfish.org>
10882
10883         Reviewed by Simon Hausmann.
10884
10885         [GTK+] Remove check to be loadable in firefox
10886         https://bugs.webkit.org/show_bug.cgi?id=27345
10887
10888         if (aMozillaVTable->size < sizeof (NPNetscapeFuncs))
10889         fails in firefox but no other example in the mozilla tree is
10890         doing that check. Remove and be happy.
10891
10892         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
10893         (NP_Initialize):
10894
10895 2009-07-17  Adam Treat  <adam.treat@torchmobile.com>
10896
10897         Reviewed by Simon Hausmann.
10898
10899         Something about having a single TAB in a style checking tool like this
10900         is equivalent to nails on a chalk board to me...
10901
10902         * Scripts/modules/cpplint.py:
10903
10904 2009-07-17  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
10905
10906         Reviewed by Simon Hausmann.
10907
10908         Overwrite the plugin directories for the DRT.
10909         Part of https://bugs.webkit.org/show_bug.cgi?id=27215
10910
10911         * DumpRenderTree/qt/DumpRenderTree.cpp:
10912         (WebCore::DumpRenderTree::DumpRenderTree):
10913
10914 2009-07-16  Fumitoshi Ukai  <ukai@chromium.org>
10915
10916         Reviewed by David Levin.
10917
10918         Add --web-sockets flag and ENABLE_WEB_SOCKETS define.
10919         https://bugs.webkit.org/show_bug.cgi?id=27206
10920
10921         Add --web-sockets flag.
10922
10923         * Scripts/build-webkit: add --web-sockets flag.
10924
10925 2009-07-16  Adam Treat  <adam.treat@torchmobile.com>
10926
10927         Reviewed by Dave Levin.
10928
10929         cpplint should check for one line control clauses that are surrounded
10930         by braces
10931         https://bugs.webkit.org/show_bug.cgi?id=27354
10932
10933         * Scripts/modules/cpplint.py: Added the new lint check.
10934         * Scripts/modules/cpplint_unittest.py: Add tests for the new lint check
10935           and fix the other tests as they were not passing this new lint check.
10936
10937 2009-07-16  Peter Kasting  <pkasting@google.com>
10938
10939         Reviewed by David Kilzer.
10940
10941         https://bugs.webkit.org/show_bug.cgi?id=27323
10942         Improve support for WebKit checkouts hosted inside other checkouts
10943         (possible for some ports, e.g. Chromium).
10944
10945         * Scripts/svn-create-patch: Determine SVN root by looking for Repository
10946           Root string and aborting when it's missing or different than what
10947           we've already seen.
10948
10949 2009-07-16  Peter Kasting  <pkasting@google.com>
10950
10951         Reviewed by Adam Roben.
10952
10953         https://bugs.webkit.org/show_bug.cgi?id=27323
10954         Improve support for non-Cygwin SVNs on Windows.
10955
10956         * Scripts/commit-log-editor: Modify regex so that trailing whitespace
10957           (e.g. \r) isn't included in filenames.
10958         * Scripts/prepare-ChangeLog: Fix a case of adding "\n" to the ChangeLog
10959           without normalizing.  Normalize file paths early instead of late so
10960           all stages of the script work.  Modify regexes so that trailing
10961           whitespace (e.g. \r) isn't included in filenames.
10962         * Scripts/svn-create-patch: Use a regex instead of chomp so we cut off
10963           line endings even if they don't match Perl's.
10964
10965 2009-07-16  Joseph Pecoraro  <joepeck02@gmail.com>
10966
10967         Reviewed by Darin Adler.
10968
10969         WebKitTools/Scripts/svn-create-patch is broken
10970         https://bugs.webkit.org/show_bug.cgi?id=27328
10971
10972         * Scripts/svn-create-patch: one line fix for unusual perl behavior
10973
10974 2009-07-16  David Levin  <levin@chromium.org>
10975
10976         Reviewed by David Kilzer.
10977
10978         cpplint should check for equality comparisons to 0/true/false
10979         https://bugs.webkit.org/show_bug.cgi?id=27333
10980
10981         * Scripts/modules/cpplint.py: Added the new lint check.
10982         * Scripts/modules/cpplint_unittest.py: Add tests for the new lint check
10983           and fix a regex that in another unit test that caused it to fail when
10984           you have a directory with a number in it (like WebKit-2)
10985
10986 2009-07-16  David D. Kilzer  <ddkilzer@webkit.org>
10987
10988         <http://webkit.org/b/27241> bugzilla-tool post-commits silently fails with bad args
10989
10990         Reviewed by Eric Seidel.
10991
10992         * Scripts/bugzilla-tool:
10993         (PostCommitsAsPatchesToBug.execute): Added more error checking
10994         when consuming arguments.
10995
10996 2009-07-16  David D. Kilzer  <ddkilzer@webkit.org>
10997
10998         TOOL FIX: scm.py: CommitMessage.message is ambiguous
10999
11000         Fixes this error when running bugzilla-tool apply-patches
11001         --local-commit:
11002
11003         File "bugzilla-tool", line 188, in apply_patches
11004           scm.commit_locally_with_message(commit_message.message() or patch['name'])
11005         TypeError: 'list' object is not callable
11006
11007         * Scripts/modules/scm.py: After r45940 (and r45971), rename
11008         CommitMessage.message attribute to CommitMessage.message_lines.
11009         (CommitMessage.__init__):
11010         (CommitMessage.body):
11011         (CommitMessage.description):
11012         (CommitMessage.message):
11013         (CommitMessage.parse_bug_id):
11014
11015 2009-07-16  David D. Kilzer  <ddkilzer@webkit.org>
11016
11017         TOOL FIX: bugzilla-tool: import CommitMessage class
11018
11019         * Scripts/bugzilla-tool: After r45940, the CommitMessage class
11020         needs to be imported for commit_message_for_this_commit().
11021
11022 2009-07-16  David Levin  <levin@chromium.org>
11023
11024         Reviewed by Maciej Stachowiak.
11025
11026         prepare-ChangeLog should display the --bug option in its help text.
11027         https://bugs.webkit.org/show_bug.cgi?id=27334
11028
11029         * Scripts/prepare-ChangeLog: Added the help text.
11030
11031 2009-07-15  Darin Adler  <darin@apple.com>
11032
11033         * Scripts/do-webcore-rename: Check in the version used to
11034         rename parseURL to deprecatedParseURL.
11035
11036 2009-07-10  David Kilzer  <ddkilzer@apple.com>
11037
11038         bugzilla-tool: create CommitMessage class
11039
11040         Reviewed by Eric Seidel.
11041
11042         Create a CommitMessage class to encapsulate related code.
11043
11044         * Scripts/bugzilla-tool:
11045          (bug_id_from_commit_message): Moved to
11046          CommitMessage.parse_bug_id().
11047          (commit_message_for_this_commit): Return a CommitMessage.
11048          (ApplyPatchesFromBug.apply_patches): Use CommitMessage.message().
11049          (LandPatchesFromBugs.build_and_commit): Ditto.
11050          (CommitMessageForCurrentDiff.execute): Ditto.
11051          (PostCommitsAsPatchesToBug.execute): Switched from
11052          Git.commit_message_for_commit() to
11053          Git.commit_message_for_local_commit().  Switched from
11054          bug_id_from_commit_message() to CommitMessage.parse_bug_id().
11055
11056          * Scripts/modules/scm.py:
11057          (first_non_empty_line_after_index): Added.
11058          (CommitMessage.__init__): Added.
11059          (CommitMessage.body): Added.
11060          (CommitMessage.description): Added.
11061          (CommitMessage.message): Added.
11062          (CommitMessage.parse_bug_id): Added.  Moved from
11063          bug_id_from_commit_message() in bugzilla-tool.
11064          (Git.commit_message_for_local_commit): Renamed from
11065          commit_message_for_commit().  Return a CommitMessage.
11066
11067 2009-07-15  Joseph Pecoraro  <joepeck02@gmail.com>
11068
11069         Reviewed by David Kilzer.
11070
11071         bugzilla-tool/svn-apply can't handle patches made from a non-root directory
11072         https://bugs.webkit.org/show_bug.cgi?id=26999
11073
11074         * Scripts/svn-create-patch:
11075
11076 2009-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
11077
11078         Reviewed by David Levin.
11079
11080         Move cpplint.py to module directory
11081         https://bugs.webkit.org/show_bug.cgi?id=27302
11082
11083         * Scripts/modules/cpplint.py: Renamed from WebKitTools/Scripts/cpplint.py.
11084         * Scripts/modules/cpplint_unittest.py: Renamed from WebKitTools/Scripts/cpplint_unittest.py.
11085
11086 2009-07-15  Simon Hausmann  <simon.hausmann@nokia.com>
11087
11088         Reviewed by Adam Treat.
11089
11090         https://bugs.webkit.org/show_bug.cgi?id=27295
11091
11092         Re-implement QWebPage::shouldInterruptJavaScript to disable
11093         js interruption and avoid showing a messagebox during Qt DRT
11094         runs when script execution takes a bit longer.
11095
11096         * DumpRenderTree/qt/DumpRenderTree.cpp:
11097         (WebCore::WebPage::shouldInterruptJavaScript): Return false
11098         in re-implemented slot.
11099
11100 2009-07-15  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>
11101
11102         Reviewed by Jan Alonzo.
11103
11104         Fix the DumpRenderTree GTK+ build
11105         https://bugs.webkit.org/show_bug.cgi?id=27290
11106
11107         Set USE_SYSTEM_MALLOC macro for the DumpRenderTree build to
11108         disable using TCmalloc in DumpRenderTree.
11109
11110         * GNUmakefile.am:
11111
11112 2009-07-14  Steve Falkenburg  <sfalken@apple.com>
11113
11114         Reorganize JavaScriptCore headers into:
11115         API: include/JavaScriptCore/
11116         Private: include/private/JavaScriptCore/
11117
11118         Reviewed by Darin Adler.
11119
11120         * DumpRenderTree/win/DumpRenderTree.vcproj:
11121         * DumpRenderTree/win/ImageDiff.vcproj:
11122
11123 2009-07-14  Shinichiro Hamaji  <hamaji@chromium.org>
11124
11125         Reviewed by David Levin.
11126
11127         WebKit needs a style linting tool
11128         https://bugs.webkit.org/show_bug.cgi?id=25884
11129
11130         Modifies cpplint (http://google-styleguide.googlecode.com/svn/trunk/cpplint/)
11131         based on WebKit's style guide.
11132
11133         * Scripts/cpplint.py: Added.
11134         * Scripts/cpplint_unittest.py: Added.
11135
11136 2009-07-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
11137
11138         Reviewed by Simon Hausmann.
11139
11140         [Qt] DumpRenderTree no longer builds with Qt4.4
11141         https://bugs.webkit.org/show_bug.cgi?id=27257
11142
11143         Flag Qt 4.5 dependency to allow building with Qt 4.4.
11144
11145         * DumpRenderTree/qt/main.cpp:
11146         (main):
11147
11148 2009-07-13  Brent Fulgham  <bfulgham@webkit.org>
11149
11150         Reviewed by Adam Roben.
11151
11152         Add new configuration flag for redistributable Windows build.
11153         https://bugs.webkit.org/show_bug.cgi=27087
11154
11155         * DumpRenderTree/config.h: Check for presence of WIN_CAIRO and
11156           select appropriate configuration. Defaults to standard Apple build.
11157         * DumpRenderTree/win/DumpRenderTree.vcproj: Add new WinCairo.vsprops
11158           to Debug_Cairo and Release_Cairo targets.
11159
11160 2009-07-13  Simon Hausmann  <simon.hausmann@nokia.com>
11161
11162         Reviewed by Ariya Hidayat.
11163
11164         Always run the Qt DRT with the raster graphicssystem on X11, for
11165         increased stability in the image based tests, in particular canvas.
11166
11167         * DumpRenderTree/qt/main.cpp:
11168         (main):
11169
11170 2009-07-13  Simon Hausmann  <simon.hausmann@nokia.com>
11171
11172         Reviewed by Ariya Hidayat.
11173
11174         Fix test netscape plugin usage with the Qt DRT.
11175
11176         * DumpRenderTree/qt/DumpRenderTree.cpp:
11177         (WebCore::WebPage::WebPage): Enable plugins in the settings.
11178         * Scripts/run-webkit-tests: Set the QT_WEBKIT_PLUGIN path to the correct build
11179         directory to make Qt DRT find the test netscape plugin.
11180
11181 2009-07-13  Simon Hausmann  <hausmann@webkit.org>
11182
11183         Reviewed by Ariya Hidayat.
11184
11185         Make sure to disable the fixed contents size when resetting the page/view
11186         state between test runs, to avoid side-effects.
11187
11188         * DumpRenderTree/qt/DumpRenderTree.cpp:
11189         (WebCore::DumpRenderTree::open): Call setFixedContentsSize() with an invalid
11190         QSize to disable the fixed layout.
11191
11192 2009-07-13  Simon Hausmann  <hausmann@webkit.org>
11193
11194         Reviewed by Ariya Hidayat.
11195
11196         When creating new windows, don't forget to connect the new
11197         page's main frame. This ensures that for example the layoutTestController
11198         is also available there.
11199
11200         * DumpRenderTree/qt/DumpRenderTree.cpp:
11201         (WebCore::DumpRenderTree::createWindow):
11202
11203 2009-07-13  Simon Hausmann  <hausmann@webkit.org>
11204
11205         Reviewed by Ariya Hidayat.
11206
11207         Added support for LayoutTestController.setPrivateBrowsingEnabled.
11208
11209         * DumpRenderTree/qt/jsobjects.cpp:
11210         (LayoutTestController::reset):
11211         (LayoutTestController::setPrivateBrowsingEnabled):
11212         * DumpRenderTree/qt/jsobjects.h:
11213
11214 2009-07-13  Simon Hausmann  <hausmann@webkit.org>
11215
11216         Reviewed by Ariya Hidayat.
11217
11218         Added support for database callbacks, storage quota setting,
11219         and clearing of all databases.
11220
11221         * DumpRenderTree/qt/DumpRenderTree.cpp:
11222         (WebCore::DumpRenderTree::DumpRenderTree):
11223         (WebCore::DumpRenderTree::dumpDatabaseQuota):
11224         * DumpRenderTree/qt/DumpRenderTree.h:
11225         * DumpRenderTree/qt/jsobjects.cpp:
11226         (LayoutTestController::reset):
11227         (LayoutTestController::setDatabaseQuota):
11228         (LayoutTestController::clearAllDatabases):
11229         * DumpRenderTree/qt/jsobjects.h:
11230         (LayoutTestController::shouldDumpDatabaseCallbacks):
11231         (LayoutTestController::dumpDatabaseCallbacks):
11232         * DumpRenderTree/qt/main.cpp:
11233         (main):
11234
11235 2009-07-13  Simon Hausmann  <hausmann@webkit.org>
11236
11237         Reviewed by Ariya Hidayat.
11238
11239         Setup the path in the Qt DRT for HTML 5 Databases, to enable some of
11240         the storage layout tests.
11241
11242         * DumpRenderTree/qt/main.cpp:
11243         (main):
11244
11245 2009-07-13  Simon Hausmann  <hausmann@webkit.org>
11246
11247         Reviewed by Ariya Hidayat.
11248
11249         Make the test output more robust by dumping only when the main
11250         frame finishes loading, instead of when _any_ frame finishes.
11251
11252         * DumpRenderTree/qt/DumpRenderTree.cpp:
11253         (WebCore::DumpRenderTree::DumpRenderTree): Connect to the
11254         main frame's loadFinished() signal instead of the page's one.
11255
11256 2009-07-13  Simon Hausmann  <hausmann@webkit.org>
11257
11258         Reviewed by Ariya Hidayat.
11259
11260         Implement the GCController DRT interface.
11261
11262         * DumpRenderTree/qt/DumpRenderTree.cpp:
11263         (WebCore::DumpRenderTree::DumpRenderTree): Allocate the GCController.
11264         (WebCore::DumpRenderTree::initJSObjects): Register the interface with the JS engine.
11265         * DumpRenderTree/qt/DumpRenderTree.h: Declare m_gcController.
11266         * DumpRenderTree/qt/jsobjects.cpp: Implement GCController.
11267         (GCController::GCController):
11268         (GCController::collect):
11269         (GCController::collectOnAlternateThread):
11270         (GCController::getJSObjectCount):
11271         * DumpRenderTree/qt/jsobjects.h: Declare GCController.
11272
11273 2009-07-13  Simon Hausmann  <hausmann@webkit.org>
11274
11275         Reviewed by Ariya Hidayat.
11276
11277         Implement the GCController DRT interface in the Qt DRT.
11278
11279         * DumpRenderTree/qt/DumpRenderTree.cpp:
11280         (WebCore::DumpRenderTree::DumpRenderTree): Allocate the GCController.
11281         (WebCore::DumpRenderTree::initJSObjects): Register the interface with the JS engine.
11282         * DumpRenderTree/qt/DumpRenderTree.h: Declare m_gcController.
11283         * DumpRenderTree/qt/jsobjects.cpp: Implement GCController.
11284         (GCController::GCController):
11285         (GCController::collect):
11286         (GCController::collectOnAlternateThread):
11287         (GCController::getJSObjectCount):
11288         * DumpRenderTree/qt/jsobjects.h: Declare GCController.
11289
11290 2009-07-13  Jan Michael Alonzo  <jmalonzo@webkit.org>
11291
11292         https://bugs.webkit.org/show_bug.cgi?id=26718 [Gtk] Add support for javascript windows for DRT
11293
11294         Reviewed by Gustavo Noronha and Xan Lopez.
11295
11296         Support running of tests that open and close JS windows automatically.
11297
11298         * DumpRenderTree/gtk/DumpRenderTree.cpp:
11299         (dumpFramesAsText):
11300         (dumpBackForwardListForAllWebViews):
11301         (resetWebViewToConsistentStateBeforeTesting):
11302         (dump):
11303         (runTest):
11304         (webViewClose):
11305         (createWebView):
11306         (webViewCreate):
11307         (main):
11308         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
11309         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
11310         (LayoutTestController::windowCount):
11311         (LayoutTestController::setPopupBlockingEnabled):
11312
11313 2009-07-13  Shinichiro Hamaji  <hamaji@chromium.org>
11314
11315         Reviewed by Maciej Stachowiak.
11316
11317         prepare-ChangeLog should decode HTML entities in short description
11318         https://bugs.webkit.org/show_bug.cgi?id=27122
11319
11320         Decode the short description by adding a function which decodes HTML
11321         entities. It can decode &, <, >, ", and ' . They may be sufficient
11322         as the description seems to be encoded by xml_quote in
11323         http://mxr.mozilla.org/bugzilla/source/Bugzilla/Util.pm
11324
11325         * Scripts/prepare-ChangeLog:
11326
11327 2009-07-13  Drew Wilson  <atwilson@google.com>
11328
11329         Reviewed by David Levin.
11330
11331         Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
11332         https://bugs.webkit.org/show_bug.cgi?id=26932
11333
11334         Added support for --shared-workers (turned off by default)
11335
11336         * Scripts/build-webkit:
11337
11338 2009-07-12  Dan Bernstein  <mitz@apple.com>
11339
11340         Reviewed by Maciej Stachowiak.
11341
11342         https://bugs.webkit.org/show_bug.cgi?id=27196
11343         Update check-for-global-initializers for the renaming for bidi.cpp to
11344         RenderBlockLineLayout.cpp
11345
11346         * Scripts/check-for-global-initializers:
11347
11348 2009-07-11  Simon Fraser  <simon.fraser@apple.com>
11349
11350         Enable support for accelerated compositing and 3d transforms on Leopard.
11351         <https://bugs.webkit.org/show_bug.cgi?id=20166>
11352         <rdar://problem/6120614>
11353
11354         Reviewed by Oliver Hunt.
11355
11356         * Configurations/FeatureDefines.xcconfig:
11357         * wtf/Platform.h:
11358
11359 2009-07-10  David Kilzer  <ddkilzer@apple.com>
11360
11361         <http://webkit.org/b/27173> svn-apply: Fix typo in git command used to find deleted files
11362
11363         Reviewed by Eric Seidel.
11364
11365         * Scripts/svn-apply:
11366         (scmWillDeleteFile): Changed 'head' to 'HEAD'.
11367
11368 2009-07-10  David Kilzer  <ddkilzer@apple.com>
11369
11370         <http://webkit.org/b/27167> bugzilla-tool: hide help for unsupported commands
11371
11372         Reviewed by Eric Seidel.
11373
11374         When bugzilla-tool -h|--help is invoked in an svn working
11375         directory, don't print help for commands that are only supported
11376         on git working directories.
11377
11378         * Scripts/bugzilla-tool:
11379         (Command.__init__): Added requires_local_commits argument with a
11380         default of False.  Set self.requires_local_commits attribute.
11381         (PostCommitsAsPatchesToBug.execute): Removed
11382         SCM.supports_local_commits() check since this is now handled by
11383         BugzillaTool.main().
11384         (PostCommitsAsPatchesToBug.__init__): Added
11385         requires_local_commits=True argument to Command.__init__().
11386         (BugzillaTool.commands_usage): Don't print help for commands if
11387         they require local commits and the current SCM doesn't support
11388         them.
11389         (BugzillaTool.main): If command_object requires local commits
11390         and the current SCM doesn't, exit with an error message.
11391
11392 2009-07-10  David Kilzer  <ddkilzer@apple.com>
11393
11394         <http://webkit.org/b/27117> bugzilla-tool: use Mac OS X keychain for authentication
11395
11396         Reviewed by Eric Seidel.
11397
11398         Try reading credentials from git config first, then keychain if
11399         running on Mac OS X, else prompt at the command-line.
11400
11401         * Scripts/modules/bugzilla.py: Added "import platform".
11402         (credentials_from_git): Added.
11403         (credentials_from_keychain): Added.
11404         (is_mac_os_x): Added.
11405         (read_credentials): Added.
11406         (Bugzilla.__init__): Moved instance attribute bug_server to a
11407         static attribute named bug-server_url.
11408         (Bugzilla.bug_server_host): Added.  Extracted host name from
11409         bug_server_url.
11410         (Bugzilla.bug_server_regex): Updated to be created using
11411         bug_server_host.
11412         (Bugzilla.bug_server_url): Renamed from bug_server.
11413         (Bugzilla.bug_url_for_bug_id): Updated for renaming of
11414         bug_server to bug_server_url.
11415         (Bugzilla.attachment_url_for_id): Ditto.
11416         (Bugzilla.fetch_bug_ids_from_commit_queue): Ditto.
11417         (Bugzilla.authenticate): Ditto.  Updated to use
11418         read_credentials().
11419         (Bugzilla.add_patch_to_bug): Ditto.
11420
11421 2009-07-10  David Kilzer  <ddkilzer@apple.com>
11422
11423         <http://webkit.org/b/27115> bugzilla-tool: extract duplicate logging methods into a module
11424
11425         Reviewed by Adam Roben.
11426
11427         * Scripts/bugzilla-tool: Removed error() and log() methods and
11428         added import of new logging module.
11429         * Scripts/modules/bugzilla.py: Ditto.  Removed "import sys".
11430         * Scripts/modules/scm.py: Ditto.
11431
11432         * Scripts/modules/logging.py: Added.
11433         (log): Added.
11434         (error): Added.  Prefix error messages with "ERROR: ".
11435
11436 2009-07-10  Adam Roben  <aroben@apple.com>
11437
11438         Sort all our Xcode projects
11439
11440         Accomplished using sort-Xcode-project-file.
11441
11442         Requested by Dave Kilzer.
11443
11444         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
11445         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
11446         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
11447
11448 2009-07-10  Adam Roben  <aroben@apple.com>
11449
11450         Print prepare-ChangeLog's reminders to STDERR so they don't end up in
11451         the diff output
11452
11453         Fixes REGRESSION (r45647): prepare-ChangeLog -d puts non-diff lines
11454         into the diff
11455         <https://bugs.webkit.org/show_bug.cgi?id=27150>
11456
11457         Reviewed by Maciej Stachowiak.
11458
11459         * Scripts/prepare-ChangeLog:
11460
11461 2009-07-08  Adam Roben  <aroben@apple.com>
11462
11463         Use case-insensitive comparisons when sorting Xcode project files
11464
11465         This matches the sorting used in Xcode's files list.
11466
11467         Fixes Bug 27079: sort-Xcode-project-file should sort
11468         case-insensitively, to match Xcode's files list
11469         <https://bugs.webkit.org/show_bug.cgi?id=27079>
11470
11471         Reviewed by Dave Kilzer.
11472
11473         * Scripts/sort-Xcode-project-file:
11474         (sortChildrenByFileName):
11475         (sortFilesByFileName):
11476         Lowercase the strings before comparing them so that the comparison
11477         will be case-insensitive.
11478
11479 2009-07-08  Simon Hausmann  <hausmann@webkit.org>
11480
11481         Reviewed by Holger Freyther.
11482
11483         https://bugs.webkit.org/show_bug.cgi?id=27109
11484
11485         Fix side-effects in the Qt DRT with tests using application fonts.
11486
11487         Detect if a test used application fonts and re-initialize the fontconfig
11488         application fontset accordingly.
11489
11490         * DumpRenderTree/qt/DumpRenderTree.cpp:
11491         (WebCore::DumpRenderTree::open): call initializeFonts and remove all application fonts
11492         after running a testcase.
11493         (WebCore::DumpRenderTree::initializeFonts): Moved fontconfig initialization code
11494         here from main.
11495         * DumpRenderTree/qt/DumpRenderTree.h: Declare initializeFonts.
11496         * DumpRenderTree/qt/main.cpp:
11497         (main): Moved fontconfig initialization code to DRT::initializeFonts.
11498
11499 2009-07-10  Antonio Gomes   <antonio.gomes@openbossa.org>
11500
11501         Reviewed by Simon Hausmann.
11502
11503         [QT] [ARM] Add pkg-config entry for FontConfig on DRT.pro
11504         https://bugs.webkit.org/show_bug.cgi?id=26990
11505
11506         Missing pkg-config entry for FontConfig in DRT.pro causes some compilers to
11507         not link fine against FontConfig bits.
11508
11509         * DumpRenderTree/qt/DumpRenderTree.pro:
11510
11511 2009-07-09  Drew Wilson  <atwilson@google.com>
11512
11513         Reviewed by Alexey Proskuryakov.
11514
11515         https://bugs.webkit.org/show_bug.cgi?id=26903
11516
11517         Turned on CHANNEL_MESSAGING by default because the MessageChannel API
11518         can now be implemented for Web Workers and is reasonably stable.
11519
11520         * Scripts/build-webkit:
11521
11522 2009-07-09  David Kilzer  <ddkilzer@apple.com>
11523
11524         <http://webkit.org/b/27114> bugzilla-tool: Parse short bug URL from commit log messages
11525
11526         Reviewed by Adam Roben.
11527
11528         * Scripts/bugzilla-tool:
11529         (bug_id_from_commit_message): Check for the short bug URL before
11530         checking for the longer bugs.webkit.org URL.
11531
11532 2009-07-08  David Kilzer  <ddkilzer@apple.com>
11533
11534         Bug 27062: bugzilla-tool: post-commits should read bug id from commit log and actually work
11535
11536         <https://bugs.webkit.org/show_bug.cgi?id=27062>
11537
11538         Reviewed by Eric Seidel.
11539
11540         Removed the required BUGID argument from the "post-commits"
11541         command and replaced it with a -b|--bug-id switch or parsing the
11542         commit log message for the bug URL.  Fixed a bug in the
11543         "post-commits" that would ignore the COMMITISH used and post a
11544         patch of local changes against HEAD.  Added --no-commit switch
11545         to disable using the bulk of the ChangeLog entry as the comment
11546         for the new patch.
11547
11548         * Scripts/bugzilla-tool:
11549         (bug_id_from_commit_message): Added.  Returns a bug id from the
11550         commit log message, thus enforcing the need for a bug URL in the
11551         message.
11552         (PostCommitsAsPatchesToBug.__init__): Updated help description
11553         to match new behavior of pulling bug ids from commit log
11554         messages instead of from the command line.  Added -b|--bug-id
11555         switch and --no-comment switch.
11556         (PostCommitsAsPatchesToBug.execute): Updated to use
11557         bug_id_from_commit_message() to pull bug ids from commit log
11558         messages.  Also switched from SCM.create_patch() to use
11559         SCM.create_patch_from_local_commit() to fix a bug where local
11560         repository changes were posted as a patch instead of the
11561         specific COMMITISH.  Fall back to -b|--bug-id if no URL is found
11562         in the commit log message.  Don't specify a comment for the
11563         patch if --no-comment is used.  Set cherry_pick argument to True
11564         for Git.commit_ids_from_range_arguments() since we don't want
11565         implicit commit range behavior for this command.
11566
11567         * Scripts/modules/bugzilla.py: Import datetime module.
11568         (timestamp): Added.  Returns a timestamp in the form of
11569         "YYYYMMDDhhmmss".
11570         (Bugzilla.bug_server_regex): Added static attribute.
11571         (Bugzilla.add_patch_to_bug): Construct a more meaningful patch
11572         file name using the bug_id and timestamp().
11573
11574         * Scripts/modules/scm.py:
11575         (SCM.create_patch_from_local_commit): Added.
11576         (Git.create_patch_from_local_commit): Added.  Runs "git diff" to
11577         return a patch for the given commit_id.
11578
11579 2009-07-08  Maciej Stachowiak  <mjs@apple.com>
11580
11581         Reviewed by Mark Rowe.
11582
11583         Make prepare-ChangeLog less shouty
11584         https://bugs.webkit.org/show_bug.cgi?id=27098
11585
11586         * Scripts/prepare-ChangeLog:
11587
11588 2009-07-08  David Kilzer  <ddkilzer@apple.com>
11589
11590         Bug 27083: bugzilla.py: Clean up bug_server use
11591
11592         <https://bugs.webkit.org/show_bug.cgi?id=27083>
11593
11594         Reviewed by Darin Adler.
11595
11596         * Scripts/modules/bugzilla.py:
11597         (Bugzilla.fetch_bug_ids_from_commit_queue): Use bug_server
11598         instead of hard-coding the URL.
11599         (Bugzilla.authenticate): Remove extra '/' before URL path.
11600         (Bugzilla.add_patch_to_bug): Ditto.
11601
11602 2009-07-08  Brent Fulgham  <bfulgham@webkit.org>
11603
11604         Build fix for Windows Cairo.
11605
11606         Cairo build was incorrectly #including the PixelDumpSupportCG.h
11607         instead of PixelDumpSupportCairo.h
11608
11609         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Correct #include
11610
11611 2009-07-08  David Faure  <faure@kde.org>
11612
11613         Reviewed by Ariya Hidayat.
11614
11615         Small documentation improvement for build-webkit --help
11616
11617         * Scripts/build-webkit: mention --debug option
11618
11619 2009-07-07  Brady Eidson  <beidson@apple.com>
11620
11621         Tiger build fix, work around missing NSString API.
11622
11623         * DumpRenderTree/mac/DumpRenderTree.mm:
11624         (dumpHistoryItem):
11625
11626 2009-07-07  Brady Eidson  <beidson@apple.com>
11627
11628         Reviewed by Mark Rowe.
11629
11630         https://bugs.webkit.org/show_bug.cgi?id=27049 - In dumpBackForwardList() mode, DRT should normalize file urls.
11631
11632         Make the dump of a history item agnostic to the layout of filesystem on the testing machine.
11633
11634         * DumpRenderTree/mac/DumpRenderTree.mm:
11635         (dumpHistoryItem):
11636         * DumpRenderTree/win/DumpRenderTree.cpp:
11637         (dumpHistoryItem):
11638
11639 2009-07-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
11640
11641         Rubber-stamped by Simon Hausmann.
11642
11643         Correct git url of the Qt test-fonts.
11644
11645         * DumpRenderTree/qt/main.cpp:
11646         (main):
11647
11648 2009-07-07  Simon Hausmann  <hausmann@webkit.org>
11649
11650         Reviewed by Holger Freyther.
11651
11652         Clear the main frame's name between loading pages, like in r36652. This
11653         reduces the side-effects between test cases.
11654
11655         * DumpRenderTree/qt/DumpRenderTree.cpp:
11656         (WebCore::DumpRenderTree::open):
11657
11658 2009-07-06  Simon Hausmann  <hausmann@webkit.org>
11659
11660         Reviewed by Holger Freyther.
11661
11662         Fix various layout tests with Qt's DRT.
11663
11664         Remember to set the focus on the web page before
11665         loading.
11666
11667         * DumpRenderTree/qt/DumpRenderTree.cpp:
11668         (WebCore::DumpRenderTree::open):
11669
11670 2009-07-07  Simon Hausmann  <hausmann@webkit.org>
11671
11672         Reviewed by Tor Arne Vestbø and Holger Freyther.
11673
11674         Fix timeout timer handling in Qt DRT.
11675
11676         Use QBasicTimer instead of startTimer/killTimer, to fix the
11677         problem that starting the timeout timer did not stop a
11678         previously started timer, causing multiple emissions of timeout.
11679         The timerEvent() implementation now also checks the timer id, to
11680         protect against double timeouts.
11681
11682         * DumpRenderTree/qt/jsobjects.cpp:
11683         (LayoutTestController::LayoutTestController):
11684         (LayoutTestController::reset):
11685         (LayoutTestController::waitUntilDone):
11686         (LayoutTestController::notifyDone):
11687         (LayoutTestController::timerEvent):
11688         * DumpRenderTree/qt/jsobjects.h:
11689
11690 2009-07-06  Eric Seidel  <eric@webkit.org>
11691
11692         Reviewed by Maciej Stachowiak.
11693
11694         bugzilla-tool fails to close bugs with bugzilla 3.0
11695         https://bugs.webkit.org/show_bug.cgi?id=27008
11696
11697         Update bugzilla.py to match changes in the bug page "changeform"
11698         Update scm.py to add bug_ids to attachments to make error reporting nicer.
11699
11700         * Scripts/modules/bugzilla.py:
11701         * Scripts/modules/scm.py:
11702
11703 2009-07-03  Maciej Stachowiak  <mjs@apple.com>
11704
11705         Reviewed by Eric Seidel.
11706
11707         bugzilla-tool forgot how to obsolete patches
11708         https://bugs.webkit.org/show_bug.cgi?id=26951
11709
11710         * Scripts/modules/bugzilla.py:
11711
11712 2009-07-02  Brent Fulgham  <bfulgham@webkit.org>
11713
11714         Unreviewed build fix (Cairo this time) for DumpRenderTree.
11715         Put Cairo code back in, but use original include order
11716         for the CG stuff to avoid compile issues.
11717
11718         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
11719         (createBitmapContextFromWebView):
11720
11721 2009-07-02  Eric Seidel  <eric@webkit.org>
11722
11723         Correct blatant typo (missing []), no review.
11724
11725         * Scripts/modules/scm.py:
11726
11727 2009-07-02  Brent Fulgham  <bfulgham@webkit.org>
11728
11729         Windows build fix, no review.
11730
11731
11732         Reverting PixelDumpSupportWin.cpp change to avoid strange
11733         error on the build-bot.
11734
11735         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
11736         (createBitmapContextFromWebView):
11737
11738 2009-07-02  Brent Fulgham  <bfulgham@webkit.org>
11739
11740         Build fix, no review.
11741
11742         * DumpRenderTree/config.h:
11743
11744 2009-07-02  Eric Seidel  <eric@webkit.org>
11745
11746         Reviewed by David Levin.
11747
11748         bugzilla-tool needs to handle login failure
11749         https://bugs.webkit.org/show_bug.cgi?id=26913
11750
11751         We now exit(1) on login failure.
11752
11753         * Scripts/modules/bugzilla.py:
11754
11755 2009-06-30  Brent Fulgham  <bfulgham@webkit.org>
11756
11757         Reviewed by Adam Roben.
11758
11759         Add build support for a Windows Cairo version of
11760         DumpRenderTree.  Share as much logic between the
11761         CG and Cairo builds as possible.
11762         https://bugs.webkit.org/show_bug.cgi?id=26457
11763
11764         * DumpRenderTree/PixelDumpSupport.cpp: Added.
11765         (dumpWebViewAsPixelsAndCompareWithExpected): Moved common logic
11766           from CG-specific file.
11767         (printPNG): Moved common logic from CG-specific file.
11768         * DumpRenderTree/PixelDumpSupport.h: Add declaration for new
11769           common printPNG function.
11770         * DumpRenderTree/cairo: Added.
11771         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Added.
11772           Implement cairo-specific logic for dealing with Cairo surfaces.
11773         (writeFunction):
11774         (printPNG): Cairo-specific PNG handling logic.
11775         (computeMD5HashStringForBitmapContext): New Cairo routine using
11776           the generic BitmapContext signature.
11777         (dumpBitmap): New function containing Cairo-specific portions of
11778           the dumping routine.
11779         * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Added.
11780           Provide Cairo version of the BitmapContext structure so that
11781           dumping routines can work on an abstract type.
11782         (BitmapContext::createByAdoptingBitmapAndContext):
11783         (BitmapContext::~BitmapContext):
11784         (BitmapContext::cairoContext):
11785         (BitmapContext::BitmapContext):
11786         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
11787         (printPNG): CG-specific PNG handling logic.
11788         (computeMD5HashStringForBitmapContext): Revised to use generic
11789           BitmapContext signature.
11790         (dumpBitmap): New function containing CG-specific portions of
11791           the dumping routine.
11792         * DumpRenderTree/cg/PixelDumpSupportCG.h: Add new signatures.
11793         * DumpRenderTree/win/DumpRenderTree.cpp: Disable CFNetwork logic
11794           when building the non-CFNetwork version.
11795         (main):
11796         * DumpRenderTree/win/DumpRenderTree.vcproj:
11797         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
11798         (createBitmapContextFromWebView): Provide parallel Cairo implementation
11799           of CG bitmap/context setup.
11800
11801 2009-07-02  Eric Seidel  <eric@webkit.org>
11802
11803         No review, just adding Antti as a reviewer.
11804
11805         * Scripts/modules/bugzilla.py:
11806
11807 2009-07-02  Antonio Gomes   <antonio.gomes@openbossa.org>
11808
11809         Reviewed by Simon Hausmann.
11810
11811         https://bugs.webkit.org/show_bug.cgi?id=26896
11812
11813         [Qt] Set DRT's default fontsize to 13.
11814
11815         * DumpRenderTree/qt/DumpRenderTree.cpp:
11816         (WebCore::WebPage::WebPage):
11817
11818 2009-07-01  Eric Seidel  <eric@webkit.org>
11819
11820         Reviewed by Adam Barth.
11821
11822         bugzilla-tool fails for SVN users
11823         https://bugs.webkit.org/show_bug.cgi?id=26914
11824
11825         To fix this I moved svn from -F - to using -m
11826         In order for -m to work I had to move us off of shell=True
11827         To move off of shell=True all call sites for run_command
11828         which take args, need to pass their args as an list instead of a string.
11829
11830         In order for the final bug update to work correctly, I had to
11831         abstract the way that we parse out revision numbers from the commit text.
11832
11833         * Scripts/bugzilla-tool:
11834         * Scripts/modules/scm.py:
11835
11836 2009-07-01  Eric Seidel  <eric@webkit.org>
11837
11838         Reviewed by Maciej Stachowiak.
11839
11840         prepare-ChangeLog should have a --bug= argument and use it for url autofill
11841         https://bugs.webkit.org/show_bug.cgi?id=26383
11842
11843         prepare-ChangeLog now knows how to grab the bug title from bugs.webkit.org
11844         I also added a bit more template text in an effort to get better ChangeLogs
11845         from casual contributers.
11846
11847         * Scripts/prepare-ChangeLog:
11848
11849 2009-07-01  Eric Seidel  <eric@webkit.org>
11850
11851         Reviewed by Adam Roben.
11852
11853         prepare-ChangeLog should fail when EMAIL_ADDRESS or REAL_NAME are missing:
11854         https://bugs.webkit.org/show_bug.cgi?id=26692
11855
11856         I also made prepare-ChangeLog sanity-check names and email addresses a little.
11857         Names must contain a space, and email addresses must contain '@'
11858
11859         Also "fixed" $email_address to $emailAddress.  This script uses mixed variable name styles.
11860
11861         * Scripts/prepare-ChangeLog:
11862
11863 2009-07-01  Chris Fleizach  <cfleizach@apple.com>
11864
11865         Reviewed by Beth Dakin.
11866
11867         Bug 26900: AX: Manual spell check with Command-; does not bring up suggestions
11868         https://bugs.webkit.org/show_bug.cgi?id=26900
11869
11870         Expose the ability to get the click point of an element through accessibility.
11871
11872         * DumpRenderTree/AccessibilityUIElement.cpp:
11873         (getClickPointXCallback):
11874         (getClickPointYCallback):
11875         (AccessibilityUIElement::getJSClass):
11876         * DumpRenderTree/AccessibilityUIElement.h:
11877         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
11878         (AccessibilityUIElement::clickPointX):
11879         (AccessibilityUIElement::clickPointY):
11880         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
11881         (AccessibilityUIElement::clickPointX):
11882         (AccessibilityUIElement::clickPointY):
11883
11884 2009-07-01  Mark Rowe  <mrowe@apple.com>
11885
11886         Reviewed by Simon Fraser.
11887
11888         Change how WebKitNightlyEnabler.dylib lies about Safari's identity to LaunchServices.
11889         This makes WebKit.app behave as expected when set as the default web browser on a wider
11890         range of OS versions.
11891
11892         * WebKitLauncher/WebKitNightlyEnabler.m:
11893         (poseAsWebKitApp):
11894         (enableWebKitNightlyBehaviour):
11895
11896 2009-07-01  Mark Rowe  <mrowe@apple.com>
11897
11898         Reviewed by Simon Fraser.
11899
11900         Shuffle some code around in preparation for a change to how poseAsWebKitApp works.
11901
11902         * WebKitLauncher/WebKitNightlyEnabler.m:
11903         (systemVersion):
11904         (webKitLauncherBundle):
11905         (insideSafari4OnTigerTrampoline):
11906
11907 2009-06-30  Xan Lopez  <xlopez@igalia.com>
11908
11909         Reviewed by Jan Alonzo.
11910
11911         https://bugs.webkit.org/show_bug.cgi?id=26877
11912         [GTK] DRT fixes to pass new plugin test
11913
11914         Silence compiler warnings.
11915
11916         Newer GCC don't like using or returning a static string where a
11917         'char*' is expected. Ideally we'd change the function signatures
11918         to return or take 'const char*' I suppose, but since we can't do
11919         that just cast the strings to 'char*'.
11920
11921         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
11922         (webkit_test_plugin_get_value):
11923
11924 2009-06-30  Xan Lopez  <xlopez@igalia.com>
11925
11926         Reviewed by Jan Alonzo.
11927
11928         https://bugs.webkit.org/show_bug.cgi?id=26877
11929         [GTK] DRT fixes to pass new plugin test
11930
11931         Use the common pluginLog function instead of a local copy.
11932
11933         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
11934         (webkit_test_plugin_new_instance):
11935         (webkit_test_plugin_destroy_instance):
11936         (webkit_test_plugin_set_window):
11937         (webkit_test_plugin_handle_event):
11938
11939 2009-06-30  Xan Lopez  <xlopez@igalia.com>
11940
11941         Reviewed by Jan Alonzo.
11942
11943         https://bugs.webkit.org/show_bug.cgi?id=26877
11944         [GTK] DRT fixes to pass new plugin test
11945
11946         Modify our DRT as done in bug #15457 to log logSrc as src in order
11947         to pass test plugins/netscape-plugin-map-data-to-src.html.
11948
11949         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
11950         (webkit_test_plugin_new_instance):
11951
11952 2009-06-30  Adrien Nader  <camaradetux@gmail.com>
11953
11954         Reviewed by Jan Alonzo.
11955
11956         [GTK] GtkLauncher depends on gtk+2-2.15 because of gtk_orientable_set_orientation()
11957         https://bugs.webkit.org/show_bug.cgi?id=26835
11958
11959         * GtkLauncher/main.c:
11960         (create_toolbar):
11961
11962 2009-06-30  Eric Seidel  <eric@webkit.org>
11963
11964         Typo fix only, no review.
11965
11966         Fix typo causing failure during land-diff
11967
11968         * Scripts/bugzilla-tool:
11969
11970 2009-06-30  Simon Fraser  <simon.fraser@apple.com>
11971
11972         Reviewed by Dan Bernstein.
11973
11974         Fix drawing of view background in pixel snapshots when using compositing.
11975         We still need to call -displayIfNeeded to ensure that the NSView drawing
11976         has happened.
11977
11978         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
11979         (createBitmapContextFromWebView):
11980
11981 2009-06-30  Simon Fraser  <simon.fraser@apple.com>
11982
11983         Reviewed by Mark Rowe.
11984
11985         createBitmapContextFromWebView() incorrectly used #ifdef BUILDING_ON_LEOPARD,
11986         and thus failed on SnowLeopard.
11987
11988         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
11989         (createBitmapContextFromWebView):
11990
11991 2009-06-30  Eric Seidel  <eric@webkit.org>
11992
11993         Reviewed by Nikolas Zimmermann.
11994
11995         Make bugzilla tool print a message explaining how to get help on failure:
11996         https://bugs.webkit.org/show_bug.cgi?id=26861
11997
11998         % bugzilla-tool
11999         Usage: bugzilla-tool [options] command [command-options] [command-arguments]
12000
12001         bugzilla-tool: error: No command specified
12002
12003         Type 'bugzilla-tool --help' to see usage.
12004
12005         * Scripts/bugzilla-tool:
12006
12007 2009-06-30  Eric Seidel  <eric@webkit.org>
12008
12009         Reviewed by Maciej Stachowiak.
12010
12011         Include a built copy of BeautifulSoup 3.1.0.1 so that
12012         bugzilla-tool users do not need to install it manually.
12013         https://bugs.webkit.org/show_bug.cgi?id=26833
12014
12015         BeautifulSoup is BSD-licensed (thus WebKit compatible) and available from:
12016         http://www.crummy.com/software/BeautifulSoup
12017
12018         * Scripts/bugzilla-tool: fixed a typo in a log message.
12019         * Scripts/modules/BeautifulSoup.py: Added.
12020         * Scripts/modules/bugzilla.py:
12021
12022 2009-06-30  Eric Seidel  <eric@webkit.org>
12023
12024         Reviewed by Simon Hausmann.
12025
12026         Fix our create_patch handling to not
12027         hang when creating large patches.
12028         https://bugs.webkit.org/show_bug.cgi?id=26834
12029
12030         We're now using StringIO to make an in-memory buffer for the patch
12031         instead of piping from the patch command directly to the upload.
12032         The previous hang was caused by calling wait() when the process had already
12033         filed the stdout buffer.
12034
12035         * Scripts/modules/scm.py:
12036
12037 2009-06-29  Sam Weinig  <sam@webkit.org>
12038
12039         Reviewed by Mark Rowe.
12040
12041         Remove more unused scons support.
12042
12043         * Scripts/build-jsc:
12044         * Scripts/build-webkit:
12045         * Scripts/webkitdirs.pm:
12046
12047 2009-06-26  Eric Seidel  <eric@webkit.org>
12048
12049         Reviewed by David Levin.
12050
12051         Rename land-and-update to land-diff and make it awesome.
12052         https://bugs.webkit.org/show_bug.cgi?id=26734
12053
12054         Renamed land-and-update to land-diff
12055         Made the BUGID argument optional.
12056         Added optional support for building and testing before landing.
12057
12058         land-diff [options] [BUGID]    Lands the current working directory diff and updates the bug if provided.
12059           Options:
12060             -r REVIEWER, --reviewer=REVIEWER
12061                               Update ChangeLogs to say Reviewed by REVIEWER.
12062             --no-close        Leave bug open after landing.
12063             --no-build        Commit without building first, implies --no-test.
12064             --no-test         Commit without running run-webkit-tests.
12065
12066         * Scripts/bugzilla-tool:
12067
12068 2009-06-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
12069
12070         Gtk build fix - include stdarg.h for va_start/va_end.
12071
12072         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
12073
12074 2009-06-28  John Abd-El-Malek  <jam@chromium.org>
12075
12076         https://bugs.webkit.org/show_bug.cgi?id=15457
12077
12078         Modify NPAPI test plugin to verify that "src" paramater is added when
12079         it's missing but "data" is present.
12080
12081         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
12082         (pluginLog):
12083         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
12084         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
12085         (NPP_New):
12086         (NPP_Destroy):
12087         (NPP_SetWindow):
12088         (handleEventCarbon):
12089         (handleEventCocoa):
12090         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
12091         (NPP_New):
12092
12093 2009-06-27  Emilio Pozuelo Monfort  <pochu27@gmail.com>
12094
12095         Reviewed by Jan Alonzo.
12096
12097         [GTK] Don't use deprecated GTK+ symbols.
12098         https://bugs.webkit.org/show_bug.cgi?id=26583
12099
12100         * GtkLauncher/main.c:
12101         (create_toolbar):
12102
12103 2009-06-26  Adam Barth  <abarth@webkit.org>
12104
12105         Reviewed by Eric Seidel.
12106
12107         Make SVN work (again?).
12108
12109         * Scripts/modules/scm.py:
12110
12111 2009-06-26  Chris Fleizach  <cfleizach@apple.com>
12112
12113         Reviewed by Oliver Hunt.
12114
12115         Add ability to query isEnabled
12116
12117         * DumpRenderTree/AccessibilityUIElement.cpp:
12118         (getIsEnabledCallback):
12119         (AccessibilityUIElement::getJSClass):
12120         * DumpRenderTree/AccessibilityUIElement.h:
12121         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
12122         (AccessibilityUIElement::isEnabled):
12123         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
12124         (AccessibilityUIElement::isEnabled):
12125
12126 2009-06-26  Brady Eidson  <beidson@apple.com>
12127
12128         Reviewed by Sam Weinig
12129
12130         <rdar://problem/6961578> REGRESSION (r43511): Opening .fdf files from Acrobat Professional fails
12131
12132         Add a dumpResourceResponseMIMETypes() mode so the ResourceLoadDelegate will dump the mime type from
12133         the NSURLResponse.  Needed for the test for this bug fix.
12134
12135         * DumpRenderTree/LayoutTestController.cpp:
12136         (LayoutTestController::LayoutTestController):
12137         (dumpResourceResponseMIMETypesCallback):
12138         (LayoutTestController::staticFunctions):
12139         * DumpRenderTree/LayoutTestController.h:
12140         (LayoutTestController::dumpResourceResponseMIMETypes):
12141         (LayoutTestController::setDumpResourceResponseMIMETypes):
12142
12143         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
12144         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
12145
12146 2009-06-26  David Kilzer  <ddkilzer@apple.com>
12147
12148         Update build-dumprendertree to use buildXCodeProject()
12149
12150         Reviewed by Adam Roben.
12151
12152         * Scripts/build-dumprendertree: Updated to use
12153         buildXCodeProject() when building for isAppleMacWebKit().  This
12154         provides additional command-line switch parsing for free.  Also
12155         added --clean and --help switches.  Updated copyright.
12156
12157 2009-06-26  Eric Seidel  <eric@webkit.org>
12158
12159         Reviewed by Tor Arne Vestbø.
12160
12161         Remove non-sense --update option to land-patches
12162         and make land-patches update before every patch application.
12163         This makes it slightly less likely that multi-patch landings will fail.
12164
12165         Also updated git diff command to include staged modifications.
12166
12167         * Scripts/bugzilla-tool:
12168         * Scripts/modules/scm.py:
12169
12170 2009-06-25  Eric Seidel  <eric@webkit.org>
12171
12172         Reviewed by Jan Alonzo.
12173
12174         Fix obsolete_attachment to work when passed a comment.
12175         https://bugs.webkit.org/show_bug.cgi?id=26745
12176
12177         * Scripts/modules/bugzilla.py:
12178
12179 2009-06-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
12180
12181         Reviewed by Mark Rowe.
12182
12183         bugzilla-tool apply-patch throws exception in Linux
12184         https://bugs.webkit.org/show_bug.cgi?id=26738
12185
12186         HEAD is case-sensitive in Linux. Convert uses of head to HEAD in
12187         the scm module.
12188
12189         * Scripts/modules/scm.py:
12190
12191 2009-06-25  Eric Seidel  <eric@webkit.org>
12192
12193         Reviewed by Jan Alonzo.
12194
12195         bugzilla-tool post-diff needs to obsolete old patches before posting
12196         https://bugs.webkit.org/show_bug.cgi?id=26740
12197
12198         I've also added a --no-obsolete to disable this behavior.
12199
12200         I also finally updated the bug page parsing to use XML. So much less code!
12201
12202         * Scripts/bugzilla-tool:
12203         * Scripts/modules/bugzilla.py:
12204
12205 2009-06-25  Eric Seidel  <eric@webkit.org>
12206
12207         Reviewed by Mark Rowe.
12208
12209         Call WebKitTools/Scripts scripts by their absolute paths
12210         https://bugs.webkit.org/show_bug.cgi?id=26704
12211
12212         bugzilla-tool used to use whatever build-webkit was in your path.
12213         That could end up building the wrong copy of WebKit.
12214
12215         * Scripts/bugzilla-tool:
12216         * Scripts/modules/scm.py:
12217
12218 2009-06-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
12219
12220         Reviewed by Dave Levin.
12221
12222         Use unicode() instead of str when reading from bugzilla.
12223         Also add Simon Fraser as a reviewer.
12224         https://bugs.webkit.org/show_bug.cgi?id=26719
12225
12226         * Scripts/modules/bugzilla.py:
12227
12228 2009-06-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
12229
12230         Reviewed by Simon Hausmann.
12231
12232         Use Q_ASSERT in Qt's DumpRenderTree instead of JSC's ASSERT
12233
12234         The WTFReportAssertionFailure function in JSC is not exported when
12235         building QtWebKit in both debug and release on Mac, so DRT fails to
12236         link.
12237
12238         We can revert this patch once the Qt port builds JSC as a separate
12239         library, and we add the proper export macros to Assertions.cpp
12240
12241         * DumpRenderTree/qt/WorkQueue.cpp:
12242         (WorkQueue::queue):
12243         (WorkQueue::dequeue):
12244
12245 2009-06-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
12246
12247         Reviewed by Jan Alonzo.
12248
12249         bugzilla-tool: Add Simon Hausmann as reviewer
12250
12251         * Scripts/modules/bugzilla.py:
12252
12253 2009-06-24  Eric Seidel  <eric@webkit.org>
12254
12255         Reviewed by Dave Levin.
12256
12257         Support local commits during apply-patches
12258         and let land-patches take multiple bug ids.
12259         https://bugs.webkit.org/show_bug.cgi?id=26703
12260
12261         I also restructured parts of land-patches into
12262         class methods and static methods in preparation
12263         for future code sharing with other commands.
12264
12265         * Scripts/bugzilla-tool:
12266         * Scripts/modules/bugzilla.py:
12267         * Scripts/modules/scm.py:
12268
12269 2009-06-25  Eric Seidel  <eric@webkit.org>
12270
12271         Reviewed by Tor Arne Vestbø.
12272
12273         Make svn-apply work with Git too
12274         https://bugs.webkit.org/show_bug.cgi?id=26299
12275
12276         Add an --force option to svn-apply and otherwise make svn-apply
12277         exit non-zero when patch application fails.
12278         https://bugs.webkit.org/show_bug.cgi?id=26300
12279
12280         I did not update svn-unapply, because it makes no sense in a Git world.
12281         You don't roll in and out patch files.  You make commits and deal with those.
12282         Git users can just git reset --hard to get the same functionality.
12283
12284         * Scripts/svn-apply:
12285
12286 2009-06-25  Eric Seidel  <eric@webkit.org>
12287
12288         Reviewed by Tor Arne Vestbø.
12289
12290         Remove use of os.system to fix reviewers with unicode chars in their names
12291         https://bugs.webkit.org/show_bug.cgi?id=26713
12292
12293         Also change to latin1 encoding of ø to make python happy.
12294
12295         * Scripts/modules/bugzilla.py:
12296         * Scripts/modules/scm.py:
12297
12298 2009-06-25  Eric Seidel  <eric@webkit.org>
12299
12300         Reviewed by Tor Arne Vestbø.
12301
12302         Add Adam Roben and Tor Arne Vestbø to the reviewers list.
12303
12304         * Scripts/modules/bugzilla.py:
12305
12306 2009-06-24  Chris Fleizach  <cfleizach@apple.com>
12307
12308         Windows build fix.
12309
12310         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
12311         (AccessibilityUIElement::language):
12312
12313 2009-06-24  Chris Fleizach  <cfleizach@apple.com>
12314
12315         Reviewed by Oliver Hunt.
12316
12317         Bug 26668: AX: need a way to retrieve the language for an element
12318         Support ability to retrieve AXLanguage for testing
12319
12320         * DumpRenderTree/AccessibilityUIElement.cpp:
12321         (getLanguageCallback):
12322         (AccessibilityUIElement::getJSClass):
12323         * DumpRenderTree/AccessibilityUIElement.h:
12324         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
12325         (AccessibilityUIElement::language):
12326
12327 2009-06-24  Eric Seidel  <eric@webkit.org>
12328
12329         Reviewed by Maciej Stachowiak.
12330
12331         Spell Maciej's name right and add Brady Eidson.
12332
12333         * Scripts/modules/bugzilla.py:
12334
12335 2009-06-23  Eric Seidel  <eric@webkit.org>
12336
12337         Reviewed by Dave Levin.
12338
12339         Fix missing comment message during land-patches and SVN.commit_with_message respecting --dry-run
12340         https://bugs.webkit.org/show_bug.cgi?id=26669
12341
12342         * Scripts/bugzilla-tool:
12343         * Scripts/modules/scm.py:
12344
12345 2009-06-23  Takeshi Yoshino  <tyoshino@google.com>
12346
12347         Reviewed by Mark Rowe.
12348
12349         Bug 26537: Builds from command-line fail if custom build product directory is set and ~/Library/Preferences/xcodebuild.plist exists
12350         https://bugs.webkit.org/show_bug.cgi?id=26537
12351
12352         Let determineBaseProductDir subroutine remove
12353         ~/Library/Preferences/xcodebuild.plist. It can prevent xcodebuild from
12354         respecting global settings such as a custom build products directory
12355         (<rdar://problem/5585899>).
12356
12357         * Scripts/webkitdirs.pm:
12358
12359 2009-06-23  Eric Seidel  <eric@webkit.org>
12360
12361         Reviewed by Dave Levin.
12362
12363         Make SCM.run_command smarter, and make all previous
12364         os.system and subprocess.popen use SCM.run_command instead.
12365         https://bugs.webkit.org/show_bug.cgi?id=26666
12366
12367         This makes it easier to handle errors in a standard way throughout all the code.
12368         Since this new code raises by default when the exit_code != 0,
12369         we should prevent future problems of bugzilla-tool continuing after
12370         a git or svn command failed.
12371
12372         * Scripts/modules/scm.py:
12373
12374 2009-06-23  Joe Mason  <joe.mason@torchmobile.com>
12375
12376         Reviewed by Adam Treat.
12377
12378         https://bugs.webkit.org/show_bug.cgi?id=26664
12379         * Scripts/prepare-ChangeLog: Added --git-index mode to list only the
12380         changes which are already staged in the index.  Useful to create an
12381         entry for what you're about to commit while ignoring unstaged changes.
12382
12383 2009-06-23  Anders Carlsson  <andersca@apple.com>
12384
12385         Reviewed by Darin Adler.
12386
12387         Update for WebKit changes.
12388
12389         * DumpRenderTree/win/UIDelegate.h:
12390         (UIDelegate::willPerformDragSourceAction):
12391
12392 2009-06-23  Eric Seidel  <eric@webkit.org>
12393
12394         Reviewed by Mark Rowe.
12395
12396         * Scripts/modules/scm.py: Fix commit_with_message to return the commit output.
12397
12398 2009-06-23  Eric Seidel  <eric@webkit.org>
12399
12400         Reviewed by Mark Rowe.
12401
12402         * Scripts/modules/scm.py: Fix error seen when commiting r44979.
12403
12404 2009-06-18  Eric Seidel  <eric@webkit.org>
12405
12406         Reviewed by Dave Levin.
12407
12408         WebKit needs a script to interact with bugzilla and automate
12409         parts of the patch posting and commit processes.
12410         https://bugs.webkit.org/show_bug.cgi?id=26283
12411
12412         This is really a first-draft tool.
12413         It's to the point where it's useful to more people than just me now though.
12414         Git support works.  SVN support is written, but mostly untested.
12415
12416         This tool requires BeautifulSoup and mechanize python modules to run:
12417         sudo easy_install BeautifulSoup
12418         sudo easy_install mechanize
12419
12420         More important than the tool itself are the Bugzilla, Git and SVN class abstractions
12421         which I hope will allow easy writing of future tools.
12422
12423         The tool currently implements 10 commands, described below.
12424
12425         Helpers for scripting dealing with the commit queue:
12426         bugs-to-commit                 Bugs in the commit queue
12427         patches-to-commit              Patches attached to bugs in the commit queue
12428
12429         Dealing with bugzilla:
12430         reviewed-patches BUGID         r+'d patches on a bug
12431         apply-patches BUGID            Applies all patches on a bug to the local working directory without committing.
12432         land-and-update BUGID          Lands the current working directory diff and updates the bug.
12433         land-patches [options] BUGID   Lands all patches on a bug optionally testing them first
12434         obsolete-attachments BUGID     Marks all attachments on a bug as obsolete.
12435         commit-message                 Prints a commit message suitable for the uncommitted changes.
12436
12437         These effectively replace git-send-bugzilla:
12438         post-diff BUGID                Attaches the current working directory diff to a bug as a patch file.
12439         post-commits BUGID COMMITISH   Attaches a range of local commits to a bug as patch files.
12440
12441         post-diff works for SVN and Git, post-commits only works for SCMs with local-commit support (like Git)
12442
12443         land-* commands in a Git environment only work with simple patches due to svn-apply bugs:
12444         https://bugs.webkit.org/show_bug.cgi?id=26299
12445         https://bugs.webkit.org/show_bug.cgi?id=26300
12446
12447         This script follows python style (similar to how for Obj-C we follow AppKit style)
12448         http://www.python.org/doc/essays/styleguide.html
12449         The Python community has a strong style culture and the WebKit style guide is silent re: Python.
12450
12451         I've filed a bug to update the WebKit style guide to mention python:
12452         https://bugs.webkit.org/show_bug.cgi?id=26524
12453
12454         * Scripts/bugzilla-tool: Added.
12455
12456 2009-06-22  Steve Falkenburg  <sfalken@apple.com>
12457
12458         Remove errant line of code mistakenly checked in.
12459
12460         * DumpRenderTree/win/DumpRenderTree.cpp:
12461         (main):
12462
12463 2009-06-22  Steve Falkenburg  <sfalken@apple.com>
12464
12465         Pass correct value to setShouldPaintNativeControls.
12466
12467         Rubber stamped by Mark Rowe.
12468
12469         * DumpRenderTree/win/DumpRenderTree.cpp:
12470         (main):
12471
12472 2009-06-22  Steve Falkenburg  <sfalken@apple.com>
12473
12474         Fix last DumpRenderTree change to correctly set preferences flag without crashing.
12475
12476         Reviewed by Mark Rowe.
12477
12478         * DumpRenderTree/win/DumpRenderTree.cpp:
12479         (main):
12480
12481 2009-06-21  Steve Falkenburg  <sfalken@apple.com>
12482
12483         Set up global native controls flag before creating the first WebView.
12484
12485         Reviewed by Darin Adler.
12486
12487         * DumpRenderTree/win/DumpRenderTree.cpp:
12488         (main):
12489
12490 2009-06-21  Mark Rowe  <mrowe@apple.com>
12491
12492         Reviewed by Sam Weinig.
12493
12494         Set a sensible user agent string for the HTTP requests that Sparkle makes (checking for and downloading updates).
12495
12496         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
12497         (userAgentStringForSparkle):
12498         (initializeSparkle):
12499
12500 2009-06-21  Mark Rowe  <mrowe@apple.com>
12501
12502         Reviewed by Sam Weinig.
12503
12504         Add a hook to the WebKit launcher application to allow a link on the nightly build start page to
12505         trigger an update via the built-in software update mechanism.
12506
12507         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
12508         * WebKitLauncher/WebKitLauncherURLProtocol.h: Added.
12509         * WebKitLauncher/WebKitLauncherURLProtocol.m: Added.
12510         (+[WebKitLauncherURLProtocol load]):
12511         (+[WebKitLauncherURLProtocol canInitWithRequest:]): Only allow use of the x-webkit-launcher scheme from .webkit.org subdomains.
12512         (+[WebKitLauncherURLProtocol canonicalRequestForRequest:]):
12513         (-[WebKitLauncherURLProtocol startLoading]):
12514         (-[WebKitLauncherURLProtocol stopLoading]):
12515         (-[WebKitLauncherURLProtocol handleIsWebKitLauncherAvailableJS]): Return a brief JavaScript snippet that can be used to programatically
12516         determine whether the x-webkit-launcher is available and working.
12517         (-[WebKitLauncherURLProtocol handleCheckForUpdates]): Trigger a software update on the main thread.
12518         (-[WebKitLauncherURLProtocol resourceNotFound]): Fail with a generic "File does not exist" error.
12519
12520 2009-06-20  Jan Michael Alonzo  <jmalonzo@webkit.org>
12521
12522         Reviewed by Gustavo Noronha and Xan Lopez.
12523
12524         [Gtk] Implement DRT XSS auditor support
12525         https://bugs.webkit.org/show_bug.cgi?id=26571
12526
12527         * DumpRenderTree/gtk/DumpRenderTree.cpp:
12528         (resetWebViewToConsistentStateBeforeTesting):
12529         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
12530         (LayoutTestController::setXSSAuditorEnabled):
12531
12532 2009-06-19  Darin Adler  <darin@apple.com>
12533
12534         * Scripts/do-webcore-rename: More renaming ideas.
12535
12536 2009-06-15  Andre Pedralho  <andre.pedralho@openbossa.org>
12537
12538         Reviewed by Tor Arne Vestbø.
12539
12540         Only pass --makeargs along if an argument is given.
12541
12542         * Scripts/build-webkit:
12543
12544 2009-06-19  Adam Barth  <abarth@webkit.org>
12545
12546         Unreviewed attempt to fix Windows build.
12547
12548         * DumpRenderTree/win/DumpRenderTree.cpp:
12549         (resetWebViewToConsistentStateBeforeTesting):
12550         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
12551         (LayoutTestController::setXSSAuditorEnabled):
12552
12553 2009-06-18  Adam Barth  <abarth@webkit.org>
12554
12555         Reviewed by Sam Weinig.
12556
12557         https://bugs.webkit.org/show_bug.cgi?id=26199
12558
12559         Add support for testing the XSSAuditor.
12560
12561         * DumpRenderTree/LayoutTestController.cpp:
12562         (setXSSAuditorEnabledCallback):
12563         (LayoutTestController::staticFunctions):
12564         * DumpRenderTree/LayoutTestController.h:
12565         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
12566         (LayoutTestController::setXSSAuditorEnabled):
12567         * DumpRenderTree/mac/DumpRenderTree.mm:
12568         (resetWebViewToConsistentStateBeforeTesting):
12569         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
12570         (LayoutTestController::setXSSAuditorEnabled):
12571         * DumpRenderTree/win/DumpRenderTree.cpp:
12572         (resetWebViewToConsistentStateBeforeTesting):
12573         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
12574         (LayoutTestController::setXSSAuditorEnabled):
12575         (LayoutTestController::setPopupBlockingEnabled):
12576         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
12577         (LayoutTestController::setXSSAuditorEnabled):
12578
12579 2009-06-18  Darin Adler  <darin@apple.com>
12580
12581         Rubber stamped by Mark Rowe.
12582
12583         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
12584         (-[DumpRenderTreeWindow close]): Resolved crashes seen during regression
12585         tests. The close method can be called on a window that's already closed
12586         so we can't assert here.
12587
12588 2009-06-17  Steve Falkenburg  <sfalken@apple.com>
12589
12590         Updated for consolidated WebKit COM interfaces.
12591
12592         Reviewed by Adam Roben.
12593
12594         * DumpRenderTree/win/FrameLoadDelegate.cpp:
12595         * DumpRenderTree/win/FrameLoadDelegate.h:
12596         * DumpRenderTree/win/UIDelegate.cpp:
12597         * DumpRenderTree/win/UIDelegate.h:
12598         * WinLauncher/WinLauncher.h:
12599
12600 2009-06-16  Adam Barth  <abarth@webkit.org>
12601
12602         Reviewed by Darin Adler.
12603
12604         https://bugs.webkit.org/show_bug.cgi?id=26437
12605
12606         Make the commit-log-editor match the ambient line endings in commit
12607         messages.
12608
12609         * Scripts/commit-log-editor:
12610
12611 2009-06-16  Xan Lopez  <xlopez@igalia.com>
12612
12613         Reviewed by Gustavo Noronha.
12614
12615         Update GtkLauncher to recent API changes in the progress property,
12616         which now goes from 0.0 to 1.0.
12617
12618         * GtkLauncher/main.c:
12619
12620 2009-06-16  Adam Barth  <abarth@webkit.org>
12621
12622         Reviewed by Darin Adler.
12623
12624         https://bugs.webkit.org/show_bug.cgi?id=26000
12625
12626         Teach prepare-ChangeLog to match the line ends that are already present
12627         in ChangeLog files.  This helps folks whose use cygwin perl with CR LF
12628         line endings on Windows.
12629
12630         Also, teach prepare-ChangeLog to normalize backslashes in paths.  This
12631         helps folks who use Windows SVN prepare correct ChangeLogs.
12632
12633         * Scripts/prepare-ChangeLog:
12634
12635 == Rolled over to ChangeLog-2009-06-16 ==