Release 20040914.
[wine/gsoc-2012-control.git] / tools / winedump / output.c
blob5b6aff3d7cf08c4bbce082809541229aa3cb6db9
1 /*
2 * Code generation functions
4 * Copyright 2000-2002 Jon Griffiths
6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Lesser General Public
8 * License as published by the Free Software Foundation; either
9 * version 2.1 of the License, or (at your option) any later version.
11 * This library is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 * Lesser General Public License for more details.
16 * You should have received a copy of the GNU Lesser General Public
17 * License along with this library; if not, write to the Free Software
18 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
21 #include "config.h"
22 #include "wine/port.h"
24 #include "winedump.h"
26 /* Output files */
27 static FILE *specfile = NULL;
28 static FILE *hfile = NULL;
29 static FILE *cfile = NULL;
31 static void output_spec_postamble (void);
32 static void output_header_postamble (void);
33 static void output_c_postamble (void);
34 static void output_c_banner (const parsed_symbol *sym);
35 static const char *get_format_str (int type);
36 static const char *get_in_or_out (const parsed_symbol *sym, size_t arg);
39 /*******************************************************************
40 * output_spec_preamble
42 * Write the first part of the .spec file
44 void output_spec_preamble (void)
46 specfile = open_file (OUTPUT_DLL_NAME, ".spec", "w");
48 atexit (output_spec_postamble);
50 if (VERBOSE)
51 puts ("Creating .spec preamble");
53 fprintf (specfile,
54 "# Generated from %s by winedump\n\n", globals.input_name);
58 /*******************************************************************
59 * output_spec_symbol
61 * Write a symbol to the .spec file
63 void output_spec_symbol (const parsed_symbol *sym)
65 char ord_spec[16];
67 assert (specfile);
68 assert (sym && sym->symbol);
70 if (sym->ordinal >= 0)
71 snprintf(ord_spec, 8, "%d", sym->ordinal);
72 else
74 ord_spec[0] = '@';
75 ord_spec[1] = '\0';
77 if (sym->flags & SYM_THISCALL)
78 strcat (ord_spec, " -i386"); /* For binary compatibility only */
80 if (!globals.do_code || !sym->function_name)
82 if (sym->flags & SYM_DATA)
84 if (globals.forward_dll)
85 fprintf (specfile, "%s forward %s %s.%s #", ord_spec, sym->symbol,
86 globals.forward_dll, sym->symbol);
88 fprintf (specfile, "%s extern %s %s\n", ord_spec, sym->symbol,
89 sym->arg_name[0]);
90 return;
93 if (globals.forward_dll)
94 fprintf (specfile, "%s forward %s %s.%s\n", ord_spec, sym->symbol,
95 globals.forward_dll, sym->symbol);
96 else
97 fprintf (specfile, "%s stub %s\n", ord_spec, sym->symbol);
99 else
101 unsigned int i = sym->flags & SYM_THISCALL ? 1 : 0;
103 fprintf (specfile, "%s %s %s(", ord_spec, sym->varargs ? "varargs" :
104 symbol_get_call_convention(sym), sym->symbol);
106 for (; i < sym->argc; i++)
107 fprintf (specfile, " %s", symbol_get_spec_type(sym, i));
109 if (sym->argc)
110 fputc (' ', specfile);
111 fprintf (specfile, ") %s_%s", OUTPUT_UC_DLL_NAME, sym->function_name);
113 if (sym->flags & SYM_THISCALL)
114 fputs (" # __thiscall", specfile);
116 fputc ('\n',specfile);
121 /*******************************************************************
122 * output_spec_postamble
124 * Write the last part of the .spec file
126 static void output_spec_postamble (void)
128 if (specfile)
129 fclose (specfile);
130 specfile = NULL;
134 /*******************************************************************
135 * output_header_preamble
137 * Write the first part of the .h file
139 void output_header_preamble (void)
141 hfile = open_file (OUTPUT_DLL_NAME, "_dll.h", "w");
143 atexit (output_header_postamble);
145 fprintf (hfile,
146 "/*\n * %s.dll\n *\n * Generated from %s.dll by winedump.\n *\n"
147 " * DO NOT SEND GENERATED DLLS FOR INCLUSION INTO WINE !\n * \n */"
148 "\n#ifndef __WINE_%s_DLL_H\n#define __WINE_%s_DLL_H\n\n#include "
149 "\"config.h\"\n#include \"windef.h\"\n#include \"wine/debug.h\"\n"
150 "#include \"winbase.h\"\n#include \"winnt.h\"\n\n\n",
151 OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_UC_DLL_NAME,
152 OUTPUT_UC_DLL_NAME);
156 /*******************************************************************
157 * output_header_symbol
159 * Write a symbol to the .h file
161 void output_header_symbol (const parsed_symbol *sym)
163 assert (hfile);
164 assert (sym && sym->symbol);
166 if (!globals.do_code)
167 return;
169 if (sym->flags & SYM_DATA)
170 return;
172 if (!sym->function_name)
173 fprintf (hfile, "/* __%s %s_%s(); */\n", symbol_get_call_convention(sym),
174 OUTPUT_UC_DLL_NAME, sym->symbol);
175 else
177 output_prototype (hfile, sym);
178 fputs (";\n", hfile);
183 /*******************************************************************
184 * output_header_postamble
186 * Write the last part of the .h file
188 static void output_header_postamble (void)
190 if (hfile)
192 fprintf (hfile, "\n\n\n#endif\t/* __WINE_%s_DLL_H */\n",
193 OUTPUT_UC_DLL_NAME);
194 fclose (hfile);
195 hfile = NULL;
200 /*******************************************************************
201 * output_c_preamble
203 * Write the first part of the .c file
205 void output_c_preamble (void)
207 cfile = open_file (OUTPUT_DLL_NAME, "_main.c", "w");
209 atexit (output_c_postamble);
211 fprintf (cfile,
212 "/*\n * %s.dll\n *\n * Generated from %s by winedump.\n *\n"
213 " * DO NOT SUBMIT GENERATED DLLS FOR INCLUSION INTO WINE!\n * \n */"
214 "\n\n#include \"%s_dll.h\"\n\nWINE_DEFAULT_DEBUG_CHANNEL(%s);\n\n",
215 OUTPUT_DLL_NAME, globals.input_name, OUTPUT_DLL_NAME,
216 OUTPUT_DLL_NAME);
218 if (globals.forward_dll)
220 if (VERBOSE)
221 puts ("Creating a forwarding DLL");
223 fputs ("\nHMODULE hDLL=0;\t/* DLL to call */\n\n", cfile);
226 fputs ("#ifdef __i386__\n#define GET_THIS(t,p) t p;\\\n__asm__ __volatile__"
227 " (\"movl %%ecx, %0\" : \"=m\" (p))\n#endif\n\n\n", cfile);
229 fprintf (cfile,
230 "BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID "
231 "lpvReserved)\n{\n\tTRACE(\"(0x%%p, %%ld, %%p)\\n\",hinstDLL,"
232 "fdwReason,lpvReserved);\n\n\t"
233 "if (fdwReason == DLL_PROCESS_ATTACH)\n\t{\n\t\t");
235 if (globals.forward_dll)
237 fprintf (cfile,
238 "hDLL = LoadLibraryA( \"%s\" );\n\t\t"
239 "TRACE(\":Forwarding DLL (%s) loaded (%%ld)\\n\",(LONG)hDLL);",
240 globals.forward_dll, globals.forward_dll);
242 else
243 fputs ("/* FIXME: Initialisation */", cfile);
245 fputs ("\n\t}\n\telse if (fdwReason == DLL_PROCESS_DETACH)\n\t{\n\t\t",
246 cfile);
248 if (globals.forward_dll)
250 fprintf (cfile,
251 "FreeLibrary( hDLL );\n\t\tTRACE(\":Forwarding DLL (%s)"
252 " freed\\n\");", globals.forward_dll);
254 else
255 fputs ("/* FIXME: Cleanup */", cfile);
257 fputs ("\n\t}\n\n\treturn TRUE;\n}\n\n\n", cfile);
261 #define CPP_END if (sym->flags & SYM_THISCALL) \
262 fputs ("#endif\n", cfile); fputs ("\n\n", cfile)
263 #define GET_THIS if (sym->flags & SYM_THISCALL) \
264 fprintf (cfile, "\tGET_THIS(%s,%s);\n", sym->arg_text[0],sym->arg_name[0])
266 /*******************************************************************
267 * output_c_symbol
269 * Write a symbol to the .c file
271 void output_c_symbol (const parsed_symbol *sym)
273 unsigned int i, start = sym->flags & SYM_THISCALL ? 1 : 0;
274 int is_void;
276 assert (cfile);
277 assert (sym && sym->symbol);
279 if (!globals.do_code)
280 return;
282 if (sym->flags & SYM_DATA)
284 fprintf (cfile, "/* FIXME: Move to top of file */\n%s;\n\n",
285 sym->arg_text[0]);
286 return;
289 if (sym->flags & SYM_THISCALL)
290 fputs ("#ifdef __i386__\n", cfile);
292 output_c_banner(sym);
294 if (!sym->function_name)
296 /* #ifdef'd dummy */
297 fprintf (cfile, "#if 0\n__%s %s_%s()\n{\n\t/* %s in .spec */\n}\n#endif\n",
298 symbol_get_call_convention(sym), OUTPUT_UC_DLL_NAME, sym->symbol,
299 globals.forward_dll ? "@forward" : "@stub");
300 CPP_END;
301 return;
304 is_void = !strcmp (sym->return_text, "void");
306 output_prototype (cfile, sym);
307 fputs ("\n{\n", cfile);
309 if (!globals.do_trace)
311 GET_THIS;
312 fputs ("\tFIXME(\":stub\\n\");\n", cfile);
313 if (!is_void)
314 fprintf (cfile, "\treturn (%s) 0;\n", sym->return_text);
315 fputs ("}\n", cfile);
316 CPP_END;
317 return;
320 /* Tracing, maybe forwarding as well */
321 if (globals.forward_dll)
323 /* Write variables for calling */
324 if (sym->varargs)
325 fputs("\tva_list valist;\n", cfile);
327 fprintf (cfile, "\t%s (__%s *pFunc)(", sym->return_text,
328 symbol_get_call_convention(sym));
330 for (i = start; i < sym->argc; i++)
331 fprintf (cfile, "%s%s", i > start ? ", " : "", sym->arg_text [i]);
333 fprintf (cfile, "%s);\n", sym->varargs ? ",..." : sym->argc == 1 &&
334 sym->flags & SYM_THISCALL ? "" : sym->argc ? "" : "void");
336 if (!is_void)
337 fprintf (cfile, "\t%s retVal;\n", sym->return_text);
339 GET_THIS;
341 fprintf (cfile, "\tpFunc=(void*)GetProcAddress(hDLL,\"%s\");\n",
342 sym->symbol);
345 /* TRACE input arguments */
346 fprintf (cfile, "\tTRACE(\"(%s", !sym->argc ? "void" : "");
348 for (i = 0; i < sym->argc; i++)
349 fprintf (cfile, "%s(%s)%s", i ? "," : "", sym->arg_text [i],
350 get_format_str (sym->arg_type [i]));
352 fprintf (cfile, "%s): %s\\n\"", sym->varargs ? ",..." : "",
353 globals.forward_dll ? "forward" : "stub");
355 for (i = 0; i < sym->argc; i++)
356 if (sym->arg_type[i] != ARG_STRUCT)
357 fprintf(cfile, ",%s%s%s%s", sym->arg_type[i] == ARG_LONG ? "(LONG)" : "",
358 sym->arg_type[i] == ARG_WIDE_STRING ? "debugstr_w(" : "",
359 sym->arg_name[i],
360 sym->arg_type[i] == ARG_WIDE_STRING ? ")" : "");
362 fputs (");\n", cfile);
364 if (!globals.forward_dll)
366 if (!is_void)
367 fprintf (cfile, "\treturn (%s) 0;\n", sym->return_text);
368 fputs ("}\n", cfile);
369 CPP_END;
370 return;
373 /* Call the DLL */
374 if (sym->varargs)
375 fprintf (cfile, "\tva_start(valist,%s);\n", sym->arg_name[sym->argc-1]);
377 fprintf (cfile, "\t%spFunc(", !is_void ? "retVal = " : "");
379 for (i = 0; i < sym->argc; i++)
380 fprintf (cfile, "%s%s", i ? "," : "", sym->arg_name [i]);
382 fputs (sym->varargs ? ",valist);\n\tva_end(valist);" : ");", cfile);
384 /* TRACE return value */
385 fprintf (cfile, "\n\tTRACE(\"Returned (%s)\\n\"",
386 get_format_str (sym->return_type));
388 if (!is_void)
390 if (sym->return_type == ARG_WIDE_STRING)
391 fputs (",debugstr_w(retVal)", cfile);
392 else
393 fprintf (cfile, ",%s%s", sym->return_type == ARG_LONG ? "(LONG)" : "",
394 sym->return_type == ARG_STRUCT ? "" : "retVal");
395 fputs (");\n\treturn retVal;\n", cfile);
397 else
398 fputs (");\n", cfile);
400 fputs ("}\n", cfile);
401 CPP_END;
405 /*******************************************************************
406 * output_c_postamble
408 * Write the last part of the .c file
410 static void output_c_postamble (void)
412 if (cfile)
413 fclose (cfile);
414 cfile = NULL;
418 /*******************************************************************
419 * output_makefile
421 * Write a Wine compatible makefile.in
423 void output_makefile (void)
425 FILE *makefile = open_file ("Makefile", ".in", "w");
427 if (VERBOSE)
428 puts ("Creating makefile");
430 fprintf (makefile,
431 "# Generated from %s by winedump.\nTOPSRCDIR = @top_srcdir@\n"
432 "TOPOBJDIR = ../..\nSRCDIR = @srcdir@\nVPATH = @srcdir@\n"
433 "MODULE = %s.dll\n", globals.input_name, OUTPUT_DLL_NAME);
435 fprintf (makefile, "IMPORTS = kernel32");
436 if (globals.forward_dll)
437 fprintf (makefile, " %s", globals.forward_dll);
439 fprintf (makefile,
440 "\n\nC_SRCS = \\\n\t%s_main.c\n\n@MAKE_DLL_RULES@\n\n### Dependencies:",
441 OUTPUT_DLL_NAME);
443 if (globals.forward_dll)
444 fprintf (specfile,"#import %s.dll\n", globals.forward_dll);
446 fclose (makefile);
450 /*******************************************************************
451 * output_install_script
453 * Write a script to insert the DLL into Wine
455 * Rather than using diff/patch, several sed calls are generated
456 * so the script can be re-run at any time without breaking.
458 void output_install_script (void)
460 char cmd[128];
461 FILE *install_file = open_file (OUTPUT_DLL_NAME, "_install", "w");
463 if (VERBOSE)
464 puts ("Creating install script");
466 fprintf (install_file,
467 "#!/bin/bash\n"
468 "# Generated from %s.dll by winedump.\n\n"
469 "if [ $# -ne 1 ] || [ ! -d $1 ] || [ ! -f $1/AUTHORS ]; then\n"
470 "\t[ $# -eq 1 ] && echo \"Invalid path\"\n"
471 "\techo \"Usage: $0 wine-base-dir\"\n"
472 "\texit 1\n"
473 "fi\n\n"
474 "if [ -d $1/dlls/%s ]; then\n"
475 "\techo \"DLL is already present\"\n"
476 "\texit 1\n"
477 "fi\n\n"
478 "echo Adding DLL %s to Wine build tree...\n\n"
479 "mkdir $1/dlls/%s\n"
480 "cp %s.spec $1/dlls/%s\n"
481 "cp %s_main.c $1/dlls/%s\n"
482 "cp %s_dll.h $1/dlls/%s\n"
483 "cp Makefile.in $1/dlls/%s/Makefile.in\n"
484 "echo Copied DLL files\n\n"
485 "cd $1\n\n"
486 "sed '/dlls\\/x11drv\\/Makefile/"
487 "{G;s/$/dlls\\/%s\\/Makefile/;}' configure.ac >t.tmp\n"
488 "mv -f t.tmp configure.ac\n"
489 "echo Patched configure.ac\n\n"
490 "sed '/^SYMLINKS =/{G;s/$/"
491 "\\^%s.dll$(DLLEXT) \\\\/;}' dlls/Makefile.in| tr ^ \\\\t >t.tmp\n"
492 "sed '/BASEDIRS =/{G;s/$/\\^%s \\\\/;}' t.tmp | tr ^ \\\\t >t.tmp2\n"
493 "sed '/Map symlink name /{G;s/$/^\\$(RM) \\$\\@ \\&\\& \\$\\"
494 "(LN_S\\) %s\\/%s.dll\\$(DLLEXT) \\$\\@/;}' t.tmp2 | tr ^ \\\\t"
495 " > t.tmp\n"
496 "sed '/Map symlink name /{G;s/$/%s.dll\\$(DLLEXT): "
497 "%s\\/%s.dll\\$(DLLEXT)/;}' t.tmp > t.tmp2\n"
498 "sed '/all dependencies/"
499 "{G;s/$/%s\\/__install__: %s.dll$(DLLEXT)/;}' t.tmp2 > t.tmp\n"
500 "sed '/dll dependencies/{G;s/$/%s: user32.dll\\$(DLLEXT) "
501 "kernel32.dll\\$(DLLEXT) ntdll.dll\\$(DLLEXT) advapi32.dll"
502 "\\$(DLLEXT)/;}' t.tmp > t.tmp2\n"
503 "sed '/^IMPORT_LIBS =/{G;s/$/\\^lib%s \\\\/;}' t.tmp2| tr ^ \\\\t >t.tmp\n"
504 "sed '/^x11drv\\/x11drv.spec.def\\: $(WINEBUILD)/"
505 "{G;s/$/%s\\/%s.spec.def: $(WINEBUILD)/;}' t.tmp >t.tmp2\n"
506 "sed '/^$(DLLTOOL) -k -l $@ -d x11drv/"
507 "{G;s/$/lib%s.def: %s\\/%s.spec.def/;}' t.tmp2 >t.tmp\n"
508 "sed '/^$(DLLTOOL) -k -l $@ -d x11drv/{G;s/$/\\^$(RM) $@ && $(LN_S) "
509 "%s\\/%s.spec.def $@/;}' t.tmp| tr ^ \\\\t >t.tmp2\n"
510 "sed '/^$(DLLTOOL) -k -l $@ -d x11drv/"
511 "{G;s/$/lib%s.a: %s\\/%s.spec.def/;}' t.tmp2 >t.tmp\n"
512 "sed '/^$(DLLTOOL) -k -l $@ -d x11drv/"
513 "{G;s/$/\\^$(DLLTOOL) -k -l $@ -d %s\\/%s.spec.def/;}' t.tmp| tr ^ \\\\t >t.tmp2\n"
514 "sed '/Map library name /{G;s/$/%s\\/%s.dll\\$(DLLEXT): %s/;}' t.tmp2 >t.tmp\n"
515 "mv -f t.tmp dlls/Makefile.in\n"
516 "rm -f t.tmp2\n"
517 "echo Patched dlls/Makefile.in\n\n"
518 "echo Run \\'autoconf\\', \\'./configure\\' then \\'make\\' to rebuild Wine\n\n",
519 OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME,
520 OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME,
521 OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME,
522 OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME,
523 OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME,
524 OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME,
525 OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME,
526 OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME,
527 OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME, OUTPUT_DLL_NAME,
528 OUTPUT_DLL_NAME, OUTPUT_DLL_NAME);
530 fclose (install_file);
531 snprintf (cmd, sizeof (cmd), "chmod a+x %s_install", OUTPUT_DLL_NAME);
532 system (cmd);
536 /*******************************************************************
537 * output_prototype
539 * Write a C prototype for a parsed symbol
541 void output_prototype (FILE *file, const parsed_symbol *sym)
543 unsigned int i, start = sym->flags & SYM_THISCALL ? 1 : 0;
545 fprintf (file, "%s __%s %s_%s(", sym->return_text, symbol_get_call_convention(sym),
546 OUTPUT_UC_DLL_NAME, sym->function_name);
548 if (!sym->argc || (sym->argc == 1 && sym->flags & SYM_THISCALL))
549 fputs ("void", file);
550 else
551 for (i = start; i < sym->argc; i++)
552 fprintf (file, "%s%s %s", i > start ? ", " : "", sym->arg_text [i],
553 sym->arg_name [i]);
554 if (sym->varargs)
555 fputs (", ...", file);
556 fputc (')', file);
560 /*******************************************************************
561 * output_c_banner
563 * Write a function banner to the .c file
565 void output_c_banner (const parsed_symbol *sym)
567 char ord_spec[16];
568 size_t i;
570 if (sym->ordinal >= 0)
571 snprintf(ord_spec, sizeof (ord_spec), "%d", sym->ordinal);
572 else
574 ord_spec[0] = '@';
575 ord_spec[1] = '\0';
578 fprintf (cfile, "/*********************************************************"
579 "*********\n *\t\t%s (%s.%s)\n *\n", sym->symbol,
580 OUTPUT_UC_DLL_NAME, ord_spec);
582 if (globals.do_documentation && sym->function_name)
584 fputs (" *\n * PARAMS\n *\n", cfile);
586 if (!sym->argc)
587 fputs (" * None.\n *\n", cfile);
588 else
590 for (i = 0; i < sym->argc; i++)
591 fprintf (cfile, " * %s [%s]%s\n", sym->arg_name [i],
592 get_in_or_out(sym, i),
593 strcmp (sym->arg_name [i], "_this") ? "" :
594 " Pointer to the class object (in ECX)");
596 if (sym->varargs)
597 fputs (" * ...[I]\n", cfile);
598 fputs (" *\n", cfile);
601 fputs (" * RETURNS\n *\n", cfile);
603 if (sym->return_text && !strcmp (sym->return_text, "void"))
604 fputs (" * Nothing.\n", cfile);
605 else
606 fprintf (cfile, " * %s\n", sym->return_text);
608 fputs (" *\n */\n", cfile);
612 /*******************************************************************
613 * get_format_str
615 * Get a string containing the correct format string for a type
617 static const char *get_format_str (int type)
619 switch (type)
621 case ARG_VOID: return "void";
622 case ARG_FLOAT: return "%f";
623 case ARG_DOUBLE: return "%g";
624 case ARG_POINTER: return "%p";
625 case ARG_WIDE_STRING:
626 case ARG_STRING: return "%s";
627 case ARG_LONG: return "%ld";
628 case ARG_STRUCT: return "struct";
630 assert (0);
631 return "";
635 /*******************************************************************
636 * get_in_or_out
638 * Determine if a parameter is In or In/Out
640 static const char *get_in_or_out (const parsed_symbol *sym, size_t arg)
642 assert (sym && arg < sym->argc);
643 assert (globals.do_documentation);
645 if (sym->arg_flag [arg] & CT_CONST)
646 return "In";
648 switch (sym->arg_type [arg])
650 case ARG_FLOAT:
651 case ARG_DOUBLE:
652 case ARG_LONG:
653 case ARG_STRUCT: return "In";
654 case ARG_POINTER:
655 case ARG_WIDE_STRING:
656 case ARG_STRING: return "In/Out";
658 assert (0);
659 return "";