lib/libUPnP/patches/0054-libUPnP-Fix-memory-allocation-of-size-0.patch

   1 From 667922032fa22607697ca4b5eb81c1f8c96e2161 Mon Sep 17 00:00:00 2001
   2 From: Peter <peter.vicman@gmail.com>
   3 Date: Tue, 25 Jun 2024 10:57:31 +0200
   4 Subject: [PATCH] libUPnP: Fix memory allocation of size 0
   5
   6 In member function 'ReallocateBuffer',
   7     inlined from 'SetBufferSize' at ../../kodi-e495e26f477d4de8a7e6c2fac4acbe1a15e22242/.aarch64-libreelec-linux-gnu/../lib/libUPnP/Neptune/Source/Core/NptDataBuffer.cpp:172:32,
   8     inlined from 'Load' at ../../kodi-e495e26f477d4de8a7e6c2fac4acbe1a15e22242/.aarch64-libreelec-linux-gnu/../lib/libUPnP/Neptune/Source/Core/NptStreams.cpp:106:33:
   9 ../../kodi-e495e26f477d4de8a7e6c2fac4acbe1a15e22242/.aarch64-libreelec-linux-gnu/../lib/libUPnP/Neptune/Source/Core/NptDataBuffer.cpp:245:23: warning: '__builtin_memcpy' writing between 1 and 4294967295 bytes into a region of size 0 [-Wstringop-overflow=]
  10 ../../kodi-e495e26f477d4de8a7e6c2fac4acbe1a15e22242/.aarch64-libreelec-linux-gnu/../lib/libUPnP/Neptune/Source/Core/NptDataBuffer.cpp:241:44: note: destination object of size 0 allocated by 'operator new []'
  11
  12 ---
  13  lib/libUPnP/Neptune/Source/Core/NptDataBuffer.cpp | 4 +++-
  14  1 file changed, 3 insertions(+), 1 deletion(-)
  15
  16 diff --git a/lib/libUPnP/Neptune/Source/Core/NptDataBuffer.cpp b/lib/libUPnP/Neptune/Source/Core/NptDataBuffer.cpp
  17 index f5ab03c..c0b1c80 100644
  18 --- a/lib/libUPnP/Neptune/Source/Core/NptDataBuffer.cpp
  19 +++ b/lib/libUPnP/Neptune/Source/Core/NptDataBuffer.cpp
  20 @@ -237,7 +237,9 @@ NPT_DataBuffer::ReallocateBuffer(NPT_Size size)
  21      // check that the existing data fits
  22      if (m_DataSize > size) return NPT_ERROR_INVALID_PARAMETERS;
  23
  24 -    // allocate a new buffer
  25 +    // allocate a new buffer only if size is not zero
  26 +    if (!size) return NPT_ERROR_INVALID_PARAMETERS;
  27 +
  28      NPT_Byte* newBuffer = new NPT_Byte[size];
  29
  30      // copy the contents of the previous buffer, if any
  31 --
  32 2.41.0.dirty
  33